dnsimpler 0.0.2 → 0.0.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YWJkZDc5MTk3NDc5ZTg5MjZiYmYzZjNjZmJkOWRiOGJjNDMzMzE0Ng==
+    Yzk3MzdmOGUxNTk4NWIxMmEzY2E5NzcyOTYyMGU0ZGNlOGZmNjQ2YQ==
   data.tar.gz: !binary |-
-    Y2FmNmIxMTEzYTc1NjY4ZmExM2EyMjc2ZTQ2ODJlMjI1ZDU5YTNhMQ==
+    Y2Q1NDFiMDUyMzBmOWRjOGNhYTJiNzI2Y2E5OGMzNTUzY2U1MmQ1Nw==
 SHA512:
   metadata.gz: !binary |-
-    YmY5YzExMDQyZmI5NDZkN2U2NDU1ODBkYjFiNTMyMzc3NzFlNDFlNzZlYjM1
-    NmE4MDBlMmJjYzQyNmExYTNhOGRkYzkzZWY1YzlkNjhhZTI3YjZmMWJmZWQ2
-    ODVjODUzZjlmNDM5YWYzOTZjMTU5Nzk0NmRjNGEzZWRmZjBiNjQ=
+    Njc4OTUxNTIwMjBkNTAzYzVkZjU1ZTA0NWM0N2ZmOTYxMWYxNGI1ZTMzYTQy
+    Y2JjM2JjOGNjMGM0ZDBmMDkzMGQzMGVkZGZlOTk5NTdiZDVmYmUzMzEyYjUw
+    YTgxNDJkOTA1YTM5Zjc4ZmMyNmU1ZjUxY2E3OTM1NzkzNGQwM2M=
   data.tar.gz: !binary |-
-    NDVhOWVjMjk3OGQ1ZWY3NDdmM2NjZTBkZGRkZmYxZTJjMjllNzM1YjQyOTBl
-    YzBlOGI0MGJjOGY2N2ZmOTVlZDVkZWEyYmQ2NjFhNTI1MGNlZTVmM2IzNGVj
-    OTNhM2ZiMjNhYTE2MmE1YWMyNDU1ZmY0NDY5ZWEyYTE2YzE1ZmU=
+    MGI4YjcwN2Q3NGU1MTYyNjAwZjU2YWFjNGFhNTg4ZTVmOTdkMGRmMDI3NWNk
+    YjYzZmQxZWEwNzUyMzRlMjhlZjNjYjQyMTBjOTgxY2Y3MjY1MmIzNjZhNTdi
+    NzQ2NzJjYTIxNzVjOTY0ODFlYzFkYzdjZTNhM2RhODU3N2VjMDc=

data/lib/dnsimpler/error.rb

@@ -0,0 +1,12 @@
+module DNSimpler
+  class Error < StandardError
+    attr_reader :code, :body, :response
+
+    def initialize(code, body, response)
+      @code = code
+      @body = body
+      @response = response
+    end
+
+  end
+end

data/lib/dnsimpler/http.rb

@@ -37,15 +37,19 @@ module DNSimpler
 
           req = super path, opts, &blk
 
-          response = OpenStruct.new(code: req.code, body: req.parsed_response)
+          if (200...400).include? req.code
+            response = OpenStruct.new(code: req.code, body: req.parsed_response)
 
-          if DNSimpler.debug
-            response.request = req
+            if DNSimpler.debug
+              response.request = req
 
-            puts "Request Options: " + opts.to_s
-          end
+              puts "Request Options: " + opts.to_s
+            end
 
-          return response
+            return response
+          else
+            raise Error.new(req.code, req.parsed_response, req)
+          end
         end
 
       RUBY_EVAL

data/lib/dnsimpler/try.rb

@@ -2,7 +2,7 @@ unless Hash.instance_methods.include? :try
   class Hash
 
     def try(key)
-      return send("[]", key)
+      return self[key]
     end
 
   end

data/lib/dnsimpler/version.rb

@@ -1,3 +1,3 @@
 module DNSimpler
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/dnsimpler.rb

@@ -1,6 +1,7 @@
 require 'ostruct'
 require "dnsimpler/version"
 require 'dnsimpler/http'
+require 'dnsimpler/error'
 require 'dnsimpler/try'
 
 module DNSimpler

data/test/dnsimpler/error_test.rb

@@ -0,0 +1,22 @@
+require 'test_helper'
+
+class DNSimpler::ErrorTest < MiniTest::Test
+
+  test "initialize" do
+    assert_raises DNSimpler::Error do
+      raise DNSimpler::Error.new(200, {body: 'blah'}, nil)
+    end
+  end
+
+  %w[code body response].each do |attr|
+    class_eval <<-RUBY_EVAL, __FILE__, __LINE__
+
+      test "##{attr}" do
+        error = DNSimpler::Error.new(200, {body: 'blah'}, true)
+        refute_nil error.#{attr}
+      end
+
+    RUBY_EVAL
+  end
+
+end

data/test/dnsimpler/http_test.rb

@@ -3,10 +3,23 @@ require 'test_helper'
 module DNSimpler
   class HTTPTest < MiniTest::Test
 
+    def setup
+      super
+      stub_request(:get, "#{DNSimpler.base_uri}v1/domains/example.com").to_return(status: 404, body: {"message"=>"Domain `example.com' not found"}.to_json)
+    end
+
     test "#base_options" do
       assert_instance_of Hash, HTTP.base_options
     end
 
+    test "an error is raised for a failed request" do
+      error = assert_raises ::DNSimpler::Error do
+        HTTP.get("v1/domains/example.com")
+      end
+
+      refute (200...400).include? error.code
+    end
+
     %w[get post head delete patch put].each do |method|
       class_eval <<-RUBY_EVAL
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dnsimpler
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Daniel Westendorf
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-07 00:00:00.000000000 Z
+date: 2015-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -83,9 +83,11 @@ files:
 - Rakefile
 - dnsimpler.gemspec
 - lib/dnsimpler.rb
+- lib/dnsimpler/error.rb
 - lib/dnsimpler/http.rb
 - lib/dnsimpler/try.rb
 - lib/dnsimpler/version.rb
+- test/dnsimpler/error_test.rb
 - test/dnsimpler/http_test.rb
 - test/dnsimpler/try_test.rb
 - test/dnsimpler_test.rb
@@ -116,6 +118,7 @@ specification_version: 4
 summary: A simple DNSimple API wrapper that always provides the response you're looking
   for.
 test_files:
+- test/dnsimpler/error_test.rb
 - test/dnsimpler/http_test.rb
 - test/dnsimpler/try_test.rb
 - test/dnsimpler_test.rb