dnsimple 7.1.1 → 8.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 186f6faf074afa519d67b5397e0e1568ed6745948239a14fb8f72f39dccea390
-  data.tar.gz: 605cf70471182fc26fb96cb99eadc204040040bee4481ff1de4837a8084940c8
+  metadata.gz: 54546cd64cb573f075ed2538cebd73573708a1f9919364b4b963a082b1dc97bf
+  data.tar.gz: 9e86592b7ff194316f5466d2b0a4cf0f988df1e90973bc29cfc30a4b7e2bccd8
 SHA512:
-  metadata.gz: 76a9bdea4ba0618262230bea5daa1d5fe66a23e414ce7c5eae0115b343bb9355e277ef492d6f4f8ce8579609e3c511075dfed7080dfac3a34260c499faea1375
-  data.tar.gz: 5c07656ba50cdd66cba4c51ea7085229c05f0140127061a0c567ec3940c9ab6e779aae9ff8627f4531fc9bdb2bdb150683f63e792a051c55be81d3e26f0f906e
+  metadata.gz: 997ac7555b02778d5bb10c03aa97640a5a2b3e2a55064785657774da5032a8b11cf009b0de1d47dc4864c5835ea1426bc46bed082119d7aae1c87dc5058d44ed
+  data.tar.gz: 7fee63c8c4f9ae899023989de18fc920b45bd5405b2075040ef167f1b7f82e0b8ddf7b6364dd23f42ac9f6ff5a53a900493af42eb489f7fa0f6acc17be74fd3b

data/.github/dependabot.yml

@@ -10,4 +10,13 @@ updates:
     labels:
       - task
       - dependencies
-      - backlog-dependencies
+
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
+      time: '12:00'
+    open-pull-requests-limit: 10
+    labels:
+      - task
+      - dependencies

data/.github/workflows/ci.yml

@@ -1,47 +1,51 @@
----
-name: ci
+name: CI
 
 on:
   push:
+    branches: [ main ]
   pull_request:
-  # Allows you to run this workflow manually from the Actions tab
   workflow_dispatch:
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   markdownlint-cli:
+    name: Lint markdown
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Run markdownlint-cli
-        uses: nosborn/github-action-markdown-cli@v2.0.0
+        uses: nosborn/github-action-markdown-cli@v3.1.0
         with:
           files: .
           config_file: ".markdownlint.yaml"
 
   yamllint:
+    name: Lint YAML
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
       - name: Run YAML Lint
         uses: actionshub/yamllint@main
 
-  build:
+  test:
     needs: [markdownlint-cli, yamllint]
     runs-on: ubuntu-latest
     name: Ruby ${{ matrix.ruby-version }}
     strategy:
       matrix:
         ruby-version:
-          - '2.6'
           - '2.7'
           - '3.0'
           - '3.1'
           - 'ruby-head'
           - 'truffleruby-head'
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -53,7 +57,7 @@ jobs:
     if: always()
     name: Post Workflow Status To Slack
     needs:
-      - build
+      - test
     runs-on: ubuntu-latest
     steps:
       - name: Slack Workflow Notification

data/.github/workflows/release.yml

@@ -1,5 +1,4 @@
----
-name: release
+name: Release
 
 on:
   push:
@@ -7,10 +6,20 @@ on:
       - v*.*.*
 jobs:
   publish:
+    name: Release to RubyGems
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v2
+      - name: Wait for tests to succeed
+        uses: lewagon/wait-on-check-action@v1.1.2
+        with:
+          ref: 'refs/heads/main'
+          running-workflow-name: 'Release to RubyGems'
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          wait-interval: 10
+          allowed-conclusions: success
+
+      - uses: actions/checkout@v3
 
       - name: Release Gem
         uses: cadwallion/publish-rubygems-action@8f9e0538302643309e4e43bf48cd34173ca48cfc # yamllint disable-line

data/.rubocop_dnsimple.yml

@@ -140,7 +140,7 @@ Style/BarePercentLiterals:
 # braces_for_chaining seems a good fit of what we've been doing so far.
 Style/BlockDelimiters:
   EnforcedStyle: braces_for_chaining
-  IgnoredMethods:
+  AllowedMethods:
     - expect
 
 # Warn on empty else.

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-12-31 12:20:10 UTC using RuboCop version 1.24.1.
+# on 2022-08-09 14:54:31 UTC using RuboCop version 1.34.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new

data/.yamllint.yml

@@ -0,0 +1,29 @@
+---
+
+extends: default
+
+rules:
+  braces:
+    level: warning
+    max-spaces-inside: 1
+  brackets:
+    level: warning
+    max-spaces-inside: 1
+  colons:
+    level: warning
+  commas:
+    level: warning
+  comments: disable
+  comments-indentation: disable
+  document-start: disable
+  empty-lines:
+    level: warning
+  hyphens:
+    level: warning
+  indentation:
+    level: warning
+    indent-sequences: consistent
+  line-length:
+    level: warning
+    allow-non-breakable-inline-mappings: true
+  truthy: disable

data/CHANGELOG.md

@@ -4,6 +4,13 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
 
 ## main
 
+## 8.0.0
+
+- CHANGED: Minimum Ruby version is now 2.7
+- REMOVED: `registrar.getDomainPremiumPrice` in favour of `registrar.getDomainPrices`
+- CHANGED: Deprecate Certificate's `contact_id` (dnsimple/dnsimple-ruby#276)
+- FIXED: Remove stale reference to Client::DomainServicesService (dnsimple/dnsimple-ruby#267)
+
 ## 7.1.1
 
 - CHANGED: Bumped up dependencies

data/Gemfile

@@ -5,7 +5,7 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'coveralls', require: false
-gem 'rubocop', '1.24.1', require: false
+gem 'rubocop', '1.34.1', require: false
 gem 'rubocop-performance', require: false
 gem 'rubocop-rake', require: false
 gem 'rubocop-rspec', require: false

data/Rakefile

@@ -33,5 +33,5 @@ task :clobber => "yardoc:clobber"
 
 desc "Open an irb session preloaded with this library"
 task :console do
-  sh "irb -rubygems -I lib -r dnsimple.rb"
+  sh "irb -r rubygems -I lib -r dnsimple.rb"
 end

data/dnsimple.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.summary     = 'The DNSimple API client for Ruby'
   s.description = 'The DNSimple API client for Ruby.'
 
-  s.required_ruby_version = ">= 2.6"
+  s.required_ruby_version = ">= 2.7"
 
   s.require_paths    = ['lib']
   s.files            = `git ls-files`.split("\n")

data/lib/dnsimple/client/certificates.rb

@@ -121,7 +121,6 @@ module Dnsimple
       # @param  account_id [Integer] the account ID
       # @param  domain_id [#to_s] the domain ID or domain name
       # @param  attributes [Hash]
-      # @option attributes [Integer] :contact_id the contact ID (mandatory)
       # @option attributes [String] :name the certificate name (optional)
       # @option attributes [Array<String>] :alternate_names the certificate alternate names (optional)
       # @option attributes [TrueClass,FalseClass] :auto_renew enable certificate auto renew (optional)
@@ -133,7 +132,7 @@ module Dnsimple
       # @raise  [Dnsimple::RequestError]
       #
       # @example Basic usage
-      #   response    = client.certificates.purchase_letsencrypt_certificate(1010, "example.com", contact_id: 1)
+      #   response    = client.certificates.purchase_letsencrypt_certificate(1010, "example.com")
       #   certificate = response.data
       #
       #   certificate.id              # => 100
@@ -142,7 +141,7 @@ module Dnsimple
       #   certificate.auto_renew      # => false
       #
       # @example Custom name
-      #   response    = client.certificates.purchase_letsencrypt_certificate(1010, "example.com", contact_id: 1, name: "docs")
+      #   response    = client.certificates.purchase_letsencrypt_certificate(1010, "example.com", name: "docs")
       #   certificate = response.data
       #
       #   certificate.id              # => 100
@@ -151,7 +150,7 @@ module Dnsimple
       #   certificate.auto_renew      # => false
       #
       # @example SAN names
-      #   response    = client.certificates.purchase_letsencrypt_certificate(1010, "example.com", contact_id: 1, alternate_names: ["api.example.com", "status.example.com"])
+      #   response    = client.certificates.purchase_letsencrypt_certificate(1010, "example.com", alternate_names: ["api.example.com", "status.example.com"])
       #   certificate = response.data
       #
       #   certificate.id              # => 100
@@ -160,15 +159,14 @@ module Dnsimple
       #   certificate.auto_renew      # => false
       #
       # @example Auto renew
-      #   response    = client.certificates.purchase_letsencrypt_certificate(1010, "example.com", contact_id: 1, auto_renew: true)
+      #   response    = client.certificates.purchase_letsencrypt_certificate(1010, "example.com", auto_renew: true)
       #   certificate = response.data
       #
       #   certificate.id              # => 100
       #   certificate.common_name     # => "www.example.com"
       #   certificate.alternate_names # => []
       #   certificate.auto_renew      # => true
-      def purchase_letsencrypt_certificate(account_id, domain_id, attributes, options = {})
-        Extra.validate_mandatory_attributes(attributes, [:contact_id])
+      def purchase_letsencrypt_certificate(account_id, domain_id, attributes = {}, options = {})
         response = client.post(Client.versioned("/%s/domains/%s/certificates/letsencrypt" % [account_id, domain_id]), attributes, options)
 
         Dnsimple::Response.new(response, Struct::CertificatePurchase.new(response["data"]))

data/lib/dnsimple/client/clients.rb

@@ -23,11 +23,6 @@ module Dnsimple
       @services[:domains] ||= Client::DomainsService.new(self)
     end
 
-    # @return [Dnsimple::Client::DomainServicesService] The domain-services-related API proxy.
-    def domain_services
-      @services[:domains] ||= Client::DomainServicesService.new(self)
-    end
-
     # @return [Dnsimple::Client::IdentityService] The identity-related API proxy.
     def identity
       @services[:auth] ||= Client::IdentityService.new(self)

data/lib/dnsimple/client/registrar.rb

@@ -24,35 +24,6 @@ module Dnsimple
         Dnsimple::Response.new(response, Struct::DomainCheck.new(response["data"]))
       end
 
-      # Checks the premium price for a domain
-      #
-      # @see https://developer.dnsimple.com/v2/registrar/#premium-price
-      #
-      # @example Check the ruby.codes premium price:
-      #   client.registrar.domain_premium_price(1010, "ruby.codes")
-      #
-      # @example Check the ruby.codes premium price for transfer:
-      #   client.registrar.domain_premium_price(1010, "ruby.codes", action: "transfer")
-      #
-      # @param  [Integer] account_id the account ID
-      # @param  [#to_s] domain_name the domain name to check
-      # @param  [Hash] options
-      # @option options [String] :action Optional action between "registration",
-      #   "renewal", and "transfer". If omitted, it defaults to "registration".
-      # @return [Struct::DomainPremiumPrice]
-      #
-      # @raise  [RequestError] When the request fails.
-      #
-      # @deprecated Use {#get_domain_prices} instead of this one as it will soon be removed from the API.
-      def domain_premium_price(account_id, domain_name, options = {})
-        Dnsimple.deprecate("Use {#get_domain_prices} instead of this one as it will soon be removed from the API.")
-        endpoint = Client.versioned("/%s/registrar/domains/%s/premium_price" % [account_id, domain_name])
-        options[:query] = { action: options.delete(:action) } if options.key?(:action)
-        response = client.get(endpoint, options)
-
-        Dnsimple::Response.new(response, Struct::DomainPremiumPrice.new(response["data"]))
-      end
-
       # Get prices for a domain.
       # @see https://developer.dnsimple.com/v2/registrar/#getDomainPrices
       #

data/lib/dnsimple/default.rb

@@ -36,43 +36,43 @@ module Dnsimple
       # Default API endpoint from ENV or {BASE_URL}
       # @return [String]
       def base_url
-        ENV['DNSIMPLE_BASE_URL'] || BASE_URL
+        ENV.fetch('DNSIMPLE_BASE_URL', BASE_URL)
       end
 
       # Default DNSimple username for Basic Auth from ENV
       # @return [String]
       def username
-        ENV['DNSIMPLE_USERNAME']
+        ENV.fetch('DNSIMPLE_USERNAME', nil)
       end
 
       # Default DNSimple password for Basic Auth from ENV
       # @return [String]
       def password
-        ENV['DNSIMPLE_PASSWORD']
+        ENV.fetch('DNSIMPLE_PASSWORD', nil)
       end
 
       # Default DNSimple access token for OAuth authentication from ENV
       # @return [String]
       def access_token
-        ENV['DNSIMPLE_ACCESS_TOKEN']
+        ENV.fetch('DNSIMPLE_ACCESS_TOKEN', nil)
       end
 
       # Default DNSimple Domain API Token for Token Auth from ENV
       # @return [String]
       def domain_api_token
-        ENV['DNSIMPLE_API_DOMAIN_TOKEN']
+        ENV.fetch('DNSIMPLE_API_DOMAIN_TOKEN', nil)
       end
 
       # Default User-Agent header string from ENV
       # @return [String]
       def user_agent
-        ENV['DNSIMPLE_USER_AGENT']
+        ENV.fetch('DNSIMPLE_USER_AGENT', nil)
       end
 
       # Default Proxy address:port from ENV
       # @return [String]
       def proxy
-        ENV['DNSIMPLE_PROXY']
+        ENV.fetch('DNSIMPLE_PROXY', nil)
       end
 
     end

data/lib/dnsimple/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dnsimple
-  VERSION = "7.1.1"
+  VERSION = "8.0.0"
 end

data/spec/dnsimple/client/certificates_spec.rb

@@ -68,8 +68,8 @@ describe Dnsimple::Client, ".certificates" do
     let(:domain_id) { "dnsimple.us" }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:certificates, account_id, domain_id, foo: "bar")
-      subject.all_certificates(account_id, domain_id, foo: "bar")
+      expect(subject).to receive(:paginate).with(:certificates, account_id, domain_id, { foo: "bar" })
+      subject.all_certificates(account_id, domain_id, { foo: "bar" })
     end
 
     it "supports sorting" do
@@ -232,7 +232,6 @@ describe Dnsimple::Client, ".certificates" do
   describe "#purchase_letsencrypt_certificate" do
     let(:account_id) { 1010 }
     let(:domain_id)  { "bingo.pizza" }
-    let(:contact_id) { 100 }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/certificates/letsencrypt})
@@ -240,7 +239,7 @@ describe Dnsimple::Client, ".certificates" do
     end
 
     it "builds the correct request" do
-      attributes = { contact_id: contact_id }
+      attributes = {}
       subject.purchase_letsencrypt_certificate(account_id, domain_id, attributes)
 
       expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/certificates/letsencrypt")
@@ -249,7 +248,7 @@ describe Dnsimple::Client, ".certificates" do
     end
 
     it "passes extra attributes" do
-      attributes = { contact_id: contact_id, name: "www", auto_renew: true, alternate_names: ["api.example.com"] }
+      attributes = { name: "www", auto_renew: true, alternate_names: ["api.example.com"] }
       subject.purchase_letsencrypt_certificate(account_id, domain_id, attributes)
 
       expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/certificates/letsencrypt")
@@ -258,7 +257,7 @@ describe Dnsimple::Client, ".certificates" do
     end
 
     it "returns the certificate purchase" do
-      response = subject.purchase_letsencrypt_certificate(account_id, domain_id, contact_id: contact_id)
+      response = subject.purchase_letsencrypt_certificate(account_id, domain_id)
       expect(response).to be_a(Dnsimple::Response)
 
       result = response.data
@@ -276,7 +275,7 @@ describe Dnsimple::Client, ".certificates" do
             .to_return(read_http_fixture("notfound-domain.http"))
 
         expect {
-          subject.purchase_letsencrypt_certificate(account_id, domain_id, contact_id: contact_id)
+          subject.purchase_letsencrypt_certificate(account_id, domain_id)
         }.to raise_error(Dnsimple::NotFoundError)
       end
     end
@@ -311,7 +310,7 @@ describe Dnsimple::Client, ".certificates" do
       expect(result.common_name).to eq("www.bingo.pizza")
       expect(result.alternate_names).to eq([])
       expect(result.years).to eq(1)
-      expect(result.csr).to be(nil)
+      expect(result.csr).to be_nil
       expect(result.state).to eq("requesting")
       expect(result.authority_identifier).to eq("letsencrypt")
       expect(result.auto_renew).to be(false)
@@ -421,7 +420,7 @@ describe Dnsimple::Client, ".certificates" do
       expect(result.common_name).to eq("www.bingo.pizza")
       expect(result.alternate_names).to eq([])
       expect(result.years).to eq(1)
-      expect(result.csr).to be(nil)
+      expect(result.csr).to be_nil
       expect(result.state).to eq("requesting")
       expect(result.authority_identifier).to eq("letsencrypt")
       expect(result.auto_renew).to be(false)

data/spec/dnsimple/client/contacts_spec.rb

@@ -73,8 +73,8 @@ describe Dnsimple::Client, ".contacts" do
     let(:account_id) { 1010 }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:contacts, account_id, foo: "bar")
-      subject.all_contacts(account_id, foo: "bar")
+      expect(subject).to receive(:paginate).with(:contacts, account_id, { foo: "bar" })
+      subject.all_contacts(account_id, { foo: "bar" })
     end
 
     it "supports sorting" do

data/spec/dnsimple/client/domains_collaborators_spec.rb

@@ -116,8 +116,8 @@ describe Dnsimple::Client, ".domains" do
         result = response.data
         expect(result).to be_a(Dnsimple::Struct::Collaborator)
         expect(result.id).to          be_a(Integer)
-        expect(result.user_id).to     be(nil)
-        expect(result.accepted_at).to be(nil)
+        expect(result.user_id).to     be_nil
+        expect(result.accepted_at).to be_nil
         expect(result.user_email).to  eq(attributes.fetch(:email))
         expect(result.invitation).to  be(true)
       end

data/spec/dnsimple/client/domains_delegation_signer_records_spec.rb

@@ -86,8 +86,8 @@ describe Dnsimple::Client, ".domains" do
     let(:domain_id) { "example.com" }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:delegation_signer_records, account_id, domain_id, foo: "bar")
-      subject.all_delegation_signer_records(account_id, domain_id, foo: "bar")
+      expect(subject).to receive(:paginate).with(:delegation_signer_records, account_id, domain_id, { foo: "bar" })
+      subject.all_delegation_signer_records(account_id, domain_id, { foo: "bar" })
     end
 
     it "supports sorting" do

data/spec/dnsimple/client/domains_email_forwards_spec.rb

@@ -86,8 +86,8 @@ describe Dnsimple::Client, ".domains" do
     let(:domain_id) { "example.com" }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:email_forwards, account_id, domain_id, foo: "bar")
-      subject.all_email_forwards(account_id, domain_id, foo: "bar")
+      expect(subject).to receive(:paginate).with(:email_forwards, account_id, domain_id, { foo: "bar" })
+      subject.all_email_forwards(account_id, domain_id, { foo: "bar" })
     end
 
     it "supports sorting" do

data/spec/dnsimple/client/domains_spec.rb

@@ -79,8 +79,8 @@ describe Dnsimple::Client, ".domains" do
     let(:account_id) { 1010 }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:domains, account_id, foo: "bar")
-      subject.all_domains(account_id, foo: "bar")
+      expect(subject).to receive(:paginate).with(:domains, account_id, { foo: "bar" })
+      subject.all_domains(account_id, { foo: "bar" })
     end
 
     it "supports sorting" do

data/spec/dnsimple/client/registrar_spec.rb

@@ -34,54 +34,6 @@ describe Dnsimple::Client, ".registrar" do
     end
   end
 
-  describe "#domain_premium_price" do
-    let(:account_id) { 1010 }
-
-    context "when premium price" do
-      before do
-        stub_request(:get, %r{/v2/#{account_id}/registrar/domains/.+/premium_price[?action]*})
-            .to_return(read_http_fixture("getDomainPremiumPrice/success.http"))
-      end
-
-      it "builds the correct request" do
-        subject.domain_premium_price(account_id, domain_name = "ruby.codes")
-
-        expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/premium_price")
-            .with(headers: { "Accept" => "application/json" })
-      end
-
-      it "returns the premium price" do
-        response = subject.domain_premium_price(account_id, "ruby.codes")
-        expect(response).to be_a(Dnsimple::Response)
-
-        result = response.data
-        expect(result).to be_a(Dnsimple::Struct::DomainPremiumPrice)
-        expect(result.premium_price).to eq("109.00")
-        expect(result.action).to        eq("registration")
-      end
-
-      it "builds the correct request when action is passed" do
-        subject.domain_premium_price(account_id, domain_name = "ruby.codes", action: "registration")
-
-        expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/premium_price?action=registration")
-            .with(headers: { "Accept" => "application/json" })
-      end
-    end
-
-    context "when not premium price" do
-      before do
-        stub_request(:get, %r{/v2/#{account_id}/registrar/domains/.+/premium_price$})
-            .to_return(read_http_fixture("getDomainPremiumPrice/failure.http"))
-      end
-
-      it "raises error" do
-        expect {
-          subject.domain_premium_price(account_id, "example.com")
-        }.to raise_error(Dnsimple::RequestError, "`example.com` is not a premium domain for registration")
-      end
-    end
-  end
-
   describe "#get_domain_prices" do
     let(:account_id) { 1010 }
 
@@ -317,7 +269,7 @@ describe Dnsimple::Client, ".registrar" do
       expect(result.state).to eq("transferring")
       expect(result.auto_renew).to be(false)
       expect(result.whois_privacy).to be(false)
-      expect(result.status_description).to eq(nil)
+      expect(result.status_description).to be_nil
       expect(result.created_at).to eq("2020-06-05T18:08:00Z")
       expect(result.updated_at).to eq("2020-06-05T18:08:04Z")
     end

data/spec/dnsimple/client/services_spec.rb

@@ -61,7 +61,7 @@ describe Dnsimple::Client, ".services" do
     end
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:services, foo: "bar")
+      expect(subject).to receive(:paginate).with(:services, { foo: "bar" })
       subject.all_services(foo: "bar")
     end
 

data/spec/dnsimple/client/templates_records_spec.rb

@@ -65,7 +65,7 @@ describe Dnsimple::Client, ".templates" do
     let(:template_id) { "alpha" }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:records, account_id, template_id, option: "value")
+      expect(subject).to receive(:paginate).with(:records, account_id, template_id, { option: "value" })
       subject.all_records(account_id, template_id, option: "value")
     end
 

data/spec/dnsimple/client/templates_spec.rb

@@ -64,8 +64,8 @@ describe Dnsimple::Client, ".templates" do
     let(:account_id) { 1010 }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:templates, account_id, foo: "bar")
-      subject.all_templates(account_id, foo: "bar")
+      expect(subject).to receive(:paginate).with(:templates, account_id, { foo: "bar" })
+      subject.all_templates(account_id, { foo: "bar" })
     end
 
     it "supports sorting" do

data/spec/dnsimple/client/tlds_spec.rb

@@ -68,7 +68,7 @@ describe Dnsimple::Client, ".tlds" do
     end
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:list_tlds, foo: "bar")
+      expect(subject).to receive(:paginate).with(:list_tlds, { foo: "bar" })
       subject.all_tlds(foo: "bar")
     end
 

data/spec/dnsimple/client/zones_records_spec.rb

@@ -93,8 +93,8 @@ describe Dnsimple::Client, ".zones" do
     let(:zone_id) { "example.com" }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:list_zone_records, account_id, zone_id, foo: "bar")
-      subject.all_zone_records(account_id, zone_id, foo: "bar")
+      expect(subject).to receive(:paginate).with(:list_zone_records, account_id, zone_id, { foo: "bar" })
+      subject.all_zone_records(account_id, zone_id, { foo: "bar" })
     end
 
     it "supports sorting" do
@@ -179,7 +179,7 @@ describe Dnsimple::Client, ".zones" do
       expect(result).to be_a(Dnsimple::Struct::ZoneRecord)
       expect(result.id).to eq(record_id)
       expect(result.zone_id).to eq("example.com")
-      expect(result.parent_id).to eq(nil)
+      expect(result.parent_id).to be_nil
       expect(result.type).to eq("MX")
       expect(result.name).to eq("")
       expect(result.content).to eq("mxa.example.com")

data/spec/dnsimple/client/zones_spec.rb

@@ -79,8 +79,8 @@ describe Dnsimple::Client, ".zones" do
     let(:account_id) { 1010 }
 
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:zones, account_id, foo: "bar")
-      subject.all_zones(account_id, foo: "bar")
+      expect(subject).to receive(:paginate).with(:zones, account_id, { foo: "bar" })
+      subject.all_zones(account_id, { foo: "bar" })
     end
 
     it "supports sorting" do

data/spec/dnsimple/client_spec.rb

@@ -49,36 +49,36 @@ describe Dnsimple::Client do
 
   describe "#get" do
     it "delegates to #request" do
-      allow(subject).to receive(:execute).with(:get, "path", nil, foo: "bar").and_return(:returned)
-      expect(subject.get("path", foo: "bar")).to eq(:returned)
+      allow(subject).to receive(:execute).with(:get, "path", nil, { foo: "bar" }).and_return(:returned)
+      expect(subject.get("path", { foo: "bar" })).to eq(:returned)
     end
   end
 
   describe "#post" do
     it "delegates to #request" do
       allow(subject).to receive(:execute).with(:post, "path", { foo: "bar" }, {}).and_return(:returned)
-      expect(subject.post("path", foo: "bar")).to eq(:returned)
+      expect(subject.post("path", { foo: "bar" })).to eq(:returned)
     end
   end
 
   describe "#put" do
     it "delegates to #request" do
       allow(subject).to receive(:execute).with(:put, "path", { foo: "bar" }, {}).and_return(:returned)
-      expect(subject.put("path", foo: "bar")).to eq(:returned)
+      expect(subject.put("path", { foo: "bar" })).to eq(:returned)
     end
   end
 
   describe "#patch" do
     it "delegates to #request" do
       allow(subject).to receive(:execute).with(:patch, "path", { foo: "bar" }, {}).and_return(:returned)
-      expect(subject.patch("path", foo: "bar")).to eq(:returned)
+      expect(subject.patch("path", { foo: "bar" })).to eq(:returned)
     end
   end
 
   describe "#delete" do
     it "delegates to #request" do
       allow(subject).to receive(:execute).with(:delete, "path", { foo: "bar" }, {}).and_return(:returned)
-      expect(subject.delete("path", foo: "bar")).to eq(:returned)
+      expect(subject.delete("path", { foo: "bar" })).to eq(:returned)
     end
   end
 
@@ -128,12 +128,12 @@ describe Dnsimple::Client do
 
       allow(HTTParty).to receive(:get)
           .with(
-              "#{subject.base_url}foo",
-              format: :json,
-              basic_auth: { username: "user", password: "pass" },
-              headers: { 'Accept' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT }
+              "#{subject.base_url}foo", {
+                format: :json,
+                basic_auth: { username: "user", password: "pass" },
+                headers: { 'Accept' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT },
+              }
             )
-          .and_return(instance_double('response', code: 200))
 
       subject.request(:get, 'foo')
     end
@@ -141,14 +141,14 @@ describe Dnsimple::Client do
     it "properly extracts processes options and encodes data" do
       allow(HTTParty).to receive(:put)
           .with(
-              "#{subject.base_url}foo",
-              format: :json,
-              body: JSON.dump(something: "else"),
-              query: { foo: "bar" },
-              basic_auth: { username: "user", password: "pass" },
-              headers: { 'Accept' => 'application/json', 'Content-Type' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT, "Custom" => "Header" }
+              "#{subject.base_url}foo", {
+                format: :json,
+                body: JSON.dump(something: "else"),
+                query: { foo: "bar" },
+                basic_auth: { username: "user", password: "pass" },
+                headers: { 'Accept' => 'application/json', 'Content-Type' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT, "Custom" => "Header" },
+              }
             )
-          .and_return(instance_double('response', code: 200))
 
       subject.request(:put, 'foo', { something: "else" }, { query: { foo: "bar" }, headers: { "Custom" => "Header" } })
     end
@@ -156,13 +156,13 @@ describe Dnsimple::Client do
     it "handles non application/json content types" do
       allow(HTTParty).to receive(:post)
           .with(
-              "#{subject.base_url}foo",
-              format: :json,
-              body: { something: "else" },
-              basic_auth: { username: "user", password: "pass" },
-              headers: { 'Accept' => 'application/json', 'Content-Type' => 'application/x-www-form-urlencoded', 'User-Agent' => Dnsimple::Default::USER_AGENT }
+              "#{subject.base_url}foo", {
+                format: :json,
+                body: { something: "else" },
+                basic_auth: { username: "user", password: "pass" },
+                headers: { 'Accept' => 'application/json', 'Content-Type' => 'application/x-www-form-urlencoded', 'User-Agent' => Dnsimple::Default::USER_AGENT },
+              }
             )
-          .and_return(instance_double('response', code: 200))
 
       subject.request(:post, 'foo', { something: "else" }, { headers: { "Content-Type" => "application/x-www-form-urlencoded" } })
     end
@@ -170,13 +170,13 @@ describe Dnsimple::Client do
     it "includes options for proxy support" do
       allow(HTTParty).to receive(:get)
           .with(
-              "#{subject.base_url}test",
-              format: :json,
-              http_proxyaddr: "example-proxy.com",
-              http_proxyport: "4321",
-              headers: { 'Accept' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT }
+              "#{subject.base_url}test", {
+                format: :json,
+                http_proxyaddr: "example-proxy.com",
+                http_proxyport: "4321",
+                headers: { 'Accept' => 'application/json', 'User-Agent' => Dnsimple::Default::USER_AGENT },
+              }
             )
-          .and_return(instance_double('response', code: 200))
 
       subject = described_class.new(proxy: "example-proxy.com:4321")
       subject.request(:get, "test", nil, {})
@@ -186,10 +186,9 @@ describe Dnsimple::Client do
       allow(HTTParty).to receive(:get)
           .with(
               "#{subject.base_url}test",
-              format: :json,
-              headers: hash_including("User-Agent" => "customAgent #{Dnsimple::Default::USER_AGENT}")
+              { format: :json,
+                headers: hash_including("User-Agent" => "customAgent #{Dnsimple::Default::USER_AGENT}"), }
             )
-          .and_return(instance_double("response", code: 200))
 
       subject = described_class.new(user_agent: "customAgent")
       subject.request(:get, "test", nil)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dnsimple
 version: !ruby/object:Gem::Version
-  version: 7.1.1
+  version: 8.0.0
 platform: ruby
 authors:
 - DNSimple
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-20 00:00:00.000000000 Z
+date: 2022-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -98,6 +98,7 @@ files:
 - ".rubocop.yml"
 - ".rubocop_dnsimple.yml"
 - ".rubocop_todo.yml"
+- ".yamllint.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
@@ -367,14 +368,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.6'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.3.7
 signing_key: 
 specification_version: 4
 summary: The DNSimple API client for Ruby