dnsimple 5.2.0 → 6.0.0

data/lib/dnsimple/struct/domain_price.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Dnsimple
+  module Struct
+
+    class DomainPrice < Base
+      # @return [String] The domain name
+      attr_accessor :domain
+
+      # @return [Boolean] Whether the domain is premium.
+      attr_accessor :premium
+
+      # @return [Float] The price for registration
+      attr_accessor :registration_price
+
+      # @return [Float] The price for renewal
+      attr_accessor :renewal_price
+
+      # @return [Float] The price for transfer
+      attr_accessor :transfer_price
+    end
+
+  end
+end

data/lib/dnsimple/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dnsimple
-  VERSION = "5.2.0"
+  VERSION = "6.0.0"
 end

data/spec/dnsimple/client/certificates_spec.rb

@@ -120,7 +120,6 @@ describe Dnsimple::Client, ".certificates" do
       expect(result.auto_renew).to be(false)
       expect(result.created_at).to eq("2020-06-18T18:54:17Z")
       expect(result.updated_at).to eq("2020-06-18T19:10:14Z")
-      expect(result.expires_on).to eq("2020-09-16")
       expect(result.expires_at).to eq("2020-09-16T18:10:13Z")
     end
 

data/spec/dnsimple/client/client_service_spec.rb

@@ -6,7 +6,7 @@ describe Dnsimple::Client::ClientService do
 
   describe "#paginate" do
     service_class = Class.new(Dnsimple::Client::ClientService) do
-      Item = Class.new(Dnsimple::Struct::Base) do
+      Item = Class.new(Dnsimple::Struct::Base) do # rubocop:disable Lint/ConstantDefinitionInBlock
         attr_accessor :id
       end
 

data/spec/dnsimple/client/contacts_spec.rb

@@ -86,13 +86,13 @@ describe Dnsimple::Client, ".contacts" do
 
   describe "#create_contact" do
     let(:account_id) { 1010 }
+    let(:attributes) { { first_name: "Simone", last_name: "Carletti", address1: "Italian Street", city: "Rome", state_province: "RM", postal_code: "00171", country: "IT", email: "example@example.com", phone: "+393391234567" } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/contacts$})
           .to_return(read_http_fixture("createContact/created.http"))
     end
 
-    let(:attributes) { { first_name: "Simone", last_name: "Carletti", address1: "Italian Street", city: "Rome", state_province: "RM", postal_code: "00171", country: "IT", email: "example@example.com", phone: "+393391234567" } }
 
     it "builds the correct request" do
       subject.create_contact(account_id, attributes)
@@ -153,13 +153,13 @@ describe Dnsimple::Client, ".contacts" do
 
   describe "#update_contact" do
     let(:account_id) { 1010 }
+    let(:attributes) { { first_name: "Updated" } }
 
     before do
       stub_request(:patch, %r{/v2/#{account_id}/contacts/.+$})
           .to_return(read_http_fixture("updateContact/success.http"))
     end
 
-    let(:attributes) { { first_name: "Updated" } }
 
     it "builds the correct request" do
       subject.update_contact(account_id, contact_id = 1, attributes)

data/spec/dnsimple/client/domains_delegation_signer_records_spec.rb

@@ -99,6 +99,7 @@ describe Dnsimple::Client, ".domains" do
 
   describe "#create_delegation_signer_record" do
     let(:account_id) { 1010 }
+    let(:attributes) { { algorithm: "13", digest: "ABC123", digest_type: "2", keytag: "1111" } }
     let(:domain_id) { "example.com" }
 
     before do
@@ -106,7 +107,6 @@ describe Dnsimple::Client, ".domains" do
           .to_return(read_http_fixture("createDelegationSignerRecord/created.http"))
     end
 
-    let(:attributes) { { algorithm: "13", digest: "ABC123", digest_type: "2", keytag: "1111" } }
 
     it "builds the correct request" do
       subject.create_delegation_signer_record(account_id, domain_id, attributes)

data/spec/dnsimple/client/domains_email_forwards_spec.rb

@@ -99,6 +99,7 @@ describe Dnsimple::Client, ".domains" do
 
   describe "#create_email_forward" do
     let(:account_id) { 1010 }
+    let(:attributes) { { from: "jim", to: "jim@another.com" } }
     let(:domain_id) { "example.com" }
 
     before do
@@ -106,7 +107,6 @@ describe Dnsimple::Client, ".domains" do
           .to_return(read_http_fixture("createEmailForward/created.http"))
     end
 
-    let(:attributes) { { from: "jim", to: "jim@another.com" } }
 
     it "builds the correct request" do
       subject.create_email_forward(account_id, domain_id, attributes)
@@ -129,7 +129,7 @@ describe Dnsimple::Client, ".domains" do
   describe "#email_forward" do
     let(:account_id) { 1010 }
     let(:domain_id) { "example.com" }
-    let(:email_forward_id) { 17706 }
+    let(:email_forward_id) { 41872 }
 
     before do
       stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/email_forwards.+$})
@@ -149,12 +149,12 @@ describe Dnsimple::Client, ".domains" do
 
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::EmailForward)
-      expect(result.id).to eq(17706)
-      expect(result.domain_id).to eq(228963)
-      expect(result.from).to eq("jim@a-domain.com")
-      expect(result.to).to eq("jim@another.com")
-      expect(result.created_at).to eq("2016-02-04T14:26:50Z")
-      expect(result.updated_at).to eq("2016-02-04T14:26:50Z")
+      expect(result.id).to eq(41872)
+      expect(result.domain_id).to eq(235146)
+      expect(result.from).to eq("example@dnsimple.xyz")
+      expect(result.to).to eq("example@example.com")
+      expect(result.created_at).to eq("2021-01-25T13:54:40Z")
+      expect(result.updated_at).to eq("2021-01-25T13:54:40Z")
     end
 
     context "when the email forward does not exist" do

data/spec/dnsimple/client/domains_pushes_spec.rb

@@ -8,6 +8,7 @@ describe Dnsimple::Client, ".domains" do
 
   describe "#initiate_push" do
     let(:account_id) { 1010 }
+    let(:attributes) { { new_account_email: "admin@target-account.test" } }
     let(:domain_id) { "example.com" }
 
     before do
@@ -15,7 +16,6 @@ describe Dnsimple::Client, ".domains" do
           .to_return(read_http_fixture("initiatePush/success.http"))
     end
 
-    let(:attributes) { { new_account_email: "admin@target-account.test" } }
 
     it "builds the correct request" do
       subject.initiate_push(account_id, domain_id, attributes)
@@ -88,6 +88,7 @@ describe Dnsimple::Client, ".domains" do
 
   describe "#accept_push" do
     let(:account_id) { 2020 }
+    let(:attributes) { { contact_id: 2 } }
     let(:push_id) { 1 }
 
     before do
@@ -95,7 +96,6 @@ describe Dnsimple::Client, ".domains" do
           .to_return(read_http_fixture("acceptPush/success.http"))
     end
 
-    let(:attributes) { { contact_id: 2 } }
 
     it "builds the correct request" do
       subject.accept_push(account_id, push_id, attributes)

data/spec/dnsimple/client/domains_spec.rb

@@ -98,13 +98,13 @@ describe Dnsimple::Client, ".domains" do
 
   describe "#create_domain" do
     let(:account_id) { 1010 }
+    let(:attributes) { { name: "example.com" } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/domains$})
           .to_return(read_http_fixture("createDomain/created.http"))
     end
 
-    let(:attributes) { { name: "example.com" } }
 
     it "builds the correct request" do
       subject.create_domain(account_id, attributes)
@@ -153,7 +153,6 @@ describe Dnsimple::Client, ".domains" do
       expect(result.auto_renew).to be(false)
       expect(result.private_whois).to be(false)
       expect(result.expires_at).to eq("2021-06-05T02:15:00Z")
-      expect(result.expires_on).to eq("2021-06-05")
       expect(result.created_at).to eq("2020-06-04T19:15:14Z")
       expect(result.updated_at).to eq("2020-06-04T19:15:21Z")
     end
@@ -204,31 +203,4 @@ describe Dnsimple::Client, ".domains" do
       end
     end
   end
-
-  describe "#reset_domain_token" do
-    let(:account_id) { 1010 }
-    let(:domain_id) { "example.com" }
-
-    before do
-      stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/token})
-          .to_return(read_http_fixture("resetDomainToken/success.http"))
-    end
-
-    it "builds the correct request" do
-      subject.reset_domain_token(account_id, domain_id)
-
-      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/token")
-          .with(headers: { 'Accept' => 'application/json' })
-    end
-
-    it "returns the domain" do
-      response = subject.reset_domain_token(account_id, domain_id)
-      expect(response).to be_a(Dnsimple::Response)
-
-      result = response.data
-      expect(result).to be_a(Dnsimple::Struct::Domain)
-      expect(result.id).to be_a(Integer)
-    end
-  end
-
 end

data/spec/dnsimple/client/registrar_delegation_spec.rb

@@ -31,13 +31,13 @@ describe Dnsimple::Client, ".registrar" do
 
   describe "#change_domain_delegation" do
     let(:account_id) { 1010 }
+    let(:attributes) { %w(ns1.dnsimple.com ns2.dnsimple.com ns3.dnsimple.com ns4.dnsimple.com) }
 
     before do
       stub_request(:put, %r{/v2/#{account_id}/registrar/domains/.+/delegation$})
           .to_return(read_http_fixture("changeDomainDelegation/success.http"))
     end
 
-    let(:attributes) { %w(ns1.dnsimple.com ns2.dnsimple.com ns3.dnsimple.com ns4.dnsimple.com) }
 
     it "builds the correct request" do
       subject.change_domain_delegation(account_id, domain_name = "example.com", attributes)
@@ -57,13 +57,13 @@ describe Dnsimple::Client, ".registrar" do
 
   describe "#change_domain_delegation_to_vanity" do
     let(:account_id) { 1010 }
+    let(:attributes) { %w(ns1.example.com ns2.example.com) }
 
     before do
       stub_request(:put, %r{/v2/#{account_id}/registrar/domains/.+/delegation/vanity$})
           .to_return(read_http_fixture("changeDomainDelegationToVanity/success.http"))
     end
 
-    let(:attributes) { %w(ns1.example.com ns2.example.com) }
 
     it "builds the correct request" do
       subject.change_domain_delegation_to_vanity(account_id, domain_name = "example.com", attributes)

data/spec/dnsimple/client/registrar_spec.rb

@@ -82,15 +82,58 @@ describe Dnsimple::Client, ".registrar" do
     end
   end
 
+  describe "#get_domain_prices" do
+    let(:account_id) { 1010 }
+
+    before do
+      stub_request(:get, %r{/v2/#{account_id}/registrar/domains/bingo.pizza/prices$})
+          .to_return(read_http_fixture("getDomainPrices/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.get_domain_prices(account_id, "bingo.pizza")
+
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/bingo.pizza/prices")
+          .with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the prices" do
+      response = subject.get_domain_prices(account_id, "bingo.pizza")
+      expect(response).to be_a(Dnsimple::Response)
+
+      result = response.data
+
+      expect(result).to be_a(Dnsimple::Struct::DomainPrice)
+      expect(result.domain).to eq("bingo.pizza")
+      expect(result.premium).to be(true)
+      expect(result.registration_price).to eq(20.0)
+      expect(result.renewal_price).to eq(20.0)
+      expect(result.transfer_price).to eq(20.0)
+    end
+
+    context "when the TLD is not supported" do
+      before do
+        stub_request(:get, %r{/v2/#{account_id}/registrar/domains/bingo.pineapple/prices$})
+            .to_return(read_http_fixture("getDomainPrices/failure.http"))
+      end
+
+      it "raises error" do
+        expect {
+          subject.get_domain_prices(account_id, "bingo.pineapple")
+        }.to raise_error(Dnsimple::RequestError, "TLD .PINEAPPLE is not supported")
+      end
+    end
+  end
+
   describe "#register_domain" do
     let(:account_id) { 1010 }
+    let(:attributes) { { registrant_id: "10" } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/registrar/domains/.+/registrations$})
           .to_return(read_http_fixture("registerDomain/success.http"))
     end
 
-    let(:attributes) { { registrant_id: "10" } }
 
     it "builds the correct request" do
       subject.register_domain(account_id, domain_name = "example.com", attributes)
@@ -119,13 +162,13 @@ describe Dnsimple::Client, ".registrar" do
 
   describe "#renew_domain" do
     let(:account_id) { 1010 }
+    let(:attributes) { { period: "3" } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/registrar/domains/.+/renewals$})
           .to_return(read_http_fixture("renewDomain/success.http"))
     end
 
-    let(:attributes) { { period: "3" } }
 
     it "builds the correct request" do
       subject.renew_domain(account_id, domain_name = "example.com", attributes)
@@ -159,13 +202,13 @@ describe Dnsimple::Client, ".registrar" do
 
   describe "#transfer_domain" do
     let(:account_id) { 1010 }
+    let(:attributes) { { registrant_id: "10", auth_code: "x1y2z3" } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/registrar/domains/.+/transfers$})
           .to_return(read_http_fixture("transferDomain/success.http"))
     end
 
-    let(:attributes) { { registrant_id: "10", auth_code: "x1y2z3" } }
 
     it "builds the correct request" do
       subject.transfer_domain(account_id, domain_name = "example.com", attributes)

data/spec/dnsimple/client/services_domains_spec.rb

@@ -52,15 +52,14 @@ describe Dnsimple::Client, ".services" do
         expect(service.sid).to be_a(String)
         expect(service.description).to be_a(String)
 
-        service.settings.each do |service_setting|
-          expect(service_setting).to be_a(Dnsimple::Struct::Service::Setting)
-        end
+        expect(service.settings).to all(be_a(Dnsimple::Struct::Service::Setting))
       end
     end
   end
 
   describe "#apply_service" do
     let(:account_id) { 1010 }
+    let(:settings) { { app: "foo" } }
     let(:domain_id)  { "example.com" }
     let(:service_id) { "service1" }
 
@@ -69,7 +68,6 @@ describe Dnsimple::Client, ".services" do
           .to_return(read_http_fixture("applyService/success.http"))
     end
 
-    let(:settings) { { app: "foo" } }
 
     it "builds the correct request" do
       subject.apply_service(account_id, service_id, domain_id, settings)

data/spec/dnsimple/client/services_spec.rb

@@ -49,9 +49,7 @@ describe Dnsimple::Client, ".services" do
         expect(service.sid).to be_a(String)
         expect(service.description).to be_a(String)
 
-        service.settings.each do |service_setting|
-          expect(service_setting).to be_a(Dnsimple::Struct::Service::Setting)
-        end
+        expect(service.settings).to all(be_a(Dnsimple::Struct::Service::Setting))
       end
     end
   end

data/spec/dnsimple/client/templates_records_spec.rb

@@ -78,6 +78,7 @@ describe Dnsimple::Client, ".templates" do
 
   describe "#create_record" do
     let(:account_id) { 1010 }
+    let(:attributes) { { type: "MX", name: "", content: "mx.example.com", priority: 10, ttl: 600 } }
     let(:template_id) { "alpha" }
 
     before do
@@ -85,7 +86,6 @@ describe Dnsimple::Client, ".templates" do
           .to_return(read_http_fixture("createTemplateRecord/created.http"))
     end
 
-    let(:attributes) { { type: "MX", name: "", content: "mx.example.com", priority: 10, ttl: 600 } }
 
     it "builds the correct request" do
       subject.create_record(account_id, template_id, attributes)

data/spec/dnsimple/client/templates_spec.rb

@@ -77,13 +77,13 @@ describe Dnsimple::Client, ".templates" do
 
   describe "#create_template" do
     let(:account_id) { 1010 }
+    let(:attributes) { { name: "Beta", short_name: "beta", description: "A beta template." } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/templates$})
           .to_return(read_http_fixture("createTemplate/created.http"))
     end
 
-    let(:attributes) { { name: "Beta", short_name: "beta", description: "A beta template." } }
 
     it "builds the correct request" do
       subject.create_template(account_id, attributes)
@@ -138,6 +138,7 @@ describe Dnsimple::Client, ".templates" do
 
   describe "#update_template" do
     let(:account_id) { 1010 }
+    let(:attributes) { { name: "Alpha", short_name: "alpha", description: "An alpha template." } }
     let(:template_id) { 1 }
 
     before do
@@ -145,7 +146,6 @@ describe Dnsimple::Client, ".templates" do
           .to_return(read_http_fixture("updateTemplate/success.http"))
     end
 
-    let(:attributes) { { name: "Alpha", short_name: "alpha", description: "An alpha template." } }
 
     it "builds the correct request" do
       subject.update_template(account_id, template_id, attributes)

data/spec/dnsimple/client/webhooks_spec.rb

@@ -49,13 +49,13 @@ describe Dnsimple::Client, ".webhooks" do
 
   describe "#create_webhook" do
     let(:account_id) { 1010 }
+    let(:attributes) { { url: "https://webhook.test" } }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/webhooks$})
           .to_return(read_http_fixture("createWebhook/created.http"))
     end
 
-    let(:attributes) { { url: "https://webhook.test" } }
 
     it "builds the correct request" do
       subject.create_webhook(account_id, attributes)