dnsimple 5.1.0 → 7.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 740c15a07bacc12086f2c0c3282e78150735247a9e85b6be0c84019a9a1a4de3
-  data.tar.gz: 4caef1a3ce2d61bcb59f882f5195990e64eeef2fe17294afe68ec31922460c23
+  metadata.gz: 599aae97228fa50e3a918d98e618849d91aa7aa011afcbd06d7fe61a2fb1e281
+  data.tar.gz: f1c811c95ab28badb5438cf56470b15c8794f31c7da241c28982fb08585ae1fe
 SHA512:
-  metadata.gz: 365c3a046910052fdc92c0c7a9f014f8dee87766097fcb00a182fe15b87916de86fe9649c9ec491cb9095237ee5e91cdda660142a1dccc72777b3f017ceb1351
-  data.tar.gz: a55e3f6c772e4667086d4b007c2af15618f8555564fca8a548d3eafcfd5fe8067e06f47057c19b981aeaf55086f32019f7a9055d4b7ae51eb11715e015e3d58c
+  metadata.gz: 23e64d29706bac2d104de41666b272d4ec89185be32d3def31d1e4fe6ee776c89e082b0c15ba084338d34b47df950c35159f8d01c6d6cc5191b3fec22129f3c8
+  data.tar.gz: eb126f66a71dd8bc5e7eb7cd329645a5f1cefdce5652b91218d5b0108d5e4a77f3000cc9eff2fd0fe24b149ac185dad7ec61560ce1797006e643b98750c5e463

data/.github/CODEOWNERS

@@ -0,0 +1 @@
+* @dnsimple/client-ruby

data/.github/dependabot.yml

@@ -0,0 +1,13 @@
+---
+version: 2
+updates:
+  - package-ecosystem: bundler
+    directory: /
+    schedule:
+      interval: daily
+      time: '12:00'
+    open-pull-requests-limit: 10
+    labels:
+      - task
+      - dependencies
+      - backlog-dependencies

data/.github/workflows/ci.yml

@@ -0,0 +1,63 @@
+---
+name: ci
+
+"on":
+  pull_request:
+  push:
+
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+jobs:
+  markdownlint-cli:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v2
+      - name: Run markdownlint-cli
+        uses: nosborn/github-action-markdown-cli@v2.0.0
+        with:
+          files: .
+          config_file: ".markdownlint.yaml"
+
+  yamllint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v2
+      - name: Run YAML Lint
+        uses: actionshub/yamllint@main
+
+  build:
+    needs: [markdownlint-cli, yamllint]
+    runs-on: ubuntu-latest
+    name: Ruby ${{ matrix.ruby-version }}
+    strategy:
+      matrix:
+        ruby-version:
+          - '2.6'
+          - '2.7'
+          - '3.0'
+          - 'ruby-head'
+          - 'truffleruby-head'
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - run: bundle exec rake
+
+  slack-workflow-status:
+    if: always()
+    name: Post Workflow Status To Slack
+    needs:
+      - build
+    runs-on: ubuntu-latest
+    steps:
+      - name: Slack Workflow Notification
+        uses: Gamesight/slack-workflow-status@master
+        with:
+          repo_token: ${{secrets.GITHUB_TOKEN}}
+          slack_webhook_url: ${{secrets.SLACK_WEBHOOK_URL_DEVELOPMENT}}

data/.gitignore

@@ -7,3 +7,6 @@ Gemfile.lock
 .yardoc
 yardoc/
 doc/
+
+#ASDF
+.tool-versions

data/.markdownlint.yaml

@@ -0,0 +1,3 @@
+---
+default: true
+line-length: false

data/.rubocop.yml

@@ -1,25 +1,20 @@
+---
 inherit_from:
   - .rubocop_todo.yml
   - .rubocop_dnsimple.yml
 
-require: rubocop-performance
+require:
+  - rubocop-performance
+  - rubocop-rake
+  - rubocop-rspec
 
 AllCops:
+  TargetRubyVersion: 3.0
   Exclude:
     - '*.gemspec'
     - 'Rakefile'
+    - 'vendor/**/*'
 
-# [codesmell]
-# It's irrelevant here, but it could be a code smell.
-# Hence keep it disabled, but don't include it in the DNSimple suite.
-Lint/Loop:
-  Enabled: false
-
-# It doesn't seem to work as expected.
-Style/IfUnlessModifier:
-  Enabled: false
-
-# This rule suggest to use safe navigation (&.) operator which was introduced
-# with Ruby 2.3. Because we are supporting Ruby 2.0+ we can't use this operator.
-Style/SafeNavigation:
+# This rule conflicts with our specs codebase using Ruby 2.x and 3.x
+Lint/NonDeterministicRequireOrder:
   Enabled: false

data/.rubocop_dnsimple.yml

@@ -1,3 +1,4 @@
+---
 # Defaults https://github.com/bbatsov/rubocop/blob/master/config/default.yml
 #
 # References:
@@ -8,6 +9,7 @@ AllCops:
   Exclude:
     # Exclude .gemspec files because they are generally auto-generated
     - '*.gemspec'
+  NewCops: enable
 
 # In most cases, Gems are sorted alphabetically.
 # However, in some few cases the order is relevant due to dependencies.
@@ -23,8 +25,8 @@ Layout/AccessModifierIndentation:
 Layout/BlockEndNewline:
   Enabled: false
 
-# Generally, the keyword style uses a lot of space. This is particularly true when
-# you use case/if statements, in combination with a long-name variable.
+# Generally, the keyword style uses a lot of space. This is particularly true
+# when you use case/if statements, in combination with a long-name variable.
 #
 #   invoice_error_message = case error
 #                           when 1 == 1
@@ -146,7 +148,8 @@ Style/EmptyElse:
   EnforcedStyle: empty
 
 # There is no specific preference for empty methods.
-# One-line methods are not exceptionally nice in Ruby. Just ignore this cop for now.
+# One-line methods are not exceptionally nice in Ruby.
+# Just ignore this cop for now.
 Style/EmptyMethod:
   Enabled: false
 
@@ -156,8 +159,10 @@ Style/EmptyMethod:
 Style/FormatString:
   Enabled: false
 
-# Annotated tokens (like %<foo>s) are a good thing, but in most cases we don't need them.
-# %s is a simpler and straightforward version that works in almost all cases. So don't complain.
+# Annotated tokens (like %<foo>s) are a good thing,
+# but in most cases we don't need them.
+# %s is a simpler and straightforward version that works in almost all cases.
+# So don't complain.
 Style/FormatStringToken:
   Enabled: false
 
@@ -169,15 +174,18 @@ Style/HashSyntax:
     # that looks nicer with the old rocket syntax.
     - 'Rakefile'
 
-# Enforces usage of Hash#each_key and Hash#each_value (vs. Hash#keys.each and Hash#values.each).
+# Enforces usage of Hash#each_key and Hash#each_value (vs. Hash#keys.each
+# and Hash#values.each).
 Style/HashEachMethods:
   Enabled: true
 
-# Enforce the use of Hash#TransformKeys introduced in Ruby 2.5 to transform Hash keys.
+# Enforce the use of Hash#TransformKeys introduced in Ruby 2.5 to transform
+# Hash keys.
 Style/HashTransformKeys:
   Enabled: true
 
-# Enforce the use of Hash#TransformValues introduced in Ruby 2.5 to transform Hash values.
+# Enforce the use of Hash#TransformValues introduced in Ruby 2.5 to transform
+# Hash values.
 Style/HashTransformValues:
   Enabled: true
 
@@ -212,8 +220,8 @@ Style/NumericLiterals:
     - 'spec/**/*_spec.rb'
     - 'test/**/*_test.rb'
 
-# For years, %w() has been the de-facto standard. A lot of libraries are using ().
-# Switching to [] would be a nightmare.
+# For years, %w() has been the de-facto standard.
+# A lot of libraries are using (). Switching to [] would be a nightmare.
 Style/PercentLiteralDelimiters:
   Enabled: false
 
@@ -232,12 +240,13 @@ Style/RedundantReturn:
 Style/RegexpLiteral:
   Enabled: false
 
-# There are cases were the inline rescue is ok. We can either downgrade the severity,
-# or rely on the developer judgement on a case-by-case basis.
+# There are cases were the inline rescue is ok. We can either downgrade
+# the severity, or rely on the developer judgement on a case-by-case basis.
 Style/RescueModifier:
   Enabled: false
 
-# This is quite annoying, especially in cases where we don't control it (e.g. schema.rb).
+# This is quite annoying, especially in cases where we don't control it
+# (e.g. schema.rb).
 Style/SymbolArray:
   Enabled: false
 
@@ -293,8 +302,8 @@ Style/WordArray:
 Style/YodaCondition:
   Enabled: false
 
-# For the same reason of EndAlignment, aligning with the case may have a bad impact
-# on a case after a very long variable.
+# For the same reason of EndAlignment, aligning with the case may have
+# a bad impact on a case after a very long variable.
 #
 #   invoice_error_message = case error
 #                           when 1 == 1
@@ -316,14 +325,16 @@ Layout/DotPosition:
 Layout/EmptyLines:
   Enabled: false
 
-# This is buggy. It detects as a style violation a few `class` and `module` definitions
+# This is buggy. It detects as a style violation a few `class`
+# and `module` definitions
 Layout/EmptyLinesAroundArguments:
   Enabled: false
 
 Layout/EmptyLinesAroundBlockBody:
   Exclude:
     # RSpec is all made of blocks. Disable this config in RSpec
-    # to be consistent with EmptyLinesAroundClassBody and EmptyLinesAroundModuleBody
+    # to be consistent with EmptyLinesAroundClassBody
+    # and EmptyLinesAroundModuleBody
     - 'spec/**/*_spec.rb'
     - 'test/**/*_test.rb'
 
@@ -377,41 +388,3 @@ Layout/MultilineOperationIndentation:
 #
 Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false
-
-
-# New cops
-# We'll remove them once they become defaults.
-# See https://docs.rubocop.org/en/latest/versioning/
-
-
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
-Lint/RaiseException:
-  Enabled: true
-
-Lint/StructNewOverride:
-  Enabled: true
-
-Style/ExponentialNotation:
-  Enabled: true
-
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-
-Style/SlicingWithRange:
-  Enabled: true
-
-# Introduced in rubocop 0.84.0
-Lint/DeprecatedOpenSSLConstant:
-  Enabled: true
-
-# Introduced in rubocop 0.85.0
-Lint/MixedRegexpCaptureTypes:
-  Enabled: true
-
-Style/RedundantRegexpCharacterClass:
-  Enabled: true
-
-Style/RedundantRegexpEscape:
-  Enabled: true

data/.rubocop_todo.yml

@@ -1,14 +1,54 @@
+---
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-03-27 01:01:12 +0100 using RuboCop version 0.38.0.
+# on 2021-10-04 12:28:12 UTC using RuboCop version 1.22.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-Style/Documentation:
-  # Silence this check for now until we fix it.
+# Offense count: 71
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 17
+
+# Offense count: 1
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/dnsimple/client/client_service_spec.rb'
+
+# Offense count: 11
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 112
+RSpec/MultipleExpectations:
+  Max: 15
+
+# Offense count: 375
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
   Enabled: false
+
+# Offense count: 16
+RSpec/SubjectStub:
   Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
+    - 'spec/dnsimple/client/certificates_spec.rb'
+    - 'spec/dnsimple/client/contacts_spec.rb'
+    - 'spec/dnsimple/client/domains_delegation_signer_records_spec.rb'
+    - 'spec/dnsimple/client/domains_email_forwards_spec.rb'
+    - 'spec/dnsimple/client/domains_spec.rb'
+    - 'spec/dnsimple/client/services_spec.rb'
+    - 'spec/dnsimple/client/templates_records_spec.rb'
+    - 'spec/dnsimple/client/templates_spec.rb'
+    - 'spec/dnsimple/client/tlds_spec.rb'
+    - 'spec/dnsimple/client/zones_records_spec.rb'
+    - 'spec/dnsimple/client/zones_spec.rb'
+    - 'spec/dnsimple/client_spec.rb'
+
+# Offense count: 37
+# Configuration parameters: AllowedConstants.
+Style/Documentation:
+  Enabled: false

data/CHANGELOG.md

@@ -2,6 +2,28 @@
 
 This project uses [Semantic Versioning 2.0.0](http://semver.org/).
 
+## main
+
+## 7.1.0
+
+- CHANGED: Updated DNSSEC-related structs and entrypoints to support DS record key-data interface. (dnsimple/dnsimple-ruby#252)
+
+## 7.0.0
+
+- CHANGED: Minimum Ruby version is now 2.6
+- CHANGED: Deprecates `registrar.getDomainPremiumPrice` in favour of `registrar.getDomainPrices`
+
+## 6.0.0
+
+- NEW: Added `registrar.get_domain_prices` to retrieve whether a domain is premium and the prices to register, transfer, and renew. (dnsimple/dnsimple-ruby#230)
+- REMOVED: `domain.reset_domain_token` endpoint no longer exists and the client method is removed. (dnsimple/dnsimple-ruby#231)
+- REMOVED: The deprecated `Domain.expires_on` is removed. (dnsimple/dnsimple-ruby#232)
+- REMOVED: The deprecated `Certificate.expires_on` is removed. (dnsimple/dnsimple-ruby#232)
+
+## 5.2.0
+
+- CHANGED: `Certificate#expires_on` (date only) is deprecated in favor of `Certificate#expires_at` (timestamp). (dnsimple/dnsimple-ruby#190)
+
 ## 5.1.0
 
 - CHANGED: `Domain#expires_on` (date only) is deprecated in favor of `Domain#expires_at` (timestamp). (dnsimple/dnsimple-ruby#186)
@@ -18,7 +40,6 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
 
 - NEW: Added WHOIS privacy renewal (GH-171)
 
-
 ## 4.5.0
 
 - NEW: Added zone distribution and zone record distribution (GH-160)
@@ -29,26 +50,22 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
 
 - REMOVED: Removed extra alias (GH-168). You should use `dnsimple.foo.list_foo` instead of `dnsimple.foo.list`. Same for create/update. The change ensures consistency across the various clients. We prefer fully qualified methods.
 
-
 ## 4.4.0
 
 - NEW: Added Let's Encrypt certificate methods (GH-159)
 
 - REMOVED: Removed premium_price attribute from registrar order responses (GH-163). Please do not rely on that attribute, as it returned an incorrect value. The attribute is going to be removed, and the API now returns a null value.
 
-
 ## 4.3.0
 
 - NEW: Added `certificates.all_certificates` (dnsimple/dnsimple-ruby#155)
 
 - CHANGED: Updated registrar URLs (dnsimple/dnsimple-ruby#153)
 
-
 ## 4.2.0
 
 - NEW: Added DNSSEC support support (dnsimple/dnsimple-ruby#152)
 
-
 ## 4.1.0
 
 - NEW: Added domain premium price support (dnsimple/dnsimple-ruby#143)
@@ -56,7 +73,6 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
 - CHANGED: Updated registration, transfer, renewal response payload (dnsimple/dnsimple-developer#111, dnsimple/dnsimple-ruby#140).
 - CHANGED: Normalize unique string identifiers to SID (dnsimple/dnsimple-ruby#141)
 
-
 ## 4.0.0
 
 - NEW: Added domain collaborators support (GH-137).
@@ -73,7 +89,6 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
 - CHANGED: Updated Tld payload (GH-133, GH-129).
 - CHANGED: Renamed registrar `auth_info` into `auth_code` (GH-136).
 
-
 ## 3.1.0
 
 - NEW: Added accounts support (GH-113).
@@ -87,7 +102,6 @@ This project uses [Semantic Versioning 2.0.0](http://semver.org/).
 
 - REMOVED: Removed support for wildcard accounts (GH-107).
 
-
 ## 3.0.0
 
 ### stable
@@ -130,7 +144,7 @@ Internal changes were made to match conventions adopted in other clients, such a
 
 ## 2.0.0
 
-**2.0.0.alpha**
+### 2.0.0.alpha
 
 2.0 is a complete client redesign.
 
@@ -148,7 +162,7 @@ Internal changes were made to match conventions adopted in other clients, such a
 
 - REMOVED: The library no longer provides built-in support for loading the credentials from a config file.
 
-**2.0**
+### 2.0
 
 - FIXED: Fixed a bug where API token environment variables were not properly detected (GH-59, GH-62). Thanks @oguzbilgic and @rupurt.
 

data/CONTRIBUTING.md

@@ -2,7 +2,7 @@
 
 ## Getting started
 
-#### 1. Clone the repository
+### 1. Clone the repository
 
 Clone the repository and move into it:
 
@@ -11,19 +11,18 @@ git clone git@github.com:dnsimple/dnsimple-ruby.git
 cd dnsimple-ruby
 ```
 
-#### 2. Install the dependencies
+### 2. Install the dependencies
 
 Install the dependencies using [Bundler](http://bundler.io/):
 
-```
+```shell
 bundle
 ```
 
-#### 3. Build and test
+### 3. Build and test
 
 [Run the test suite](#testing) to check everything works as expected.
 
-
 ## Releasing
 
 The following instructions uses `$VERSION` as a placeholder, where `$VERSION` is a `MAJOR.MINOR.BUGFIX` release such as `1.2.0`.
@@ -36,13 +35,13 @@ The following instructions uses `$VERSION` as a placeholder, where `$VERSION` is
 
 1. Run the test suite and ensure all the tests pass.
 
-1. Finalize the `## master` section in `CHANGELOG.md` assigning the version.
+1. Finalize the `## main` section in `CHANGELOG.md` assigning the version.
 
 1. Commit and push the changes
 
     ```shell
     git commit -a -m "Release $VERSION"
-    git push origin master
+    git push origin main
     ```
 
 1. Wait for CI to complete.
@@ -66,18 +65,16 @@ The following instructions uses `$VERSION` as a placeholder, where `$VERSION` is
     gem push pkg/<filename>
     ```
 
-
 ## Testing
 
 To run the test suite:
 
-```
+```shell
 rake
 ```
 
-
 ## Tests
 
 Submit unit tests for your changes. You can test your changes on your machine by [running the test suite](#testing).
 
-When you submit a PR, tests will also be run on the [continuous integration environment via Travis](https://travis-ci.org/dnsimple/dnsimple-ruby).
+When you submit a PR, tests will also be run on the [continuous integration environment via GitHub Actions](https://github.com/dnsimple/dnsimple-ruby/actions).

data/Gemfile

@@ -5,5 +5,7 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'coveralls', require: false
-gem 'rubocop', '0.85.1', require: false
+gem 'rubocop', '1.22.1', require: false
 gem 'rubocop-performance', require: false
+gem 'rubocop-rake', require: false
+gem 'rubocop-rspec', require: false

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2010-2020 DNSimple Corporation
+Copyright (c) 2010-2021 DNSimple Corporation
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -2,25 +2,24 @@
 
 A Ruby client for the [DNSimple API v2](https://developer.dnsimple.com/v2/).
 
-[![Build Status](https://travis-ci.com/dnsimple/dnsimple-ruby.svg?branch=master)](https://travis-ci.com/dnsimple/dnsimple-ruby)
-[![Coverage Status](https://img.shields.io/coveralls/dnsimple/dnsimple-ruby.svg)](https://coveralls.io/r/dnsimple/dnsimple-ruby?branch=master)
+[![Build Status](https://github.com/dnsimple/dnsimple-ruby/actions/workflows/ci.yml/badge.svg)](https://github.com/dnsimple/dnsimple-ruby/actions/workflows/ci.yml)
+[![Coverage Status](https://img.shields.io/coveralls/dnsimple/dnsimple-ruby.svg)](https://coveralls.io/r/dnsimple/dnsimple-ruby?branch=main)
 
 [DNSimple](https://dnsimple.com/) provides DNS hosting and domain registration that is simple and friendly.
 We provide a full API and an easy-to-use web interface so you can get your domain registered and set up with a minimal amount of effort.
 
-
 ## Installation
 
 You can install the gem manually:
 
-```
+```shell
 gem install dnsimple
 ```
 
 Or use Bundler and define it as a dependency in your Gemfile:
 
-```
-gem 'dnsimple', '~> 4.0'
+```ruby
+gem 'dnsimple', '~> 6.0'
 ```
 
 ## Usage
@@ -59,8 +58,7 @@ response = client.domains.domain(account_id, "example.com")
 puts response.data
 ```
 
-For the full library documentation visit http://rubydoc.info/gems/dnsimple
-
+For the full library documentation visit <http://rubydoc.info/gems/dnsimple>
 
 ## Sandbox Environment
 
@@ -74,7 +72,6 @@ client = Dnsimple::Client.new(base_url: "https://api.sandbox.dnsimple.com", acce
 
 You will need to ensure that you are using an access token created in the sandbox environment. Production tokens will *not* work in the sandbox environment.
 
-
 ## Setting a custom `User-Agent` header
 
 You can customize the `User-Agent` header for the calls made to the DNSimple API:
@@ -87,7 +84,6 @@ The value you provide will be prepended to the default `User-Agent` the client u
 
 We recommend to customize the user agent. If you are building a library or integration on top of the official client, customizing the client will help us to understand what is this client used for, and allow to contribute back or get in touch.
 
-
 ## License
 
-Copyright (c) 2010-2020 DNSimple Corporation. This is Free Software distributed under the MIT license.
+Copyright (c) 2010-2021 DNSimple Corporation. This is Free Software distributed under the MIT license.

data/UPGRADING.md

@@ -7,8 +7,7 @@ and take advantage of Ruby 1.9.3 and Ruby 2.0.
 
 If you are upgrading your code from v1.x, here's the major changes you should be aware of.
 
-
-1.  The client is now an instance.
+1. The client is now an instance.
 
     All the API calls are performed within the scope of an instance, rather than a class,
     making it possible to pass the client around, write thread-safe code and create multiple client instances
@@ -25,7 +24,7 @@ If you are upgrading your code from v1.x, here's the major changes you should be
     domain = client.domains.domain("example.com")
     ```
 
-1.  API call responses are now simple struct-like objects, rather Model-like objects.
+1. API call responses are now simple struct-like objects, rather Model-like objects.
 
     ```ruby
     domain = client.domains.domain("example.com")
@@ -35,7 +34,7 @@ If you are upgrading your code from v1.x, here's the major changes you should be
     A struct-like object is designed to be a simple container of key/value attributes,
     as opposite to a fully-features instance you can interact with.
 
-1.  API methods are now defined as methods of the client instance.
+1. API methods are now defined as methods of the client instance.
 
     This is a consequence (or the cause, depending on the POV) of the previous point. It is no longer possible to call
     persistence methods on an object returned from the API, as it was in v1.
@@ -99,4 +98,4 @@ If you are upgrading your code from v1.x, here's the major changes you should be
 
     ```ruby
     client.domains.update_record("example.com", 12, name: "updated", content: "127.0.0.1")
-    ```
+    ```

data/dnsimple.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |s|
   s.summary     = 'The DNSimple API client for Ruby'
   s.description = 'The DNSimple API client for Ruby.'
 
-  s.required_ruby_version = ">= 2.4"
+  s.required_ruby_version = ">= 2.6"
 
   s.require_paths    = ['lib']
   s.files            = `git ls-files`.split("\n")

data/lib/dnsimple/client/clients.rb

@@ -98,14 +98,15 @@ module Dnsimple
         options = args.pop
         response = nil
 
-        begin
+        loop do
           current_page += 1
           query = Extra.deep_merge(options, query: { page: current_page, per_page: 100 })
 
           response = send(method, *(args + [query]))
           total_pages ||= response.total_pages
           collection.concat(response.data)
-        end while current_page < total_pages
+          break unless current_page < total_pages
+        end
 
         CollectionResponse.new(response.http_response, collection)
       end