dnsimple 4.6.0 → 10.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6ccd26ac738f667185d2005071eb215045dcce8bdcaaf48ba5b1b31f9187bdcf
-  data.tar.gz: a8474bcd18275b39465931d06230fd07434a839a39dbfeead1e130289929f7a6
+  metadata.gz: 717f1a8443a707774595d0f3f4fc0ebeeb1383bd91424e1fdca0e46ba9fd9043
+  data.tar.gz: 0f97c2fa6be76c363bb2a1f6ac793553c051a55f6e191597c0aaf2669c4d3b32
 SHA512:
-  metadata.gz: bb079ccceb1587b61ce3d0660a9963dad812d01da3634d0581dc80095fb2157fc86a191d711590bfb8d85c48c9c47e47a6a30b7e6e14c107b50195894e552c67
-  data.tar.gz: e7a5735a36b36dca5dee66104d90c0bbdb83afa878a9e5423bcac5b46b965a5324e16ad6380cb9f8a51ee91d3df8baa3bff47633c750b9ce529d0a9ed62c0e78
+  metadata.gz: 270a8d238b4e9bca275f407c2643152892288b8328fa0e1df43750b2a180f172e38597697cc2d936ca9eb0eb284bcaa0f80d534692d6ee8ca3cbde0d3f068dda
+  data.tar.gz: 8c0bcc9b2b79848ab07c440e0bda804284918e0cfe668c2d838a388609825ff5d200569d26198aed4d6a5545403f9a026c04b5a10d2fc88987b0988bf0b24608

data/.github/CODEOWNERS

@@ -0,0 +1 @@
+* @dnsimple/external-integrations

data/.github/dependabot.yml

@@ -0,0 +1,21 @@
+---
+version: 2
+updates:
+  - package-ecosystem: bundler
+    directory: /
+    schedule:
+      interval: monthly
+    open-pull-requests-limit: 10
+    labels:
+      - task
+      - dependencies
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: monthly
+      time: '12:00'
+    open-pull-requests-limit: 10
+    labels:
+      - task
+      - dependencies
+      - automerge

data/.github/workflows/auto-merge.yml

@@ -0,0 +1,32 @@
+name: Auto-merge
+
+on:
+  pull_request:
+    types:
+      - labeled
+      - synchronize
+      - opened
+
+jobs:
+  auto-merge:
+    name: 'Auto-merge'
+    runs-on: ubuntu-latest
+    permissions: write-all
+
+    if: github.event.pull_request.user.login == 'dependabot[bot]' && contains(github.event.pull_request.labels.*.name, 'automerge')
+    steps:
+      - name: Wait for tests to succeed
+        uses: lewagon/wait-on-check-action@v1.3.4
+        timeout-minutes: 15
+        with:
+          ref: ${{ github.ref }}
+          running-workflow-name: 'Auto-merge'
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          wait-interval: 10
+          allowed-conclusions: success
+      - uses: juliangruber/merge-pull-request-action@v1
+        with:
+          github-token: "${{ secrets.GITHUB_TOKEN }}"
+          number: ${{ github.event.number }}
+          method: squash
+          repo: dnsimple/dnsimple-ruby

data/.github/workflows/ci.yml

@@ -0,0 +1,45 @@
+name: CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+  workflow_dispatch:
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  markdownlint-cli:
+    name: Lint markdown
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v4
+      - name: Run markdownlint-cli
+        uses: nosborn/github-action-markdown-cli@v3.4.0
+        with:
+          files: .
+          config_file: ".markdownlint.yaml"
+
+  test:
+    needs: [markdownlint-cli]
+    runs-on: ubuntu-latest
+    name: Ruby ${{ matrix.ruby-version }}
+    strategy:
+      matrix:
+        ruby-version:
+          - '3.2'
+          - '3.3'
+          - '3.4'
+          - 'ruby-head'
+          - 'truffleruby-head'
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - run: bundle exec rake

data/.github/workflows/release.yml

@@ -0,0 +1,29 @@
+name: Release
+
+on:
+  push:
+    tags:
+      - v*.*.*
+jobs:
+  publish:
+    name: Release to RubyGems
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Wait for tests to succeed
+        uses: lewagon/wait-on-check-action@v1.3.4
+        with:
+          ref: 'refs/heads/main'
+          running-workflow-name: 'Release to RubyGems'
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          wait-interval: 10
+          allowed-conclusions: success
+
+      - uses: actions/checkout@v4
+
+      - name: Release Gem
+        uses: simplyqio/publish-rubygems-action@2.0.0
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          RUBYGEMS_API_KEY: ${{ secrets.RUBYGEMS_API_KEY }}
+          RELEASE_COMMAND: "rake build && gem push pkg/*.gem"

data/.gitignore

@@ -1,3 +1,6 @@
+# ASDF
+.tool-versions
+
 # Bundler
 .bundle
 pkg/*

data/.markdownlint.yaml

@@ -0,0 +1,3 @@
+---
+default: true
+line-length: false

data/.rubocop.yml

@@ -1,23 +1,16 @@
+---
 inherit_from:
   - .rubocop_todo.yml
   - .rubocop_dnsimple.yml
 
+require:
+  - rubocop-performance
+  - rubocop-rake
+  - rubocop-rspec
+
 AllCops:
+  TargetRubyVersion: 3.0
   Exclude:
     - '*.gemspec'
     - 'Rakefile'
-
-# [codesmell]
-# It's irrelevant here, but it could be a code smell.
-# Hence keep it disabled, but don't include it in the DNSimple suite.
-Lint/Loop:
-  Enabled: false
-
-# It doesn't seem to work as expected.
-Style/IfUnlessModifier:
-  Enabled: false
-
-# This rule suggest to use safe navigation (&.) operator which was introduced
-# with Ruby 2.3. Because we are supporting Ruby 2.0+ we can't use this operator.
-Style/SafeNavigation:
-  Enabled: false
+    - 'vendor/**/*'

data/.rubocop_dnsimple.yml

@@ -8,6 +8,7 @@ AllCops:
   Exclude:
     # Exclude .gemspec files because they are generally auto-generated
     - '*.gemspec'
+  NewCops: enable
 
 # In most cases, Gems are sorted alphabetically.
 # However, in some few cases the order is relevant due to dependencies.
@@ -19,6 +20,10 @@ Bundler/OrderedGems:
 Layout/AccessModifierIndentation:
   Enabled: false
 
+# It causes weird aligments, especially for specs.
+Layout/BlockEndNewline:
+  Enabled: false
+
 # Generally, the keyword style uses a lot of space. This is particularly true when
 # you use case/if statements, in combination with a long-name variable.
 #
@@ -33,7 +38,15 @@ Layout/EndAlignment:
   EnforcedStyleAlignWith: variable
 
 # [codesmell]
-Lint/HandleExceptions:
+Layout/LineLength:
+  Enabled: false
+  Exclude:
+    - 'spec/**/*_spec.rb'
+    - 'test/**/*_test.rb'
+  Max: 100
+
+# [codesmell]
+Lint/SuppressedException:
   Enabled: false
 
 # [codesmell]
@@ -61,14 +74,6 @@ Metrics/ClassLength:
     - 'spec/**/*_spec.rb'
     - 'test/**/*_test.rb'
 
-# [codesmell]
-Metrics/LineLength:
-  Enabled: false
-  Exclude:
-    - 'spec/**/*_spec.rb'
-    - 'test/**/*_test.rb'
-  Max: 100
-
 # [codesmell]
 Metrics/MethodLength:
   Enabled: false
@@ -105,23 +110,21 @@ Naming/MemoizedInstanceVariableName:
 Naming/PredicateName:
   Enabled: false
 
+# The team agreed decided to use exception
+Naming/RescuedExceptionsVariableName:
+  PreferredName: 'exception'
+
 # This cop triggers several false positives that make sense in our domain model.
 # For instance, ip is considered an uncommunicative parameter name:
 #
 #   ipv4_to_arpa_name(ip)
 #
-Naming/UncommunicativeMethodParamName:
+Naming/MethodParameterName:
   Enabled: false
 
-# [codesmell]
-# I don't really get the point of this cop.
-Performance/RedundantMerge:
-  Enabled: false
-
-# This cop returns false positive violations (as of rubocop 0.57.0)
-# https://github.com/rubocop-hq/rubocop/issues/5953
-Style/AccessModifierDeclarations:
-  Enabled: false
+Style/AccessorGrouping:
+  Enabled: true
+  EnforcedStyle: separated
 
 # Do not use "and" or "or" in conditionals, but for readability we can use it
 # to chain executions. Just beware of operator order.
@@ -132,26 +135,19 @@ Style/AndOr:
 Style/BarePercentLiterals:
   EnforcedStyle: percent_q
 
-# braces_for_chaining seems a good fit of what we've been doing so far.
+# Pick one option for consistency.
 Style/BlockDelimiters:
   EnforcedStyle: braces_for_chaining
-  IgnoredMethods:
+  AllowedMethods:
     - expect
 
-# I'm not sure we should enforce a style,
-# but if we do, context_dependent offers a good compromise on readability.
-Style/BracesAroundHashParameters:
-  Enabled: false
-  EnforcedStyle: context_dependent
-
 # Warn on empty else.
 Style/EmptyElse:
   EnforcedStyle: empty
 
-# There is no specific preference for empty methods.
-# One-line methods are not exceptionally nice in Ruby. Just ignore this cop for now.
+# Pick one option for consistency.
 Style/EmptyMethod:
-  Enabled: false
+  EnforcedStyle: expanded
 
 # We don't care about the format style.
 # In most cases we use %, but not at the point we want to enforce it
@@ -164,16 +160,10 @@ Style/FormatString:
 Style/FormatStringToken:
   Enabled: false
 
-# We don't support frozen strings.
-# This is an experimental feature and we don't know if it will be shipped with
-# Ruby 3.0 or not.
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 # Prefer the latest Hash syntax
 Style/HashSyntax:
   Exclude:
-    # But Rakefiles generally have some definition like
+    # Rakefiles generally have definitions like
     #   :default => :test
     # that looks nicer with the old rocket syntax.
     - 'Rakefile'
@@ -188,7 +178,7 @@ Style/IfInsideElse:
   Enabled: false
 
 # module_function doesn't respect the visibility of the methods,
-# and doesn't work well when the module contain both public/private methods.
+# and doesn't work well when the module contains both public/private methods.
 Style/ModuleFunction:
   Enabled: false
 
@@ -209,11 +199,6 @@ Style/NumericLiterals:
     - 'spec/**/*_spec.rb'
     - 'test/**/*_test.rb'
 
-# For years, %w() has been the de-facto standard. A lot of libraries are using ().
-# Switching to [] would be a nightmare.
-Style/PercentLiteralDelimiters:
-  Enabled: false
-
 # Enable but only for multiple returns value.
 #
 #   return foo, bar
@@ -225,15 +210,6 @@ Style/PercentLiteralDelimiters:
 Style/RedundantReturn:
   AllowMultipleReturnValues: true
 
-# Do we care?
-Style/RegexpLiteral:
-  Enabled: false
-
-# There are cases were the inline rescue is ok. We can either downgrade the severity,
-# or rely on the developer judgement on a case-by-case basis.
-Style/RescueModifier:
-  Enabled: false
-
 # This is quite annoying, especially in cases where we don't control it (e.g. schema.rb).
 Style/SymbolArray:
   Enabled: false
@@ -249,9 +225,8 @@ Style/StringLiterals:
   Enabled: false
   EnforcedStyle: double_quotes
 
-# As before.
+# Pick one option for consistency.
 Style/StringLiteralsInInterpolation:
-  Enabled: false
   EnforcedStyle: double_quotes
 
 # It's nice to be consistent. The trailing comma also allows easy reordering,
@@ -278,18 +253,6 @@ Style/WordArray:
   EnforcedStyle: percent
   MinSize: 3
 
-# Forces the order of comparison arguments.
-#
-# According to this cop, the following statement is bad:
-#
-#   "https" == uri.scheme
-#
-# Whereas the following is considered good:
-#
-#   uri.scheme == "https"
-Style/YodaCondition:
-  Enabled: false
-
 # For the same reason of EndAlignment, aligning with the case may have a bad impact
 # on a case after a very long variable.
 #
@@ -313,10 +276,6 @@ Layout/DotPosition:
 Layout/EmptyLines:
   Enabled: false
 
-# This is buggy. It detects as a style violation a few `class` and `module` definitions
-Layout/EmptyLinesAroundArguments:
-  Enabled: false
-
 Layout/EmptyLinesAroundBlockBody:
   Exclude:
     # RSpec is all made of blocks. Disable this config in RSpec
@@ -324,37 +283,33 @@ Layout/EmptyLinesAroundBlockBody:
     - 'spec/**/*_spec.rb'
     - 'test/**/*_test.rb'
 
-# In most cases, a space is nice. Sometimes, it's not.
-# Just be consistent with the rest of the surrounding code.
+# Pick one option for consistency. beginning+ending is the most used approach.
 Layout/EmptyLinesAroundClassBody:
-  Enabled: false
+  EnforcedStyle: empty_lines_except_namespace
 
 # We're ok with it. We use it quite often for method-level rescue statements.
 Layout/EmptyLinesAroundExceptionHandlingKeywords:
   Enabled: false
 
-# In most cases, a space is nice. Sometimes, it's not.
-# Just be consistent with the rest of the surrounding code.
+# Pick one option for consistency. beginning+ending is the most used approach.
 Layout/EmptyLinesAroundModuleBody:
-  Enabled: false
+  EnforcedStyle: empty_lines_except_namespace
 
 # This is quite buggy, as it doesn't recognize double lines.
 Layout/EmptyLineBetweenDefs:
   Enabled: false
 
 # Multi-line differs from standard indentation, they are indented twice.
-Layout/FirstParameterIndentation:
+Layout/FirstArgumentIndentation:
   IndentationWidth: 4
 
-# Array indentation should be considered like MultilineMethodCallIndentation indentation
-# and use 4 spaces instead of 2.
-Layout/IndentArray:
-  IndentationWidth: 4
+# Array indentation should be consistent with method/variable definition.
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
 
-# Hash indentation should be considered like MultilineMethodCallIndentation indentation
-# and use 4 spaces instead of 2.
-Layout/IndentHash:
-  IndentationWidth: 4
+# Hash indentation should be consistent with method/variable definition.
+Layout/FirstHashElementIndentation:
+  EnforcedStyle: consistent
 
 # Multi-line differs from standard indentation, they are indented twice.
 Layout/MultilineMethodCallIndentation:
@@ -370,9 +325,9 @@ Layout/MultilineOperationIndentation:
 #
 #   %w( foo bar )
 #
-# looks better to me than
+# looks better than:
 #
-#   %w( foo bar )
+#   %w(foo bar)
 #
 Layout/SpaceInsidePercentLiteralDelimiters:
   Enabled: false

data/.rubocop_todo.yml

@@ -1,14 +1,54 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-03-27 01:01:12 +0100 using RuboCop version 0.38.0.
+# on 2023-01-26 12:48:02 UTC using RuboCop version 1.44.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-Style/Documentation:
-  # Silence this check for now until we fix it.
+# Offense count: 74
+# Configuration parameters: CountAsOne.
+RSpec/ExampleLength:
+  Max: 17
+
+# Offense count: 1
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/dnsimple/client/client_service_spec.rb'
+
+# Offense count: 12
+# Configuration parameters: .
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
+# Offense count: 115
+RSpec/MultipleExpectations:
+  Max: 15
+
+# Offense count: 372
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
+RSpec/NamedSubject:
   Enabled: false
+
+# Offense count: 16
+RSpec/SubjectStub:
   Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
+    - 'spec/dnsimple/client/certificates_spec.rb'
+    - 'spec/dnsimple/client/contacts_spec.rb'
+    - 'spec/dnsimple/client/domains_delegation_signer_records_spec.rb'
+    - 'spec/dnsimple/client/domains_email_forwards_spec.rb'
+    - 'spec/dnsimple/client/domains_spec.rb'
+    - 'spec/dnsimple/client/services_spec.rb'
+    - 'spec/dnsimple/client/templates_records_spec.rb'
+    - 'spec/dnsimple/client/templates_spec.rb'
+    - 'spec/dnsimple/client/tlds_spec.rb'
+    - 'spec/dnsimple/client/zones_records_spec.rb'
+    - 'spec/dnsimple/client/zones_spec.rb'
+    - 'spec/dnsimple/client_spec.rb'
+
+# Offense count: 69
+# Configuration parameters: AllowedConstants.
+Style/Documentation:
+  Enabled: false