dnsimple 4.3.0 → 5.1.0

data/spec/dnsimple/client/client_service_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client::ClientService do

data/spec/dnsimple/client/contacts_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".contacts" do
@@ -54,7 +56,7 @@ describe Dnsimple::Client, ".contacts" do
     it "exposes the pagination information" do
       response = subject.contacts(account_id)
 
-      expect(response.respond_to?(:page)).to be_truthy
+      expect(response.respond_to?(:page)).to be(true)
       expect(response.page).to eq(1)
       expect(response.per_page).to be_a(Integer)
       expect(response.total_entries).to be_a(Integer)

data/spec/dnsimple/client/{collaborators_spec.rb → domains_collaborators_spec.rb}

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -49,7 +51,7 @@ describe Dnsimple::Client, ".domains" do
     it "exposes the pagination information" do
       response = subject.collaborators(account_id, domain_id)
 
-      expect(response.respond_to?(:page)).to be_truthy
+      expect(response.respond_to?(:page)).to be(true)
       expect(response.page).to eq(1)
       expect(response.per_page).to be_a(Integer)
       expect(response.total_entries).to be_a(Integer)

data/spec/dnsimple/client/domains_delegation_signer_records_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -55,7 +57,7 @@ describe Dnsimple::Client, ".domains" do
     it "exposes the pagination information" do
       response = subject.delegation_signer_records(account_id, domain_id)
 
-      expect(response.respond_to?(:page)).to be_truthy
+      expect(response.respond_to?(:page)).to be(true)
       expect(response.page).to eq(1)
       expect(response.per_page).to be_a(Integer)
       expect(response.total_entries).to be_a(Integer)

data/spec/dnsimple/client/domains_dnssec_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -27,7 +29,7 @@ describe Dnsimple::Client, ".domains" do
 
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::Dnssec)
-      expect(result.enabled).to be_truthy
+      expect(result.enabled).to be(true)
     end
 
     context "when the domain does not exist" do
@@ -103,7 +105,7 @@ describe Dnsimple::Client, ".domains" do
 
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::Dnssec)
-      expect(result.enabled).to be_truthy
+      expect(result.enabled).to be(true)
     end
 
     context "when the domain does not exist" do

data/spec/dnsimple/client/domains_email_forwards_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -55,7 +57,7 @@ describe Dnsimple::Client, ".domains" do
     it "exposes the pagination information" do
       response = subject.email_forwards(account_id, domain_id)
 
-      expect(response.respond_to?(:page)).to be_truthy
+      expect(response.respond_to?(:page)).to be(true)
       expect(response.page).to eq(1)
       expect(response.per_page).to be_a(Integer)
       expect(response.total_entries).to be_a(Integer)

data/spec/dnsimple/client/domains_pushes_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -76,7 +78,7 @@ describe Dnsimple::Client, ".domains" do
     it "exposes the pagination information" do
       response = subject.pushes(account_id)
 
-      expect(response.respond_to?(:page)).to be_truthy
+      expect(response.respond_to?(:page)).to be(true)
       expect(response.page).to eq(1)
       expect(response.per_page).to be_a(Integer)
       expect(response.total_entries).to be_a(Integer)

data/spec/dnsimple/client/domains_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".domains" do
@@ -33,9 +35,9 @@ describe Dnsimple::Client, ".domains" do
     end
 
     it "supports sorting" do
-      subject.domains(account_id, sort: "expires_on:asc")
+      subject.domains(account_id, sort: "expiration:asc")
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains?sort=expires_on:asc")
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains?sort=expiration:asc")
     end
 
     it "supports filtering" do
@@ -60,7 +62,7 @@ describe Dnsimple::Client, ".domains" do
     it "exposes the pagination information" do
       response = subject.domains(account_id)
 
-      expect(response.respond_to?(:page)).to be_truthy
+      expect(response.respond_to?(:page)).to be(true)
       expect(response.page).to eq(1)
       expect(response.per_page).to be_a(Integer)
       expect(response.total_entries).to be_a(Integer)
@@ -82,9 +84,9 @@ describe Dnsimple::Client, ".domains" do
     end
 
     it "supports sorting" do
-      subject.all_domains(account_id, sort: "expires_on:asc")
+      subject.all_domains(account_id, sort: "expiration:asc")
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains?page=1&per_page=100&sort=expires_on:asc")
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains?page=1&per_page=100&sort=expiration:asc")
     end
 
     it "supports filtering" do
@@ -131,28 +133,29 @@ describe Dnsimple::Client, ".domains" do
     end
 
     it "builds the correct request" do
-      subject.domain(account_id, domain = "example.com")
+      subject.domain(account_id, domain = "example-alpha.com")
 
       expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain}")
           .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the domain" do
-      response = subject.domain(account_id, "example.com")
+      response = subject.domain(account_id, "example-alpha.com")
       expect(response).to be_a(Dnsimple::Response)
 
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::Domain)
-      expect(result.id).to eq(1)
-      expect(result.account_id).to eq(1010)
-      expect(result.registrant_id).to eq(nil)
+      expect(result.id).to eq(181984)
+      expect(result.account_id).to eq(1385)
+      expect(result.registrant_id).to eq(2715)
       expect(result.name).to eq("example-alpha.com")
-      expect(result.state).to eq("hosted")
-      expect(result.auto_renew).to eq(false)
-      expect(result.private_whois).to eq(false)
-      expect(result.expires_on).to eq(nil)
-      expect(result.created_at).to eq("2014-12-06T15:56:55Z")
-      expect(result.updated_at).to eq("2015-12-09T00:20:56Z")
+      expect(result.state).to eq("registered")
+      expect(result.auto_renew).to be(false)
+      expect(result.private_whois).to be(false)
+      expect(result.expires_at).to eq("2021-06-05T02:15:00Z")
+      expect(result.expires_on).to eq("2021-06-05")
+      expect(result.created_at).to eq("2020-06-04T19:15:14Z")
+      expect(result.updated_at).to eq("2020-06-04T19:15:21Z")
     end
 
     context "when the domain does not exist" do

data/spec/dnsimple/client/identity_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".identity" do

data/spec/dnsimple/client/oauth_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".oauth" do

data/spec/dnsimple/client/registrar_auto_renewal_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".registrar" do

data/spec/dnsimple/client/registrar_delegation_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".registrar" do
@@ -75,8 +77,9 @@ describe Dnsimple::Client, ".registrar" do
       response = subject.change_domain_delegation_to_vanity(account_id, "example.com", attributes)
       expect(response).to be_a(Dnsimple::Response)
 
-      vanity_name_servers = response.data.map { |ns| ns["name"] }
-      expect(vanity_name_servers).to match_array(%w(ns1.example.com ns2.example.com))
+      vanity_name_server = response.data.first
+      expect(vanity_name_server).to be_a(Dnsimple::Struct::VanityNameServer)
+      expect(vanity_name_server.name).to eq("ns1.example.com")
     end
   end
 

data/spec/dnsimple/client/registrar_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".registrar" do
@@ -27,8 +29,8 @@ describe Dnsimple::Client, ".registrar" do
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::DomainCheck)
       expect(result.domain).to eq("ruby.codes")
-      expect(result.available).to be_truthy
-      expect(result.premium).to be_truthy
+      expect(result.available).to be(true)
+      expect(result.premium).to be(true)
     end
   end
 
@@ -37,7 +39,7 @@ describe Dnsimple::Client, ".registrar" do
 
     context "when premium price" do
       before do
-        stub_request(:get, %r{/v2/#{account_id}/registrar/domains/.+/premium_price[\?action]*})
+        stub_request(:get, %r{/v2/#{account_id}/registrar/domains/.+/premium_price[?action]*})
             .to_return(read_http_fixture("getDomainPremiumPrice/success.http"))
       end
 
@@ -212,12 +214,79 @@ describe Dnsimple::Client, ".registrar" do
     end
   end
 
+  describe "#get_transfer_domain" do
+    let(:account_id) { 1010 }
+
+    before do
+      stub_request(:get, %r{/v2/#{account_id}/registrar/domains/.+/transfers/.+$})
+          .to_return(read_http_fixture("getDomainTransfer/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.get_domain_transfer(account_id, domain_name = "example.com", transfer_id = 361)
+
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/transfers/#{transfer_id}")
+          .with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the domain transfer" do
+      response = subject.get_domain_transfer(account_id, "example.com", 361)
+      expect(response).to be_a(Dnsimple::Response)
+
+      result = response.data
+      expect(result).to be_a(Dnsimple::Struct::DomainTransfer)
+      expect(result.id).to eq(361)
+      expect(result.domain_id).to eq(182245)
+      expect(result.registrant_id).to eq(2715)
+      expect(result.state).to eq("cancelled")
+      expect(result.auto_renew).to be(false)
+      expect(result.whois_privacy).to be(false)
+      expect(result.status_description).to eq("Canceled by customer")
+      expect(result.created_at).to eq("2020-06-05T18:08:00Z")
+      expect(result.updated_at).to eq("2020-06-05T18:10:01Z")
+    end
+  end
+
+  describe "#cancel_domain_transfer" do
+    let(:account_id) { 1010 }
+
+    before do
+      stub_request(:delete, %r{/v2/#{account_id}/registrar/domains/.+/transfers/.+$})
+          .to_return(read_http_fixture("cancelDomainTransfer/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.cancel_domain_transfer(account_id, domain_name = "example.com", transfer_id = 361)
+
+      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/transfers/#{transfer_id}")
+          .with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the domain transfer" do
+      response = subject.cancel_domain_transfer(account_id, "example.com", 361)
+      expect(response).to be_a(Dnsimple::Response)
+
+      result = response.data
+      expect(result).to be_a(Dnsimple::Struct::DomainTransfer)
+      expect(result.id).to eq(361)
+      expect(result.domain_id).to eq(182245)
+      expect(result.registrant_id).to eq(2715)
+      expect(result.state).to eq("transferring")
+      expect(result.auto_renew).to be(false)
+      expect(result.whois_privacy).to be(false)
+      expect(result.status_description).to eq(nil)
+      expect(result.created_at).to eq("2020-06-05T18:08:00Z")
+      expect(result.updated_at).to eq("2020-06-05T18:08:04Z")
+    end
+  end
+
+
   describe "#transfer_domain_out" do
     let(:account_id) { 1010 }
 
     before do
       stub_request(:post, %r{/v2/#{account_id}/registrar/domains/.+/authorize_transfer_out$})
-          .to_return(read_http_fixture("transferDomainOut/success.http"))
+          .to_return(read_http_fixture("authorizeDomainTransferOut/success.http"))
     end
 
     it "builds the correct request" do

data/spec/dnsimple/client/registrar_whois_privacy_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".registrar" do
@@ -27,7 +29,7 @@ describe Dnsimple::Client, ".registrar" do
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::WhoisPrivacy)
       expect(result.domain_id).to be_kind_of(Integer)
-      expect(result.enabled).to be_truthy
+      expect(result.enabled).to be(true)
       expect(result.expires_on).to be_kind_of(String)
     end
   end
@@ -56,7 +58,7 @@ describe Dnsimple::Client, ".registrar" do
         result = response.data
         expect(result).to be_a(Dnsimple::Struct::WhoisPrivacy)
         expect(result.domain_id).to be_kind_of(Integer)
-        expect(result.enabled).to be_truthy
+        expect(result.enabled).to be(true)
         expect(result.expires_on).to be_kind_of(String)
       end
     end
@@ -111,9 +113,64 @@ describe Dnsimple::Client, ".registrar" do
       result = response.data
       expect(result).to be_a(Dnsimple::Struct::WhoisPrivacy)
       expect(result.domain_id).to be_kind_of(Integer)
-      expect(result.enabled).to be_falsey
+      expect(result.enabled).to be(false)
+      expect(result.expires_on).to be_kind_of(String)
+    end
+  end
+
+
+  describe "#renew_whois_privacy" do
+    let(:account_id) { 1010 }
+
+    before do
+      stub_request(:post, %r{/v2/#{account_id}/registrar/domains/.+/whois_privacy/renewals$})
+          .to_return(read_http_fixture("renewWhoisPrivacy/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.renew_whois_privacy(account_id, domain_name = "example.com")
+
+      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy/renewals")
+          .with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the whois privacy order" do
+      response = subject.renew_whois_privacy(account_id, "example.com")
+      expect(response).to be_a(Dnsimple::Response)
+
+      result = response.data
+      expect(result).to be_a(Dnsimple::Struct::WhoisPrivacyRenewal)
+      expect(result.domain_id).to be_kind_of(Integer)
+      expect(result.whois_privacy_id).to be_kind_of(Integer)
+      expect(result.enabled).to be(true)
       expect(result.expires_on).to be_kind_of(String)
     end
+
+    context "when whois privacy was't previously purchased" do
+      before do
+        stub_request(:post, %r{/v2/#{account_id}/registrar/domains/.+/whois_privacy/renewals$})
+            .to_return(read_http_fixture("renewWhoisPrivacy/whois-privacy-not-found.http"))
+      end
+
+      it "raises error" do
+        expect do
+          subject.renew_whois_privacy(account_id, "example.com")
+        end.to raise_error(Dnsimple::RequestError, "WHOIS privacy not found for example.com")
+      end
+    end
+
+    context "when there is already a whois privacy renewal order in progress" do
+      before do
+        stub_request(:post, %r{/v2/#{account_id}/registrar/domains/.+/whois_privacy/renewals$})
+            .to_return(read_http_fixture("renewWhoisPrivacy/whois-privacy-duplicated-order.http"))
+      end
+
+      it "raises error" do
+        expect do
+          subject.renew_whois_privacy(account_id, "example.com")
+        end.to raise_error(Dnsimple::RequestError, "The whois privacy for example.com has just been renewed, a new renewal cannot be started at this time")
+      end
+    end
   end
 
 end

data/spec/dnsimple/client/services_domains_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".services" do

data/spec/dnsimple/client/services_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".services" do
@@ -98,7 +100,7 @@ describe Dnsimple::Client, ".services" do
       expect(service.sid).to eq("service1")
       expect(service.description).to eq("First service example.")
       expect(service.setup_description).to be_nil
-      expect(service.requires_setup).to eq(true)
+      expect(service.requires_setup).to be(true)
       expect(service.default_subdomain).to be_nil
 
       settings = service.settings

data/spec/dnsimple/client/templates_domains_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Dnsimple::Client, ".templates" do