dnsimple 4.2.0 → 4.3.0

data/spec/dnsimple/client/client_service_spec.rb

@@ -19,12 +19,12 @@ describe Dnsimple::Client::ClientService do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:get, %r{/v2/#{account_id}/list\?page=1&per_page=100}).
-          to_return(read_http_fixture("pages-1of3.http"))
-      stub_request(:get, %r{/v2/#{account_id}/list\?page=2&per_page=100}).
-          to_return(read_http_fixture("pages-2of3.http"))
-      stub_request(:get, %r{/v2/#{account_id}/list\?page=3&per_page=100}).
-          to_return(read_http_fixture("pages-3of3.http"))
+      stub_request(:get, %r{/v2/#{account_id}/list\?page=1&per_page=100})
+          .to_return(read_http_fixture("pages-1of3.http"))
+      stub_request(:get, %r{/v2/#{account_id}/list\?page=2&per_page=100})
+          .to_return(read_http_fixture("pages-2of3.http"))
+      stub_request(:get, %r{/v2/#{account_id}/list\?page=3&per_page=100})
+          .to_return(read_http_fixture("pages-3of3.http"))
     end
 
     it "loops all the pages" do

data/spec/dnsimple/client/collaborators_spec.rb

@@ -10,15 +10,15 @@ describe Dnsimple::Client, ".domains" do
     let(:domain_id)  { "example.com" }
 
     before do
-      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators}).
-          to_return(read_http_fixture("listCollaborators/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators})
+          .to_return(read_http_fixture("listCollaborators/success.http"))
     end
 
     it "builds the correct request" do
       subject.collaborators(account_id, domain_id)
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/collaborators").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/collaborators")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "supports pagination" do
@@ -63,8 +63,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "invite user already registered on DNSimple" do
       before do
-        stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators$}).
-            to_return(read_http_fixture("addCollaborator/success.http"))
+        stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators$})
+            .to_return(read_http_fixture("addCollaborator/success.http"))
       end
 
       let(:attributes) { { email: "existing-user@example.com" } }
@@ -72,9 +72,9 @@ describe Dnsimple::Client, ".domains" do
       it "builds the correct request" do
         subject.add_collaborator(account_id, domain_id, attributes)
 
-        expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/collaborators").
-            with(body: attributes).
-            with(headers: { 'Accept' => 'application/json' })
+        expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/collaborators")
+            .with(body: attributes)
+            .with(headers: { 'Accept' => 'application/json' })
       end
 
       it "returns the contact" do
@@ -93,8 +93,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "invite not registered on DNSimple" do
       before do
-        stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators$}).
-            to_return(read_http_fixture("addCollaborator/invite-success.http"))
+        stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators$})
+            .to_return(read_http_fixture("addCollaborator/invite-success.http"))
       end
 
       let(:attributes) { { email: "invited-user@example.com" } }
@@ -102,9 +102,9 @@ describe Dnsimple::Client, ".domains" do
       it "builds the correct request" do
         subject.add_collaborator(account_id, domain_id, attributes)
 
-        expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/collaborators").
-            with(body: attributes).
-            with(headers: { 'Accept' => 'application/json' })
+        expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/collaborators")
+            .with(body: attributes)
+            .with(headers: { 'Accept' => 'application/json' })
       end
 
       it "returns the contact" do
@@ -128,15 +128,15 @@ describe Dnsimple::Client, ".domains" do
     let(:collaborator_id) { 100 }
 
     before do
-      stub_request(:delete, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators/.+$}).
-          to_return(read_http_fixture("removeCollaborator/success.http"))
+      stub_request(:delete, %r{/v2/#{account_id}/domains/#{domain_id}/collaborators/.+$})
+          .to_return(read_http_fixture("removeCollaborator/success.http"))
     end
 
     it "builds the correct request" do
       subject.remove_collaborator(account_id, domain_id, collaborator_id)
 
-      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/collaborators/#{collaborator_id}").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/collaborators/#{collaborator_id}")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns nothing" do
@@ -149,8 +149,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "when the collaborator does not exist" do
       it "raises NotFoundError" do
-        stub_request(:delete, %r{/v2}).
-            to_return(read_http_fixture("notfound-collaborator.http"))
+        stub_request(:delete, %r{/v2})
+            .to_return(read_http_fixture("notfound-collaborator.http"))
 
         expect {
           subject.remove_collaborator(account_id, domain_id, collaborator_id)

data/spec/dnsimple/client/contacts_spec.rb

@@ -9,15 +9,15 @@ describe Dnsimple::Client, ".contacts" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:get, %r{/v2/#{account_id}/contacts}).
-          to_return(read_http_fixture("listContacts/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/contacts})
+          .to_return(read_http_fixture("listContacts/success.http"))
     end
 
     it "builds the correct request" do
       subject.contacts(account_id)
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/contacts").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/contacts")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "supports pagination" do
@@ -64,8 +64,8 @@ describe Dnsimple::Client, ".contacts" do
 
   describe "#all_contacts" do
     before do
-      stub_request(:get, %r{/v2/#{account_id}/contacts}).
-          to_return(read_http_fixture("listContacts/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/contacts})
+          .to_return(read_http_fixture("listContacts/success.http"))
     end
 
     let(:account_id) { 1010 }
@@ -86,8 +86,8 @@ describe Dnsimple::Client, ".contacts" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:post, %r{/v2/#{account_id}/contacts$}).
-          to_return(read_http_fixture("createContact/created.http"))
+      stub_request(:post, %r{/v2/#{account_id}/contacts$})
+          .to_return(read_http_fixture("createContact/created.http"))
     end
 
     let(:attributes) { { first_name: "Simone", last_name: "Carletti", address1: "Italian Street", city: "Rome", state_province: "RM", postal_code: "00171", country: "IT", email: "example@example.com", phone: "+393391234567" } }
@@ -95,9 +95,9 @@ describe Dnsimple::Client, ".contacts" do
     it "builds the correct request" do
       subject.create_contact(account_id, attributes)
 
-      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/contacts").
-          with(body: attributes).
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/contacts")
+          .with(body: attributes)
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the contact" do
@@ -114,15 +114,15 @@ describe Dnsimple::Client, ".contacts" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:get, %r{/v2/#{account_id}/contacts/.+$}).
-          to_return(read_http_fixture("getContact/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/contacts/.+$})
+          .to_return(read_http_fixture("getContact/success.http"))
     end
 
     it "builds the correct request" do
       subject.contact(account_id, contact = 1)
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/contacts/#{contact}").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/contacts/#{contact}")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the contact" do
@@ -139,8 +139,8 @@ describe Dnsimple::Client, ".contacts" do
 
     context "when the contact does not exist" do
       it "raises NotFoundError" do
-        stub_request(:get, %r{/v2}).
-            to_return(read_http_fixture("notfound-contact.http"))
+        stub_request(:get, %r{/v2})
+            .to_return(read_http_fixture("notfound-contact.http"))
 
         expect {
           subject.contact(account_id, 0)
@@ -153,8 +153,8 @@ describe Dnsimple::Client, ".contacts" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:patch, %r{/v2/#{account_id}/contacts/.+$}).
-          to_return(read_http_fixture("updateContact/success.http"))
+      stub_request(:patch, %r{/v2/#{account_id}/contacts/.+$})
+          .to_return(read_http_fixture("updateContact/success.http"))
     end
 
     let(:attributes) { { first_name: "Updated" } }
@@ -162,9 +162,9 @@ describe Dnsimple::Client, ".contacts" do
     it "builds the correct request" do
       subject.update_contact(account_id, contact_id = 1, attributes)
 
-      expect(WebMock).to have_requested(:patch, "https://api.dnsimple.test/v2/#{account_id}/contacts/#{contact_id}").
-          with(body: attributes).
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:patch, "https://api.dnsimple.test/v2/#{account_id}/contacts/#{contact_id}")
+          .with(body: attributes)
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the contact" do
@@ -178,8 +178,8 @@ describe Dnsimple::Client, ".contacts" do
 
     context "when the contact does not exist" do
       it "raises NotFoundError" do
-        stub_request(:patch, %r{/v2}).
-            to_return(read_http_fixture("notfound-contact.http"))
+        stub_request(:patch, %r{/v2})
+            .to_return(read_http_fixture("notfound-contact.http"))
 
         expect {
           subject.update_contact(account_id, 0, {})
@@ -192,15 +192,15 @@ describe Dnsimple::Client, ".contacts" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:delete, %r{/v2/#{account_id}/contacts/.+$}).
-          to_return(read_http_fixture("deleteContact/success.http"))
+      stub_request(:delete, %r{/v2/#{account_id}/contacts/.+$})
+          .to_return(read_http_fixture("deleteContact/success.http"))
     end
 
     it "builds the correct request" do
       subject.delete_contact(account_id, domain = "example.com")
 
-      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/contacts/#{domain}").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/contacts/#{domain}")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns nothing" do
@@ -213,8 +213,8 @@ describe Dnsimple::Client, ".contacts" do
 
     context "when the contact does not exist" do
       it "raises NotFoundError" do
-        stub_request(:delete, %r{/v2}).
-            to_return(read_http_fixture("notfound-contact.http"))
+        stub_request(:delete, %r{/v2})
+            .to_return(read_http_fixture("notfound-contact.http"))
 
         expect {
           subject.delete_contact(account_id, 0)

data/spec/dnsimple/client/domains_delegation_signer_records_spec.rb

@@ -10,15 +10,15 @@ describe Dnsimple::Client, ".domains" do
     let(:domain_id) { "example.com" }
 
     before do
-      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records}).
-          to_return(read_http_fixture("listDelegationSignerRecords/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records})
+          .to_return(read_http_fixture("listDelegationSignerRecords/success.http"))
     end
 
     it "builds the correct request" do
       subject.delegation_signer_records(account_id, domain_id)
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/ds_records").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/ds_records")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "supports pagination" do
@@ -64,8 +64,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "when the domain does not exist" do
       it "raises NotFoundError" do
-        stub_request(:get, %r{/v2}).
-            to_return(read_http_fixture("notfound-domain.http"))
+        stub_request(:get, %r{/v2})
+            .to_return(read_http_fixture("notfound-domain.http"))
 
         expect {
           subject.delegation_signer_records(account_id, domain_id)
@@ -76,8 +76,8 @@ describe Dnsimple::Client, ".domains" do
 
   describe "#all_delegation_signer_records" do
     before do
-      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records}).
-          to_return(read_http_fixture("listDelegationSignerRecords/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records})
+          .to_return(read_http_fixture("listDelegationSignerRecords/success.http"))
     end
 
     let(:account_id) { 1010 }
@@ -100,8 +100,8 @@ describe Dnsimple::Client, ".domains" do
     let(:domain_id) { "example.com" }
 
     before do
-      stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records$}).
-          to_return(read_http_fixture("createDelegationSignerRecord/created.http"))
+      stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records$})
+          .to_return(read_http_fixture("createDelegationSignerRecord/created.http"))
     end
 
     let(:attributes) { { algorithm: "13", digest: "ABC123", digest_type: "2", keytag: "1111" } }
@@ -109,9 +109,9 @@ describe Dnsimple::Client, ".domains" do
     it "builds the correct request" do
       subject.create_delegation_signer_record(account_id, domain_id, attributes)
 
-      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/ds_records").
-          with(body: attributes).
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/ds_records")
+          .with(body: attributes)
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the delegation signer record" do
@@ -130,15 +130,15 @@ describe Dnsimple::Client, ".domains" do
     let(:ds_record_id) { 24 }
 
     before do
-      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records.+$}).
-          to_return(read_http_fixture("getDelegationSignerRecord/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records.+$})
+          .to_return(read_http_fixture("getDelegationSignerRecord/success.http"))
     end
 
     it "builds the correct request" do
       subject.delegation_signer_record(account_id, domain_id, ds_record_id)
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/ds_records/#{ds_record_id}").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/ds_records/#{ds_record_id}")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the delegation signer record" do
@@ -159,8 +159,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "when the delegation signer record does not exist" do
       it "raises NotFoundError" do
-        stub_request(:get, %r{/v2}).
-            to_return(read_http_fixture("notfound-delegationsignerrecord.http"))
+        stub_request(:get, %r{/v2})
+            .to_return(read_http_fixture("notfound-delegationsignerrecord.http"))
 
         expect {
           subject.delegation_signer_record(account_id, domain_id, ds_record_id)
@@ -175,15 +175,15 @@ describe Dnsimple::Client, ".domains" do
     let(:ds_record_id) { 1 }
 
     before do
-      stub_request(:delete, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records/#{ds_record_id}$}).
-          to_return(read_http_fixture("deleteDelegationSignerRecord/success.http"))
+      stub_request(:delete, %r{/v2/#{account_id}/domains/#{domain_id}/ds_records/#{ds_record_id}$})
+          .to_return(read_http_fixture("deleteDelegationSignerRecord/success.http"))
     end
 
     it "builds the correct request" do
       subject.delete_delegation_signer_record(account_id, domain_id, ds_record_id)
 
-      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/ds_records/#{ds_record_id}").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/ds_records/#{ds_record_id}")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns nothing" do
@@ -196,8 +196,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "when the delegation signer record does not exist" do
       it "raises NotFoundError" do
-        stub_request(:delete, %r{/v2}).
-            to_return(read_http_fixture("notfound-delegationsignerrecord.http"))
+        stub_request(:delete, %r{/v2})
+            .to_return(read_http_fixture("notfound-delegationsignerrecord.http"))
 
         expect {
           subject.delete_delegation_signer_record(account_id, domain_id, ds_record_id)

data/spec/dnsimple/client/domains_dnssec_spec.rb

@@ -9,16 +9,16 @@ describe Dnsimple::Client, ".domains" do
     let(:domain_id) { "example.com" }
 
     before do
-      stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/dnssec}).
-          to_return(read_http_fixture("enableDnssec/success.http"))
+      stub_request(:post, %r{/v2/#{account_id}/domains/#{domain_id}/dnssec})
+          .to_return(read_http_fixture("enableDnssec/success.http"))
     end
 
 
     it "builds the correct request" do
       subject.enable_dnssec(account_id, domain_id)
 
-      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/dnssec").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/dnssec")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the dnssec status" do
@@ -32,8 +32,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "when the domain does not exist" do
       it "raises NotFoundError" do
-        stub_request(:post, %r{/v2}).
-            to_return(read_http_fixture("notfound-domain.http"))
+        stub_request(:post, %r{/v2})
+            .to_return(read_http_fixture("notfound-domain.http"))
 
         expect {
           subject.enable_dnssec(account_id, domain_id)
@@ -48,16 +48,16 @@ describe Dnsimple::Client, ".domains" do
     let(:domain_id) { "example.com" }
 
     before do
-      stub_request(:delete, %r{/v2/#{account_id}/domains/#{domain_id}/dnssec}).
-          to_return(read_http_fixture("disableDnssec/success.http"))
+      stub_request(:delete, %r{/v2/#{account_id}/domains/#{domain_id}/dnssec})
+          .to_return(read_http_fixture("disableDnssec/success.http"))
     end
 
 
     it "builds the correct request" do
       subject.disable_dnssec(account_id, domain_id)
 
-      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/dnssec").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/dnssec")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns nothing" do
@@ -70,8 +70,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "when the domain does not exist" do
       it "raises NotFoundError" do
-        stub_request(:delete, %r{/v2}).
-            to_return(read_http_fixture("notfound-domain.http"))
+        stub_request(:delete, %r{/v2})
+            .to_return(read_http_fixture("notfound-domain.http"))
 
         expect {
           subject.disable_dnssec(account_id, domain_id)
@@ -85,16 +85,16 @@ describe Dnsimple::Client, ".domains" do
     let(:domain_id) { "example.com" }
 
     before do
-      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/dnssec}).
-          to_return(read_http_fixture("getDnssec/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/domains/#{domain_id}/dnssec})
+          .to_return(read_http_fixture("getDnssec/success.http"))
     end
 
 
     it "builds the correct request" do
       subject.get_dnssec(account_id, domain_id)
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/dnssec").
-          with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/domains/#{domain_id}/dnssec")
+          .with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the dnssec status" do
@@ -108,8 +108,8 @@ describe Dnsimple::Client, ".domains" do
 
     context "when the domain does not exist" do
       it "raises NotFoundError" do
-        stub_request(:get, %r{/v2}).
-            to_return(read_http_fixture("notfound-domain.http"))
+        stub_request(:get, %r{/v2})
+            .to_return(read_http_fixture("notfound-domain.http"))
 
         expect {
           subject.get_dnssec(account_id, domain_id)