dnsimple 3.0.0.pre.beta2 → 3.0.0

data/spec/dnsimple/client/registrar_whois_privacy_spec.rb

@@ -9,15 +9,15 @@ describe Dnsimple::Client, ".registrar" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:get, %r[/v2/#{account_id}/registrar/domains/.+/whois_privacy$])
-          .to_return(read_http_fixture("getWhoisPrivacy/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/registrar/domains/.+/whois_privacy$}).
+          to_return(read_http_fixture("getWhoisPrivacy/success.http"))
     end
 
     it "builds the correct request" do
       subject.whois_privacy(account_id, domain_name = "example.com")
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy")
-          .with(headers: { "Accept" => "application/json" })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy").
+          with(headers: { "Accept" => "application/json" })
     end
 
     it "returns the whois privacy" do
@@ -37,15 +37,15 @@ describe Dnsimple::Client, ".registrar" do
 
     context "when the whois privacy had already been purchased" do
       before do
-        stub_request(:put, %r[/v2/#{account_id}/registrar/domains/.+/whois_privacy$])
-            .to_return(read_http_fixture("enableWhoisPrivacy/success.http"))
+        stub_request(:put, %r{/v2/#{account_id}/registrar/domains/.+/whois_privacy$}).
+            to_return(read_http_fixture("enableWhoisPrivacy/success.http"))
       end
 
       it "builds the correct request" do
         subject.enable_whois_privacy(account_id, domain_name = "example.com")
 
-        expect(WebMock).to have_requested(:put, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy")
-            .with(headers: { "Accept" => "application/json" })
+        expect(WebMock).to have_requested(:put, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy").
+            with(headers: { "Accept" => "application/json" })
       end
 
       it "returns the whois privacy" do
@@ -63,15 +63,15 @@ describe Dnsimple::Client, ".registrar" do
 
     context "when the whois privacy is newly purchased" do
       before do
-        stub_request(:put, %r[/v2/#{account_id}/registrar/domains/.+/whois_privacy$])
-            .to_return(read_http_fixture("enableWhoisPrivacy/created.http"))
+        stub_request(:put, %r{/v2/#{account_id}/registrar/domains/.+/whois_privacy$}).
+            to_return(read_http_fixture("enableWhoisPrivacy/created.http"))
       end
 
       it "builds the correct request" do
         subject.enable_whois_privacy(account_id, domain_name = "example.com")
 
-        expect(WebMock).to have_requested(:put, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy")
-            .with(headers: { "Accept" => "application/json" })
+        expect(WebMock).to have_requested(:put, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy").
+            with(headers: { "Accept" => "application/json" })
       end
 
       it "returns the whois privacy" do
@@ -93,15 +93,15 @@ describe Dnsimple::Client, ".registrar" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:delete, %r[/v2/#{account_id}/registrar/domains/.+/whois_privacy$])
-          .to_return(read_http_fixture("disableWhoisPrivacy/success.http"))
+      stub_request(:delete, %r{/v2/#{account_id}/registrar/domains/.+/whois_privacy$}).
+          to_return(read_http_fixture("disableWhoisPrivacy/success.http"))
     end
 
     it "builds the correct request" do
       subject.disable_whois_privacy(account_id, domain_name = "example.com")
 
-      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy")
-          .with(headers: { "Accept" => "application/json" })
+      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/registrar/domains/#{domain_name}/whois_privacy").
+          with(headers: { "Accept" => "application/json" })
     end
 
     it "returns the whois privacy" do

data/spec/dnsimple/client/services_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+describe Dnsimple::Client, ".services" do
+
+  subject { described_class.new(base_url: "https://api.dnsimple.test", access_token: "a1b2c3").services }
+
+
+  describe "#list_services" do
+    before do
+      stub_request(:get, %r{/v2/services$}).
+          to_return(read_http_fixture("listServices/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.list_services
+
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/services").
+          with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the list of available services" do
+      response = subject.list_services
+      expect(response).to be_a(Dnsimple::CollectionResponse)
+
+      response.data.each do |service|
+        expect(service).to be_a(Dnsimple::Struct::Service)
+        expect(service.id).to be_a(Fixnum)
+        expect(service.name).to be_a(String)
+        expect(service.short_name).to be_a(String)
+        expect(service.description).to be_a(String)
+
+        service.settings.each do |service_setting|
+          expect(service_setting).to be_a(Dnsimple::Struct::Service::Setting)
+        end
+      end
+    end
+  end
+
+  describe "#all_services" do
+    it "delegates to client.paginate" do
+      expect(subject).to receive(:paginate).with(:services, foo: "bar")
+      subject.all_services(foo: "bar")
+    end
+  end
+
+  describe "#service" do
+    let(:service_id) { 1 }
+
+    before do
+      stub_request(:get, %r{/v2/services/#{service_id}$}).
+          to_return(read_http_fixture("getService/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.service(service_id)
+
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/services/#{service_id}").
+          with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the service" do
+      response = subject.service(service_id)
+      expect(response).to be_a(Dnsimple::Response)
+
+      service = response.data
+      expect(service).to be_a(Dnsimple::Struct::Service)
+      expect(service.id).to eq(1)
+      expect(service.name).to eq("Service 1")
+      expect(service.short_name).to eq("service1")
+      expect(service.description).to eq("First service example.")
+      expect(service.setup_description).to be_nil
+      expect(service.requires_setup).to be_falsey
+      expect(service.default_subdomain).to be_nil
+      expect(service.settings).to eq([])
+    end
+  end
+
+end

data/spec/dnsimple/client/templates_spec.rb

@@ -0,0 +1,163 @@
+require 'spec_helper'
+
+describe Dnsimple::Client, ".templates" do
+
+  subject { described_class.new(base_url: "https://api.dnsimple.test", access_token: "a1b2c3").templates }
+
+
+  describe "#list_templates" do
+    let(:account_id) { 1010 }
+
+    before do
+      stub_request(:get, %r{/v2/#{account_id}/templates$}).
+          to_return(read_http_fixture("listTemplates/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.list_templates(account_id)
+
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/templates").
+          with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the list of templates" do
+      response = subject.list_templates(account_id)
+      expect(response).to be_a(Dnsimple::CollectionResponse)
+
+      response.data.each do |result|
+        expect(result).to be_a(Dnsimple::Struct::Template)
+        expect(result.id).to be_a(Numeric)
+        expect(result.account_id).to be_a(Numeric)
+        expect(result.name).to be_a(String)
+        expect(result.short_name).to be_a(String)
+        expect(result.description).to be_a(String)
+      end
+    end
+  end
+
+  describe "#all_templates" do
+    let(:account_id) { 1010 }
+
+    it "delegates to client.paginate" do
+      expect(subject).to receive(:paginate).with(:templates, account_id, foo: "bar")
+      subject.all_templates(account_id, foo: "bar")
+    end
+  end
+
+  describe "#create_template" do
+    let(:account_id) { 1010 }
+
+    before do
+      stub_request(:post, %r{/v2/#{account_id}/templates$}).
+          to_return(read_http_fixture("createTemplate/created.http"))
+    end
+
+    let(:attributes) { { name: "Beta", short_name: "beta", description: "A beta template." } }
+
+    it "builds the correct request" do
+      subject.create_template(account_id, attributes)
+
+      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/templates").
+          with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the list of templates" do
+      response = subject.create_template(account_id, attributes)
+      expect(response).to be_a(Dnsimple::Response)
+
+      template = response.data
+      expect(template).to be_a(Dnsimple::Struct::Template)
+      expect(template.id).to eq(1)
+      expect(template.account_id).to eq(1010)
+      expect(template.name).to eq("Beta")
+      expect(template.short_name).to eq("beta")
+      expect(template.description).to eq("A beta template.")
+    end
+  end
+
+  describe "#template" do
+    let(:account_id) { 1010 }
+    let(:template_id) { 1 }
+
+    before do
+      stub_request(:get, %r{/v2/#{account_id}/templates/#{template_id}$}).
+          to_return(read_http_fixture("getTemplate/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.template(account_id, template_id)
+
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/templates/#{template_id}").
+          with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the list of templates" do
+      response = subject.template(account_id, template_id)
+      expect(response).to be_a(Dnsimple::Response)
+
+      template = response.data
+      expect(template).to be_a(Dnsimple::Struct::Template)
+      expect(template.id).to eq(1)
+      expect(template.account_id).to eq(1010)
+      expect(template.name).to eq("Alpha")
+      expect(template.short_name).to eq("alpha")
+      expect(template.description).to eq("An alpha template.")
+    end
+  end
+
+  describe "#update_template" do
+    let(:account_id) { 1010 }
+    let(:template_id) { 1 }
+
+    before do
+      stub_request(:patch, %r{/v2/#{account_id}/templates/#{template_id}$}).
+          to_return(read_http_fixture("updateTemplate/success.http"))
+    end
+
+    let(:attributes) { { name: "Alpha", short_name: "alpha", description: "An alpha template." } }
+
+    it "builds the correct request" do
+      subject.update_template(account_id, template_id, attributes)
+
+      expect(WebMock).to have_requested(:patch, "https://api.dnsimple.test/v2/#{account_id}/templates/#{template_id}").
+          with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the list of templates" do
+      response = subject.update_template(account_id, template_id, attributes)
+      expect(response).to be_a(Dnsimple::Response)
+
+      template = response.data
+      expect(template).to be_a(Dnsimple::Struct::Template)
+      expect(template.id).to eq(1)
+      expect(template.account_id).to eq(1010)
+      expect(template.name).to eq("Alpha")
+      expect(template.short_name).to eq("alpha")
+      expect(template.description).to eq("An alpha template.")
+    end
+  end
+
+  describe "#delete_template" do
+    let(:account_id) { 1010 }
+    let(:template_id) { 5410 }
+
+    before do
+      stub_request(:delete, %r{/v2/#{account_id}/templates/#{template_id}$}).
+          to_return(read_http_fixture("deleteTemplate/success.http"))
+    end
+
+    it "builds the correct request" do
+      subject.delete_template(account_id, template_id)
+
+      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/templates/#{template_id}").
+          with(headers: { "Accept" => "application/json" })
+    end
+
+    it "returns the list of templates" do
+      response = subject.delete_template(account_id, template_id)
+      expect(response).to be_a(Dnsimple::Response)
+      expect(response.data).to be_nil
+    end
+  end
+
+end

data/spec/dnsimple/client/tlds_spec.rb

@@ -5,15 +5,15 @@ describe Dnsimple::Client, ".tlds" do
 
   describe "#tlds" do
     before do
-      stub_request(:get, %r[/v2/tlds])
-          .to_return(read_http_fixture("listTlds/success.http"))
+      stub_request(:get, %r{/v2/tlds}).
+          to_return(read_http_fixture("listTlds/success.http"))
     end
 
     it "builds the correct request" do
       subject.tlds
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/tlds")
-          .with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/tlds").
+          with(headers: { 'Accept' => 'application/json' })
     end
 
     it "supports pagination" do
@@ -55,22 +55,22 @@ describe Dnsimple::Client, ".tlds" do
 
   describe "#all_tlds" do
     it "delegates to client.paginate" do
-      expect(subject).to receive(:paginate).with(:tlds, { foo: "bar" })
-      subject.all_tlds({ foo: "bar" })
+      expect(subject).to receive(:paginate).with(:tlds, foo: "bar")
+      subject.all_tlds(foo: "bar")
     end
   end
 
   describe "#tld" do
     before do
-      stub_request(:get, %r[/v2/tlds/.+$])
-          .to_return(read_http_fixture("getTld/success.http"))
+      stub_request(:get, %r{/v2/tlds/.+$}).
+          to_return(read_http_fixture("getTld/success.http"))
     end
 
     it "builds the correct request" do
       subject.tld(tld = "com")
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/tlds/#{tld}")
-          .with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/tlds/#{tld}").
+          with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the tld" do
@@ -89,15 +89,15 @@ describe Dnsimple::Client, ".tlds" do
 
   describe "#extended_attributes" do
     before do
-      stub_request(:get, %r[/v2/tlds/uk/extended_attributes$])
-          .to_return(read_http_fixture("getTldExtendedAttributes/success.http"))
+      stub_request(:get, %r{/v2/tlds/uk/extended_attributes$}).
+          to_return(read_http_fixture("getTldExtendedAttributes/success.http"))
     end
 
     it "builds the correct request" do
       subject.extended_attributes(tld = "uk")
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/tlds/#{tld}/extended_attributes")
-          .with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/tlds/#{tld}/extended_attributes").
+          with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the extended attributes" do
@@ -110,21 +110,20 @@ describe Dnsimple::Client, ".tlds" do
         expect(result.description).to be_a(String)
         expect(result).to respond_to(:required)
 
-        if !result.options.empty?
-          result.options.each do |option|
-            expect(option).to be_a(Dnsimple::Struct::ExtendedAttribute::Option)
-            expect(option.title).to be_a(String)
-            expect(option.value).to be_a(String)
-            expect(option.description).to be_a(String)
-          end
+        next if result.options.empty?
+        result.options.each do |option|
+          expect(option).to be_a(Dnsimple::Struct::ExtendedAttribute::Option)
+          expect(option.title).to be_a(String)
+          expect(option.value).to be_a(String)
+          expect(option.description).to be_a(String)
         end
       end
     end
 
     context "when there are no extended attributes for a TLD" do
       before do
-        stub_request(:get, %r[/v2/tlds/com/extended_attributes$])
-            .to_return(read_http_fixture("getTldExtendedAttributes/success-noattributes.http"))
+        stub_request(:get, %r{/v2/tlds/com/extended_attributes$}).
+            to_return(read_http_fixture("getTldExtendedAttributes/success-noattributes.http"))
       end
 
       it "returns an empty CollectionResponse" do

data/spec/dnsimple/client/webhooks_spec.rb

@@ -8,15 +8,15 @@ describe Dnsimple::Client, ".webhooks" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:get, %r[/v2/#{account_id}/webhooks])
-          .to_return(read_http_fixture("listWebhooks/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/webhooks}).
+          to_return(read_http_fixture("listWebhooks/success.http"))
     end
 
     it "builds the correct request" do
       subject.webhooks(account_id)
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/webhooks")
-          .with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/webhooks").
+          with(headers: { 'Accept' => 'application/json' })
     end
 
     it "supports extra request options" do
@@ -43,18 +43,18 @@ describe Dnsimple::Client, ".webhooks" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:post, %r[/v2/#{account_id}/webhooks$])
-          .to_return(read_http_fixture("createWebhook/created.http"))
+      stub_request(:post, %r{/v2/#{account_id}/webhooks$}).
+          to_return(read_http_fixture("createWebhook/created.http"))
     end
 
-    let(:attributes) { {url: "https://webhook.test"} }
+    let(:attributes) { { url: "https://webhook.test" } }
 
     it "builds the correct request" do
       subject.create_webhook(account_id, attributes)
 
-      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/webhooks")
-          .with(body: attributes)
-          .with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:post, "https://api.dnsimple.test/v2/#{account_id}/webhooks").
+          with(body: attributes).
+          with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the webhook" do
@@ -71,15 +71,15 @@ describe Dnsimple::Client, ".webhooks" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:get, %r[/v2/#{account_id}/webhooks/.+$])
-          .to_return(read_http_fixture("getWebhook/success.http"))
+      stub_request(:get, %r{/v2/#{account_id}/webhooks/.+$}).
+          to_return(read_http_fixture("getWebhook/success.http"))
     end
 
     it "builds the correct request" do
       subject.webhook(account_id, webhook_id = "1")
 
-      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/webhooks/#{webhook_id}")
-          .with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:get, "https://api.dnsimple.test/v2/#{account_id}/webhooks/#{webhook_id}").
+          with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns the webhook" do
@@ -94,8 +94,8 @@ describe Dnsimple::Client, ".webhooks" do
 
     context "when the webhook does not exist" do
       it "raises NotFoundError" do
-        stub_request(:get, %r[/v2])
-            .to_return(read_http_fixture("notfound-webhook.http"))
+        stub_request(:get, %r{/v2}).
+            to_return(read_http_fixture("notfound-webhook.http"))
 
         expect {
           subject.webhook(account_id, 0)
@@ -108,15 +108,15 @@ describe Dnsimple::Client, ".webhooks" do
     let(:account_id) { 1010 }
 
     before do
-      stub_request(:delete, %r[/v2/#{account_id}/webhooks/.+$])
-          .to_return(read_http_fixture("deleteWebhook/success.http"))
+      stub_request(:delete, %r{/v2/#{account_id}/webhooks/.+$}).
+          to_return(read_http_fixture("deleteWebhook/success.http"))
     end
 
     it "builds the correct request" do
       subject.delete_webhook(account_id, webhook_id = "1")
 
-      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/webhooks/#{webhook_id}")
-          .with(headers: { 'Accept' => 'application/json' })
+      expect(WebMock).to have_requested(:delete, "https://api.dnsimple.test/v2/#{account_id}/webhooks/#{webhook_id}").
+          with(headers: { 'Accept' => 'application/json' })
     end
 
     it "returns nothing" do
@@ -129,8 +129,8 @@ describe Dnsimple::Client, ".webhooks" do
 
     context "when the webhook does not exist" do
       it "raises NotFoundError" do
-        stub_request(:delete, %r[/v2])
-            .to_return(read_http_fixture("notfound-webhook.http"))
+        stub_request(:delete, %r{/v2}).
+            to_return(read_http_fixture("notfound-webhook.http"))
 
         expect {
           subject.delete_webhook(account_id, 0)