dnsimple 11.0.0 → 12.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4181725aaf336953ed62dc82cb74fe1d4457880f9fccf3940c817e27ffa559b5
-  data.tar.gz: 11662d9a7780adbb47599e34a6e820c2b980c0be22ec79985557f4bd1801592c
+  metadata.gz: bf5d85da45a3b9f1f9cfdf8eebb6e138f7701b105d3b5e1168374712bf0c962a
+  data.tar.gz: 243d214bf5ecc19649eeac0ee2035591702108e0b49588921466ddba787623d6
 SHA512:
-  metadata.gz: c4357613ee6e5c1b8d25a89a8ce6d61fa53c3369bf59ff9e33f5fce0fc800f31e5a0f0d4709726de2fb0f0c4bc7ec092a34c238d9b8fca28bdb722ad6cd2462b
-  data.tar.gz: fa7726f50d6794b34ce537292d50b8050379751942201dad2e61ae246aed2ba5079841140b87ac6bd4494b724aeebc155cc59438f9f9693f69b8dc0c4742357f
+  metadata.gz: 529d35b92ffd260c29bd62c0dfe5302112b82620cf77f3b59b69c8bae4d7705a47dee1b09d86af8431f420c56fb916860bee1c6b2718b6441e61d08635823f98
+  data.tar.gz: 5a0536f22fb8fe8e0833fad81476c2e92433e349b4c8722c9cc57270644bab5931bea8cf67172f971f886e0b6db35c15e719af4bef20cc61c393423c10bb5dd9

data/.github/workflows/ci.yml

@@ -2,7 +2,10 @@ name: CI
 
 on:
   push:
-    branches: [ main ]
+    branches:
+      - main
+    tags:
+      - v*.*.*
   pull_request:
   workflow_dispatch:
 
@@ -11,12 +14,12 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  markdownlint-cli:
+  markdown-lint:
     name: Lint markdown
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Code
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
       - name: Run markdownlint-cli
         uses: nosborn/github-action-markdown-cli@v3.5.0
         with:
@@ -24,7 +27,8 @@ jobs:
           config_file: ".markdownlint.yaml"
 
   test:
-    needs: [markdownlint-cli]
+    needs:
+      - markdown-lint
     runs-on: ubuntu-latest
     name: Ruby ${{ matrix.ruby-version }}
     strategy:
@@ -33,10 +37,11 @@ jobs:
           - '3.2'
           - '3.3'
           - '3.4'
+          - '4.0'
           - 'ruby-head'
           - 'truffleruby-head'
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/release.yml

@@ -1,25 +1,56 @@
 name: Release
 
 on:
-  push:
-    tags:
-      - v*.*.*
+  workflow_run:
+    workflows:
+      - "CI"
+    types:
+      - completed
 jobs:
+  validate-tag:
+    name: Check tag
+    runs-on: ubuntu-latest
+    outputs:
+      valid_tag: ${{ steps.validation.outputs.valid_tag }}
+    if: ${{ github.event.workflow_run.conclusion == 'success' && github.event.workflow_run.event == 'push' && startsWith(github.event.workflow_run.head_branch, 'v') }}
+    steps:
+      - name: Check out the repository including tags
+        uses: actions/checkout@v6
+        with:
+          ref: ${{ github.event.workflow_run.head_sha }}
+          fetch-depth: 0
+          fetch-tags: true
+      - name: Validate tag
+        id: validation
+        run: |
+          # Validation is necessary in the unlikely case that a branch matching the tag naming pattern is pushed
+          # and the CI workflow in that branch is modified to run upon a push to that branch
+          REF='${{ github.event.workflow_run.head_branch }}' # This can be a branch or tag name
+          if [[ "$REF" != v*.*.* ]]; then
+            echo "valid_tag=false" >> "$GITHUB_OUTPUT"; exit 0
+          fi
+          # Validate that the tag exists
+          if ! git rev-parse -q --verify "refs/tags/$REF" >/dev/null; then
+            echo "There is no tag matching $REF - $REF is a branch"
+            echo "valid_tag=false" >> "$GITHUB_OUTPUT"; exit 0
+          fi
+          # Validate that the tag is for the same commit that was pushed
+          TAG_SHA="$(git rev-parse "$REF^{commit}")"
+          COMMIT_SHA="${{ github.event.workflow_run.head_sha }}"
+          if [ "$TAG_SHA" != "$COMMIT_SHA" ]; then
+            echo "Tag SHA $TAG_SHA does not match pushed commit SHA $COMMIT_SHA"
+            echo "valid_tag=false" >> "$GITHUB_OUTPUT"; exit 0
+          fi
+          echo "Tag $REF exists and is valid. Tag $TAG_SHA matches the pushed commit $COMMIT_SHA."
+          echo "valid_tag=true"  >> "$GITHUB_OUTPUT"
   publish:
     name: Release to RubyGems
+    needs: validate-tag
     runs-on: ubuntu-latest
+    if: ${{ needs.validate-tag.outputs.valid_tag == 'true' && github.event.workflow_run.conclusion == 'success' }}
 
     steps:
-      - name: Wait for tests to succeed
-        uses: lewagon/wait-on-check-action@v1.4.0
-        with:
-          ref: 'refs/heads/main'
-          running-workflow-name: 'Release to RubyGems'
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          wait-interval: 10
-          allowed-conclusions: success
-
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
 
       - name: Release Gem
         uses: simplyqio/publish-rubygems-action@2.0.0

data/.github/workflows/sync-test-fixtures.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
       - name: Sync fixtures
         run: |
           TMP_DIR=$(mktemp -d)

data/.rubocop.yml

@@ -9,8 +9,11 @@ plugins:
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 3.0
+  TargetRubyVersion: 3.2
   Exclude:
     - '*.gemspec'
     - 'Rakefile'
     - 'vendor/**/*'
+
+Style/Documentation:
+  Enabled: false

data/.rubocop_dnsimple.yml

@@ -1,13 +1,12 @@
-# This file serves as a template for RuboCop configuration. The primary template is maintained in the engineering repository.
-# Please ensure that any changes made here are also reflected in the engineering file to maintain consistency.
+# This is the DNSimple organization-wide RuboCop configuration.
+# It defines our unified linting and coding standards for all Ruby projects,
+# in accordance with our Ruby development practices and guidelines.
 #
-# DNSimple Ruby engineering template: https://github.com/dnsimple/dnsimple-engineering/blob/main/templates/ruby/rubocop_dnsimple.yml
+# This template is maintained centrally in the infra-github repository:
+# https://github.com/dnsimple/infra-github/blob/main/workspace/templates/ruby/rubocop_dnsimple.yml
 #
-# For default configurations, refer to: https://github.com/bbatsov/rubocop/blob/master/config/default.yml
-#
-# Additional References:
-#  * Ruby Style Guide: https://github.com/bbatsov/ruby-style-guide
-#  * RuboCop Documentation: https://rubocop.readthedocs.io/
+# For details on RuboCop itself and its configuration options, refer to:
+# https://docs.rubocop.org/rubocop/
 
 AllCops:
   Exclude:
@@ -28,24 +27,16 @@ AllCops:
 Layout/EndAlignment:
   EnforcedStyleAlignWith: variable
 
-# [codesmell]
 Layout/LineLength:
   Enabled: false
-  Exclude:
-    - 'spec/**/*_spec.rb'
-    - 'test/**/*_test.rb'
   Max: 100
 
 # [codesmell]
 Lint/SuppressedException:
   Enabled: false
 
-# [codesmell]
 Metrics/AbcSize:
   Enabled: false
-  Exclude:
-    - 'spec/**/*_spec.rb'
-    - 'test/**/*_test.rb'
 
 # [codesmell]
 Metrics/BlockLength:
@@ -58,20 +49,11 @@ Metrics/CyclomaticComplexity:
     - 'spec/**/*_spec.rb'
     - 'test/**/*_test.rb'
 
-# [codesmell]
 Metrics/ClassLength:
   Enabled: false
-  Exclude:
-    - 'spec/**/*_spec.rb'
-    - 'test/**/*_test.rb'
 
-# [codesmell]
 Metrics/MethodLength:
   Enabled: false
-  Exclude:
-    - 'spec/**/*_spec.rb'
-    - 'test/**/*_test.rb'
-  Max: 10
 
 # [codesmell]
 Metrics/ModuleLength:
@@ -98,7 +80,7 @@ Naming/MemoizedInstanceVariableName:
 # to use simple ? methods.
 # Moreover, it's actually more efficient to not-use predicates:
 # https://github.com/bbatsov/rubocop/issues/3633
-Naming/PredicateName:
+Naming/PredicatePrefix:
   Enabled: false
 
 # The team agreed decided to use exception.
@@ -218,12 +200,12 @@ Style/StringLiterals:
 Style/StringLiteralsInInterpolation:
   EnforcedStyle: double_quotes
 
-# It's nice to be consistent. The trailing comma also allows easy reordering,
+# Be consistent. The trailing comma also allows easy reordering,
 # and doesn't cause a diff in Git when you add a line to the bottom.
 Style/TrailingCommaInArrayLiteral:
   EnforcedStyleForMultiline: consistent_comma
 
-# It's nice to be consistent. The trailing comma also allows easy reordering,
+# Be consistent. The trailing comma also allows easy reordering,
 # and doesn't cause a diff in Git when you add a line to the bottom.
 Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: consistent_comma
@@ -255,11 +237,13 @@ Style/WordArray:
 Layout/CaseIndentation:
   EnforcedStyle: end
 
-# Double empty lines are useful to separate conceptually different methods
-# in the same class or module.
+# This is quite buggy, as it doesn't recognize double lines.
 Layout/EmptyLines:
   Enabled: false
 
+Layout/EmptyLineBetweenDefs:
+  NumberOfEmptyLines: [1, 2]
+
 Layout/EmptyLinesAroundBlockBody:
   Exclude:
     # RSpec is all made of blocks. Disable this config in RSpec
@@ -267,22 +251,10 @@ Layout/EmptyLinesAroundBlockBody:
     - 'spec/**/*_spec.rb'
     - 'test/**/*_test.rb'
 
-# Pick one option for consistency. beginning+ending is the most used approach.
-Layout/EmptyLinesAroundClassBody:
-  EnforcedStyle: empty_lines_except_namespace
-
 # We're ok with it. We use it quite often for method-level rescue statements.
 Layout/EmptyLinesAroundExceptionHandlingKeywords:
   Enabled: false
 
-# Pick one option for consistency. beginning+ending is the most used approach.
-Layout/EmptyLinesAroundModuleBody:
-  EnforcedStyle: empty_lines_except_namespace
-
-# This is quite buggy, as it doesn't recognize double lines.
-Layout/EmptyLineBetweenDefs:
-  Enabled: false
-
 # Multi-line differs from standard indentation, they are indented twice.
 Layout/FirstArgumentIndentation:
   IndentationWidth: 4

data/.rubocop_todo.yml

@@ -1,12 +1,12 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-01-26 12:48:02 UTC using RuboCop version 1.44.1.
+# on 2025-12-27 17:14:14 UTC using RuboCop version 1.82.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 74
+# Offense count: 90
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 17
@@ -22,11 +22,11 @@ RSpec/LeakyConstantDeclaration:
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 115
+# Offense count: 134
 RSpec/MultipleExpectations:
   Max: 15
 
-# Offense count: 372
+# Offense count: 422
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only
 RSpec/NamedSubject:
@@ -47,8 +47,3 @@ RSpec/SubjectStub:
     - 'spec/dnsimple/client/zones_records_spec.rb'
     - 'spec/dnsimple/client/zones_spec.rb'
     - 'spec/dnsimple/client_spec.rb'
-
-# Offense count: 69
-# Configuration parameters: AllowedConstants.
-Style/Documentation:
-  Enabled: false