dns_adapter 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3d8dfc76014b9bfd17a92150ac19f3846adad58e
-  data.tar.gz: 6aea0dfbb4a549a6304243cc7a777944027fea83
+  metadata.gz: 7ebb8290a9ed4fb59e1d7b4672c7293482102b29
+  data.tar.gz: fd4919453ea2a37c820150183762693ac972a5b4
 SHA512:
-  metadata.gz: 32bd75b2bdb092278b03737d27d3fefb4e1a5a1401b241e5507c1f710e870a314ff0cee804a0da547f46c20feac077d6a406e356fe23fe6fed0d408fba55012e
-  data.tar.gz: c027ec4d89fb7b870c823ff8f0dd80e6239fde10c2089cd23524d09938e610fa834c803e64ed07ac7707e760da85002e4348cfa062674775501f6fc109449525
+  metadata.gz: 11213627f86949e648a426f65db6eb5ec08a05ecf549abcba48b9c52a0496f9c914b6d49e156503af4d2c67567ec0a6e9a9ed727d7e7b6c228a47e8fd2074ab8
+  data.tar.gz: cb7b62d7c1973b490d36320ada3c074353c8303790a3cdc95eb85f001af4a9c7113a67b4bae8577011f77323470bda6850e167e842cc40a8988474c134ac5cdd

data/.codeclimate.yml

@@ -0,0 +1,9 @@
+---
+engines:
+  duplication:
+    enabled: true
+    config:
+      languages:
+      - ruby
+      - javascript
+

data/.travis.yml

@@ -1,9 +1,11 @@
+sudo: false
 language: ruby
 env:
-  - CODECLIMATE_REPO_TOKEN=9881d1116b64b55a16845046a4a2dc43f12203d7201a33ce92fec4b7732e3c93
+  - CODECLIMATE_REPO_TOKEN=230883de63c3f82afe4a809f5a488bd849ddfbbaa2c10dae95b57aaf2e60c1e9
 rvm:
-  - 2.0.0
+  - 2.0
   - 2.1
-  - 2.2
-  - jruby-19mode
+  - 2.2.5
+  - 2.3.1
+  - jruby-9.0.4.0
 

data/README.md

@@ -1,8 +1,8 @@
 # DNSAdapter
 
-[![Build Status](https://travis-ci.org/petergoldstein/dns_adapter.svg?branch=master)](https://travis-ci.org/petergoldstein/dns_adapter)
-[![Test Coverage](https://codeclimate.com/github/petergoldstein/dns_adapter/badges/coverage.svg)](https://codeclimate.com/github/petergoldstein/dns_adapter)
-[![Code Climate](https://codeclimate.com/github/petergoldstein/dns_adapter/badges/gpa.svg)](https://codeclimate.com/github/petergoldstein/dns_adapter)
+[![Build Status](https://travis-ci.org/ValiMail/dns_adapter.svg?branch=master)](https://travis-ci.org/ValiMail/dns_adapter)
+[![Test Coverage](https://codeclimate.com/github/ValiMail/dns_adapter/badges/coverage.svg)](https://codeclimate.com/github/ValiMail/dns_adapter)
+[![Code Climate](https://codeclimate.com/github/ValiMail/dns_adapter/badges/gpa.svg)](https://codeclimate.com/github/ValiMail/dns_adapter)
 
 An adapter layer for DNS queries that makes it simple to swap in different DNS providers.
 

data/lib/dns_adapter/mock_client.rb

@@ -72,10 +72,10 @@ module DNSAdapter
       end
     end
 
-    TIMEOUT = 'TIMEOUT'
+    TIMEOUT = 'TIMEOUT'.freeze
     def check_for_timeout(record_set)
       return [] if record_set.select { |r| r == TIMEOUT }.empty?
-      fail DNSAdapter::TimeoutError
+      raise DNSAdapter::TimeoutError
     end
 
     RECORD_TYPE_TO_ATTR_NAME_MAP = {
@@ -87,12 +87,12 @@ module DNSAdapter
       'CNAME' => :name,
       'SPF' => :text,
       'TXT' => :text
-    }
+    }.freeze
 
     def formatted_records(records, type)
       records.map do |r|
         val = r[type]
-        fail DNSAdapter::TimeoutError if val == TIMEOUT
+        raise DNSAdapter::TimeoutError if val == TIMEOUT
         val = normalize_value(val, type)
         {
           type: type,

data/lib/dns_adapter/resolv_client.rb

@@ -60,7 +60,9 @@ module DNSAdapter
           type: type,
           # Use strings.join('') to avoid JRuby issue where
           # data only returns the first string
-          text: record.strings.join(''),
+          text: record.strings.join('').encode('US-ASCII', invalid: :replace,
+                                                           undef: :replace,
+                                                           replace: '?'),
           ttl: record.ttl
         }
       end
@@ -91,8 +93,8 @@ module DNSAdapter
       resources = getresources(domain, rr_type)
 
       unless resources
-        fail DNSAdapter::Error,
-             "Unknown error on DNS '#{rr_type}' lookup of '#{domain}'"
+        raise DNSAdapter::Error,
+              "Unknown error on DNS '#{rr_type}' lookup of '#{domain}'"
       end
 
       resources
@@ -108,12 +110,12 @@ module DNSAdapter
       raise DNSAdapter::Error, "Error on DNS lookup of '#{domain}'"
     end
 
-    SUPPORTED_RR_TYPES = %w(A AAAA MX PTR TXT SPF NS CNAME)
+    SUPPORTED_RR_TYPES = %w(A AAAA MX PTR TXT SPF NS CNAME).freeze
     def self.type_class(rr_type)
       if SUPPORTED_RR_TYPES.include?(rr_type)
         Resolv::DNS::Resource::IN.const_get(rr_type)
       else
-        fail ArgumentError, "Unknown RR type: #{rr_type}"
+        raise ArgumentError, "Unknown RR type: #{rr_type}"
       end
     end
 

data/lib/dns_adapter/version.rb

@@ -1,3 +1,3 @@
 module DNSAdapter
-  VERSION = '0.0.5'
+  VERSION = '0.0.6'.freeze
 end

data/spec/resolv_client_spec.rb

@@ -20,7 +20,7 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_a_records(domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'A' })
+        .to eq(Array.new(record_list.length) { 'A' })
       expect(results.map { |x| x[:address] })
         .to eq(record_list.map(&:address).map(&:to_s))
     end
@@ -32,7 +32,7 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_a_records(domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'A' })
+        .to eq(Array.new(record_list.length) { 'A' })
       expect(results.map { |x| x[:address] })
         .to eq(record_list.map(&:address).map(&:to_s))
     end
@@ -92,7 +92,7 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_aaaa_records(domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'AAAA' })
+        .to eq(Array.new(record_list.length) { 'AAAA' })
       expect(results.map { |x| x[:address] })
         .to eq(record_list.map(&:address).map(&:to_s))
     end
@@ -104,7 +104,7 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_aaaa_records(domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'AAAA' })
+        .to eq(Array.new(record_list.length) { 'AAAA' })
       expect(results.map { |x| x[:address] })
         .to eq(record_list.map(&:address).map(&:to_s))
     end
@@ -152,7 +152,7 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_mx_records(domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'MX' })
+        .to eq(Array.new(record_list.length) { 'MX' })
       expect(results.map { |x| x[:exchange] })
         .to eq(record_list.map(&:exchange).map(&:to_s))
     end
@@ -164,7 +164,7 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_mx_records(domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'MX' })
+        .to eq(Array.new(record_list.length) { 'MX' })
       expect(results.map { |x| x[:exchange] })
         .to eq(record_list.map(&:exchange).map(&:to_s))
     end
@@ -213,10 +213,11 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_txt_records(domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'TXT' })
+        .to eq(Array.new(record_list.length) { 'TXT' })
       expect(results.map { |x| x[:text] }).to eq(
         [first_txt_string,
-         ([second_txt_string] + second_txt_string_array).join('')])
+         ([second_txt_string] + second_txt_string_array).join('')]
+      )
     end
 
     it 'should map when the domain has a trailing dot' do
@@ -227,10 +228,11 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_txt_records(domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'TXT' })
+        .to eq(Array.new(record_list.length) { 'TXT' })
       expect(results.map { |x| x[:text] }).to eq(
         [first_txt_string,
-         ([second_txt_string] + second_txt_string_array).join('')])
+         ([second_txt_string] + second_txt_string_array).join('')]
+      )
     end
 
     it 'should map the Resolv errors to Coppertone errors' do
@@ -277,10 +279,11 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_spf_records(domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'SPF' })
+        .to eq(Array.new(record_list.length) { 'SPF' })
       expect(results.map { |x| x[:text] }).to eq(
         [first_spf_string,
-         ([second_spf_string] + second_spf_string_array).join('')])
+         ([second_spf_string] + second_spf_string_array).join('')]
+      )
     end
 
     it 'should map when the domain has a trailing dot' do
@@ -291,10 +294,11 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_spf_records(domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'SPF' })
+        .to eq(Array.new(record_list.length) { 'SPF' })
       expect(results.map { |x| x[:text] }).to eq(
         [first_spf_string,
-         ([second_spf_string] + second_spf_string_array).join('')])
+         ([second_spf_string] + second_spf_string_array).join('')]
+      )
     end
 
     it 'should map the Resolv errors to Coppertone errors' do
@@ -333,9 +337,10 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_ptr_records(arpa_domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'PTR' })
+        .to eq(Array.new(record_list.length) { 'PTR' })
       expect(results.map { |x| x[:name] }).to eq(
-        [first_ptr_name])
+        [first_ptr_name]
+      )
     end
 
     it 'should map when the domain has a trailing dot' do
@@ -346,9 +351,10 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_ptr_records(arpa_domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'PTR' })
+        .to eq(Array.new(record_list.length) { 'PTR' })
       expect(results.map { |x| x[:name] }).to eq(
-        [first_ptr_name])
+        [first_ptr_name]
+      )
     end
 
     it 'should map the Resolv errors to Coppertone errors' do
@@ -387,9 +393,10 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_ns_records(ns_domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'NS' })
+        .to eq(Array.new(record_list.length) { 'NS' })
       expect(results.map { |x| x[:name] }).to eq(
-        [first_ns_name])
+        [first_ns_name]
+      )
     end
 
     it 'should map when the domain has a trailing dot' do
@@ -400,9 +407,10 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_ns_records(ns_domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'NS' })
+        .to eq(Array.new(record_list.length) { 'NS' })
       expect(results.map { |x| x[:name] }).to eq(
-        [first_ns_name])
+        [first_ns_name]
+      )
     end
 
     it 'should map the Resolv errors to Coppertone errors' do
@@ -441,9 +449,10 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_cname_records(cname_domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'CNAME' })
+        .to eq(Array.new(record_list.length) { 'CNAME' })
       expect(results.map { |x| x[:name] }).to eq(
-        [first_cname_name])
+        [first_cname_name]
+      )
     end
 
     it 'should map when the domain has a trailing dot' do
@@ -454,9 +463,10 @@ describe DNSAdapter::ResolvClient do
       results = subject.fetch_cname_records(cname_domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
-        .to eq(record_list.length.times.map { 'CNAME' })
+        .to eq(Array.new(record_list.length) { 'CNAME' })
       expect(results.map { |x| x[:name] }).to eq(
-        [first_cname_name])
+        [first_cname_name]
+      )
     end
 
     it 'should map the Resolv errors to Coppertone errors' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dns_adapter
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Peter M. Goldstein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-18 00:00:00.000000000 Z
+date: 2016-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -73,6 +73,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".travis.yml"
 - Gemfile
@@ -109,7 +110,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: An adapter layer for DNS queries.