dns_adapter 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f19132b4cfb08ff5ec8ebf1d890930207c2b8878
-  data.tar.gz: 1b169dc215f89e09f844f64e4f0573704716b706
+  metadata.gz: 02c19670fbd1108a45d6c80bdac4329a77e784d2
+  data.tar.gz: 9a725d4d553ebec3386a505ee01ab6ce9a92a303
 SHA512:
-  metadata.gz: 95f8e9bebe8cbe45c4f9b4c8b102e4184228952c202d274b8b6595dea6a8ccc774c13f5a190e2eabd8976314d61d57da1da79d25bec9ac56444899e96fcef345
-  data.tar.gz: be86352abc7d1f4f5a038e6ead661fc620cc7f4955ea7d0078a6f10655b1efe5dd30cbe2f0bdddf33891ace87a6a913db2b71c3f2c80eb5aa10f5680108d8616
+  metadata.gz: 49fb8d15b30460c3034f36002fc5c891ff6dd02f44266d4c445b1e74f0a75bf9561ffff8993ece11fd5abb94e33466bfdea4e9b97d80363288a978585393022a
+  data.tar.gz: 4bf6e56344dae4e03a5ab49cd45d31d4a6060686d41668191ce66158d41ab928f18d0217d55790d80744cf1a8f7a688198dc3080a76a705944112b7398d78a69

data/lib/dns_adapter/resolv_client.rb

@@ -23,13 +23,7 @@ module DNSAdapter
     end
 
     def fetch_ptr_records(arpa_address)
-      fetch_records(arpa_address, 'PTR') do |record|
-        {
-          type: 'PTR',
-          name: record.name.to_s,
-          ttl: record.ttl
-        }
-      end
+      fetch_name_records(arpa_address, 'PTR')
     end
 
     def fetch_txt_records(domain)
@@ -40,6 +34,10 @@ module DNSAdapter
       fetch_txt_type_records(domain, 'SPF')
     end
 
+    def fetch_ns_records(domain)
+      fetch_name_records(domain, 'NS')
+    end
+
     private
 
     def fetch_a_type_records(domain, type)
@@ -64,6 +62,16 @@ module DNSAdapter
       end
     end
 
+    def fetch_name_records(domain, type)
+      fetch_records(domain, type) do |record|
+        {
+          type: type,
+          name: record.name.to_s,
+          ttl: record.ttl
+        }
+      end
+    end
+
     def fetch_records(domain, type, &block)
       records = dns_lookup(domain, type)
       records.map(&block)
@@ -96,7 +104,7 @@ module DNSAdapter
       raise DNSAdapter::Error, "Error on DNS lookup of '#{domain}'"
     end
 
-    SUPPORTED_RR_TYPES = %w(A AAAA MX PTR TXT SPF)
+    SUPPORTED_RR_TYPES = %w(A AAAA MX PTR TXT SPF NS)
     def self.type_class(rr_type)
       if SUPPORTED_RR_TYPES.include?(rr_type)
         Resolv::DNS::Resource::IN.const_get(rr_type)

data/lib/dns_adapter/version.rb

@@ -1,3 +1,3 @@
 module DNSAdapter
-  VERSION = '0.0.2'
+  VERSION = '0.0.3'
 end

data/spec/mock_client_spec.rb

@@ -0,0 +1,4 @@
+require 'spec_helper'
+
+describe DNSAdapter::MockClient do
+end

data/spec/resolv_client_spec.rb

@@ -172,7 +172,8 @@ describe DNSAdapter::ResolvClient do
     it 'should map the Resolv errors to Coppertone errors' do
       expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
       expect(mock_resolver).to receive(:getresources)
-        .with(domain, Resolv::DNS::Resource::IN::MX).and_raise(Resolv::ResolvError)
+        .with(domain, Resolv::DNS::Resource::IN::MX)
+        .and_raise(Resolv::ResolvError)
       expect { subject.fetch_mx_records(domain_with_trailing) }
         .to raise_error(DNSAdapter::Error)
     end
@@ -207,8 +208,8 @@ describe DNSAdapter::ResolvClient do
     it 'should map the Resolv classes to a set of hashes' do
       expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
       expect(mock_resolver).to receive(:getresources)
-                               .with(domain, Resolv::DNS::Resource::IN::TXT)
-                               .and_return(record_list)
+        .with(domain, Resolv::DNS::Resource::IN::TXT)
+        .and_return(record_list)
       results = subject.fetch_txt_records(domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
@@ -221,8 +222,8 @@ describe DNSAdapter::ResolvClient do
     it 'should map when the domain has a trailing dot' do
       expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
       expect(mock_resolver).to receive(:getresources)
-                               .with(domain, Resolv::DNS::Resource::IN::TXT)
-                               .and_return(record_list)
+        .with(domain, Resolv::DNS::Resource::IN::TXT)
+        .and_return(record_list)
       results = subject.fetch_txt_records(domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
@@ -271,8 +272,8 @@ describe DNSAdapter::ResolvClient do
     it 'should map the Resolv classes to a set of hashes' do
       expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
       expect(mock_resolver).to receive(:getresources)
-                               .with(domain, Resolv::DNS::Resource::IN::SPF)
-                               .and_return(record_list)
+        .with(domain, Resolv::DNS::Resource::IN::SPF)
+        .and_return(record_list)
       results = subject.fetch_spf_records(domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
@@ -285,8 +286,8 @@ describe DNSAdapter::ResolvClient do
     it 'should map when the domain has a trailing dot' do
       expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
       expect(mock_resolver).to receive(:getresources)
-                               .with(domain, Resolv::DNS::Resource::IN::SPF)
-                               .and_return(record_list)
+        .with(domain, Resolv::DNS::Resource::IN::SPF)
+        .and_return(record_list)
       results = subject.fetch_spf_records(domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
@@ -327,8 +328,8 @@ describe DNSAdapter::ResolvClient do
     it 'should map the Resolv classes to a set of hashes' do
       expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
       expect(mock_resolver).to receive(:getresources)
-                               .with(arpa_domain, Resolv::DNS::Resource::IN::PTR)
-                               .and_return(record_list)
+        .with(arpa_domain, Resolv::DNS::Resource::IN::PTR)
+        .and_return(record_list)
       results = subject.fetch_ptr_records(arpa_domain)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
@@ -340,8 +341,8 @@ describe DNSAdapter::ResolvClient do
     it 'should map when the domain has a trailing dot' do
       expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
       expect(mock_resolver).to receive(:getresources)
-                               .with(arpa_domain, Resolv::DNS::Resource::IN::PTR)
-                               .and_return(record_list)
+        .with(arpa_domain, Resolv::DNS::Resource::IN::PTR)
+        .and_return(record_list)
       results = subject.fetch_ptr_records(arpa_domain_with_trailing)
       expect(results.size).to eq(record_list.length)
       expect(results.map { |x| x[:type] })
@@ -368,4 +369,58 @@ describe DNSAdapter::ResolvClient do
         .to raise_error(DNSAdapter::TimeoutError)
     end
   end
+
+  context '#fetch_ns_records' do
+    let(:first_ns_name) { SecureRandom.hex(10) }
+    let(:first_ns_record) do
+      Resolv::DNS::Resource::IN::NS.new(first_ns_name)
+    end
+    let(:record_list) { [first_ns_record] }
+    let(:ns_domain) { 'example.com' }
+    let(:ns_domain_with_trailing) { "#{ns_domain}." }
+
+    it 'should map the Resolv classes to a set of hashes' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(ns_domain, Resolv::DNS::Resource::IN::NS)
+        .and_return(record_list)
+      results = subject.fetch_ns_records(ns_domain)
+      expect(results.size).to eq(record_list.length)
+      expect(results.map { |x| x[:type] })
+        .to eq(record_list.length.times.map { 'NS' })
+      expect(results.map { |x| x[:name] }).to eq(
+        [first_ns_name])
+    end
+
+    it 'should map when the domain has a trailing dot' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(ns_domain, Resolv::DNS::Resource::IN::NS)
+        .and_return(record_list)
+      results = subject.fetch_ns_records(ns_domain_with_trailing)
+      expect(results.size).to eq(record_list.length)
+      expect(results.map { |x| x[:type] })
+        .to eq(record_list.length.times.map { 'NS' })
+      expect(results.map { |x| x[:name] }).to eq(
+        [first_ns_name])
+    end
+
+    it 'should map the Resolv errors to Coppertone errors' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(ns_domain, Resolv::DNS::Resource::IN::NS)
+        .and_raise(Resolv::ResolvError)
+      expect { subject.fetch_ns_records(ns_domain_with_trailing) }
+        .to raise_error(DNSAdapter::Error)
+    end
+
+    it 'should map the Resolv timeout errors to Coppertone errors' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(ns_domain, Resolv::DNS::Resource::IN::NS)
+        .and_raise(Resolv::ResolvTimeout)
+      expect { subject.fetch_ns_records(ns_domain_with_trailing) }
+        .to raise_error(DNSAdapter::TimeoutError)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dns_adapter
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Peter M. Goldstein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-05 00:00:00.000000000 Z
+date: 2015-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,6 +86,7 @@ files:
 - lib/dns_adapter/resolv_client.rb
 - lib/dns_adapter/version.rb
 - lib/resolv/dns/resource/in/spf.rb
+- spec/mock_client_spec.rb
 - spec/resolv_client_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/petergoldstein/dns_adapter
@@ -108,10 +109,11 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: An adapter layer for DNS queries.
 test_files:
+- spec/mock_client_spec.rb
 - spec/resolv_client_spec.rb
 - spec/spec_helper.rb