dns_adapter 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3d8e3fd1654dd5ce7799fa3211d210ba4b633c67
-  data.tar.gz: f72a3cabad09a65366f89b55fc6fca4111aae82c
+  metadata.gz: f19132b4cfb08ff5ec8ebf1d890930207c2b8878
+  data.tar.gz: 1b169dc215f89e09f844f64e4f0573704716b706
 SHA512:
-  metadata.gz: 1630678f66915f648dceee32bc418021c3de846954824b03ef3bf0670b720f30d0944b1d9bc66457f706ea285a448418bc605597085e91b43165681993e773c9
-  data.tar.gz: 2420893ee8679b6b13c3c8b21f62d35af148d474ed5f06dcdeb6ab7a8fd03d509f85255a4580213cb262186273e3c0c8530adb77eb79c13671e853de37738af0
+  metadata.gz: 95f8e9bebe8cbe45c4f9b4c8b102e4184228952c202d274b8b6595dea6a8ccc774c13f5a190e2eabd8976314d61d57da1da79d25bec9ac56444899e96fcef345
+  data.tar.gz: be86352abc7d1f4f5a038e6ead661fc620cc7f4955ea7d0078a6f10655b1efe5dd30cbe2f0bdddf33891ace87a6a913db2b71c3f2c80eb5aa10f5680108d8616

data/.travis.yml

@@ -3,6 +3,7 @@ env:
   - CODECLIMATE_REPO_TOKEN=9881d1116b64b55a16845046a4a2dc43f12203d7201a33ce92fec4b7732e3c93
 rvm:
   - 2.0.0
-  - 2.1.2
+  - 2.1
+  - 2.2
   - jruby-19mode
 

data/dns_adapter.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(/^(test|spec|features)\//)
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '>= 3.0'
   spec.add_development_dependency 'rubocop'

data/lib/dns_adapter/resolv_client.rb

@@ -16,7 +16,8 @@ module DNSAdapter
       fetch_records(domain, 'MX') do |record|
         {
           type: 'MX',
-          exchange: record.exchange.to_s
+          exchange: record.exchange.to_s,
+          ttl: record.ttl
         }
       end
     end
@@ -25,7 +26,8 @@ module DNSAdapter
       fetch_records(arpa_address, 'PTR') do |record|
         {
           type: 'PTR',
-          name: record.name.to_s
+          name: record.name.to_s,
+          ttl: record.ttl
         }
       end
     end
@@ -44,7 +46,8 @@ module DNSAdapter
       fetch_records(domain, type) do |record|
         {
           type: type,
-          address: record.address.to_s
+          address: record.address.to_s,
+          ttl: record.ttl
         }
       end
     end
@@ -55,7 +58,8 @@ module DNSAdapter
           type: type,
           # Use strings.join('') to avoid JRuby issue where
           # data only returns the first string
-          text: record.strings.join('')
+          text: record.strings.join(''),
+          ttl: record.ttl
         }
       end
     end

data/lib/dns_adapter/version.rb

@@ -1,3 +1,3 @@
 module DNSAdapter
-  VERSION = '0.0.1'
+  VERSION = '0.0.2'
 end

data/spec/resolv_client_spec.rb

@@ -56,6 +56,16 @@ describe DNSAdapter::ResolvClient do
         subject.fetch_a_records(domain_with_trailing)
       end.to raise_error(DNSAdapter::TimeoutError)
     end
+
+    it 'should map the Resolv timeout errors to Coppertone errors' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(domain, Resolv::DNS::Resource::IN::A)
+        .and_return(nil)
+      expect do
+        subject.fetch_a_records(domain_with_trailing)
+      end.to raise_error(DNSAdapter::Error)
+    end
   end
 
   context '#fetch_aaaa_records' do
@@ -304,4 +314,58 @@ describe DNSAdapter::ResolvClient do
         .to raise_error(DNSAdapter::TimeoutError)
     end
   end
+
+  context '#fetch_ptr_records' do
+    let(:first_ptr_name) { SecureRandom.hex(10) }
+    let(:first_ptr_record) do
+      Resolv::DNS::Resource::IN::PTR.new(first_ptr_name)
+    end
+    let(:record_list) { [first_ptr_record] }
+    let(:arpa_domain) { '126.18.67.80.in-addr.arpa' }
+    let(:arpa_domain_with_trailing) { "#{arpa_domain}." }
+
+    it 'should map the Resolv classes to a set of hashes' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+                               .with(arpa_domain, Resolv::DNS::Resource::IN::PTR)
+                               .and_return(record_list)
+      results = subject.fetch_ptr_records(arpa_domain)
+      expect(results.size).to eq(record_list.length)
+      expect(results.map { |x| x[:type] })
+        .to eq(record_list.length.times.map { 'PTR' })
+      expect(results.map { |x| x[:name] }).to eq(
+        [first_ptr_name])
+    end
+
+    it 'should map when the domain has a trailing dot' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+                               .with(arpa_domain, Resolv::DNS::Resource::IN::PTR)
+                               .and_return(record_list)
+      results = subject.fetch_ptr_records(arpa_domain_with_trailing)
+      expect(results.size).to eq(record_list.length)
+      expect(results.map { |x| x[:type] })
+        .to eq(record_list.length.times.map { 'PTR' })
+      expect(results.map { |x| x[:name] }).to eq(
+        [first_ptr_name])
+    end
+
+    it 'should map the Resolv errors to Coppertone errors' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(arpa_domain, Resolv::DNS::Resource::IN::PTR)
+        .and_raise(Resolv::ResolvError)
+      expect { subject.fetch_ptr_records(arpa_domain_with_trailing) }
+        .to raise_error(DNSAdapter::Error)
+    end
+
+    it 'should map the Resolv timeout errors to Coppertone errors' do
+      expect(Resolv::DNS).to receive(:new).and_return(mock_resolver)
+      expect(mock_resolver).to receive(:getresources)
+        .with(arpa_domain, Resolv::DNS::Resource::IN::PTR)
+        .and_raise(Resolv::ResolvTimeout)
+      expect { subject.fetch_ptr_records(arpa_domain_with_trailing) }
+        .to raise_error(DNSAdapter::TimeoutError)
+    end
+  end
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: dns_adapter
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Peter M. Goldstein
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-27 00:00:00.000000000 Z
+date: 2015-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -108,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: An adapter layer for DNS queries.