dmarc 0.2.0 → 0.3.0

data/spec/record_spec.rb

@@ -2,58 +2,72 @@ require 'spec_helper'
 require 'dmarc/record'
 
 describe Record do
-  context 'by default' do
-    it 'has a relaxed DKIM alignment' do
-      expect(subject.adkim).to eq('r')
+  describe '#initialize' do
+    let(:attributes) do
+      {
+        v: :DMARC1,
+        p: :none,
+        adkim: :r
+      }
     end
 
-    it 'has a relaxed SPF alignment' do
-      expect(subject.aspf).to eq('r')
+    subject { described_class.new(attributes) }
+
+    it 'assigns the fields to its properties' do
+      expect(subject.v).to     be :DMARC1
+      expect(subject.p).to     be :none
+      expect(subject.adkim).to be :r
     end
 
-    it 'has failure reporting options of "0"' do
-      expect(subject.fo).to eq('0')
+    it 'gives "sp" the same value as "p" if undefined' do
+      expect(subject.sp).to be :none
     end
+  end
 
-    it 'has an application percentage of 100' do
-      expect(subject.pct).to eq(100)
+  context 'with default values' do
+    describe "#adkim" do
+      it "should return :r" do
+        expect(subject.adkim).to be == :r
+      end
     end
 
-    it 'has an afrf report format' do
-      expect(subject.rf).to eq('afrf')
+    describe "#aspf" do
+      it "should return :r" do
+        expect(subject.aspf).to be == :r
+      end
     end
 
-    it 'has a report interval of 1 day' do
-      expect(subject.ri).to eq(86400)
+    describe "#fo" do
+      it "should return ['0']" do
+        expect(subject.fo).to be == ['0']
+      end
     end
-  end
 
-  describe '#initialize' do
-    let(:parse_tree) do
-      {
-        v: 'DMARC1',
-        p: 'none',
-        adkim: 'r'
-      }
+    describe "#pct" do
+      it "should return 100" do
+        expect(subject.pct).to be == 100
+      end
     end
 
-    it 'assigns the fields to its properties' do
-      rec = described_class.new parse_tree
-      expect(rec.v).to eq('DMARC1')
-      expect(rec.p).to eq('none')
-      expect(rec.adkim).to eq('r')
+    describe "#rf" do
+      it "should return afrf" do
+        expect(subject.rf).to be == :afrf
+      end
     end
 
-    it 'gives "sp" the same value as "p" if undefined' do
-      rec = described_class.new parse_tree
-      expect(rec.sp).to eq('none')
+    describe "#ri" do
+      it "should return 86400" do
+        expect(subject.ri).to be == 86400
+      end
     end
   end
 
-  describe '.from_txt' do
+  describe '.parse' do
+    subject { described_class }
+
     context 'with a valid record' do
       it 'parse and returns a record' do
-        rec = described_class.from_txt('v=DMARC1; p=quarantine')
+        rec = subject.parse('v=DMARC1; p=quarantine')
 
         expect(rec).to be_a Record
         expect(rec.p).to eq :quarantine
@@ -62,11 +76,53 @@ describe Record do
 
     context 'with an invalid record' do
       it 'raises an InvalidRecord error' do
-        expect { described_class.from_txt('v=DMARC1; foo=bar') }.to raise_error do |error|
-          expect(error).to be_a InvalidRecord
-          expect(error.ascii_tree).to_not be_nil
-        end
+        expect {
+          subject.parse('v=XXXXXXXXXX')
+        }.to raise_error(InvalidRecord)
+      end
+    end
+  end
+
+  describe ".query" do
+    subject { described_class }
+
+    context "when given a domain" do
+      let(:domain) { 'google.com' }
+
+      it "should query and parse the DMARC record" do
+        record = subject.query(domain)
+
+        expect(record).to be_kind_of(Record)
+        expect(record.v).to be == :DMARC1
       end
     end
+
+    context "when given a bad domain" do
+      it "should raise a DNS error" do
+        expect(subject.query('foobar.com')).to be_nil
+      end
+    end
+  end
+
+  describe "#to_s" do
+    let(:v) { :DMARC1 }
+    let(:p) { :reject }
+    let(:rua) { [URI.parse('mailto:d@rua.agari.com')] }
+    let(:ruf) { [URI.parse('mailto:d@rua.agari.com')] }
+    let(:fo)  { %w[0 1 d] }
+
+    subject do
+      described_class.new(
+        v: v,
+        p: p,
+        rua: rua,
+        ruf: ruf,
+        fo: fo
+      )
+    end
+
+    it "should convert the record to a String" do
+      expect(subject.to_s).to be == "v=#{v}; p=#{p}; rua=#{rua[0]}; ruf=#{ruf[0]}; fo=#{fo[0]}:#{fo[1]}:#{fo[2]}"
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
+require "codeclimate-test-reporter"
+CodeClimate::TestReporter.start
+
 require 'rspec'
 require 'dmarc'
 

metadata

@@ -1,41 +1,41 @@
 --- !ruby/object:Gem::Specification
 name: dmarc
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Davis Gallinghouse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-21 00:00:00.000000000 Z
+date: 2015-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parslet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 description: DMARC Record Parser
@@ -45,11 +45,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .document
-- .gitignore
-- .rspec
-- .travis.yml
-- .yardopts
+- ".document"
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- ".yardopts"
 - ChangeLog.md
 - Gemfile
 - LICENSE.txt
@@ -57,11 +57,13 @@ files:
 - Rakefile
 - dmarc.gemspec
 - lib/dmarc.rb
+- lib/dmarc/dmarc.rb
 - lib/dmarc/exceptions.rb
 - lib/dmarc/parser.rb
 - lib/dmarc/record.rb
 - lib/dmarc/version.rb
 - spec/data/alexa.csv
+- spec/dmarc_spec.rb
 - spec/parser_spec.rb
 - spec/record_spec.rb
 - spec/spec_helper.rb
@@ -76,22 +78,23 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.1
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.4.7
 signing_key: 
 specification_version: 4
 summary: DMARC Record Parser
 test_files:
 - spec/data/alexa.csv
+- spec/dmarc_spec.rb
 - spec/parser_spec.rb
 - spec/record_spec.rb
 - spec/spec_helper.rb