dm_preferences 1.0 → 1.5

data/spec/spec_helper.rb

@@ -1,20 +1,22 @@
-ENV['RAILS_ENV'] ||= 'test'
+ENV["RAILS_ENV"] ||= 'test'
 
-require File.expand_path("../dummy/config/environment.rb",  __FILE__)
+require 'rspec/core' unless defined? RSpec.configure
+require 'spec_helper'
+require File.expand_path("../dummy/config/environment", __FILE__)
 require 'rspec/rails'
 
-Rails.backtrace_cleaner.remove_silencers!
+FactoryGirl.definition_file_paths = [File.expand_path('../factories', __FILE__)]
+FactoryGirl.find_definitions
 
-# Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+ENGINE_RAILS_ROOT = File.join(File.dirname(__FILE__), '../')
+Dir[File.join(ENGINE_RAILS_ROOT, "spec/support/**/*.rb")].each {|f| require f }
+
+ActiveRecord::Migration.maintain_test_schema!
 
 RSpec.configure do |config|
   config.mock_with :rspec
-  config.use_transactional_fixtures = true
-  config.infer_base_class_for_anonymous_controllers = false
   config.order = "random"
+  config.use_transactional_fixtures = true
+  config.infer_spec_type_from_file_location!
+  config.include FactoryGirl::Syntax::Methods
 end
-
-# Checks for pending migrations before tests are run.
-# If you are not using ActiveRecord, you can remove this line.
-ActiveRecord::Migration.maintain_test_schema!

data/spec/unit/preference_definition_spec.rb

@@ -7,7 +7,6 @@ describe 'PreferenceDefinitionByDefaultTest' do
   end
 
   it 'test_should_have_a_name' do
-    # assert_equal 'notifications2', @definition.name
     expect('notifications').to eq @definition.name
   end
 
@@ -16,15 +15,15 @@ describe 'PreferenceDefinitionByDefaultTest' do
   end
 
   it "test_should_have_a_type" do
-    assert_equal :boolean, @definition.type
+    expect(@definition.type).to eq :boolean
   end
 
   it "test_should_type_cast_values_as_booleans" do
-    assert_equal nil, @definition.type_cast(nil)
-    assert_equal true, @definition.type_cast(true)
-    assert_equal false, @definition.type_cast(false)
-    assert_equal false, @definition.type_cast(0)
-    assert_equal true, @definition.type_cast(1)
+    expect(@definition.type_cast(nil)).to eq nil
+    expect(@definition.type_cast(true)).to eq true
+    expect(@definition.type_cast(false)).to eq false
+    expect(@definition.type_cast(0)).to eq false
+    expect(@definition.type_cast(1)).to eq true
   end
 end
 
@@ -44,7 +43,7 @@ describe "PreferenceDefinitionWithDefaultValueTest" do
   end
 
   it "test_should_type_cast_default_values" do
-    assert_equal true, @definition.default_value
+    expect(@definition.default_value).to eq true
   end
 end
 
@@ -55,15 +54,15 @@ describe "PreferenceDefinitionWithGroupDefaultsTest" do
   end
 
   it "test_should_use_default_for_default_group" do
-    assert_equal true, @definition.default_value
+    expect(@definition.default_value).to eq true
   end
 
   it "test_should_use_default_for_unknown_group" do
-    assert_equal true, @definition.default_value('email')
+    expect(@definition.default_value('email')).to eq true
   end
 
   it "test_should_use_group_default_for_known_group" do
-    assert_equal false, @definition.default_value('chat')
+    expect(@definition.default_value('chat')).to eq false
   end
 end
 
@@ -74,7 +73,7 @@ describe "PreferenceDefinitionWithStringifiedTypeTest" do
   end
 
   it "test_should_symbolize_type" do
-    assert_equal :any, @definition.type
+    expect(@definition.type).to eq :any
   end
 end
 
@@ -85,41 +84,41 @@ describe "PreferenceDefinitionWithAnyTypeTest" do
   end
 
   it "test_use_custom_type" do
-    assert_equal :any, @definition.type
+    expect(@definition.type).to eq :any
   end
 
   it "test_should_not_be_number" do
-    assert !@definition.number?
+    expect(!@definition.number?).to eq true
   end
 
   it "test_should_not_type_cast" do
-    assert_equal nil, @definition.type_cast(nil)
-    assert_equal 0, @definition.type_cast(0)
-    assert_equal 1, @definition.type_cast(1)
-    assert_equal false, @definition.type_cast(false)
-    assert_equal true, @definition.type_cast(true)
-    assert_equal '', @definition.type_cast('')
+    expect(@definition.type_cast(nil)).to eq nil
+    expect(@definition.type_cast(0)).to eq 0
+    expect(@definition.type_cast(1)).to eq 1
+    expect(@definition.type_cast(false)).to eq false
+    expect(@definition.type_cast(true)).to eq true
+    expect(@definition.type_cast('')).to eq ''
   end
 
   it "test_should_query_false_if_value_is_nil" do
-    assert_equal false, @definition.query(nil)
+    expect(@definition.query(nil)).to eq false
   end
 
   it "test_should_query_true_if_value_is_zero" do
-    assert_equal true, @definition.query(0)
+    expect(@definition.query(0)).to eq true
   end
 
   it "test_should_query_true_if_value_is_not_zero" do
-    assert_equal true, @definition.query(1)
-    assert_equal true, @definition.query(-1)
+    expect(@definition.query(1)).to eq true
+    expect(@definition.query(-1)).to eq true
   end
 
   it "test_should_query_false_if_value_is_blank" do
-    assert_equal false, @definition.query('')
+    expect(@definition.query('')).to eq false
   end
 
   it "test_should_query_true_if_value_is_not_blank" do
-    assert_equal true, @definition.query('hello')
+    expect(@definition.query('hello')).to eq true
   end
 end
 
@@ -130,31 +129,31 @@ describe "PreferenceDefinitionWithBooleanTypeTest" do
   end
 
   it "test_should_not_be_number" do
-    assert !@definition.number?
+    expect(!@definition.number?).to eq true
   end
 
   it "test_should_not_type_cast_if_value_is_nil" do
-    assert_equal nil, @definition.type_cast(nil)
+    expect(@definition.type_cast(nil)).to eq nil
   end
 
   it "test_should_type_cast_to_false_if_value_is_zero" do
-    assert_equal false, @definition.type_cast(0)
+    expect(@definition.type_cast(0)).to eq false
   end
 
   it "test_should_type_cast_to_true_if_value_is_not_zero" do
-    assert_equal true, @definition.type_cast(1)
+    expect(@definition.type_cast(1)).to eq true
   end
 
   it "test_should_type_cast_to_true_if_value_is_true_string" do
-    assert_equal true, @definition.type_cast('true')
+    expect(@definition.type_cast('true')).to eq true
   end
 
   it "test_should_type_cast_to_nil_if_value_is_not_true_string" do
-    assert_nil @definition.type_cast('')
+    expect(@definition.type_cast('')).to eq nil
   end
 
   it "test_should_query_false_if_value_is_nil" do
-    assert_equal false, @definition.query(nil)
+    expect(@definition.query(nil)).to eq false
   end
 
   it "test_should_query_true_if_value_is_one" do
@@ -162,15 +161,15 @@ describe "PreferenceDefinitionWithBooleanTypeTest" do
   end
 
   it "test_should_query_false_if_value_not_one" do
-    assert_equal false, @definition.query(0)
+    expect(@definition.query(0)).to eq false
   end
 
   it "test_should_query_true_if_value_is_true_string" do
-    assert_equal true, @definition.query('true')
+    expect(@definition.query('true')).to eq true
   end
 
   it "test_should_query_false_if_value_is_not_true_string" do
-    assert_equal false, @definition.query('')
+    expect(@definition.query('')).to eq false
   end
 end
 
@@ -181,11 +180,11 @@ describe "PreferenceDefinitionWithNumericTypeTest" do
   end
 
   it "test_should_be_number" do
-    assert @definition.number?
+    expect(@definition.number?).to eq true
   end
 
   it "test_should_type_cast_true_to_integer" do
-    assert_equal 1, @definition.type_cast(true)
+    expect(@definition.type_cast(true)).to eq 1
   end
 
   # it "test_should_type_cast_false_to_integer" do
@@ -193,19 +192,19 @@ describe "PreferenceDefinitionWithNumericTypeTest" do
   # end
 
   it "test_should_type_cast_string_to_integer" do
-    assert_equal 0, @definition.type_cast('hello')
+    expect(@definition.type_cast('hello')).to eq 0
   end
 
   it "test_should_query_false_if_value_is_nil" do
-    assert_equal false, @definition.query(nil)
+    expect(@definition.query(nil)).to eq false
   end
 
   it "test_should_query_true_if_value_is_one" do
-    assert_equal true, @definition.query(1)
+    expect(@definition.query(1)).to eq true
   end
 
   it "test_should_query_false_if_value_is_zero" do
-    assert_equal false, @definition.query(0)
+    expect(@definition.query(0)).to eq false
   end
 end
 
@@ -216,34 +215,34 @@ describe "> PreferenceDefinitionWithStringTypeTest" do
   end
 
   it "test_should_not_be_number" do
-    assert !@definition.number?
+    expect(!@definition.number?).to eq true
   end
 
   it "test_should_type_cast_integers_to_strings" do
-    assert_equal '1', @definition.type_cast('1')
+    expect(@definition.type_cast('1')).to eq '1'
   end
 
   it "test_should_not_type_cast_booleans" do
-    assert_equal 't', @definition.type_cast(true)
+    expect(@definition.type_cast(true)).to eq 't'
   end
 
   it "test_should_query_false_if_value_is_nil" do
-    assert_equal false, @definition.query(nil)
+    expect(@definition.query(nil)).to eq false
   end
 
   it "test_should_query_true_if_value_is_one" do
-    assert_equal true, @definition.query(1)
+    expect(@definition.query(1)).to eq true
   end
 
   it "test_should_query_true_if_value_is_zero" do
-    assert_equal true, @definition.query(0)
+    expect(@definition.query(0)).to eq true
   end
 
   it "test_should_query_false_if_value_is_blank" do
-    assert_equal false, @definition.query('')
+    expect(@definition.query('')).to eq false
   end
 
   it "test_should_query_true_if_value_is_not_blank" do
-    assert_equal true, @definition.query('hello')
+    expect(@definition.query('hello')).to eq true
   end
 end

data/spec/unit/preference_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-include Factory
+# include Factory
 
 #------------------------------------------------------------------------------
 describe "PreferenceByDefaultTest" do
@@ -9,31 +9,31 @@ describe "PreferenceByDefaultTest" do
   end
 
   it "test_should_not_have_a_name" do
-    assert @preference.name.blank?
+    expect(@preference.name.blank?).to eq true
   end
 
   it "test_should_not_have_an_owner" do
-    assert_nil @preference.owner_id
+    expect(@preference.owner_id).to eq nil
   end
 
   it "test_should_not_have_an_owner_type" do
-    assert @preference.owner_type.blank?
+    expect(@preference.owner_type.blank?).to eq true
   end
 
   it "test_should_not_have_a_group_association" do
-    assert_nil @preference.group_id
+    expect(@preference.group_id).to eq nil
   end
 
   it "test_should_not_have_a_group_type" do
-    assert @preference.group_type.nil?
+    expect(@preference.group_type.nil?).to eq true
   end
 
   it "test_should_not_have_a_value" do
-    assert @preference.value.blank?
+    expect(@preference.value.blank?).to eq true
   end
 
   it "test_should_not_have_a_definition" do
-    assert_nil @preference.definition
+    expect(@preference.definition).to eq nil
   end
 end
 
@@ -41,49 +41,49 @@ end
 describe "PreferenceTest" do
   
   it "test_should_be_valid_with_a_set_of_valid_attributes" do
-    preference = new_preference
-    assert preference.valid?
+    preference = build(:preference)
+    expect(preference.valid?).to eq true
   end
 
   it "test_should_require_a_name" do
-    preference = new_preference(:name => nil)
-    assert !preference.valid?
-    assert preference.errors.include?(:name)
+    preference = build(:preference, :name => nil)
+    expect(preference.valid?).to eq false
+    expect(preference.errors.include?(:name)).to eq true
   end
 
   it "test_should_require_an_owner_id" do
-    preference = new_preference(:owner => nil)
-    assert !preference.valid?
-    assert preference.errors.include?(:owner_id)
+    preference = build(:preference, :owner => nil)
+    expect(preference.valid?).to eq false
+    expect(preference.errors.include?(:owner_id)).to eq true
   end
 
   it "test_should_require_an_owner_type" do
-    preference = new_preference(:owner => nil)
-    assert !preference.valid?
-    assert preference.errors.include?(:owner_type)
+    preference = build(:preference, :owner => nil)
+    expect(preference.valid?).to eq false
+    expect(preference.errors.include?(:owner_type)).to eq true
   end
 
   it "test_should_not_require_a_group_id" do
-    preference = new_preference(:group => nil)
-    assert preference.valid?
+    preference = build(:preference, :group => nil)
+    expect(preference.valid?).to eq true
   end
 
   it "test_should_not_require_a_group_id_if_type_specified" do
-    preference = new_preference(:group => nil)
+    preference = build(:preference, :group => nil)
     preference.group_type = 'Car'
-    assert preference.valid?
+    expect(preference.valid?).to eq true
   end
 
   it "test_should_not_require_a_group_type" do
-    preference = new_preference(:group => nil)
-    assert preference.valid?
+    preference = build(:preference, :group => nil)
+    expect(preference.valid?).to eq true
   end
 
   it "test_should_require_a_group_type_if_id_specified" do
-    preference = new_preference(:group => nil)
+    preference = build(:preference, :group => nil)
     preference.group_id = 1
-    assert !preference.valid?
-    assert preference.errors.include?(:group_type)
+    expect(preference.valid?).to eq false
+    expect(preference.errors.include?(:group_type)).to eq true
   end
 end
 
@@ -91,30 +91,30 @@ end
 describe "PreferenceAsAClassTest" do
   it "test_should_be_able_to_split_nil_groups" do
     group_id, group_type = Preference.split_group(nil)
-    assert_nil group_id
-    assert_nil group_type
+    expect(group_id).to be_nil
+    expect(group_type).to be_nil
   end
 
   it "test_should_be_able_to_split_non_active_record_groups" do
     group_id, group_type = Preference.split_group('car')
-    assert_nil group_id
-    assert_equal 'car', group_type
+    expect(group_id).to be_nil
+    expect(group_type).to eq 'car'
 
     group_id, group_type = Preference.split_group(:car)
-    assert_nil group_id
-    assert_equal 'car', group_type
+    expect(group_id).to be_nil
+    expect(group_type).to eq 'car'
 
     group_id, group_type = Preference.split_group(10)
-    assert_nil group_id
-    assert_equal 10, group_type
+    expect(group_id).to be_nil
+    expect(group_type).to eq 10
   end
 
   it "test_should_be_able_to_split_active_record_groups" do
-    car = create_car
+    car = create(:car)
 
     group_id, group_type = Preference.split_group(car)
-    assert_equal 1, group_id
-    assert_equal 'Car', group_type
+    expect(group_id).to eq 1
+    expect(group_type).to eq 'Car'
   end
 end
 
@@ -123,7 +123,7 @@ describe "PreferenceAfterBeingCreatedTest" do
   before do
     User.preference :notifications, :boolean
 
-    @preference = create_preference(:name => 'notifications')
+    @preference = create(:preference, :name => 'notifications')
   end
 
   it "test_should_have_an_owner" do
@@ -139,7 +139,7 @@ describe "PreferenceAfterBeingCreatedTest" do
   end
 
   it "test_should_not_have_a_group_association" do
-    assert_nil @preference.group
+    expect(@preference.group).to be_nil
   end
 
   after do
@@ -150,23 +150,23 @@ end
 #------------------------------------------------------------------------------
 describe "PreferenceWithBasicGroupTest" do
   before do
-    @preference = create_preference(:group_type => 'car')
+    @preference = create(:preference, :group_type => 'car')
   end
 
   it "test_should_have_a_group_association" do
-    assert_equal 'car', @preference.group
+    expect(@preference.group).to eq 'car'
   end
 end
 
 #------------------------------------------------------------------------------
 describe "PreferenceWithActiveRecordGroupTest" do
   before do
-    @car = create_car
-    @preference = create_preference(:group => @car)
+    @car = create(:car)
+    @preference = create(:preference, :group => @car)
   end
 
   it "test_should_have_a_group_association" do
-    assert_equal @car, @preference.group
+    expect(@preference.group).to eq @car
   end
 end
 
@@ -177,24 +177,24 @@ describe "PreferenceWithBooleanTypeTest" do
   end
 
   it "test_should_type_cast_nil_values" do
-    preference = new_preference(:name => 'notifications', :value => nil)
-    assert_nil preference.value
+    preference = build(:preference, :name => 'notifications', :value => nil)
+    expect(preference.value).to be_nil
   end
 
   it "test_should_type_cast_numeric_values" do
-    preference = new_preference(:name => 'notifications', :value => 0)
-    assert_equal false, preference.value
+    preference = build(:preference, :name => 'notifications', :value => 0)
+    expect(preference.value).to eq false
 
     preference.value = 1
-    assert_equal true, preference.value
+    expect(preference.value).to eq true
   end
 
   it "test_should_type_cast_boolean_values" do
-    preference = new_preference(:name => 'notifications', :value => false)
-    assert_equal false, preference.value
+    preference = build(:preference, :name => 'notifications', :value => false)
+    expect(preference.value).to eq false
 
     preference.value = true
-    assert_equal true, preference.value
+    expect(preference.value).to eq true
   end
 
   after do
@@ -209,16 +209,16 @@ describe "PreferenceWithFloatTypeTest" do
   end
 
   it "test_should_type_cast_nil_values" do
-    preference = new_preference(:name => 'rate', :value => nil)
-    assert_nil preference.value
+    preference = build(:preference, :name => 'rate', :value => nil)
+    expect(preference.value).to be_nil
   end
 
   it "test_should_type_cast_numeric_values" do
-    preference = new_preference(:name => 'rate', :value => 1.0)
-    assert_equal 1.0, preference.value
+    preference = build(:preference, :name => 'rate', :value => 1.0)
+    expect(preference.value).to eq 1.0
 
     preference.value = "1.1"
-    assert_equal 1.1, preference.value
+    expect(preference.value).to eq 1.1
   end
 
   after do
@@ -229,16 +229,16 @@ end
 #------------------------------------------------------------------------------
 describe "PreferenceWithSTIOwnerTest" do
   before do
-    @manager = create_manager
-    @preference = create_preference(:owner => @manager, :name => 'health_insurance', :value => true)
+    @manager = create(:manager)
+    @preference = create(:preference, :owner => @manager, :name => 'health_insurance', :value => true)
   end
 
   it "test_should_have_an_owner" do
-    assert_equal @manager, @preference.owner
+    expect(@preference.owner).to eq @manager
   end
 
   it "test_should_have_an_owner_type" do
-    assert_equal 'Employee', @preference.owner_type
+    expect(@preference.owner_type).to eq 'Employee'
   end
 
   it "test_should_have_a_definition" do
@@ -246,6 +246,6 @@ describe "PreferenceWithSTIOwnerTest" do
   end
 
   it "test_should_have_a_value" do
-    assert_equal true, @preference.value
+    expect(@preference.value).to eq true
   end
 end