dm-validations 0.9.2

data/spec/integration/primitive_validator_spec.rb

@@ -0,0 +1,25 @@
+require 'pathname'
+require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
+
+class Monica # :nodoc:
+  include DataMapper::Resource
+  property :id, Integer, :serial => true
+  property :birth_date, Date, :auto_validation => false
+  validates_is_primitive :birth_date
+end
+
+describe DataMapper::Validate::PrimitiveValidator do
+  it "should validate a property to check for the type" do
+    b = Monica.new
+    p b.valid?
+    p b.errors
+    b.should be_valid
+
+    b.birth_date = 'ABC'
+    b.should_not be_valid
+    b.birth_date.should eql('ABC')
+    b.birth_date = '2008-01-01'
+    b.should be_valid
+    b.birth_date.should eql(Date.civil(2008,1,1))
+  end
+end

data/spec/integration/required_field_validator_spec.rb

@@ -0,0 +1,93 @@
+require 'pathname'
+require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
+
+if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+  describe DataMapper::Validate::RequiredFieldValidator do
+
+    describe "Resources" do
+      before do
+        class Landscaper
+          include DataMapper::Resource
+          property :id, Integer, :key => true
+          property :name, String
+        end
+
+        class Garden
+          include DataMapper::Resource
+          property :id, Integer, :key => true
+          property :landscaper_id, Integer
+          property :name, String, :auto_validation => false
+
+          belongs_to :landscaper #has :landscaper, 1..n
+
+          validates_present :name, :when => :property_test
+          validates_present :landscaper, :when => :association_test
+        end
+
+        class Fertilizer
+          include DataMapper::Resource
+          property :id, Integer, :serial => true
+          property :brand, String, :auto_validation => false, :default => 'Scotts'
+          validates_present :brand, :when => :property_test
+        end
+
+        Landscaper.auto_migrate!
+        Garden.auto_migrate!
+        Fertilizer.auto_migrate!
+      end
+
+      it "should validate the presence of a property value on an instance of a resource" do
+        garden = Garden.new
+        garden.should_not be_valid_for_property_test
+        garden.errors.on(:name).should include('Name must not be blank')
+
+        garden.name = 'The Wilds'
+        garden.should be_valid_for_property_test
+      end
+
+      it "should validate the presence of an association value on an instance of a resource when dirty"
+      #do
+      #  garden = Garden.new
+      #  landscaper = garden.landscaper
+      #  puts landscaper.children.length
+      #  #puts "Gardens landscaper is #{garden.landscaper.child_key}"
+      #end
+
+      it "should pass when a default is available" do
+        fert = Fertilizer.new
+        fert.should be_valid_for_property_test
+      end
+    end
+
+    describe "A plain class (not a DM resource)" do
+
+      before do
+        class PlainClass
+          extend DataMapper::Validate::ClassMethods
+          include DataMapper::Validate
+          attr_accessor :accessor
+          validates_present :here, :empty, :nil, :accessor
+          def here;  "here" end
+          def empty; ""     end
+          def nil;   nil    end
+        end
+
+        @pc = PlainClass.new
+      end
+
+      it "should fail validation with empty, nil, or blank fields" do
+        @pc.should_not be_valid
+        @pc.errors.on(:empty).should    include("Empty must not be blank")
+        @pc.errors.on(:nil).should      include("Nil must not be blank")
+        @pc.errors.on(:accessor).should include("Accessor must not be blank")
+      end
+
+      it "giving accessor a value should remove validation error" do
+        @pc.accessor = "full"
+        @pc.valid?
+        @pc.errors.on(:accessor).should be_nil
+      end
+    end
+
+  end
+end

data/spec/integration/uniqueness_validator_spec.rb

@@ -0,0 +1,81 @@
+require 'pathname'
+require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
+
+if HAS_SQLITE3 || HAS_MYSQL || HAS_POSTGRES
+  describe DataMapper::Validate::UniquenessValidator do
+
+    before do
+      class Organisation
+        include DataMapper::Resource
+        property :id, Serial
+        property :name, String
+        property :domain, String #, :unique => true
+
+        validates_is_unique :domain, :allow_nil => true
+      end
+
+      class User
+        include DataMapper::Resource
+        property :id, Serial
+        property :organisation_id, Integer
+        property :user_name, String
+
+        belongs_to :organisation #has :organisation, n..1
+
+        validates_is_unique :user_name, :when => :testing_association, :scope => [:organisation]
+        validates_is_unique :user_name, :when => :testing_property, :scope => [:organisation_id]
+      end
+
+      Organisation.auto_migrate!
+      User.auto_migrate!
+
+      repository do
+         Organisation.new(:id=>1, :name=>'Org One', :domain=>'taken').save
+         Organisation.new(:id=>2, :name=>'Org Two', :domain=>'two').save
+
+         User.new(:id=>1,:organisation_id=>1,:user_name=>'guy').save
+      end
+    end
+
+    it 'should validate the uniqueness of a value on a resource' do
+      repository do
+        o = Organisation.get!(1)
+        o.should be_valid
+
+        o = Organisation.new(:id=>20,:name=>"Org Twenty", :domain=>nil)
+        o.should be_valid
+        o.save
+
+        o = Organisation.new(:id=>30,:name=>"Org Thirty", :domain=>nil)
+        o.should be_valid
+      end
+    end
+
+    it "should not even check if :allow_nil is true" do
+      repository do
+        o = Organisation.get!(1)
+        o.should be_valid
+
+        o = Organisation.new(:id=>2,:name=>"Org Two", :domain=>"taken")
+        o.should_not be_valid
+        o.errors.on(:domain).should include('Domain is already taken')
+
+        o = Organisation.new(:id=>2,:name=>"Org Two", :domain=>"not_taken")
+        o.should be_valid
+      end
+    end
+
+    it 'should validate the uniqueness of a value with scope' do
+      repository do
+        u = User.new(:id => 2, :organisation_id=>1, :user_name => 'guy')
+        u.should_not be_valid_for_testing_property
+        u.should_not be_valid_for_testing_association
+
+
+        u = User.new(:id => 2, :organisation_id => 2, :user_name  => 'guy')
+        u.should be_valid_for_testing_property
+        u.should be_valid_for_testing_association
+      end
+    end
+  end
+end

data/spec/integration/validation_errors_spec.rb

@@ -0,0 +1,18 @@
+require 'pathname'
+require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
+
+describe DataMapper::Validate::ValidationErrors do
+
+  before(:each) do
+    @errors = DataMapper::Validate::ValidationErrors.new
+  end
+
+  it "should report that it is empty on first creation" do
+    @errors.empty?.should == true
+  end
+
+  it "should continue to report that it is empty even after being checked" do
+    @errors.on(:foo)
+    @errors.empty?.should == true
+  end
+end

data/spec/integration/validation_spec.rb

@@ -0,0 +1,339 @@
+require 'pathname'
+require Pathname(__FILE__).dirname.expand_path.parent + 'spec_helper'
+
+describe DataMapper::Validate do
+  before :all do
+    class Yacht
+      include DataMapper::Resource
+      property :id, Integer, :serial => true
+      property :name, String, :auto_validation => false
+
+      validates_present :name
+    end
+  end
+
+  it 'should respond to save' do
+    Yacht.new.should respond_to(:save)
+  end
+
+  describe '#save' do
+    before do
+      Yacht.auto_migrate!
+      @yacht = Yacht.new :name => 'The Gertrude'
+    end
+
+    describe 'without context specified' do
+      it 'should validate using the default context' do
+        @yacht.should_receive(:valid?).with(:default)
+        @yacht.save
+      end
+
+      it 'should save if the object is valid for the default context' do
+        @yacht.should be_valid
+        @yacht.save.should be_true
+        @yacht.should_not be_new_record
+      end
+
+      it 'should not save if the object is not valid for the default context' do
+        @yacht.name = 'a'
+        @yacht.should be_valid
+
+        @yacht.name = nil
+        @yacht.should_not be_valid
+        @yacht.save.should be_false
+        @yacht.should be_new_record
+      end
+    end
+
+    describe 'with context specified' do
+      before :all do
+        class Yacht
+          validates_length :name, :min => 2, :context => [ :strict_name ]
+        end
+      end
+
+      it 'should validate using the specified context' do
+        @yacht.should_receive(:valid?).with(:strict_name)
+        @yacht.save(:strict_name)
+      end
+
+      it 'should save if the object is valid for the specified context' do
+        @yacht.should be_valid(:strict_name)
+        @yacht.save(:strict_name).should be_true
+        @yacht.should_not be_new_record
+      end
+
+      it 'should not save if the object is not valid for the specified context' do
+        @yacht.name = 'aa'
+        @yacht.should be_valid(:strict_name)
+
+        @yacht.name = 'a'
+        @yacht.should_not be_valid(:strict_name)
+        @yacht.save(:strict_name).should be_false
+        @yacht.should be_new_record
+      end
+    end
+  end
+
+  describe '#save!' do
+    before do
+      Yacht.auto_migrate!
+      @yacht = Yacht.new
+    end
+
+    it "should save object without running validations" do
+      @yacht.should_not_receive(:valid?)
+      @yacht.save!
+      @yacht.should_not be_new_record
+    end
+  end
+
+  it "should respond to validatable? (for recursing assocations)" do
+    Yacht.new.should be_validatable
+    Class.new.new.should_not be_validatable
+  end
+
+  it "should have a set of errors on the instance of the resource" do
+    shamrock = Yacht.new
+    shamrock.should respond_to(:errors)
+  end
+
+  it "should have a set of contextual validations on the class of the resource" do
+    Yacht.should respond_to(:validators)
+  end
+
+  it "should execute all validators for a given context against the resource" do
+    Yacht.validators.should respond_to(:execute)
+  end
+
+  it "should place a validator in the :default context if a named context is not provided" do
+    Yacht.validators.context(:default).length.should == 2
+  end
+
+  it "should allow multiple user defined contexts for a validator" do
+    class Yacht
+      property :port, String, :auto_validation => false
+      validates_present :port, :context => [:at_sea, :in_harbor]
+    end
+
+    Yacht.validators.context(:at_sea).length.should == 1
+    Yacht.validators.context(:in_harbor).length.should == 1
+    Yacht.validators.context(:no_such_context).length.should == 0
+  end
+
+  it "should alias :on and :when for :context" do
+    class Yacht
+      property :owner, String, :auto_validation => false
+      property :bosun, String, :auto_validation => false
+
+      validates_present :owner, :on => :owned_vessel
+      validates_present :bosun, :when => [:under_way]
+    end
+    Yacht.validators.context(:owned_vessel).length.should == 1
+    Yacht.validators.context(:under_way).length.should == 1
+  end
+
+  it "should alias :group for :context (backward compat with Validatable??)" do
+    class Yacht
+      property :captain, String, :auto_validation => false
+      validates_present :captain, :group => [:captained_vessel]
+    end
+    Yacht.validators.context(:captained_vessel).length.should == 1
+  end
+
+  it "should add a method valid_for_<context_name>? for each context" do
+    class Yacht
+      property :engine_size, String, :auto_validation => false
+      validates_present :engine_size, :when => :power_boat
+    end
+
+    cigaret = Yacht.new
+    cigaret.valid_for_default?.should_not == true
+    cigaret.should respond_to(:valid_for_power_boat?)
+    cigaret.valid_for_power_boat?.should_not == true
+
+    cigaret.engine_size = '4 liter V8'
+    cigaret.valid_for_power_boat?.should == true
+  end
+
+  it "should add a method all_valid_for_<context_name>? for each context" do
+    class Yacht
+      property :mast_height, String, :auto_validation => false
+      validates_present :mast_height, :when => :sailing_vessel
+    end
+    swift = Yacht.new
+    swift.should respond_to(:all_valid_for_sailing_vessel?)
+  end
+
+  it "should be able to translate the error message" # needs String::translations
+
+  it "should be able to get the error message for a given field" do
+    class Yacht
+      property :wood_type, String, :auto_validation => false
+      validates_present :wood_type, :on => :wooden_boats
+    end
+    fantasy = Yacht.new
+    fantasy.valid_for_wooden_boats?.should == false
+    fantasy.errors.on(:wood_type).first.should == 'Wood type must not be blank'
+    fantasy.wood_type = 'birch'
+    fantasy.valid_for_wooden_boats?.should == true
+  end
+
+  it "should be able to specify a custom error message" do
+    class Yacht
+      property :year_built, String, :auto_validation => false
+      validates_present :year_built, :when => :built, :message => 'Year built is a must enter field'
+    end
+
+    sea = Yacht.new
+    sea.valid_for_built?.should == false
+    sea.errors.full_messages.first.should == 'Year built is a must enter field'
+  end
+
+  it "should execute a Proc when provided in an :if clause and run validation if the Proc returns true" do
+    class Dingy
+      include DataMapper::Resource
+      property :id, Integer, :serial => true
+      property :owner, String, :auto_validation => false
+      validates_present :owner, :if => Proc.new{|resource| resource.owned?}
+
+      def owned?
+        false
+      end
+    end
+
+    Dingy.new.valid?.should == true
+
+    class Dingy
+      def owned?
+        true
+      end
+    end
+
+    Dingy.new.valid?.should_not == true
+  end
+
+  it "should execute a symbol or method name provided in an :if clause and run validation if the method returns true" do
+    class Dingy
+      validators.clear!
+      validates_present :owner, :if => :owned?
+
+      def owned?
+        false
+      end
+    end
+
+    Dingy.new.valid?.should == true
+
+    class Dingy
+      def owned?
+        true
+      end
+    end
+
+    Dingy.new.valid?.should_not == true
+  end
+
+  it "should execute a Proc when provided in an :unless clause and not run validation if the Proc returns true" do
+    class RowBoat
+      include DataMapper::Resource
+      property :id, Integer, :serial => true
+      validates_present :salesman, :unless => Proc.new{|resource| resource.sold?}
+
+      def sold?
+        false
+      end
+    end
+
+    RowBoat.new.valid?.should_not == true
+
+    class RowBoat
+      def sold?
+        true
+      end
+    end
+
+    RowBoat.new.valid?.should == true
+  end
+
+  it "should execute a symbol or method name provided in an :unless clause and not run validation if the method returns true" do
+    class Dingy
+      validators.clear!
+      validates_present :salesman, :unless => :sold?
+
+      def sold?
+        false
+      end
+    end
+
+    Dingy.new.valid?.should_not == true  #not sold and no salesman
+
+    class Dingy
+      def sold?
+        true
+      end
+    end
+
+    Dingy.new.valid?.should == true    # sold and no salesman
+  end
+
+  it "should perform automatic recursive validation #all_valid? checking all instance variables (and ivar.each items if valid)" do
+    class Invoice
+      include DataMapper::Resource
+      property :id, Integer, :serial => true
+      property :customer, String, :auto_validation => false
+      validates_present :customer
+
+      def line_items
+        @line_items || @line_items = []
+      end
+
+      def comment
+        @comment || nil
+      end
+
+      def comment=(value)
+        @comment = value
+      end
+    end
+
+    class LineItem
+      include DataMapper::Resource
+      property :id, Integer, :serial => true
+      property :price, String, :auto_validation => false
+      validates_is_number :price
+
+      def initialize(price)
+        @price = price
+      end
+    end
+
+    class Comment
+      include DataMapper::Resource
+      property :id, Integer, :serial => true
+      property :note, String, :auto_validation => false
+
+      validates_present :note
+    end
+
+    invoice = Invoice.new(:customer => 'Billy Bob')
+    invoice.valid?.should == true
+
+    for i in 1..6 do
+      invoice.line_items << LineItem.new(i.to_s)
+    end
+    invoice.line_items[1].price = 'BAD VALUE'
+    invoice.comment = Comment.new
+
+    invoice.comment.valid?.should == false
+    invoice.line_items[1].valid?.should == false
+
+    invoice.all_valid?.should == false
+    invoice.comment.note = 'This is a note'
+
+    invoice.all_valid?.should == false
+    invoice.line_items[1].price = '23.44'
+
+    invoice.all_valid?.should == true
+  end
+end