dm-noisy-failures 0.2.1 → 0.2.2

data/lib/data_mapper/noisy_failures.rb

@@ -4,24 +4,24 @@ module DataMapper
     alias_method :destroy?, :destroy
 
     def save
-      unless self.save?
-        return if self.errors.empty?
-        error_message = self.errors.map { |e| "#{self.class}: #{e.join(', ')}" }.join("; ")
-        raise SaveFailureError.new(error_message, self)
-      end
+      return if self.save? || self.errors.empty?
+      error_message = self.errors.map { |e| "#{self.class}: #{e.join(', ')}" }.join("; ")
+      raise SaveFailureError.new(error_message, self)
     end
 
     def destroy
-      unless self.destroy?
-        error_message = "#{self.class}: Unable to destroy, probably due to associated records."
-        raise SaveFailureError.new(error_message, self)
-      end
+      return if self.destroy?
+      error_message = "#{self.class}: Unable to destroy, probably due to associated records."
+      raise SaveFailureError.new(error_message, self)
     end
 
     def update?(*args)
       self.update(*args)
       true
     rescue => e
+      # This seems like the cleanest way of doing this. #update calls #save internally, so we can't
+      # use alias_method because then #update? would call #save, which would raise an exception now
+      # that we've done our monkey-patching.
       false
     end
 

data/lib/data_mapper/noisy_failures/version.rb

@@ -1,5 +1,5 @@
 module DataMapper
   module NoisyFailures
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

data/lib/dm_noisy_failures.rb

@@ -1 +1,2 @@
+require "data_mapper"
 require "data_mapper/noisy_failures"

metadata

@@ -1,87 +1,70 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: dm-noisy-failures
-version: !ruby/object:Gem::Version 
-  hash: 21
+version: !ruby/object:Gem::Version
+  version: 0.2.2
   prerelease: 
-  segments: 
-  - 0
-  - 2
-  - 1
-  version: 0.2.1
 platform: ruby
-authors: 
+authors:
 - Daniel Tao
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2013-01-28 00:00:00 -08:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2013-05-02 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: data_mapper
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id001
-description: |
-  This library replaces the default behavior of DataMapper by raising exceptions with
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: ! 'This library replaces the default behavior of DataMapper by raising
+  exceptions with
+
   descriptive error messages whenever DB operations are not successfully completed.
 
-email: 
+'
+email:
 - daniel.tao@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
+- lib/dm_noisy_failures.rb
 - lib/data_mapper/noisy_failures/version.rb
 - lib/data_mapper/noisy_failures.rb
 - lib/dm-noisy-failures.rb
-- lib/dm_noisy_failures.rb
-has_rdoc: true
 homepage: http://github.com/dtao/dm-noisy-failures
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.4.2
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Noisy (and descriptive) failures for DataMapper
 test_files: []
-