diverge 1.0.0 → 1.0.1

data/lib/diverge.rb

@@ -18,7 +18,13 @@ class Diverge
   end
   
   def kullback_leibler(reverse = false)
-    (reverse ? q.zip(p) : p.zip(q)).inject(0.0) { |sum, (i, j)| sum + (i.zero? ? 0 : i * Math.log(safe_cast(i) / safe_cast(j))) }
+    (reverse ? q.zip(p) : p.zip(q)).inject(0.0) do |sum, (i, j)|
+      if i > 0 && j.zero?
+        raise ArgumentError.new("Kullback-Leibler is not defined when P(i) > 0 and Q(i) = 0")
+      end
+      
+      sum + (i.zero? ? 0 : i * Math.log(i / j))
+    end
   end
   
   alias :kl :kullback_leibler
@@ -28,11 +34,4 @@ class Diverge
   end
   
   alias :js :jensen_shannon
-  
-  private
-  
-  def safe_cast(value)
-    # Just to make sure we don't go crazy and to_f a Complex, for whatever insane reason that might come up, while still avoiding integer division
-    value.class < Integer ? value.to_f : value
-  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: diverge
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-19 00:00:00.000000000 Z
+date: 2012-06-20 00:00:00.000000000 Z
 dependencies: []
 description: A simple collection of functions for determining the divergence between
   two distributions.