disposable 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 344f81de5499edef8813bf4f4c20d4b39e8b351f
-  data.tar.gz: 1e2a2305010b56e2f6a285a704206a54d6f6fb0e
+  metadata.gz: 8c253349d4d314ee180fd275bf708c5d1dc3fcc2
+  data.tar.gz: 76b13c0d6262f330cc183c2498ab60f8cb0bf127
 SHA512:
-  metadata.gz: 0ae1f63242b61ca78b801762a36caeff71c292e83a146478e60916b5fac3a072879296dcee95c7dbe06a3b146a7f533613fd32bb9a4deb7ff7ceb287535163d1
-  data.tar.gz: e9d20cb50187ead62ff6a58ed89e4598e74168ab7d49a9edf857d0d46e683c521e616e448a76b66fdc341c41217067bd3b7b1b0b9c954f2af5d273a35d47e974
+  metadata.gz: 5d5f2a357dac409f5d1c89dd20a2dc66d6de8526bc27f62a9b7b290291d8ff2d7073cc3c06b74722ceba3be6ed9289de47ed1ac08b63ea81b50ef620999b7927
+  data.tar.gz: 8d21e16cf85e61cec5cc2591386b1879642588b5afe48d41f490f7880b1467f3259004155407a5d582d00c3c79ff86990b0abd270489e9918db200b936665c5a

data/CHANGES.md

@@ -1,3 +1,8 @@
+# 0.1.3
+
+* Fix `Composition#save`, it now returns true only if all models could be saved.
+* Introduce `Callback::Group::clone`.
+
 # 0.1.2
 
 * Fix `Changed` which does not use the public reader to compare anymore, but the private `field_read`.

data/README.md

@@ -279,7 +279,7 @@ Compositions of objects can be mapped, too.
 
 ```ruby
 class AlbumTwin < Disposable::Twin
-  feature Composition
+  include Composition
 
   property :id,    on: :album
   property :title, on: :album

data/lib/disposable/callback.rb

@@ -25,6 +25,10 @@ module Disposable::Callback
       end
     end
 
+    def self.clone
+      Class.new(self)
+    end
+
     def self.feature(*args)
     end
 

data/lib/disposable/twin/composition.rb

@@ -48,7 +48,9 @@ module Disposable
 
     private
       def save_model
-        mapper.each(&:save) # goes through all models in Composition.
+        res = true
+        mapper.each { |twin| res &= twin.save } # goes through all models in Composition.
+        res
       end
     end
   end

data/lib/disposable/version.rb

@@ -1,3 +1,3 @@
 module Disposable
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/test/callback_group_test.rb

@@ -219,4 +219,15 @@ class CallbackGroupInheritanceTest < MiniTest::Spec
     RemovingInheritGroup.representer_class.representable_attrs.get(RemovingInheritGroup.hooks[0][1]).representer_module.hooks.to_s.must_equal "[[:on_add, [:reset_song!]]]"
     RemovingInheritGroup.representer_class.representable_attrs.get(RemovingInheritGroup.hooks[2][1]).representer_module.hooks.to_s.must_equal "[[:on_change, [:sing!]]]"
   end
+
+  # Group::clone
+  ClonedGroup = Group.clone
+  ClonedGroup.class_eval do
+    remove! :on_change, :change!
+  end
+
+  it do
+    Group.hooks.size.must_equal 4
+    ClonedGroup.hooks.size.must_equal 3
+  end
 end

data/test/twin/composition_test.rb

@@ -43,7 +43,8 @@ class TwinCompositionTest < MiniTest::Spec
     requester.name.must_equal "Greg Howe"
 
 
-    request.save
+    res = request.save
+    res.must_equal true
 
     # make sure models got synced and saved.
     song.id.must_equal 2
@@ -73,4 +74,11 @@ class TwinCompositionTest < MiniTest::Spec
 
     nested_hash.must_equal(:song=>{"title"=>"Tease", "id"=>2}, :requester=>{"name"=>"Wooten", "id"=>1, "captcha"=>"Awesome!"})
   end
+
+  # save with one unsaveable model.
+    #save returns result.
+  it do
+    song.instance_eval { def save; false; end }
+    request.save.must_equal false
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: disposable
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Nick Sutterer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-27 00:00:00.000000000 Z
+date: 2015-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: uber