dispatch-rider 1.9.0 → 2.0.0

data/spec/lib/dispatch-rider/scheduled_job_spec.rb

@@ -3,10 +3,10 @@ require "spec_helper"
 describe DispatchRider::ScheduledJob do
   let(:message_details) {
     {
-      destinations: [:allied_forces],
+      destinations: ["allied_forces"],
       message: {
-        subject: :war_update,
-        body: { enigma_machine: :broken }
+        "subject" => "war_update",
+        "body" => { "enigma_machine" => "broken" }
       }
     }
   }
@@ -32,10 +32,10 @@ describe DispatchRider::ScheduledJob do
 
   describe ".publish_due_jobs" do
     example {
-      expect(described_class.publisher).to receive(:publish).once.with destinations: [:allied_forces],
+      expect(described_class.publisher).to receive(:publish).once.with destinations: ["allied_forces"],
                                                                        message: {
-                                                                         subject: :war_update,
-                                                                         body: { enigma_machine: :broken }
+                                                                         "subject" => "war_update",
+                                                                         "body" => { "enigma_machine" => "broken" }
                                                                        }
 
       2.times { described_class.publish_due_jobs }
@@ -45,15 +45,15 @@ describe DispatchRider::ScheduledJob do
   describe "#destinations serialization" do
     subject { described_class.find(due_job.id).destinations }
 
-    it { is_expected.to eq [:allied_forces] }
+    it { is_expected.to eq ["allied_forces"] }
   end
 
   describe "#message serialization" do
     subject { described_class.find(due_job.id).message }
 
     it {
-      is_expected.to eq subject: :war_update,
-                        body: { enigma_machine: :broken }
+      is_expected.to eq "subject" => "war_update",
+                        "body" => { "enigma_machine" => "broken" }
     }
   end
 
@@ -61,10 +61,10 @@ describe DispatchRider::ScheduledJob do
     subject(:job) { described_class.find(due_job.id) }
 
     example {
-      expect(described_class.publisher).to receive(:publish).with destinations: [:allied_forces],
+      expect(described_class.publisher).to receive(:publish).with destinations: ["allied_forces"],
                                                                   message: {
-                                                                    subject: :war_update,
-                                                                    body: { enigma_machine: :broken }
+                                                                    "subject" => "war_update",
+                                                                    "body" => { "enigma_machine" => "broken" }
                                                                   }
 
       job.publish

data/spec/lib/dispatch-rider/subscriber_spec.rb

@@ -93,6 +93,7 @@ describe DispatchRider::Subscriber do
 
       context "when process quits" do
         let(:message_subject) { :quiter }
+
         before do
           konst = Class.new(DispatchRider::Handlers::Base) do
             def process(_options)
@@ -110,6 +111,7 @@ describe DispatchRider::Subscriber do
 
       context "when process terminates" do
         let(:message_subject) { :terminator }
+
         before do
           konst = Class.new(DispatchRider::Handlers::Base) do
             def process(_options)
@@ -126,6 +128,7 @@ describe DispatchRider::Subscriber do
 
       context "when process is interupted" do
         let(:message_subject) { :interupter }
+
         before do
           konst = Class.new(DispatchRider::Handlers::Base) do
             def process(_options)
@@ -142,6 +145,7 @@ describe DispatchRider::Subscriber do
 
       context "when process is interupted twice" do
         let(:message_subject) { :twice_interupter }
+
         before do
           allow(subject.demultiplexer).to receive(:stop) # do nothing just ignore the interuption
           allow(subject).to receive(:exit) { throw :got_forcefully_stopped }

data/spec/spec_helper.rb

@@ -1,4 +1,32 @@
-require 'bundler'
+# frozen_string_literal: true
+
+require 'bundler/setup'
+
+require 'simplecov'
+require 'coveralls'
+
+if RUBY_VERSION < "3.1"
+  SimpleCov.start 'rails' do
+    if ENV['CI']
+      require 'simplecov-lcov'
+
+      SimpleCov::Formatter::LcovFormatter.config do |c|
+        c.report_with_single_file = true
+        c.single_report_path = 'coverage/lcov.info'
+      end
+
+      formatter SimpleCov::Formatter::LcovFormatter
+    end
+
+    add_filter '/bin/'
+    add_filter '/script/'
+    add_filter '/db/'
+    add_filter '/spec/' # for rspec
+    add_filter '/test/' # for minitest
+  end
+
+  Coveralls.wear!('rails')
+end
 
 Bundler.setup
 Bundler.require(:default, :development)
@@ -7,8 +35,8 @@ require 'dispatch-rider'
 
 Dir['./spec/support/**/*.rb'].each { |fn| require(fn) }
 
-FactoryGirl.definition_file_paths = %w{spec/factories/}
-FactoryGirl.find_definitions
+FactoryBot.definition_file_paths = %w{spec/factories/}
+FactoryBot.find_definitions
 
 RSpec.configure do |config|
   config.raise_errors_for_deprecations!
@@ -42,7 +70,7 @@ RSpec.configure do |config|
     DispatchRider::ScheduledJob.destroy_all
   end
 
-  config.include FactoryGirl::Syntax::Methods
+  config.include FactoryBot::Syntax::Methods
 end
 
 # Airbrake dummy module

data/spec/support/integration_support.rb

@@ -29,5 +29,4 @@ module IntegrationSupport
 
     subscriber.demultiplexer.start
   end
-
 end

metadata

@@ -1,17 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: dispatch-rider
 version: !ruby/object:Gem::Version
-  version: 1.9.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Suman Mukherjee
 - Dane Natoli
 - Piotr Banasik
 - Ronald Maravilla
+- Mathieu Jobin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-11 00:00:00.000000000 Z
+date: 2022-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -19,42 +20,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 5.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 5.2.0
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 5.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 5.2.0
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 5.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 5.2.0
 - !ruby/object:Gem::Dependency
   name: daemons
   requirement: !ruby/object:Gem::Requirement
@@ -103,22 +104,64 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: aws-sdk-sqs
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
+- !ruby/object:Gem::Dependency
+  name: aws-sdk-sns
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.30'
 - !ruby/object:Gem::Dependency
   name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: coveralls_reborn
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0.25'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '0.25'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: simplecov-lcov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -132,7 +175,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: debug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -146,7 +189,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubygems-tasks
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -160,7 +203,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: github_changelog_generator
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -174,7 +217,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: yard
+  name: rubygems-tasks
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -188,21 +231,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: github_changelog_generator
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: yard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -216,21 +259,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: aws-sdk
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '3.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '3.3'
+- !ruby/object:Gem::Dependency
+  name: factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rubocop_challenger
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -249,16 +306,17 @@ description: "\n    Messaging system based on the reactor pattern.\n\n    You ca
   hands over the message to the appropriate\n    handler.\n\n    You can choose your
   own queueing service.\n  "
 email:
-- piotr@payrollhero.com
-- rmaravilla@payrollhero.com
+- mathieu@payrollhero.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
+- ".github/workflows/build.yml"
+- ".github/workflows/rubocop-challenger.yml"
 - ".gitignore"
-- ".rubocop.hound.yml"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - DEPLOYING.md
@@ -267,6 +325,10 @@ files:
 - README.md
 - Rakefile
 - dispatch-rider.gemspec
+- gemfiles/Gemfile-5-2
+- gemfiles/Gemfile-6-0
+- gemfiles/Gemfile-6-1
+- gemfiles/Gemfile-7-0
 - lib/dispatch-rider.rb
 - lib/dispatch-rider/callbacks.rb
 - lib/dispatch-rider/callbacks/access.rb
@@ -378,7 +440,6 @@ files:
 - spec/lib/dispatch-rider/queue_services/file_system_spec.rb
 - spec/lib/dispatch-rider/queue_services/received_message_spec.rb
 - spec/lib/dispatch-rider/queue_services/simple_spec.rb
-- spec/lib/dispatch-rider/queue_services_spec.rb
 - spec/lib/dispatch-rider/registrars/base_spec.rb
 - spec/lib/dispatch-rider/registrars/file_system_channel_spec.rb
 - spec/lib/dispatch-rider/registrars/handler_spec.rb
@@ -408,14 +469,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.8
+      version: 2.6.5
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.3.5
 signing_key: 
 specification_version: 4
 summary: Messaging system that is customizable based on which queueing system we are
@@ -457,7 +518,6 @@ test_files:
 - spec/lib/dispatch-rider/queue_services/file_system_spec.rb
 - spec/lib/dispatch-rider/queue_services/received_message_spec.rb
 - spec/lib/dispatch-rider/queue_services/simple_spec.rb
-- spec/lib/dispatch-rider/queue_services_spec.rb
 - spec/lib/dispatch-rider/registrars/base_spec.rb
 - spec/lib/dispatch-rider/registrars/file_system_channel_spec.rb
 - spec/lib/dispatch-rider/registrars/handler_spec.rb

data/.rubocop.hound.yml

@@ -1,261 +0,0 @@
-# this is the default from hound's github, do not modify
-AllCops:
-  Exclude:
-    - db/schema.rb
-
-AccessorMethodName:
-  Enabled: false
-
-ActionFilter:
-  Enabled: false
-
-Alias:
-  Enabled: false
-
-ArrayJoin:
-  Enabled: false
-
-AsciiComments:
-  Enabled: false
-
-AsciiIdentifiers:
-  Enabled: false
-
-Attr:
-  Enabled: false
-
-BlockNesting:
-  Enabled: false
-
-CaseEquality:
-  Enabled: false
-
-CharacterLiteral:
-  Enabled: false
-
-ClassAndModuleChildren:
-  Enabled: false
-
-ClassLength:
-  Enabled: false
-
-ClassVars:
-  Enabled: false
-
-CollectionMethods:
-  PreferredMethods:
-    find: detect
-    reduce: inject
-    collect: map
-    find_all: select
-
-ColonMethodCall:
-  Enabled: false
-
-CommentAnnotation:
-  Enabled: false
-
-CyclomaticComplexity:
-  Enabled: false
-
-Delegate:
-  Enabled: false
-
-DeprecatedHashMethods:
-  Enabled: false
-
-Documentation:
-  Enabled: false
-
-DotPosition:
-  EnforcedStyle: trailing
-
-DoubleNegation:
-  Enabled: false
-
-EachWithObject:
-  Enabled: false
-
-EmptyLiteral:
-  Enabled: false
-
-Encoding:
-  Enabled: false
-
-EvenOdd:
-  Enabled: false
-
-FileName:
-  Enabled: false
-
-FlipFlop:
-  Enabled: false
-
-FormatString:
-  Enabled: false
-
-GlobalVars:
-  Enabled: false
-
-GuardClause:
-  Enabled: false
-
-IfUnlessModifier:
-  Enabled: false
-
-IfWithSemicolon:
-  Enabled: false
-
-InlineComment:
-  Enabled: false
-
-Lambda:
-  Enabled: false
-
-LambdaCall:
-  Enabled: false
-
-LineEndConcatenation:
-  Enabled: false
-
-LineLength:
-  Max: 120
-  AllowURI: true
-
-MethodLength:
-  Enabled: false
-
-ModuleFunction:
-  Enabled: false
-
-NegatedIf:
-  Enabled: false
-
-NegatedWhile:
-  Enabled: false
-
-Next:
-  Enabled: false
-
-NilComparison:
-  Enabled: false
-
-Not:
-  Enabled: false
-
-NumericLiterals:
-  Enabled: false
-
-OneLineConditional:
-  Enabled: false
-
-OpMethod:
-  Enabled: false
-
-ParameterLists:
-  Enabled: false
-
-PercentLiteralDelimiters:
-  Enabled: false
-
-PerlBackrefs:
-  Enabled: false
-
-PredicateName:
-  NamePrefixBlacklist:
-    - is_
-
-Proc:
-  Enabled: false
-
-RaiseArgs:
-  Enabled: false
-
-RegexpLiteral:
-  Enabled: false
-
-SelfAssignment:
-  Enabled: false
-
-SingleLineBlockParams:
-  Enabled: false
-
-SingleLineMethods:
-  Enabled: false
-
-SignalException:
-  Enabled: false
-
-SpecialGlobalVars:
-  Enabled: false
-
-StringLiterals:
-  EnforcedStyle: double_quotes
-
-VariableInterpolation:
-  Enabled: false
-
-TrailingComma:
-  Enabled: false
-
-TrivialAccessors:
-  Enabled: false
-
-VariableInterpolation:
-  Enabled: false
-
-WhenThen:
-  Enabled: false
-
-WhileUntilModifier:
-  Enabled: false
-
-WordArray:
-  Enabled: false
-
-# Lint
-
-AmbiguousOperator:
-  Enabled: false
-
-AmbiguousRegexpLiteral:
-  Enabled: false
-
-AssignmentInCondition:
-  Enabled: false
-
-ConditionPosition:
-  Enabled: false
-
-DeprecatedClassMethods:
-  Enabled: false
-
-ElseLayout:
-  Enabled: false
-
-HandleExceptions:
-  Enabled: false
-
-InvalidCharacterLiteral:
-  Enabled: false
-
-LiteralInCondition:
-  Enabled: false
-
-LiteralInInterpolation:
-  Enabled: false
-
-Loop:
-  Enabled: false
-
-ParenthesesAsGroupedExpression:
-  Enabled: false
-
-RequireParentheses:
-  Enabled: false
-
-UnderscorePrefixedVariableName:
-  Enabled: false
-
-Void:
-  Enabled: false