dispatch-rider 1.5.3 → 1.6.0

data/spec/lib/dispatch-rider/runner_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe DispatchRider::Runner do
 
   describe ".run" do
-    let(:subscriber){ double(:subscriber) }
+    let(:subscriber) { double(:subscriber) }
 
     before :each do
       DispatchRider.configure do |config|

data/spec/lib/dispatch-rider/subscriber_spec.rb

@@ -3,39 +3,46 @@ require "spec_helper"
 describe DispatchRider::Subscriber do
 
   before do
-    DispatchRider::Handlers::Base.stub(:subclasses){ Set.new }
+    allow(DispatchRider::Handlers::Base).to receive(:subclasses) { Set.new }
 
-    stub_const("FooBar", Class.new(DispatchRider::Handlers::Base) {
-      def process(options)
+    konst = Class.new(DispatchRider::Handlers::Base) do
+      def process(_options)
         throw :process_was_called
       end
-    })
+    end
+    stub_const("FooBar", konst)
   end
 
   describe "#initialize" do
     it "should assign a new queue service registrar" do
-      subject.queue_service_registrar.store.should be_empty
+      expect(subject.queue_service_registrar.store).to be_empty
     end
   end
 
   describe "#register_queue" do
     it "should register a queue service with the queue service registrar" do
       subject.register_queue(:simple)
-      subject.queue_service_registrar.fetch(:simple).should be_empty
+      expect(subject.queue_service_registrar.fetch(:simple)).to be_empty
     end
   end
 
   describe "#register_handler" do
     it "should register a handler" do
       subject.register_handler(:foo_bar)
-      expect { subject.dispatcher.dispatch(DispatchRider::Message.new(:subject => :foo_bar, :body => {'foo' => 'bar'})) }.to throw_symbol(:process_was_called)
+      expect {
+        message = DispatchRider::Message.new(subject: :foo_bar, body: { 'foo' => 'bar' })
+        subject.dispatcher.dispatch(message)
+      }.to throw_symbol(:process_was_called)
     end
   end
 
   describe "#register_handlers" do
     it "should register all the handlers" do
       subject.register_handlers(:foo_bar)
-      expect { subject.dispatcher.dispatch(DispatchRider::Message.new(:subject => :foo_bar, :body => {'foo' => 'bar'})) }.to throw_symbol(:process_was_called)
+      expect {
+        message = DispatchRider::Message.new(subject: :foo_bar, body: { 'foo' => 'bar' })
+        subject.dispatcher.dispatch(message)
+      }.to throw_symbol(:process_was_called)
     end
   end
 
@@ -48,8 +55,8 @@ describe DispatchRider::Subscriber do
 
       it "should assign a demultiplexer" do
         subject.setup_demultiplexer(:simple)
-        subject.demultiplexer.queue.should be_empty
-        subject.demultiplexer.dispatcher.fetch(:foo_bar).should eq(FooBar)
+        expect(subject.demultiplexer.queue).to be_empty
+        expect(subject.demultiplexer.dispatcher.fetch(:foo_bar)).to eq(FooBar)
       end
     end
   end
@@ -63,7 +70,8 @@ describe DispatchRider::Subscriber do
 
     describe "processing" do
       before do
-        subject.queue_service_registrar.fetch(:simple).push(DispatchRider::Message.new(subject: :foo_bar, body: {'baz' => 'blah'}))
+        message = DispatchRider::Message.new(subject: :foo_bar, body: { 'baz' => 'blah' })
+        subject.queue_service_registrar.fetch(:simple).push(message)
       end
 
       it "should process the queue" do
@@ -73,18 +81,20 @@ describe DispatchRider::Subscriber do
 
     # kills travis sometimes so leaving it here as tested documentation
     describe "process termination", if: false do
-      before { subject.demultiplexer.stub(:stop){ throw :got_stopped } }
+      before { allow(subject.demultiplexer).to receive(:stop) { throw :got_stopped } }
 
       context "when process quits" do
         before do
-          stub_const("Quiter", Class.new(DispatchRider::Handlers::Base) {
-            def process(options)
+          konst = Class.new(DispatchRider::Handlers::Base) do
+            def process(_options)
               Process.kill("QUIT", 0)
             end
-          })
+          end
+          stub_const("Quiter", konst)
 
           subject.register_handler(:quiter)
-          subject.queue_service_registrar.fetch(:simple).push(DispatchRider::Message.new(subject: :quiter, body: {}))
+          message = DispatchRider::Message.new(subject: :quiter, body: {})
+          subject.queue_service_registrar.fetch(:simple).push(message)
         end
 
         example { expect { subject.process }.to throw_symbol(:got_stopped) }
@@ -92,13 +102,15 @@ describe DispatchRider::Subscriber do
 
       context "when process terminates" do
         before do
-          stub_const("Terminator", Class.new(DispatchRider::Handlers::Base) {
-            def process(options)
+          konst = Class.new(DispatchRider::Handlers::Base) do
+            def process(_options)
               Process.kill("TERM", 0)
             end
-          })
+          end
+          stub_const("Terminator", konst)
           subject.register_handler(:terminator)
-          subject.queue_service_registrar.fetch(:simple).push(DispatchRider::Message.new(subject: :terminator, body: {}))
+          message = DispatchRider::Message.new(subject: :terminator, body: {})
+          subject.queue_service_registrar.fetch(:simple).push(message)
         end
 
         example { expect { subject.process }.to throw_symbol(:got_stopped) }
@@ -106,13 +118,15 @@ describe DispatchRider::Subscriber do
 
       context "when process is interupted" do
         before do
-          stub_const("Interupter", Class.new(DispatchRider::Handlers::Base) {
-            def process(options)
+          konst = Class.new(DispatchRider::Handlers::Base) do
+            def process(_options)
               Process.kill("INT", 0)
             end
-          })
+          end
+          stub_const("Interupter", konst)
           subject.register_handler(:interupter)
-          subject.queue_service_registrar.fetch(:simple).push(DispatchRider::Message.new(subject: :interupter, body: {}))
+          message = DispatchRider::Message.new(subject: :interupter, body: {})
+          subject.queue_service_registrar.fetch(:simple).push(message)
         end
 
         example { expect { subject.process }.to throw_symbol(:got_stopped) }
@@ -120,16 +134,18 @@ describe DispatchRider::Subscriber do
 
       context "when process is interupted twice" do
         before do
-          subject.demultiplexer.stub(:stop) # do nothing just ignore the interuption
-          subject.stub(:exit){ throw :got_forcefully_stopped }
+          allow(subject.demultiplexer).to receive(:stop) # do nothing just ignore the interuption
+          allow(subject).to receive(:exit) { throw :got_forcefully_stopped }
 
-          stub_const("TwiceInterupter", Class.new(DispatchRider::Handlers::Base) {
+          konst = Class.new(DispatchRider::Handlers::Base) do
             def process(options)
               2.times { Process.kill("INT", 0) }
             end
-          })
+          end
+          stub_const("TwiceInterupter", konst)
           subject.register_handler(:twice_interupter)
-          subject.queue_service_registrar.fetch(:simple).push(DispatchRider::Message.new(subject: :twice_interupter, body: {}))
+          message = DispatchRider::Message.new(subject: :twice_interupter, body: {})
+          subject.queue_service_registrar.fetch(:simple).push(message)
         end
 
         example { expect { subject.process }.to throw_symbol(:got_forcefully_stopped) }

data/spec/lib/dispatch-rider_spec.rb

@@ -4,13 +4,13 @@ describe DispatchRider do
 
   describe ".configuration" do
     example do
-      described_class.configuration.should be_a(DispatchRider::Configuration)
+      expect(described_class.configuration).to be_a(DispatchRider::Configuration)
     end
   end
 
   describe ".config" do
     example do
-      described_class.config.should be_a(DispatchRider::Configuration)
+      expect(described_class.config).to be_a(DispatchRider::Configuration)
     end
   end
 
@@ -20,7 +20,7 @@ describe DispatchRider do
         config.queue_kind = :test_queue
       end
 
-      described_class.config.queue_kind.should == :test_queue
+      expect(described_class.config.queue_kind).to eq(:test_queue)
     end
   end
 

data/spec/spec_helper.rb

@@ -6,6 +6,7 @@ require 'rake'
 require 'tempfile'
 
 RSpec.configure do |config|
+  config.raise_errors_for_deprecations!
   config.mock_with :rspec
   config.order = 'random'
   config.color = true
@@ -16,6 +17,7 @@ RSpec.configure do |config|
 end
 
 # Airbrake dummy module
-module Airbrake; end
+module Airbrake
+end
 
 require 'dispatch-rider'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dispatch-rider
 version: !ruby/object:Gem::Version
-  version: 1.5.3
+  version: 1.6.0
 platform: ruby
 authors:
 - Suman Mukherjee
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-21 00:00:00.000000000 Z
+date: 2015-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -114,6 +114,11 @@ files:
 - lib/dispatch-rider/handlers/inheritance_tracking.rb
 - lib/dispatch-rider/handlers/named_process.rb
 - lib/dispatch-rider/integrations/appsignal.rb
+- lib/dispatch-rider/logging.rb
+- lib/dispatch-rider/logging/base_formatter.rb
+- lib/dispatch-rider/logging/json_formatter.rb
+- lib/dispatch-rider/logging/lifecycle_logger.rb
+- lib/dispatch-rider/logging/text_formatter.rb
 - lib/dispatch-rider/message.rb
 - lib/dispatch-rider/notification_services.rb
 - lib/dispatch-rider/notification_services/aws_sns.rb
@@ -169,6 +174,9 @@ files:
 - spec/lib/dispatch-rider/dispatcher_spec.rb
 - spec/lib/dispatch-rider/handlers/base_spec.rb
 - spec/lib/dispatch-rider/handlers/inheritance_tracking_spec.rb
+- spec/lib/dispatch-rider/logging/json_formatter_spec.rb
+- spec/lib/dispatch-rider/logging/lifecycle_logger_spec.rb
+- spec/lib/dispatch-rider/logging/text_formatter_spec.rb
 - spec/lib/dispatch-rider/message_spec.rb
 - spec/lib/dispatch-rider/notification_services/aws_sns_spec.rb
 - spec/lib/dispatch-rider/notification_services/base_spec.rb
@@ -238,6 +246,9 @@ test_files:
 - spec/lib/dispatch-rider/dispatcher_spec.rb
 - spec/lib/dispatch-rider/handlers/base_spec.rb
 - spec/lib/dispatch-rider/handlers/inheritance_tracking_spec.rb
+- spec/lib/dispatch-rider/logging/json_formatter_spec.rb
+- spec/lib/dispatch-rider/logging/lifecycle_logger_spec.rb
+- spec/lib/dispatch-rider/logging/text_formatter_spec.rb
 - spec/lib/dispatch-rider/message_spec.rb
 - spec/lib/dispatch-rider/notification_services/aws_sns_spec.rb
 - spec/lib/dispatch-rider/notification_services/base_spec.rb