dispatch-rider 1.5.2 → 1.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9cc97d7a9062650d258c05ce905239d08c208eb7
-  data.tar.gz: f884937b1b4f1c67ff5835432dad776488e8b4e5
+  metadata.gz: 00791dcc6642fcdce813e92abe1e6112af845b47
+  data.tar.gz: 4db374187ef33441a01b17999c6c4dac5a87b535
 SHA512:
-  metadata.gz: bc9e8902fa6f05383ccac0509f4b6b87104c03789e6a524422f26dd940e907dacb01e9df1262eb10990aba7644512657ea83f503755ef6dfca49dc76c8f52436
-  data.tar.gz: 527922a952e05997f7f0c3650797d9d586a7ca5ceade46e7e58d3a0e7a212aed8c6349ecda9f739ec957f9ec9f915e9c780793336d921b449faadd3975eb8fdb
+  metadata.gz: 89bd9117b23f3ae1a26c0e5b2bd0b5dafaf2509413ac5a06ed12f01b0acdbd29f61b9694a0a3805d92acc4b9c7dfa402b425a263f3fb91055d328d1f4778eb23
+  data.tar.gz: 49054767ae3bc31d56144826a5d41d5b1410045b35020f264815e8e096cd7c9e7a6f2c55cffe446bd2743b8b082e0b37683cdd8dbe3acd3e4d527ea9bf929fb6

data/lib/dispatch-rider/notification_services/aws_sns.rb

@@ -16,12 +16,8 @@ module DispatchRider
         Registrars::SnsChannel
       end
 
-      def publish(options)
-        channels(options[:to]).each do |channel|
-          with_retries(max_retries: 10, rescue: AWS::Errors::MissingCredentialsError) do
-            channel.publish(serialize(options[:message]))
-          end
-        end
+      def publish_to_channel(channel, message:)
+        with_retries(max_retries: 10, rescue: AWS::Errors::MissingCredentialsError) { super }
       end
 
       # not really happy with this, but the notification service registrar system is way too rigid to do this cleaner

data/lib/dispatch-rider/notification_services/base.rb

@@ -28,10 +28,8 @@ module DispatchRider
         raise NotImplementedError
       end
 
-      def publish(options)
-        channels(options[:to]).each do |channel|
-          channel.publish(serialize(options[:message]))
-        end
+      def publish(to:, message:)
+        channels(to).each { |channel| publish_to_channel channel, message: message }
       end
 
       def channels(names)
@@ -42,6 +40,10 @@ module DispatchRider
         raise NotImplementedError
       end
 
+      def publish_to_channel(channel, message:)
+        channel.publish(serialize(message))
+      end
+
       private
 
       def serialize(item)

data/lib/dispatch-rider/publisher.rb

@@ -54,7 +54,7 @@ module DispatchRider
 
     def build_message(attributes)
       DispatchRider::Message.new(attributes).tap do |message|
-        message.body[:guid] = generate_new_message_id
+        message.body[:guid] ||= generate_new_message_id
       end
     end
 

data/lib/dispatch-rider/version.rb

@@ -1,4 +1,4 @@
 # This file specifies the current version of the gem.
 module DispatchRider
-  VERSION = "1.5.2"
+  VERSION = "1.5.3"
 end

data/spec/lib/dispatch-rider/notification_services/aws_sns_spec.rb

@@ -15,6 +15,23 @@ describe DispatchRider::NotificationServices::AwsSns do
     end
   end
 
+  describe "#publish_to_channel" do
+    let(:channel) { double(:channel) }
+    let(:message) { DispatchRider::Message.new(subject: :test_handler, body: { "bar" => "baz" }) }
+
+    # @note: This is tested this way cause you don't really wanna post a message to the actual service.
+    it "publishes the message to the channels" do
+      expect(channel).to receive(:publish).with(kind_of String) { |serialized_message|
+        expect(JSON.parse(serialized_message)).to eq(
+          "subject" => "test_handler",
+          "body" => { "bar" => "baz" }
+        )
+      }
+
+      subject.publish_to_channel(channel, message: message)
+    end
+  end
+
   describe "#channel" do
     before { subject.stub(:channel_registrar).and_return(foo: amazon_resource_name) }
 

data/spec/lib/dispatch-rider/notification_services/base_spec.rb

@@ -39,10 +39,28 @@ describe DispatchRider::NotificationServices::Base do
       subject.notifier.topics['arn:aws:sns:us-east-1:123:PlanOfAttack'] = channel
     end
 
+    let(:message) { DispatchRider::Message.new(subject: :test_handler, body: { "bar" => "baz" }) }
+
+    it "publishes the message to the channels" do
+      catch(:published) { subject.publish to: :foo, message: message }.should eq("baz")
+    end
+  end
+
+  describe "#publish_to_channel" do
+    let(:channel) { double(:channel) }
+
+    let(:message) { DispatchRider::Message.new(subject: :test_handler, body: { "bar" => "baz" }) }
+
+    # @note: This is tested this way cause you don't really wanna post a message to the actual service.
     it "publishes the message to the channels" do
-      catch :published do
-        subject.publish(:to => :foo, :message => {:subject => :test_handler, :body => {"bar" => "baz"}})
-      end.should eq('baz')
+      expect(channel).to receive(:publish).with(kind_of String) { |serialized_message|
+        expect(JSON.parse(serialized_message)).to eq(
+          "subject" => "test_handler",
+          "body" => { "bar" => "baz" }
+        )
+      }
+
+      subject.publish_to_channel(channel, message: message)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dispatch-rider
 version: !ruby/object:Gem::Version
-  version: 1.5.2
+  version: 1.5.3
 platform: ruby
 authors:
 - Suman Mukherjee
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-14 00:00:00.000000000 Z
+date: 2015-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport