discourse_api 2.0.1 → 2.1.0

data/spec/discourse_api/api/email_spec.rb

@@ -2,7 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::Email do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#email_settings" do
     before do
@@ -15,12 +15,12 @@ describe DiscourseApi::API::Email do
     end
 
     it "requests the correct resource" do
-      subject.email_settings
+      client.email_settings
       expect(a_get("#{host}/admin/email.json")).to have_been_made
     end
 
     it "returns the requested settings" do
-      settings = subject.email_settings
+      settings = client.email_settings
       expect(settings).to be_a Hash
       expect(settings).to have_key("delivery_method")
       expect(settings).to have_key("settings")
@@ -38,12 +38,12 @@ describe DiscourseApi::API::Email do
     end
 
     it "requests the correct resource" do
-      subject.list_email("all")
+      client.list_email("all")
       expect(a_get("#{host}/admin/email/all.json")).to have_been_made
     end
 
     it "returns all email" do
-      all_email = subject.list_email("all")
+      all_email = client.list_email("all")
       expect(all_email).to be_an Array
     end
   end

data/spec/discourse_api/api/groups_spec.rb

@@ -2,7 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::Groups do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#groups" do
     before do
@@ -15,12 +15,12 @@ describe DiscourseApi::API::Groups do
     end
 
     it "requests the correct resource" do
-      subject.groups
+      client.groups
       expect(a_get("#{host}/groups.json")).to have_been_made
     end
 
     it "returns the requested groups" do
-      groups = subject.groups
+      groups = client.groups
       expect(groups).to be_an Array
       groups.each { |g| expect(g).to be_a Hash }
     end
@@ -32,20 +32,20 @@ describe DiscourseApi::API::Groups do
           content_type: "application/json",
         },
       )
-      group = subject.group("some-group")
+      group = client.group("some-group")
       expect(group["basic_group"]).to be_a Hash
     end
 
     it "create new groups" do
       stub_post("#{host}/admin/groups")
-      subject.create_group(name: "test_group")
+      client.create_group(name: "test_group")
       params = escape_params("group[name]" => "test_group", "group[visibility_level]" => 0)
       expect(a_post("#{host}/admin/groups").with(body: params)).to have_been_made
     end
 
     it "update an existing group" do
       stub_put("#{host}/groups/42")
-      subject.update_group(42, name: "test_group")
+      client.update_group(42, name: "test_group")
       params = escape_params("group[name]" => "test_group", "group[visibility_level]" => 0)
       expect(a_put("#{host}/groups/42").with(body: params)).to have_been_made
     end
@@ -54,14 +54,14 @@ describe DiscourseApi::API::Groups do
       before { stub_request(:put, "#{host}/admin/groups/123/members.json") }
 
       it "adds a single member by username" do
-        subject.group_add(123, username: "sam")
+        client.group_add(123, username: "sam")
         expect(
           a_request(:put, "#{host}/admin/groups/123/members.json").with(body: { usernames: "sam" }),
         ).to have_been_made
       end
 
       it "adds an array of members by username" do
-        subject.group_add(123, usernames: %w[sam jeff])
+        client.group_add(123, usernames: %w[sam jeff])
         expect(
           a_request(:put, "#{host}/admin/groups/123/members.json").with(
             body: {
@@ -72,14 +72,14 @@ describe DiscourseApi::API::Groups do
       end
 
       it "adds a single member by user_id" do
-        subject.group_add(123, user_id: 456)
+        client.group_add(123, user_id: 456)
         expect(
           a_request(:put, "#{host}/admin/groups/123/members.json").with(body: { user_ids: "456" }),
         ).to have_been_made
       end
 
       it "adds an array of members by user_id" do
-        subject.group_add(123, user_id: [123, 456])
+        client.group_add(123, user_id: [123, 456])
         expect(
           a_request(:put, "#{host}/admin/groups/123/members.json").with(
             body: {
@@ -96,7 +96,7 @@ describe DiscourseApi::API::Groups do
       before { stub_delete(url) }
 
       it "removes member" do
-        subject.group_remove(123, username: "sam")
+        client.group_remove(123, username: "sam")
         expect(a_delete(url)).to have_been_made
       end
     end
@@ -107,7 +107,7 @@ describe DiscourseApi::API::Groups do
       before { stub_put(url) }
 
       it "makes the member an owner" do
-        subject.group_add_owners(123, usernames: "sam")
+        client.group_add_owners(123, usernames: "sam")
         params = escape_params("group[usernames]" => "sam")
         expect(
           a_request(:put, "#{host}/admin/groups/123/owners.json").with(body: params),
@@ -121,7 +121,7 @@ describe DiscourseApi::API::Groups do
       before { stub_delete(url) }
 
       it "removes the owner role from the group member" do
-        subject.group_remove_owners(123, usernames: "sam")
+        client.group_remove_owners(123, usernames: "sam")
         expect(a_delete(url)).to have_been_made
       end
     end
@@ -140,10 +140,10 @@ describe DiscourseApi::API::Groups do
             content_type: "application/json",
           },
         )
-        members = subject.group_members("mygroup")
+        members = client.group_members("mygroup")
         expect(a_get("#{host}/groups/mygroup/members.json?limit=100&offset=0")).to have_been_made
         expect(members.length).to eq(100)
-        members = subject.group_members("mygroup", offset: 100)
+        members = client.group_members("mygroup", offset: 100)
         expect(a_get("#{host}/groups/mygroup/members.json?limit=100&offset=100")).to have_been_made
         expect(members.length).to eq(90)
       end
@@ -156,7 +156,7 @@ describe DiscourseApi::API::Groups do
               content_type: "application/json",
             },
           )
-          member_data = subject.group_members("mygroup", all: true)
+          member_data = client.group_members("mygroup", all: true)
           expect(a_get("#{host}/groups/mygroup/members.json?limit=100&offset=0")).to have_been_made
           expect(member_data["members"].length).to eq(100)
           expect(member_data["owners"].length).to eq(7)
@@ -169,7 +169,7 @@ describe DiscourseApi::API::Groups do
       before { stub_post("#{host}/groups/mygroup/notifications?user_id=77&notification_level=3") }
 
       it "updates user's notification level for group" do
-        subject.group_set_user_notification_level("mygroup", 77, 3)
+        client.group_set_user_notification_level("mygroup", 77, 3)
         expect(
           a_post("#{host}/groups/mygroup/notifications?user_id=77&notification_level=3"),
         ).to have_been_made

data/spec/discourse_api/api/invite_spec.rb

@@ -2,7 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::Invite do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#invite_user" do
     before do
@@ -15,12 +15,12 @@ describe DiscourseApi::API::Invite do
     end
 
     it "requests the correct resource" do
-      subject.invite_user(email: "fake_user@example.com", group_ids: "41,42")
+      client.invite_user(email: "fake_user@example.com", group_ids: "41,42")
       expect(a_post("#{host}/invites")).to have_been_made
     end
 
     it "returns success" do
-      response = subject.invite_user(email: "fake_user@example.com", group_ids: "41,42")
+      response = client.invite_user(email: "fake_user@example.com", group_ids: "41,42")
       expect(response).to be_a Hash
       expect(response["success"]).to be_truthy
     end
@@ -37,7 +37,7 @@ describe DiscourseApi::API::Invite do
     end
 
     it "updates invite" do
-      subject.update_invite(27, email: "namee@example.com")
+      client.update_invite(27, email: "namee@example.com")
       expect(a_put("#{host}/invites/27")).to have_been_made
     end
   end
@@ -53,17 +53,17 @@ describe DiscourseApi::API::Invite do
     end
 
     it "requests the correct resource" do
-      subject.retrieve_invite(email: "foo@bar.com")
+      client.retrieve_invite(email: "foo@bar.com")
       expect(a_get("#{host}/invites/retrieve.json?email=foo@bar.com")).to have_been_made
     end
 
     it "returns the requested topics" do
-      invites = subject.retrieve_invite(email: "foo@bar.com")
+      invites = client.retrieve_invite(email: "foo@bar.com")
       expect(invites).to be_an Hash
     end
 
     it "returns the requested invite" do
-      invites = subject.retrieve_invite(email: "foo@bar.com")
+      invites = client.retrieve_invite(email: "foo@bar.com")
       expect(invites["email"]).to eq("foo@bar.com")
       expect(invites).to have_key("invite_key")
     end
@@ -82,7 +82,7 @@ describe DiscourseApi::API::Invite do
     end
 
     it "destroys all expired invites" do
-      subject.destroy_all_expired_invites
+      client.destroy_all_expired_invites
       expect(a_post(url)).to have_been_made
     end
   end
@@ -100,7 +100,7 @@ describe DiscourseApi::API::Invite do
     end
 
     it "resends all invites" do
-      subject.resend_all_invites
+      client.resend_all_invites
       expect(a_post(url)).to have_been_made
     end
   end
@@ -118,7 +118,7 @@ describe DiscourseApi::API::Invite do
     end
 
     it "resends invite" do
-      subject.resend_invite("foo@bar.com")
+      client.resend_invite("foo@bar.com")
       expect(a_post(url)).to have_been_made
     end
   end
@@ -136,7 +136,7 @@ describe DiscourseApi::API::Invite do
     end
 
     it "destroys the invite" do
-      subject.destroy_invite(27)
+      client.destroy_invite(27)
       expect(a_delete(url)).to have_been_made
     end
   end

data/spec/discourse_api/api/notifications_spec.rb

@@ -2,7 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::Notifications do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#notifications" do
     before do
@@ -15,12 +15,12 @@ describe DiscourseApi::API::Notifications do
     end
 
     it "requests the correct resource" do
-      subject.notifications
+      client.notifications
       expect(a_get("#{host}/notifications.json")).to have_been_made
     end
 
     it "returns the requested notifications" do
-      notifications = subject.notifications
+      notifications = client.notifications
       expect(notifications).to be_an Array
       expect(notifications.first).to be_an Hash
       expect(notifications[0]["notification_type"]).to eq(9)

data/spec/discourse_api/api/polls_spec.rb

@@ -2,7 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::Polls do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#poll vote" do
     before do
@@ -17,13 +17,13 @@ describe DiscourseApi::API::Polls do
 
     it "requests the correct resource" do
       options = ["8b4736b1ae3dfb5a28088530f036f9e5"]
-      subject.poll_vote post_id: 5, poll_name: "poll", options: options
+      client.poll_vote post_id: 5, poll_name: "poll", options: options
       expect(a_put("#{host}/polls/vote")).to have_been_made
     end
 
     it "returns the expected votes" do
       options = ["8b4736b1ae3dfb5a28088530f036f9e5"]
-      vote = subject.poll_vote post_id: 5, poll_name: "poll", options: options
+      vote = client.poll_vote post_id: 5, poll_name: "poll", options: options
       expect(vote.body).to be_a Hash
       expect(vote.body["poll"]["options"]).to be_an Array
       expect(vote.body["vote"]).to eq(["8b4736b1ae3dfb5a28088530f036f9e5"])
@@ -41,13 +41,13 @@ describe DiscourseApi::API::Polls do
       end
 
       it "toggles the poll status to closed" do
-        subject.toggle_poll_status post_id: 5, poll_name: "poll", status: "closed"
+        client.toggle_poll_status post_id: 5, poll_name: "poll", status: "closed"
         expect(a_put("#{host}/polls/toggle_status")).to have_been_made
       end
 
       it "returns the expected results of closed poll" do
         returned_poll_status =
-          subject.toggle_poll_status post_id: 5, poll_name: "poll", status: "closed"
+          client.toggle_poll_status post_id: 5, poll_name: "poll", status: "closed"
         expect(returned_poll_status.body).to be_a Hash
         returned_poll_status.body["poll"]["options"].each { |g| expect(g).to be_a Hash }
       end
@@ -64,12 +64,12 @@ describe DiscourseApi::API::Polls do
       end
 
       it "requests the correct resource" do
-        subject.poll_voters post_id: 5, poll_name: "poll"
+        client.poll_voters post_id: 5, poll_name: "poll"
         expect(a_get("#{host}/polls/voters.json?post_id=5&poll_name=poll")).to have_been_made
       end
 
       it "returns the expected votes" do
-        voters = subject.poll_voters post_id: 5, poll_name: "poll"
+        voters = client.poll_voters post_id: 5, poll_name: "poll"
         expect(voters).to be_a Hash
         voters.each { |g| expect(g).to be_an Array }
         expect(voters["voters"]["e539a9df8700d0d05c69356a07b768cf"]).to be_an Array

data/spec/discourse_api/api/posts_spec.rb

@@ -2,9 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::Posts do
-  let (:client) {
-    DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user")
-  }
+  let(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#get_post" do
     before do

data/spec/discourse_api/api/private_messages_spec.rb

@@ -2,7 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::PrivateMessages do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#private_messages" do
     before do
@@ -15,12 +15,12 @@ describe DiscourseApi::API::PrivateMessages do
     end
 
     it "requests the correct resource" do
-      subject.private_messages("test_user")
+      client.private_messages("test_user")
       expect(a_get("#{host}/topics/private-messages/test_user.json")).to have_been_made
     end
 
     it "returns the requested private messages" do
-      private_messages = subject.private_messages("test_user")
+      private_messages = client.private_messages("test_user")
       expect(private_messages).to be_an Array
     end
   end
@@ -36,12 +36,12 @@ describe DiscourseApi::API::PrivateMessages do
     end
 
     it "requests the correct resource" do
-      subject.sent_private_messages("test_user")
+      client.sent_private_messages("test_user")
       expect(a_get("#{host}/topics/private-messages-sent/test_user.json")).to have_been_made
     end
 
     it "returns the requested sent private messages" do
-      private_messages = subject.sent_private_messages("test_user")
+      private_messages = client.sent_private_messages("test_user")
       expect(private_messages).to be_an Array
     end
   end
@@ -49,7 +49,7 @@ describe DiscourseApi::API::PrivateMessages do
   describe "#create_pm" do
     before do
       stub_post("#{host}/posts")
-      subject.create_pm(
+      client.create_pm(
         title: "Confidential: Hello World!",
         raw: "This is the raw markdown for my private message",
         target_recipients: "user1,user2",

data/spec/discourse_api/api/search_spec.rb

@@ -2,7 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::Search do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#search" do
     before do
@@ -15,22 +15,22 @@ describe DiscourseApi::API::Search do
     end
 
     it "requests the correct resource" do
-      subject.search("test")
+      client.search("test")
       expect(a_get("#{host}/search").with(query: { q: "test" })).to have_been_made
     end
 
     it "returns the requested search" do
-      results = subject.search("test")
+      results = client.search("test")
       expect(results).to be_an Array
       expect(results.first).to be_a Hash
     end
 
     it "raises an ArgumentError for nil" do
-      expect { subject.search(nil) }.to raise_error(ArgumentError)
+      expect { client.search(nil) }.to raise_error(ArgumentError)
     end
 
     it "raises an ArgumentError for empty string" do
-      expect { subject.search("") }.to raise_error(ArgumentError)
+      expect { client.search("") }.to raise_error(ArgumentError)
     end
   end
 end

data/spec/discourse_api/api/site_settings_spec.rb

@@ -2,12 +2,12 @@
 require "spec_helper"
 
 describe DiscourseApi::API::SiteSettings do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   describe "#site_setting_update" do
     before do
       stub_put("#{host}/admin/site_settings/foo")
-      subject.site_setting_update(name: "foo", value: "bar")
+      client.site_setting_update(name: "foo", value: "bar")
     end
 
     it "makes a site_settings_update request" do

data/spec/discourse_api/api/sso_spec.rb

@@ -2,7 +2,7 @@
 require "spec_helper"
 
 describe DiscourseApi::API::SSO do
-  subject { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
+  subject(:client) { DiscourseApi::Client.new("#{host}", "test_d7fd0429940", "test_user") }
 
   let(:params) do
     {
@@ -47,7 +47,7 @@ describe DiscourseApi::API::SSO do
     it "assigns params to sso instance" do
       allow(DiscourseApi::SingleSignOn).to(receive(:parse_hash).with(params).and_return(sso_double))
 
-      subject.sync_sso(params)
+      client.sync_sso(params)
 
       expect(sso_double.custom_fields).to eql(
         { "custom.field_1" => "tomato", :field_2 => "potato" },
@@ -56,7 +56,7 @@ describe DiscourseApi::API::SSO do
     end
 
     it "requests the correct resource" do
-      subject.sync_sso({ :sso_secret => "test_d7fd0429940", "custom.riffle_url" => "test" })
+      client.sync_sso({ :sso_secret => "test_d7fd0429940", "custom.riffle_url" => "test" })
       expect(a_post(/.*sync_sso.*/)).to have_been_made
     end
   end