discourse_api 0.28.0 → 0.28.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac0d5e801885cf4c2f505292d4caa47c3f7716fe19691952f140ccc8177ef86d
-  data.tar.gz: a96ae94f70262aef6334cf5aa2d2c740d33cee3235d69184dde0354173ff6134
+  metadata.gz: dfbf0f7096f27cfc80d554849976a9b061ea3915b31b74b52b81bc5642376516
+  data.tar.gz: 0bfad1c8ee9a66154f9eb0e20f5e95d04173480f40616670697d54139ca16120
 SHA512:
-  metadata.gz: 7ee9c491b8a7864ff71f71d46df767c2d6daa1c1fe8e554ce5102c9a1ea72e4a86545a470959bddaf2fb3ecf815312a4195476bc24468016ec28377fabf4073b
-  data.tar.gz: 500de1352f63b8b3d7ef0f48737e0e1720795091c6ede9f10d79786b8140787e7b176e0e2a00a18f99e9f8ef04163c1ac8de722136c4de4926a54363f3fea8df
+  metadata.gz: 67f10c18d2ec354583ac205f0d0da1897147260d2822c87c0032357686b919602b7e6d3fff9966f00e5851eff9a1d6258239d40554dca8220ee6564eb16511dd
+  data.tar.gz: cbe23cec7233b872bc9efa2f9ff50fdf1805b6033ca410f38124fea8720d48077246dd4eadec747858576a70e296403d3b7c64347ca822a6e8c33cc20a1bc92f

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.28.1] - 2018-10-26
+### Fixed
+- Fixed non-URI chars in `check_username` method
+
 ## [0.28.0] - 2018-10-23
 ### Added
 - Added `check_username` method

data/lib/discourse_api/api/users.rb

@@ -94,7 +94,7 @@ module DiscourseApi
       end
 
       def check_username(username)
-        response = get("/users/check_username.json?username=#{username}")
+        response = get("/users/check_username.json?username=#{CGI.escape(username)}")
         response[:body]
       end
     end

data/lib/discourse_api/version.rb

@@ -1,3 +1,3 @@
 module DiscourseApi
-  VERSION = "0.28.0"
+  VERSION = "0.28.1"
 end

data/spec/discourse_api/api/groups_spec.rb

@@ -78,14 +78,15 @@ describe DiscourseApi::API::Groups do
     end
 
     describe "remove members" do
+      let(:url) { "http://localhost:3000/admin/groups/123/members.json?api_key=test_d7fd0429940&api_username=test_user&usernames=sam" }
+
       before do
-        url = "http://localhost:3000/admin/groups/123/members.json?api_key=test_d7fd0429940&api_username=test_user&username=sam"
         stub_delete(url)
       end
 
       it "removes member" do
         subject.group_remove(123, username: "sam")
-        expect(a_delete("http://localhost:3000/admin/groups/123/members.json?api_key=test_d7fd0429940&api_username=test_user&username=sam")).to have_been_made
+        expect(a_delete(url)).to have_been_made
       end
     end
 

data/spec/discourse_api/api/users_spec.rb

@@ -287,9 +287,9 @@ describe DiscourseApi::API::Users do
 
   describe "#check_username" do
     let(:url) { "http://localhost:3000/users/check_username.json?username=sparrow&api_key=test_d7fd0429940&api_username=test_user" }
+    let(:body) { '{"available":false,"suggestion":"sparrow1"}' }
 
     before do
-      body = '{"available":false,"suggestion":"sparrow1"}'
       stub_get(url).to_return(body: body, headers: { content_type: "application/json" })
     end
 
@@ -302,5 +302,20 @@ describe DiscourseApi::API::Users do
       result = subject.check_username("sparrow")
       expect(result['available']).to eq false
     end
+
+    context "when non-URI characters are used" do
+      let(:url) { "http://localhost:3000/users/check_username.json?username=1_%5B4%5D%21+%40the%24%23%3F&api_key=test_d7fd0429940&api_username=test_user" }
+      let(:body) { '{"errors":["must only include numbers, letters, dashes, and underscores"]}' }
+
+      it "escapes them" do
+        subject.check_username("1_[4]! @the$#?")
+        expect(a_get(url)).to have_been_made
+      end
+
+      it "returns the result" do
+        result = subject.check_username("1_[4]! @the$#?")
+        expect(result['errors'].first).to eq "must only include numbers, letters, dashes, and underscores"
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: discourse_api
 version: !ruby/object:Gem::Version
-  version: 0.28.0
+  version: 0.28.1
 platform: ruby
 authors:
 - Sam Saffron
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-23 00:00:00.000000000 Z
+date: 2018-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday