disco_app 0.16.0 → 0.16.1.pre.sidekiq.pre.6.pre.release

data/test/dummy/db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20170606160751) do
+ActiveRecord::Schema.define(version: 2018_12_29_100327) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -24,12 +24,12 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.index ["token"], name: "index_carts_on_token", unique: true
   end
 
-  create_table "disco_app_app_settings", force: :cascade do |t|
+  create_table "disco_app_app_settings", id: :serial, force: :cascade do |t|
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false
   end
 
-  create_table "disco_app_application_charges", force: :cascade do |t|
+  create_table "disco_app_application_charges", id: :serial, force: :cascade do |t|
     t.bigint "shop_id"
     t.bigint "subscription_id"
     t.integer "status", default: 0
@@ -39,7 +39,33 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.string "confirmation_url"
   end
 
-  create_table "disco_app_plan_codes", force: :cascade do |t|
+  create_table "disco_app_flow_actions", force: :cascade do |t|
+    t.bigint "shop_id"
+    t.string "action_id"
+    t.string "action_run_id"
+    t.jsonb "properties", default: {}
+    t.integer "status", default: 0
+    t.datetime "processed_at"
+    t.jsonb "processing_errors", default: []
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.index ["action_run_id"], name: "index_disco_app_flow_actions_on_action_run_id", unique: true
+  end
+
+  create_table "disco_app_flow_triggers", force: :cascade do |t|
+    t.bigint "shop_id"
+    t.string "title"
+    t.string "resource_name"
+    t.string "resource_url"
+    t.jsonb "properties", default: {}
+    t.integer "status", default: 0
+    t.datetime "processed_at"
+    t.jsonb "processing_errors", default: []
+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+  end
+
+  create_table "disco_app_plan_codes", id: :serial, force: :cascade do |t|
     t.bigint "plan_id"
     t.string "code"
     t.integer "trial_period_days"
@@ -49,7 +75,7 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.integer "status", default: 0
   end
 
-  create_table "disco_app_plans", force: :cascade do |t|
+  create_table "disco_app_plans", id: :serial, force: :cascade do |t|
     t.integer "status", default: 0
     t.string "name"
     t.integer "plan_type", default: 0
@@ -62,7 +88,7 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.integer "interval_count", default: 1
   end
 
-  create_table "disco_app_recurring_application_charges", force: :cascade do |t|
+  create_table "disco_app_recurring_application_charges", id: :serial, force: :cascade do |t|
     t.bigint "shop_id"
     t.bigint "subscription_id"
     t.integer "status", default: 0
@@ -72,7 +98,7 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.string "confirmation_url"
   end
 
-  create_table "disco_app_sessions", force: :cascade do |t|
+  create_table "disco_app_sessions", id: :serial, force: :cascade do |t|
     t.string "session_id", null: false
     t.text "data"
     t.datetime "created_at", null: false
@@ -82,7 +108,7 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.index ["updated_at"], name: "index_disco_app_sessions_on_updated_at"
   end
 
-  create_table "disco_app_shops", force: :cascade do |t|
+  create_table "disco_app_shops", id: :serial, force: :cascade do |t|
     t.string "shopify_domain", null: false
     t.string "shopify_token", null: false
     t.datetime "created_at", null: false
@@ -95,7 +121,7 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.index ["shopify_domain"], name: "index_disco_app_shops_on_shopify_domain", unique: true
   end
 
-  create_table "disco_app_sources", force: :cascade do |t|
+  create_table "disco_app_sources", id: :serial, force: :cascade do |t|
     t.string "source"
     t.string "name"
     t.datetime "created_at", null: false
@@ -103,7 +129,7 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.index ["source"], name: "index_disco_app_sources_on_source"
   end
 
-  create_table "disco_app_subscriptions", force: :cascade do |t|
+  create_table "disco_app_subscriptions", id: :serial, force: :cascade do |t|
     t.integer "shop_id"
     t.integer "plan_id"
     t.integer "status"
@@ -121,7 +147,7 @@ ActiveRecord::Schema.define(version: 20170606160751) do
     t.index ["shop_id"], name: "index_disco_app_subscriptions_on_shop_id"
   end
 
-  create_table "disco_app_users", force: :cascade do |t|
+  create_table "disco_app_users", id: :serial, force: :cascade do |t|
     t.bigint "shop_id"
     t.string "first_name"
     t.string "last_name"
@@ -154,6 +180,8 @@ ActiveRecord::Schema.define(version: 20170606160751) do
   add_foreign_key "carts", "disco_app_shops", column: "shop_id"
   add_foreign_key "disco_app_application_charges", "disco_app_shops", column: "shop_id"
   add_foreign_key "disco_app_application_charges", "disco_app_subscriptions", column: "subscription_id"
+  add_foreign_key "disco_app_flow_actions", "disco_app_shops", column: "shop_id", on_delete: :cascade
+  add_foreign_key "disco_app_flow_triggers", "disco_app_shops", column: "shop_id", on_delete: :cascade
   add_foreign_key "disco_app_plan_codes", "disco_app_plans", column: "plan_id"
   add_foreign_key "disco_app_recurring_application_charges", "disco_app_shops", column: "shop_id"
   add_foreign_key "disco_app_recurring_application_charges", "disco_app_subscriptions", column: "subscription_id"

data/test/services/disco_app/flow/create_action_test.rb

@@ -0,0 +1,51 @@
+require 'test_helper'
+
+module DiscoApp
+  module Flow
+    class CreateActionTest < ActiveSupport::TestCase
+
+      include ActiveJob::TestHelper
+
+      def setup
+        @shop = disco_app_shops(:widget_store)
+      end
+
+      def teardown
+        @shop = nil
+      end
+
+      test 'call to create flow action creates model' do
+        result = CreateAction.call(shop: @shop, action_id: action_id, action_run_id: action_run_id, properties: properties)
+        assert result.success?
+        assert result.action.persisted?
+        assert result.action.pending?
+        assert_equal action_id, result.action.action_id
+        assert_equal action_run_id, result.action.action_run_id
+        assert_equal properties, result.action.properties
+      end
+
+      test 'call to create flow action enqueues processing job' do
+        assert_enqueued_with(job: ProcessActionJob) do
+          CreateAction.call(shop: @shop, action_id: action_id, action_run_id: action_run_id, properties: properties)
+        end
+      end
+
+      private
+
+        def action_id
+          'test_action_id'
+        end
+
+        def action_run_id
+          'bdb15e45-4f9d-4c80-88c8-7b43a24edaac-30892-cc8eb62a-14db-43fc-bc33-d6dea41ae623'
+        end
+
+        def properties
+          {
+            'customer_email' => 'name@example.com'
+          }
+        end
+
+    end
+  end
+end

data/test/services/disco_app/flow/create_trigger_test.rb

@@ -0,0 +1,56 @@
+require 'test_helper'
+
+module DiscoApp
+  module Flow
+    class CreateTriggerTest < ActiveSupport::TestCase
+
+      include ActiveJob::TestHelper
+
+      def setup
+        @shop = disco_app_shops(:widget_store)
+      end
+
+      def teardown
+        @shop = nil
+      end
+
+      test 'call to create flow trigger creates model' do
+        result = CreateTrigger.call(shop: @shop, title: title, resource_name: resource_name, resource_url: resource_url, properties: properties)
+        assert result.success?
+        assert result.trigger.persisted?
+        assert result.trigger.pending?
+        assert_equal title, result.trigger.title
+        assert_equal resource_name, result.trigger.resource_name
+        assert_equal resource_url, result.trigger.resource_url
+        assert_equal properties, result.trigger.properties
+      end
+
+      test 'call to create flow trigger enqueues processing job' do
+        assert_enqueued_with(job: ProcessTriggerJob) do
+          CreateTrigger.call(shop: @shop, title: title, resource_name: resource_name, resource_url: resource_url, properties: properties)
+        end
+      end
+
+      private
+
+        def title
+          'Test trigger'
+        end
+
+        def resource_name
+          'test_resource_name'
+        end
+
+        def resource_url
+          'https://example.com/test-resource-url'
+        end
+
+        def properties
+          {
+            'Customer email' => 'name@example.com'
+          }
+        end
+
+    end
+  end
+end

data/test/services/disco_app/flow/process_action_test.rb

@@ -0,0 +1,68 @@
+require 'test_helper'
+require 'interactor'
+
+class TestActionId
+
+  include Interactor
+
+  def call
+    # noop
+  end
+
+end
+
+module DiscoApp
+  module Flow
+    class ProcessActionTest < ActiveSupport::TestCase
+
+      include ActiveJob::TestHelper
+
+      def setup
+        @shop = disco_app_shops(:widget_store)
+        @action = @shop.flow_actions.create(
+          action_id: 'test_action_id',
+          action_run_id: 'bdb15e45-4f9d-4c80-88c8-7b43a24edaac-30892-cc8eb62a-14db-43fc-bc33-d6dea41ae623',
+          properties: { 'customer_email' => 'name@example.com' }
+        )
+        @now = Time.parse('2018-12-29T00:00:00Z')
+        Timecop.freeze(@now)
+      end
+
+      def teardown
+        @shop = nil
+        @action = nil
+        @now = nil
+        Timecop.return
+      end
+
+      test 'call to process action that has already succeeded fails' do
+        @action.succeeded!
+        result = ProcessAction.call(action: @action)
+        assert_not result.success?
+      end
+
+      test 'call to process trigger that has already failed fails' do
+        @action.failed!
+        result = ProcessAction.call(action: @action)
+        assert_not result.success?
+      end
+
+      test 'processing pending action with existing service class succeeds' do
+        result = ProcessAction.call(action: @action)
+        assert result.success?
+        assert @action.succeeded?
+        assert_equal @now, @action.processed_at
+      end
+
+      test 'processing pending action with non-existent service class does not succeed' do
+        @action.update!(action_id: 'unknown_test_action_id')
+        result = ProcessAction.call(action: @action)
+        assert_not result.success?
+        assert @action.failed?
+        assert_equal @now, @action.processed_at
+        assert_equal ['Could not find service class for unknown_test_action_id'], @action.processing_errors
+      end
+
+    end
+  end
+end

data/test/services/disco_app/flow/process_trigger_test.rb

@@ -0,0 +1,61 @@
+require 'test_helper'
+
+module DiscoApp
+  module Flow
+    class ProcessTriggerTest < ActiveSupport::TestCase
+
+      include ActiveJob::TestHelper
+
+      def setup
+        @shop = disco_app_shops(:widget_store)
+        @trigger = @shop.flow_triggers.create(
+          title: 'Test trigger',
+          resource_name: 'test_resource_name',
+          resource_url: 'https://example.com/test-resource-url',
+          properties: { 'Customer email' => 'name@example.com' }
+        )
+        @now = Time.parse('2018-12-29T00:00:00Z')
+        Timecop.freeze(@now)
+      end
+
+      def teardown
+        @shop = nil
+        @trigger = nil
+        @now = nil
+        Timecop.return
+      end
+
+      test 'call to process trigger that has already succeeded fails' do
+        @trigger.succeeded!
+        result = ProcessTrigger.call(trigger: @trigger)
+        assert_not result.success?
+      end
+
+      test 'call to process trigger that has already failed fails' do
+        @trigger.failed!
+        result = ProcessTrigger.call(trigger: @trigger)
+        assert_not result.success?
+      end
+
+      test 'processing valid pending trigger succeeds and makes the expected api call' do
+        VCR.use_cassette('flow_trigger_valid') do
+          result = ProcessTrigger.call(trigger: @trigger)
+          assert result.success?
+          assert @trigger.succeeded?
+          assert_equal @now, @trigger.processed_at
+        end
+      end
+
+      test 'processing invalid pending trigger makes the expected api call with errors logged' do
+        VCR.use_cassette('flow_trigger_invalid_title') do
+          result = ProcessTrigger.call(trigger: @trigger)
+          assert_not result.success?
+          assert @trigger.failed?
+          assert_equal @now, @trigger.processed_at
+          assert_equal 1, @trigger.processing_errors.size
+        end
+      end
+
+    end
+  end
+end

data/test/vcr/flow_trigger_invalid_title.yml

@@ -0,0 +1,35 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://widgets.myshopify.com/admin/api/graphql.json
+    body:
+      encoding: UTF-8
+      string: '{"query":"\n        mutation {\n          flowTriggerReceive(body: \"{\\\"trigger_title\\\":\\\"Test trigger\\\",\\\"resources\\\":[{\\\"name\\\":\\\"test_resource_name\\\",\\\"url\\\":\\\"https://example.com/test-resource-url\\\"}],\\\"properties\\\":{\\\"Customer email\\\":\\\"name@example.com\\\"}}\") {\n            userErrors {\n              field,\n              message\n            }\n          }\n        }\n      "}'
+    headers:
+      Accept:
+      - "*/*"
+      Accept-Encoding:
+      - gzip, deflate
+      Content-Type:
+      - application/json
+      X-Shopify-Access-Token:
+      - 00000000000000000000000000000000
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Sat, 29 Dec 2018 11:44:11 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+    body:
+      encoding: ASCII-8BIT
+      string: '{"data":{"flowTriggerReceive":{"userErrors":[{"field":["body"],"message":"Errors
+        validating schema:\n  Invalid trigger_title ''Test trigger''.\n"}]}},"extensions":{"cost":{"requestedQueryCost":1,"actualQueryCost":1,"throttleStatus":{"maximumAvailable":2000.0,"currentlyAvailable":1999,"restoreRate":100.0}}}}'
+    http_version:
+  recorded_at: Sat, 29 Dec 2018 11:44:11 GMT
+recorded_with: VCR 3.0.3

data/test/vcr/flow_trigger_valid.yml

@@ -0,0 +1,38 @@
+---
+http_interactions:
+- request:
+    method: post
+    uri: https://widgets.myshopify.com/admin/api/graphql.json
+    body:
+      encoding: UTF-8
+      string: '{"query":"\n        mutation {\n          flowTriggerReceive(body: \"{\\\"trigger_title\\\":\\\"Test trigger\\\",\\\"resources\\\":[{\\\"name\\\":\\\"test_resource_name\\\",\\\"url\\\":\\\"https://example.com/test-resource-url\\\"}],\\\"properties\\\":{\\\"Customer email\\\":\\\"name@example.com\\\"}}\") {\n            userErrors {\n              field,\n              message\n            }\n          }\n        }\n      "}'
+    headers:
+      Accept:
+      - "*/*"
+      Accept-Encoding:
+      - gzip, deflate
+      Content-Type:
+      - application/json
+      X-Shopify-Access-Token:
+      - 00000000000000000000000000000000
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Server:
+      - nginx
+      Date:
+      - Sat, 29 Dec 2018 11:46:27 GMT
+      Content-Type:
+      - application/json; charset=utf-8
+      Transfer-Encoding:
+      - chunked
+      Connection:
+      - keep-alive
+    body:
+      encoding: ASCII-8BIT
+      string: '{"data":{"flowTriggerReceive":{"userErrors":[]}},"extensions":{"cost":{"requestedQueryCost":1,"actualQueryCost":1,"throttleStatus":{"maximumAvailable":2000.0,"currentlyAvailable":1999,"restoreRate":100.0}}}}'
+    http_version:
+  recorded_at: Sat, 29 Dec 2018 11:46:27 GMT
+recorded_with: VCR 3.0.3