dirty_seed 0.2.0 → 0.2.1

data/spec/lib/dirty_seed/data_model_spec.rb

@@ -10,11 +10,13 @@ RSpec.describe DirtySeed::DataModel do
       end
 
       context 'when logger is "verbose"' do
-        it 'logs data' do
-          DirtySeed::Logger.instance.verbose!
-          expect { described_class.instance.seed(1) }.to output(/Alfa/).to_stdout
-          expect { described_class.instance.seed(2) }.to output(/seeded: 2/).to_stdout
-          expect { described_class.instance.seed(1) }.to output(/(errors:)(.*)(string should be specific)/).to_stdout
+        it 'logs seeded records count' do
+          expect { described_class.instance.seed(2, verbose: true) }.to output(/seeded: 2/).to_stdout
+        end
+
+        it 'logs unique errors' do
+          expect { described_class.instance.seed(1, verbose: true) }
+            .to output(/(errors:)(.*)(string should be specific)/).to_stdout
         end
       end
     end

data/spec/lib/dirty_seed/seeder_spec.rb

@@ -13,26 +13,25 @@ RSpec.describe DirtySeed::Seeder do
   end
 
   describe '#seed(count)' do
-    it 'tries to create x instances of the model' do
+    it 'tries to create x records of the model' do
       expect { described_class.new(DirtySeed::Model.new(Bravo)).seed(3) }.to change(Bravo, :count).by(3)
     end
 
-    it 'stores the number of successfully seeded instances' do
+    it 'stores the number of successfully seeded records' do
       seeder = described_class.new(alfa)
       seeder.seed(3)
-      expect(seeder.instances.count).to eq 3
+      expect(seeder.records.count).to eq 3
     end
 
-    it 'stores the errors' do
-      Alfa.create
-      seeder = described_class.new(DirtySeed::Model.new(Juliett))
-      seeder.seed(3)
-      expect(seeder.errors).to include('Alfa should be specific')
-      expect(seeder.errors).to include('A string should be specific')
-      expect(seeder.errors).to include('An integer should be specific')
+    context 'when it raises ActiveRecord::RecordInvalid error' do
+      it 'stores the error' do
+        seeder = described_class.new(DirtySeed::Model.new(Juliett))
+        seeder.seed(1)
+        expect(seeder.errors).to include('A string should be specific')
+      end
     end
 
-    context 'when the application throws error' do
+    context 'when it raises another StandardError' do
       let(:seeder) { described_class.new(alfa) }
 
       context 'when it happens on initialize' do
@@ -42,14 +41,16 @@ RSpec.describe DirtySeed::Seeder do
           allow(seeder).to receive(:params_collection).and_return([{ a_string: bad_string }])
         end
 
-        it 'rescues from error' do
+        it 'rescues from StandardError' do
           expect { Alfa.new(a_string: bad_string) }.to raise_error StandardError
           expect { seeder.seed(1) }.not_to raise_error
         end
 
-        it 'adds error to the errors list' do
-          seeder.seed(1)
-          expect(seeder.errors).to include('StandardError')
+        it 'cleans and adds error message to the errors list' do
+          seeder.seed(10)
+          expect(seeder.errors.count).to eq 1
+          expect(seeder.errors.first.length).to be <= 200
+          expect(seeder.errors.first).not_to include("\n")
         end
       end
 
@@ -60,14 +61,16 @@ RSpec.describe DirtySeed::Seeder do
           allow(seeder).to receive(:params_collection).and_return([{ a_string: bad_string }])
         end
 
-        it 'rescues from error' do
+        it 'rescues from StandardError' do
           expect { Alfa.create(a_string: bad_string) }.to raise_error StandardError
           expect { seeder.seed(1) }.not_to raise_error
         end
 
-        it 'adds error to the errors list' do
-          seeder.seed(1)
-          expect(seeder.errors).to include('StandardError')
+        it 'cleans and adds error message to the errors list' do
+          seeder.seed(10)
+          expect(seeder.errors.count).to eq 1
+          expect(seeder.errors.first.length).to be <= 200
+          expect(seeder.errors.first).not_to include("\n")
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dirty_seed
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Edouard Piron
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-11-27 00:00:00.000000000 Z
+date: 2020-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faker