directlink 0.0.9.1 → 0.0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '08e29b8a3032310a9443ca5f2bc001c449722aa8'
-  data.tar.gz: 15ee2b72e8ea566e2250a0311afe530a5b9dbd36
+  metadata.gz: f745bed3faf2b74dfe4532357fbb772fe32598b1
+  data.tar.gz: 203127452f8e51be364fff16a4c1eafa8a0a21df
 SHA512:
-  metadata.gz: b30d00607103ed669f5876b9360b8280e24a6ba66c06117f577e47b497eb1ed76eee953bf0cfc97a2525dffc7c0f1169377cbcb780d7d2c9c1a1d74e9aaec212
-  data.tar.gz: 36a8ecce05a750e1b5aea43929037d67c38f4dcc0df8d022739aa7508a01d51d573e3f39f0ebbca14fca2dbb90d29eb2be6ae74949b77e1e735da7c2be16ac04
+  metadata.gz: 75bd9d5351c48c4f1df45b76f4835abc52bd057eabd01f4615a2056c16f4f9cf57546c3ff7123f479836206d1bb3164a740bebd2d81b84899b5507ee74d0e178
+  data.tar.gz: 6e20c47d7270b6bf3b0920ea964337b5143e255eb789baac70823218c9b689b13a6b16abdc729a3c134a2b5cf48fccfa074ec64bebac6ed835a32764b8f5726c

data/bin/directlink

@@ -68,16 +68,7 @@ begin
       (t.is_a?(Array) ? t : [t]).each{ |s| puts "=> #{s.url}\n   #{s.type} #{s.width}x#{s.height}" }
     end
   end
-rescue SocketError,
-       Net::OpenTimeout,
-       Errno::ECONNRESET,
-       NetHTTPUtils::Error,
-       FastImage::UnknownImageType,
-       FastImage::ImageFetchFailure,
-       # DirectLink::ErrorMissingEnvVar,
-       # DirectLink::ErrorAssert,
-       DirectLink::ErrorNotFound,
-       DirectLink::ErrorBadLink => e
+rescue *DirectLink::NORMAL_EXCEPTIONS => e
   puts e.backtrace if debug
   cause = e.cause if e.cause if e.respond_to? :cause
   c = e.class.to_s

data/directlink.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |spec|
   spec.name         = "directlink"
-  spec.version      = "0.0.9.1"
-  spec.summary      = "converts any kind of image hyperlink to direct link, type of image and its resolution"
+  spec.version      = "0.0.9.2"
+  spec.summary      = "obtains from any kind of hyperlink a link to an image, its format and resolution"
 
   spec.author       = "Victor Maslov aka Nakilon"
   spec.email        = "nakilon@gmail.com"
@@ -11,19 +11,18 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "fastimage", "~>2.1.3"
   spec.add_dependency "nokogiri"
-  spec.add_dependency "nethttputils", "~>0.4.0.0"
-  spec.add_dependency "reddit_bot", "~>1.7.0"
+  spec.add_dependency "nethttputils", "~>0.4.1.0"
+  spec.add_dependency "reddit_bot", "~>1.7.8"
   spec.add_dependency "kramdown"
   spec.add_dependency "addressable"
   spec.add_development_dependency "minitest"
-  spec.add_development_dependency "byebug"
 
   spec.require_path = "lib"
   spec.bindir       = "bin"
   spec.executable   = "directlink"
   spec.test_file    = "test.rb"
-  spec.files        = `git ls-files -z`.split(?\0) - spec.test_files
+  spec.files        = %w{ LICENSE directlink.gemspec lib/directlink.rb bin/directlink }
 
-  spec.requirements << "you may need to create apps and provide their API tokens:"
+  spec.requirements << "you may want to create apps and provide API tokens:"
   spec.requirements << "IMGUR_CLIENT_ID, FLICKR_API_KEY, REDDIT_SECRETS"
 end

data/lib/directlink.rb

@@ -2,11 +2,10 @@ module DirectLink
 
   class << self
     attr_accessor :silent
-  end
-  self.silent = false
-  class << self
     attr_accessor :logger
+    attr_accessor :timeout
   end
+  self.silent = false
   self.logger = Object.new
   self.logger.define_singleton_method :error do |str|
     puts str unless Module.nesting.first.silent
@@ -35,6 +34,20 @@ module DirectLink
     end
   end
 
+  require "nethttputils"
+  require "fastimage"
+  NORMAL_EXCEPTIONS = [
+    SocketError,
+    Net::OpenTimeout,
+    Errno::ECONNRESET,
+    NetHTTPUtils::Error,
+    NetHTTPUtils::EOFError_from_rbuf_fill,
+    FastImage::UnknownImageType,
+    FastImage::ImageFetchFailure,
+    DirectLink::ErrorNotFound,
+    DirectLink::ErrorBadLink,
+  ]  # the only exceptions gem user should expect and handle
+
 
   def self.google src, width = 0
     # this can handle links without schema because it's used for parsing community HTML pages
@@ -76,10 +89,9 @@ module DirectLink
   end
 
   require "json"
-  require "nethttputils"
 
   # TODO make the timeout handling respect the way the Directlink method works with timeouts
-  def self.imgur link, timeout = 1000
+  def self.imgur link, timeout = 2000
     raise ErrorMissingEnvVar.new "define IMGUR_CLIENT_ID env var" unless ENV["IMGUR_CLIENT_ID"]
 
     request_data = lambda do |url|
@@ -107,16 +119,16 @@ module DirectLink
       elsif data["images"]
         raise ErrorNotFound.new link.inspect if data["images"].empty?
         data["images"]
-      elsif data["type"] && data["type"].start_with?("image/")
+      elsif data["type"] && %w{ image/jpeg image/png image/gif video/mp4 }.include?(data["type"])
         # TODO check if this branch is possible at all
         [ data ]
       # elsif data["comment"]
       #   fi["https://imgur.com/" + data["image_id"]]
       else
         # one day single-video item should hit this but somehow it didn't yet
-        raise ErrorAssert.new "unknown data format #{data.inspect} for #{link}"
+        raise ErrorAssert.new "unknown data format #{json} for #{link}"
       end
-    when /\Ahttps?:\/\/(?:(?:i|m|www)\.)?imgur\.com\/([a-zA-Z0-9]{7,8})(?:\.(?:gifv|jpg(?:\?fb)?|png))?\z/,
+    when /\Ahttps?:\/\/(?:(?:i|m|www)\.)?imgur\.com\/([a-zA-Z0-9]{7,8})(?:\.(?:gifv|jpe?g(?:\?fb)?|png))?\z/,
          /\Ahttps?:\/\/(?:(?:i|m|www)\.)?imgur\.com\/([a-zA-Z0-9]{5})\.mp4\z/,
          /\Ahttps?:\/\/imgur\.com\/([a-zA-Z0-9]{5}(?:[a-zA-Z0-9]{2})?)\z/,
          /\Ahttps?:\/\/imgur\.com\/([a-zA-Z0-9]{7})(?:\?\S+)?\z/,
@@ -128,7 +140,7 @@ module DirectLink
       raise ErrorBadLink.new link
     end.map do |image|
       case image["type"]
-      when "image/jpeg", "image/png", "image/gif", "video/mp4"
+      when *%w{ image/jpeg image/png image/gif video/mp4 }
         image.values_at "link", "width", "height", "type"
       else
         raise ErrorAssert.new "unknown type of #{link}: #{image}"
@@ -191,11 +203,11 @@ module DirectLink
     attr_accessor :reddit_bot
   end
   def self.reddit link, timeout = 1000
-    unless id = URI(link).path[/\A(?:\/r\/[0-9a-zA-Z_]+)?(?:\/comments|\/duplicates)?\/([0-9a-z]{5,6})(?:\/|\z)/, 1]
-      raise DirectLink::ErrorBadLink.new link unless URI(link).host &&
-                                                     URI(link).host.split(?.) == %w{ i redd it } &&
-                                                     URI(link).path[/\A\/[a-z0-9]{12,13}\.(gif|jpg)\z/]
-      return [true, link]
+    return [true, link] if URI(link).host &&
+                           URI(link).host.split(?.) == %w{ i redd it } &&
+                           URI(link).path[/\A\/[a-z0-9]{12,13}\.(gif|jpg)\z/]
+    unless id = link[/\Ahttps:\/\/www\.reddit\.com\/gallery\/([0-9a-z]{5,6})\z/, 1]
+      raise DirectLink::ErrorBadLink.new link unless id = URI(link).path[/\A(?:\/r\/[0-9a-zA-Z_]+)?(?:\/comments|\/duplicates)?\/([0-9a-z]{5,6})(?:\/|\z)/, 1]
     end
     retry_on_json_parseerror = lambda do |&b|
       t = 1
@@ -223,16 +235,17 @@ module DirectLink
     end
     # TODO: do we handle linking Imgur albums?
     data = json["data"]["children"].first["data"]
-    if data["media"]["reddit_video"]
-      return [true, data["media"]["reddit_video"]["fallback_url"]]
-    else
+    if data["media"]
+      return [true, data["media"]["reddit_video"]["fallback_url"]] if data["media"]["reddit_video"]
       raise ErrorAssert.new "our knowledge about Reddit API seems to be outdated" unless data["media"].keys.sort == %w{ oembed type } && %w{ youtube.com gfycat.com imgur.com }.include?(data["media"]["type"])
       return [true, data["media"]["oembed"]["thumbnail_url"]]
-    end if data["media"]
+    end
     return [true, data["media_metadata"].values.map do |media|
-      [media["m"], *media["p"].max_by{ |_| _["x"] * _["y"] }.values_at("x", "y", "u")]
-    end] if data["media_metadata"]
-    return [true, data["url"]] if data["crosspost_parent"]
+      next if media == {"status"=>"failed"}
+      raise ErrorAssert.new "our knowledge about Reddit API seems to be outdated" unless media["status"] == "valid"
+      [media["m"], *media["s"].values_at("x", "y"), CGI.unescapeHTML(media["s"]["u"])]
+    end.compact] if data["media_metadata"]
+    return [true, "#{"https://www.reddit.com" if /\A\/r\/[0-9a-zA-Z_]+\/comments\/[0-9a-z]{5,6}\// =~ data["url"]}#{data["url"]}"] if data["crosspost_parent"]
     return [true, data["url"]] unless data["is_self"]
     raise ErrorAssert.new "our knowledge about Reddit API seems to be outdated" if data["url"] != "https://www.reddit.com" + data["permalink"]
     return [false, data["selftext"]]
@@ -242,7 +255,7 @@ module DirectLink
     id, mtd, field, f = case link
     when %r{\Ahttps://vk\.com/id(?<user_id>\d+)\?z=photo(?<id>\k<user_id>_\d+)(%2F(album\k<user_id>_0|photos\k<user_id>))?\z},
          %r{\Ahttps://vk\.com/[a-z_]+\?z=photo(?<_>)(?<id>(?<user_id>\d+)_\d+)%2Fphotos\k<user_id>\z},
-         %r{\Ahttps://vk\.com/photo(?<_>)(?<id>-?\d+_\d+)(\?all=1)?\z},
+         %r{\Ahttps://vk\.com/photo(?<_>)(?<id>-?\d+_\d+)(\?(?:all|rev)=1)?\z},
          %r{\Ahttps://vk\.com/feed\?section=likes&z=photo(?<_>)(?<id>-(?<user_id>\d+)_\d+)%2F(liked\d+|album\k<user_id>_0)\z},
          %r{\Ahttps://vk\.com/[a-z_]+\?z=photo(?<_>)(?<id>(?<user_id>-\d+)_\d+)%2F(wall\k<user_id>_\d+|album\k<user_id>_0)\z},
          %r{\Ahttps://vk\.com/wall(?<user_id>-\d+)_\d+\?z=photo(?<id>\k<user_id>_\d+)%2F(wall\k<user_id>_\d+|album\k<user_id>_00%2Frev|\d+)\z}
@@ -286,9 +299,8 @@ module DirectLink
 end
 
 
-require "fastimage"
-
-def DirectLink link, timeout = nil, giveup: false, ignore_meta: false
+def DirectLink link, timeout = nil, proxy = nil, giveup: false, ignore_meta: false
+  timeout ||= DirectLink.timeout
   ArgumentError.new("link should be a <String>, not <#{link.class}>") unless link.is_a? String
   begin
     URI link
@@ -326,7 +338,7 @@ def DirectLink link, timeout = nil, giveup: false, ignore_meta: false
       **( %w{ reddit com } == URI(link).host.split(?.).last(2) ||
           %w{   redd it  } == URI(link).host.split(?.) ? {Cookie: "over18=1"} : {} ),
     }
-    head = NetHTTPUtils.request_data link, :head, header: header, **(timeout ? {
+    head = NetHTTPUtils.request_data link, :HEAD, header: header, **(proxy ? {proxy: proxy} : {}), **(timeout ? {
       timeout: timeout,
       max_start_http_retry_delay: timeout,
       max_read_retry_delay: timeout
@@ -383,7 +395,7 @@ def DirectLink link, timeout = nil, giveup: false, ignore_meta: false
       f = ->_{ _.type == :a ? _.attr["href"] : _.children.flat_map(&f) }
       require "kramdown"
       return f[Kramdown::Document.new(u).root].flat_map do |sublink|
-        DirectLink URI.join(link, sublink).to_s, timeout, giveup: giveup
+        DirectLink URI.join(link, sublink).to_s, timeout, giveup: giveup   # TODO: maybe subtract from timeout the time we've already wasted
       end
     end
     if u.is_a? Hash
@@ -393,8 +405,8 @@ def DirectLink link, timeout = nil, giveup: false, ignore_meta: false
         struct.new u, x, y, t
       end
     end
-    return DirectLink u
-    fail if link == u
+    raise DirectLink::ErrorNotFound.new link.inspect if link == u
+    return DirectLink u, timeout, giveup: giveup
   rescue DirectLink::ErrorMissingEnvVar
   end if %w{ reddit com } == URI(link).host.split(?.).last(2) ||
          %w{   redd it  } == URI(link).host.split(?.)
@@ -407,11 +419,15 @@ def DirectLink link, timeout = nil, giveup: false, ignore_meta: false
   end if %w{ vk com } == URI(link).host.split(?.)
 
   begin
-    f = FastImage.new(link, raise_on_failure: true, timeout: 5, http_header: {"User-Agent" => "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36"})
+    f = FastImage.new link,
+      raise_on_failure: true,
+      timeout: timeout,
+      **(proxy ? {proxy: "http://#{proxy}"} : {}),
+      http_header: {"User-Agent" => "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36"}
   rescue FastImage::UnknownImageType
     raise if giveup
     require "nokogiri"
-    head = NetHTTPUtils.request_data link, :head, header: {"User-Agent" => "Mozilla"},
+    head = NetHTTPUtils.request_data link, :HEAD, header: {"User-Agent" => "Mozilla"},
       max_start_http_retry_delay: timeout,
       timeout: timeout,                 # NetHTTPUtild passes this as read_timeout to Net::HTTP.start
       max_read_retry_delay: timeout     # and then compares accumulated delay to this
@@ -423,7 +439,7 @@ def DirectLink link, timeout = nil, giveup: false, ignore_meta: false
     html = Nokogiri::HTML NetHTTPUtils.request_data link, header: {"User-Agent" => "Mozilla"}
     if t = html.at_css("meta[@property='og:image']")
       begin
-        return DirectLink URI.join(link, t[:content]).to_s, nil, giveup: true
+        return DirectLink URI.join(link, t[:content]).to_s, nil, *proxy, giveup: true
       rescue URI::InvalidURIError
       end
     end unless ignore_meta

data/test.rb

@@ -13,6 +13,8 @@ fail unless ENV.include? "REDDIT_SECRETS"
 
 require_relative "lib/directlink"
 DirectLink.silent = true
+DirectLink.timeout = 30   # TODO: tests about this attribute
+
 describe DirectLink do
 
   describe "./lib" do
@@ -329,9 +331,11 @@ describe DirectLink do
         ["https://imgur.com/9yaMdJq", "https://i.imgur.com/9yaMdJq.mp4", 720, 404, "video/mp4"],
         ["http://imgur.com/gallery/dCQprEq/new", "https://i.imgur.com/dCQprEq.jpg", 5760, 3840, "image/jpeg"],
         ["https://i.imgur.com/fFUTSJu.jpg?fb", "https://i.imgur.com/fFUTSJu.jpg", 1469, 2200, "image/jpeg"],    # from reddit.com/93mtba
+        ["https://i.imgur.com/IxUrhGX.jpeg", "https://i.imgur.com/IxUrhGX.jpg", 4384, 3012, "image/jpeg"],  # jpEg
+        ["https://imgur.com/gallery/9f2s9EE", "https://i.imgur.com/9f2s9EE.mp4", 960, 1438, "video/mp4"],  # mp4
       ].each_with_index do |t, i|
         url, n, first, last, type = t
-        it "##{i + 1}" do
+        it "kinds of post ##{i + 1}" do
           case last
           when NilClass
             if n.is_a? Class
@@ -377,7 +381,7 @@ describe DirectLink do
         ["https://www.flickr.com/photos/130019700@N03/18848891351/in/dateposted-public/", [4621, 3081, "https://live.staticflickr.com/3796/18848891351_f751b35aeb_o.jpg"]],      # userid   in-public
         ["https://www.flickr.com/photos/frank3/3778768209/in/photolist-6KVb92-eCDTCr-ur8K-7qbL5z-c71afh-c6YvXW-7mHG2L-c71ak9-c71aTq-c71azf-c71aq5-ur8Q-6F6YkR-eCDZsD-eCEakg-eCE6DK-4ymYku-7ubEt-51rUuc-buujQE-ur8x-9fuNu7-6uVeiK-qrmcC6-ur8D-eCEbei-eCDY9P-eCEhCk-eCE5a2-eCH457-eCHrcq-eCEdZ4-eCH6Sd-c71b5o-c71auE-eCHa8m-eCDSbz-eCH1dC-eCEg3v-7JZ4rh-9KwxYL-6KV9yR-9tUSbU-p4UKp7-eCHfwS-6KVbAH-5FrdbP-eeQ39v-eeQ1UR-4jHAGN", [4096, 2723, "https://live.staticflickr.com/2499/3778768209_dfa75a41cc_4k.jpg"]],
         ["https://www.flickr.com/photos/patricksloan/18230541413/sizes/l", [2048, 491, "https://live.staticflickr.com/5572/18230541413_fec4783d79_k.jpg"]],
-        ["https://flic.kr/p/vPvCWJ", [2048, 1365, "https://live.staticflickr.com/507/19572004110_d44d1b4ead_k.jpg"]],
+        ["https://flic.kr/p/vPvCWJ", [5120, 3413, "https://live.staticflickr.com/507/19572004110_1bd49c5ebd_5k.jpg"]],
       ] ],
       [ :wiki, [
         ["https://en.wikipedia.org/wiki/Prostitution_by_country#/media/File:Prostitution_laws_of_the_world.PNG", "https://upload.wikimedia.org/wikipedia/commons/e/e8/Prostitution_laws_of_the_world.PNG"],
@@ -396,26 +400,18 @@ describe DirectLink do
         ["http://redd.it/988889", [true, "https://i.redd.it/3h5xls6ehrg11.jpg"]],
         ["https://www.reddit.com/r/CatsStandingUp/duplicates/abn0ua/cat/", [true, "https://v.redd.it/s9b86afb6w721/DASH_2_4_M?source=fallback"]],
         ["https://www.reddit.com/r/hangers/comments/97you5/tara_radovic/", [true, "https://i.imgur.com/rbLqgOu.jpg"]],   # "crossport" from Imgur
-      ] ],
-      [ :vk, [
-        ["https://vk.com/wall-105984091_7806", [[960, 1280, "https://sun9-41.userapi.com/c855224/v855224900/a72f1/7OZ8ux9Wcwo.jpg"]]],
-        ["https://vk.com/wall298742340_4715", [[1080, 1080, "https://sun9-24.userapi.com/c857136/v857136625/15e38b/CsCqsJD174A.jpg"]]],
-        ["https://vk.com/id57030827?z=photo57030827_456241143%2Falbum57030827_0", [[1920, 1440, "https://sun9-66.userapi.com/c845322/v845322944/167836/bP9z41BybhI.jpg"]]],
-        ["https://vk.com/id57030827?z=photo57030827_456241143", [[1920, 1440, "https://sun9-66.userapi.com/c845322/v845322944/167836/bP9z41BybhI.jpg"]]],
-        ["https://vk.com/wall-185182611_454?z=photo-185182611_457239340%2Fwall-185182611_454", [[1280, 960, "https://sun9-46.userapi.com/c851028/v851028578/1a62f6/VB4SdR1O6Tg.jpg"]]],
-        ["https://vk.com/wall-105984091_7946?z=photo-105984091_457243312%2Falbum-105984091_00%2Frev", [[1280, 875, "https://sun9-37.userapi.com/c852020/v852020134/1b6b36/0IsDFb-Hda4.jpg"]]],
-        ["https://vk.com/photo533531776_456239427?all=1", [[750, 938, "https://sun9-25.userapi.com/c849416/v849416600/14b949/V01Ch1gYjhc.jpg"]]],
-        ["https://vk.com/photo-155488973_456242404", [[1486, 1000, "https://sun9-7.userapi.com/c852132/v852132877/8578e/m6AJWiskiKE.jpg"]]],
-        ["https://vk.com/id2272074?z=photo2272074_264578776%2Fphotos2272074", [[604, 484, "https://sun9-10.userapi.com/c10472/u2272074/-7/x_407b2ba2.jpg"]]],
-        ["https://vk.com/feed?section=likes&z=photo-117564754_456261460%2Fliked3902406", [[1024, 1335, "https://sun9-72.userapi.com/c854028/v854028353/895b6/izQJresLdf0.jpg"]]],
-        ["https://vk.com/likizimy?z=photo-42543351_456239941%2Fwall-42543351_1908", [[1179, 1731, "https://sun9-47.userapi.com/c855036/v855036571/60f7b/ryCPJIMyMkI.jpg"]]],
-        ["https://vk.com/e_rod?z=photo298742340_457247118%2Fphotos298742340", [[1728, 2160, "https://sun9-53.userapi.com/c858320/v858320596/c7714/oImGe4o1ZJI.jpg"]]],
+        ["https://www.reddit.com/gallery/i1u6rb", [true, [["image/jpg", 1440, 1440, "https://preview.redd.it/x31msdj6vee51.jpg?width=1440&format=pjpg&auto=webp&s=b79952f8364bb98692d978944347f19e28774d1b"], ["image/jpg", 2441, 2441, "https://preview.redd.it/mwkzq6j6vee51.jpg?width=2441&format=pjpg&auto=webp&s=455e669356550351e6b8768d8009de616c11142a"], ["image/jpg", 1440, 1440, "https://preview.redd.it/0ws1j8j6vee51.jpg?width=1440&format=pjpg&auto=webp&s=061582da8478e7601a7ce7a97fa1663852873726"], ["image/jpg", 1440, 1440, "https://preview.redd.it/2un68aj6vee51.jpg?width=1440&format=pjpg&auto=webp&s=a980f0e5814c2360f5d7a0fb12f391e304942c06"], ["image/jpg", 3024, 3780, "https://preview.redd.it/5bsfaej6vee51.jpg?width=3024&format=pjpg&auto=webp&s=9b96b4b7262eebacc7571a9f0ad902e2034bf990"], ["image/jpg", 1440, 1440, "https://preview.redd.it/0z010ej6vee51.jpg?width=1440&format=pjpg&auto=webp&s=f0c29be6ec98b835a482c7584cca43fd16217bc8"], ["image/jpg", 1440, 1440, "https://preview.redd.it/aylm2ej6vee51.jpg?width=1440&format=pjpg&auto=webp&s=39cf471b14020a1f137bc9bbb294bf5489cab3e7"]]]],   # TODO: find smaller gallery
+        ["https://www.reddit.com/i1u6rb",         [true, [["image/jpg", 1440, 1440, "https://preview.redd.it/x31msdj6vee51.jpg?width=1440&format=pjpg&auto=webp&s=b79952f8364bb98692d978944347f19e28774d1b"], ["image/jpg", 2441, 2441, "https://preview.redd.it/mwkzq6j6vee51.jpg?width=2441&format=pjpg&auto=webp&s=455e669356550351e6b8768d8009de616c11142a"], ["image/jpg", 1440, 1440, "https://preview.redd.it/0ws1j8j6vee51.jpg?width=1440&format=pjpg&auto=webp&s=061582da8478e7601a7ce7a97fa1663852873726"], ["image/jpg", 1440, 1440, "https://preview.redd.it/2un68aj6vee51.jpg?width=1440&format=pjpg&auto=webp&s=a980f0e5814c2360f5d7a0fb12f391e304942c06"], ["image/jpg", 3024, 3780, "https://preview.redd.it/5bsfaej6vee51.jpg?width=3024&format=pjpg&auto=webp&s=9b96b4b7262eebacc7571a9f0ad902e2034bf990"], ["image/jpg", 1440, 1440, "https://preview.redd.it/0z010ej6vee51.jpg?width=1440&format=pjpg&auto=webp&s=f0c29be6ec98b835a482c7584cca43fd16217bc8"], ["image/jpg", 1440, 1440, "https://preview.redd.it/aylm2ej6vee51.jpg?width=1440&format=pjpg&auto=webp&s=39cf471b14020a1f137bc9bbb294bf5489cab3e7"]]]],   # TODO: find smaller gallery
+        ["https://www.reddit.com/gallery/i3y7pc", [true, "https://www.reddit.com/gallery/i3y7pc"]],   # deleted gallery
+        ["https://www.reddit.com/ik6c6a", [true, "https://www.reddit.com/r/Firewatch/comments/ik6brf/new_wallpaper_for_my_triple_monitor_setup/"]],   # deleted gallery
+        ["https://www.reddit.com/kbjdwc", [true, [["image/jpg", 500, 500, "https://preview.redd.it/71t8ljeexo461.jpg?width=500&format=pjpg&auto=webp&s=df211fe0699e3970681ffe493ed1af79725857e8"], ["image/jpg", 720, 446, "https://preview.redd.it/c11nt7hexo461.jpg?width=720&format=pjpg&auto=webp&s=5e34ab0e6d54c0acfdb47f1daaf283087c5ad6a6"], ["image/jpg", 713, 588, "https://preview.redd.it/67mqvllexo461.jpg?width=713&format=pjpg&auto=webp&s=969dfb52bedd6f0055249aa8b7454b23adaa946e"]]]],   # failed media
+        # TODO: empty result? https://redd.it/9hhtsq
       ] ],
     ].each do |method, tests|
-      next if method == :vk && ENV.include?("TRAVIS")
-      describe method do
+      next if method == :vk && ENV.include?("CI")
+      describe "kinds of links #{method}" do
         tests.each_with_index do |(input, expectation), i|
-          it "#{method} ##{i + 1}" do
+          it "##{i + 1}" do
             if expectation.is_a? Class
               assert_raises expectation, input do
                 DirectLink.method(method).call input
@@ -429,6 +425,37 @@ describe DirectLink do
       end
     end
 
+    describe "kinds of links vk" do
+      next if ENV.include? "CI"
+      [
+        ["https://vk.com/wall-105984091_7806", [960, 1280, "https://userapi.com/impf/c855224/v855224900/a72f1/7OZ8ux9Wcwo.jpg"]],
+        # ["https://vk.com/wall298742340_4715", [1080, 1080, "https://userapi.com/impf/c857136/v857136625/15e38b/CsCqsJD174A.jpg"]],  # TODO: it's now 404
+        ["https://vk.com/wall-185182611_454?z=photo-185182611_457239340%2Fwall-185182611_454", [1280, 960, "https://userapi.com/impf/c851028/v851028578/1a62f6/VB4SdR1O6Tg.jpg"]],
+        ["https://vk.com/wall-105984091_7946?z=photo-105984091_457243312%2Falbum-105984091_00%2Frev", [1280, 875, "https://userapi.com/impf/c852020/v852020134/1b6b36/0IsDFb-Hda4.jpg"]],
+        ["https://vk.com/id57030827?z=photo57030827_456241143%2Falbum57030827_0", [1920, 1440, "https://userapi.com/impf/c845322/v845322944/167836/bP9z41BybhI.jpg"]],
+        ["https://vk.com/id57030827?z=photo57030827_456241143", [1920, 1440, "https://userapi.com/impf/c845322/v845322944/167836/bP9z41BybhI.jpg"]],
+        ["https://vk.com/photo1_215187843?all=1", [2560, 1913, "https://userapi.com/impf/c210/v210001/6/53_VwoACy4I.jpg"]],
+        ["https://vk.com/photo298742340_456243948?rev=1", [1583, 1080, "https://userapi.com/impf/c852224/v852224479/321be/9rZaJ2QTdz4.jpg"]],
+        ["https://vk.com/photo-155488973_456242404", [1486, 1000, "https://userapi.com/impf/c852132/v852132877/8578e/m6AJWiskiKE.jpg"]],
+        # ["https://vk.com/id2272074?z=photo2272074_264578776%2Fphotos2272074", [604, 484, "https://userapi.com/impf/c10472/u2272074/-7/x_407b2ba2.jpg"]],  # TODO: it's now 404
+        ["https://vk.com/feed?section=likes&z=photo-117564754_456261460%2Fliked3902406", [1024, 1335, "https://userapi.com/impf/c854028/v854028353/895b6/izQJresLdf0.jpg"]],
+        ["https://vk.com/likizimy?z=photo-42543351_456239941%2Fwall-42543351_1908", [1179, 1731, "https://userapi.com/impf/c855036/v855036571/60f7b/ryCPJIMyMkI.jpg"]],
+        ["https://vk.com/e_rod?z=photo298742340_457247118%2Fphotos298742340", [1728, 2160, "https://userapi.com/impf/c858320/v858320596/c7714/oImGe4o1ZJI.jpg"]],
+      ].each_with_index do |(input, expectation), i|
+        it "##{i + 1}" do
+          result = DirectLink.method(:vk).call input
+          assert_equal 1, result.size
+          result[0][-1].tap do |url|
+            url.replace( URI.parse(url).tap do |_|
+              _.host = _.host.split(?.).drop(1).join(?.)
+              _.query = nil
+            end.to_s )
+          end
+          assert_equal [expectation], result, "#{input} :: #{result.inspect} != #{expectation.inspect}"
+        end
+      end
+    end
+
     {
       google: [
         "https://lh3.googleusercontent.com/-NVJgqmI_2Is/WqMM2OMYg-I/AAAAAAAALrk/5-p3JL3iZt0Ho9dOf_p3gpddzqwr3Wp0ACJoC/w424-h318-n/001",
@@ -461,13 +488,13 @@ describe DirectLink do
         ["http://redd.it/32tq0i", "https://www.reddit.com/comments/32tq0i"],
         ["https://reddit.com/123456", "https://www.reddit.com/r/funny/comments/123456/im_thinking_about_getting_a_dog_and_youtubed_ways/"],
         # ["https://www.reddit.com/r/travel/988889", "https://www.reddit.com/r/travel/comments/988889/playa_miramar_in_guaymas_sonora/"],
-        "https://www.reddit.com/r/KsyushaEgorova/comments/beuqs2/a_little_shy/", # NSFW causes redirect to /over_18? if the special cookie not provided
+        "https://www.reddit.com/r/PareidoliaGoneWild/comments/hzrlq6/beard_trimmer_on_display_at_best_buy_they_knew/", # NSFW causes redirect to /over_18? if the special cookie not provided
       ],
       vk: [
         "https://vk.com/id57030827?z=photo57030827_456241143",
       ],
     }.each do |method, tests|
-      describe "DirectLink() calls #{method}" do
+      describe "DirectLink() sees domain name and calls #{method}" do
         tests.each_with_index do |(input, expected), i|
           it "##{i + 1}" do
             DirectLink.stub method, ->link{
@@ -603,6 +630,16 @@ describe DirectLink do
       )
     end
 
+    it "throws ErrorNotFound when Reddit gallery is removed" do
+      assert_raises DirectLink::ErrorNotFound do
+        DirectLink "https://www.reddit.com/gallery/i3y7pc"
+      end
+    end
+
+    it "follows Reddit crosspost" do
+      assert_equal %w{ image/png image/png }, DirectLink("https://www.reddit.com/ik6c6a").map(&:type)
+    end
+
     it "throws ErrorBadLink if link is invalid" do
       assert_equal "test".inspect, (
         assert_raises DirectLink::ErrorBadLink do
@@ -655,7 +692,7 @@ describe DirectLink do
       [
         # ["http://www.aeronautica.difesa.it/organizzazione/REPARTI/divolo/PublishingImages/6%C2%B0%20Stormo/2013-decollo%20al%20tramonto%20REX%201280.jpg", ["http://www.aeronautica.difesa.it/organizzazione/REPARTI/divolo/PublishingImages/6%C2%B0%20Stormo/2013-decollo%20al%20tramonto%20REX%201280.jpg", 1280, 853, :jpeg], nil, 1],   # website is dead?
         # ["http://minus.com/lkP3hgRJd9npi", SocketError, /nodename nor servname provided, or not known|No address associated with hostname/, 0],
-        ["http://www.cutehalloweencostumeideas.org/wp-content/uploads/2017/10/Niagara-Falls_04.jpg", SocketError, /nodename nor servname provided, or not known|Name or service not known/, 0],
+        ["http://www.cutehalloweencostumeideas.org/wp-content/uploads/2017/10/Niagara-Falls_04.jpg", SocketError, /nodename nor servname provided, or not known|Name or service not known|getaddrinfo: Name does not resolve/, 0],
       ].each_with_index do |(input, expectation, message_string_or_regex, max_redirect_resolving_retry_delay), i|
         it "##{i + 1}" do
           if expectation.is_a? Class
@@ -696,19 +733,20 @@ describe DirectLink do
             case expectation
             when Class
               e = assert_raises expectation, "for #{input} (giveup = #{giveup})" do
-                DirectLink input, 10, giveup: giveup
+                DirectLink input, 5, *ENV["PROXY"], giveup: giveup
               end
               assert_equal expectation.to_s, e.class.to_s, "for #{input} (giveup = #{giveup})"
             when String
-              result = DirectLink input, 10, giveup: giveup
+              result = DirectLink input, 5, *ENV["PROXY"], giveup: giveup
               assert_equal expectation, result.url, "for #{input} (giveup = #{giveup})"
             else
-              result = DirectLink input, 10, giveup: giveup
+              result = DirectLink input, 5, *ENV["PROXY"], giveup: giveup
               result = [result] unless result.is_a? Array   # we can't do `Array(<Struct>)` because it splats by elements
               assert_equal expectation, result.size, ->{
                 "for #{input} (giveup = #{giveup}): #{result.map &:url}"
               }
             end
+            # weird that this test may take longer than 5 sec
           ensure
             ENV["IMGUR_CLIENT_ID"] = ti if ti
             ENV["REDDIT_SECRETS"] = tr if tr
@@ -751,21 +789,28 @@ describe DirectLink do
 
     describe "fails" do
       [
-        [1, "http://example.com/", "FastImage::UnknownImageType"],
-        [1, "http://example.com/404", "NetHTTPUtils::Error: HTTP error #404 "],
+        [1, "http://example.com/", /\AFastImage::UnknownImageType\n\z/],
+        [1, "http://example.com/404", /\ANetHTTPUtils::Error: HTTP error #404 \n\z/],
 
         # TODO: a test when the giveup=false fails and reraises the DirectLink::ErrorMissingEnvVar
         #       maybe put it to ./lib tests
 
         # by design it should be impossible to write a test for DirectLink::ErrorAssert
-        [1, "https://flic.kr/p/DirectLinkErrorNotFound", "NetHTTPUtils::Error: HTTP error #404 "],
+        [1, "https://flic.kr/p/DirectLinkErrorNotFound", /\ANetHTTPUtils::Error: HTTP error #404 \n\z/],
 
-        [1, "https://imgur.com/a/badlinkpattern", "NetHTTPUtils::Error: HTTP error #404 "],
+        [1, "https://imgur.com/a/badlinkpattern", /\ANetHTTPUtils::Error: HTTP error #404 \n\z/],
         # TODO: a test that it appends the `exception.cause`
+
+        [1, "https://groundingpositivity.com/2020/08/13/new-quantum-app-will-make-you-wonder-do-we-live-in-a-simulation/", (
+          Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.4.0") ?
+          /\ANetHTTPUtils::EOFError_from_rbuf_fill: probably the old Ruby empty backtrace EOFError exception from net\/protocol\.rb: end of file reached\n\z/ :
+          /\A\S+\/net\/protocol\.rb:\d+:in `rbuf_fill': end of file reached \(EOFError\)\n/
+        ) ],  # TODO: add also a test to nethttputils gem
       ].each_with_index do |(expected_exit_code, link, expected_output, unset), i| # TODO: unset is not used anymore or I have to go sleep?
         it "##{i + 1}" do
           string, status = Open3.capture2e "export #{(File.read("api_tokens_for_travis.sh") + File.read("vk.secret")).scan(/(?<=^export )\S+=\S+/).join(" ")}#{unset} && RUBYOPT='-rbundler/setup #{$-I.map{ |i| "-I #{i}" }.join " "}' ./bin/directlink #{link}"
-          assert_equal [expected_exit_code, "#{expected_output}\n"], [status.exitstatus, string], "for #{link}"
+          assert_equal expected_exit_code, status.exitstatus, "for #{link}"
+          assert string[expected_output], "for #{link}"
         end
       end
     end
@@ -820,12 +865,13 @@ describe DirectLink do
     # TODO: test about --json
     it "uses <meta> tag" do
       string, status = Open3.capture2e "RUBYOPT='-rbundler/setup' ./bin/directlink --json https://www.kp.ru/daily/26342.7/3222103/"
-      assert_equal [0, "https://s9.stc.all.kpcdn.net/share/i/12/8054352/cr-1200-630.wm-asnpmfru-100-tr-0-0.t-13-3222103-ttps-47-8-0083CD-1010-l-85-b-41.t-13-3222103-ttps-47-8-FFF-1010-l-85-b-42.t-207-5-asb-37-10-FFF-788-l-370-t-68.m2018-03-14x02-10-20.jpg"], [status.exitstatus, JSON.load(string).fetch("url")]
-    end
-    it "ignores <meta> tag" do
-      string, status = Open3.capture2e "RUBYOPT='-rbundler/setup' ./bin/directlink --json --ignore-meta https://www.kp.ru/daily/26342.7/3222103/"
-      assert_equal [0, 21, "https://s11.stc.all.kpcdn.net/share/i/12/8024261/inx960x640.jpg"], [status.exitstatus, JSON.load(string).size, JSON.load(string).first.fetch("url")]
+      assert_equal [0, "https://s11.stc.all.kpcdn.net/share/i/12/8054352/cr-1200-630.wm-asnplfru-100-tr-0-0.t-13-3222103-ttps-54-14-0083CD-1010-l-85-b-42.t-13-3222103-ttps-54-14-FFF-1010-l-85-b-42.t-207-5-asb-37-10-FFF-788-l-370-t-68.m2018-03-14T02-10-20.jpg"], [status.exitstatus, JSON.load(string).fetch("url")]
     end
+    # TODO: kp.ru broke the page -- images are gone
+    # it "ignores <meta> tag" do
+    #   string, status = Open3.capture2e "RUBYOPT='-rbundler/setup' ./bin/directlink --json --ignore-meta https://www.kp.ru/daily/26342.7/3222103/"
+    #   assert_equal [0, 21, "https://s11.stc.all.kpcdn.net/share/i/12/8024261/inx960x640.jpg"], [status.exitstatus, JSON.load(string).size, JSON.load(string).first.fetch("url")]
+    # end
 
   end