directlink 0.0.8.4 → 0.0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f42b5eafdc2cffee78b290dd2b2873863da1f17
-  data.tar.gz: edda6ebe3c54923788d5ead6591896a26d0601fc
+  metadata.gz: 2fd631d28a9163381634ef669e093e592f930ded
+  data.tar.gz: 0b50f85bbfc1650fd3c600a087088bce1d804c7b
 SHA512:
-  metadata.gz: b3e0f61364cce617a0bcc7f1ffa03ff2b94f459c80b368a3395596a17015c04217dfeee31d31b8f416f76f88ee80851084e55a6fc1180725f128ac874bc8fbde
-  data.tar.gz: 07e69d129b074449d3dcc52d187dc9e163fc70bbaabf2a5bbd319127a6447c13408f75b3d8528be8fb1974b8f9b21904a09b13fff301311fd7dfa99070a5f335
+  metadata.gz: 0f37f81c0cc925df667eddca3ce2bf2c801438712deb22547acd2bc96f314728a377e1efbfc00c35304ed308b9bbf2f481a07a65edaf0626baf2e37b51044c84
+  data.tar.gz: fddbc5f906b2b9b49434dd7d0e2bb9fbffd5119defd5494b5b849ff8eb7ff201275b2e2b271db6f80506641bb3dddbce046f482db387671753b4fc53acc9f23f

data/.bashrc

@@ -1,4 +1,5 @@
 source api_tokens_for_travis.sh
-echo 'to test: ruby -I../nethttputils/lib -I./lib test.rb'
-echo 'to test: ruby -I../nethttputils/lib -I./lib ./bin/directlink --debug ...'
-echo 'or: bundle exec ./bin/directlink --debug ...'
+echo 'to test: ruby -I./lib test.rb'
+echo 'or: ruby -I../nethttputils/lib -I./lib ./bin/directlink --debug ...'
+echo 'or: bundle exec ruby -I./lib ./bin/directlink --debug ...'
+echo 'or: byebug -I./lib ./bin/directlink ...'

data/.travis.yml

@@ -8,6 +8,8 @@ os:
   - osx
 rvm:
   - ruby-head
+  - 2.7
+  - 2.6
   - 2.5
   - 2.4
   - 2.3

data/bin/directlink

@@ -53,6 +53,7 @@ abort "usage: directlink [--debug] [--json] [--github] [--ignore-meta]  <
       }" if [nil, "-h", "--help", "-v", "--version"].include? ARGV.first
 
 begin
+  # Struct instances have #each and Array() ruins them so we use .is_a?(Array)
   if json
     require "json"
     t = ARGV.map do |link|

data/directlink.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name         = "directlink"
-  spec.version      = "0.0.8.4"
+  spec.version      = "0.0.9.0"
   spec.summary      = "converts any kind of image hyperlink to direct link, type of image and its resolution"
 
   spec.author       = "Victor Maslov aka Nakilon"
@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "fastimage", "~>2.1.3"
   spec.add_dependency "nokogiri"
-  spec.add_dependency "nethttputils", "~>0.3.3.0"
+  spec.add_dependency "nethttputils", "~>0.4.0.0"
   spec.add_dependency "reddit_bot", "~>1.7.0"
   spec.add_dependency "kramdown"
   spec.add_dependency "addressable"

data/lib/directlink.rb

@@ -137,7 +137,7 @@ module DirectLink
   end
 
   def self._500px link
-    raise ErrorBadLink.new link unless %r{\Ahttps://500px\.com/photo/(?<id>[^/]+)/[^/]+\z} =~ link
+    raise ErrorBadLink.new link unless %r{\Ahttps://500px\.com/photo/(?<id>[^/]+)/[-[a-zA-Z]]+\/?\z} =~ link
     require "nokogiri"
     resp = NetHTTPUtils.request_data link
     f = lambda do |form|
@@ -236,7 +236,7 @@ module DirectLink
 
   def self.vk link
     id, mtd, field, f = case link
-    when %r{\Ahttps://vk\.com/id(?<user_id>\d+)\?z=photo(?<id>\k<user_id>_\d+)(%2F(album\k<user_id>_0|photos\k<user_id>))\z},
+    when %r{\Ahttps://vk\.com/id(?<user_id>\d+)\?z=photo(?<id>\k<user_id>_\d+)(%2F(album\k<user_id>_0|photos\k<user_id>))?\z},
          %r{\Ahttps://vk\.com/[a-z_]+\?z=photo(?<_>)(?<id>(?<user_id>\d+)_\d+)%2Fphotos\k<user_id>\z},
          %r{\Ahttps://vk\.com/photo(?<_>)(?<id>-?\d+_\d+)(\?all=1)?\z},
          %r{\Ahttps://vk\.com/feed\?section=likes&z=photo(?<_>)(?<id>-(?<user_id>\d+)_\d+)%2F(liked\d+|album\k<user_id>_0)\z},
@@ -244,15 +244,22 @@ module DirectLink
          %r{\Ahttps://vk\.com/wall(?<user_id>-\d+)_\d+\?z=photo(?<id>\k<user_id>_\d+)%2F(wall\k<user_id>_\d+|album\k<user_id>_00%2Frev|\d+)\z}
       [$2, :photos, :photos, lambda do |t|
         raise ErrorAssert.new "our knowledge about VK API seems to be outdated" unless 1 == t.size
-        t.first
+        t
       end ]
-    when %r{\Ahttps://vk\.com/wall(?<id>-\d+_\d+)\z}
+    when %r{\Ahttps://vk\.com/wall(?<id>-?\d+_\d+)\z},
+         %r{\Ahttps://vk\.com/[a-z\.]+\?w=wall(?<id>\d+_\d+)\z}
       [$1, :wall, :posts, lambda do |t|
-        t.first.fetch("attachments").tap do |t|
-          raise ErrorAssert.new "our knowledge about VK API seems to be outdated" unless 1 == t.size
-        end.first.tap do |t|
-          raise ErrorAssert.new "our knowledge about VK API seems to be outdated" unless %w{ type photo } == t.keys
-        end.fetch("photo")
+        t.first.fetch("attachments").select do |item|
+          case item.keys
+          when %w{ type photo }
+            raise ErrorAssert.new "our knowledge about VK API seems to be outdated" unless item["type"] == "photo"
+            next true
+          when %w{ type audio }
+            raise ErrorAssert.new "our knowledge about VK API seems to be outdated" unless item["type"] == "audio"
+          else
+            raise ErrorAssert.new "our knowledge about VK API seems to be outdated"
+          end
+        end.map{ |i| i.fetch "photo" }
       end ]
     else
       raise ErrorBadLink.new link
@@ -261,12 +268,14 @@ module DirectLink
     sleep 0.25 # "error_msg"=>"Too many requests per second"
     f.call( JSON.load( NetHTTPUtils.request_data "https://api.vk.com/method/#{mtd}.getById",
       :POST, form: { field => id, :access_token => ENV["VK_ACCESS_TOKEN"], :client_secret => ENV["VK_CLIENT_SECRET"], :v => "5.101" }
-    ).fetch("response") ).fetch("sizes").map do |s|
-      s.values_at("width", "height", "url").tap do |whu|
-        w, h, u = whu
-        whu[0, 2] = FastImage.new(u, raise_on_failure: true).size if [w, h].include? 0
-      end
-    end.max_by{ |w, h, u| w * h }
+    ).fetch("response") ).map do |photos|
+      photos.fetch("sizes").map do |size|
+        size.values_at("width", "height", "url").tap do |whu|
+          w, h, u = whu
+          whu[0, 2] = FastImage.new(u, raise_on_failure: true).size if [w, h].include? 0
+        end
+      end.max_by{ |w, h, u| w * h }
+    end
   end
 
   class_variable_set :@@directlink, Struct.new(:url, :width, :height, :type)
@@ -275,7 +284,7 @@ end
 
 require "fastimage"
 
-def DirectLink link, max_redirect_resolving_retry_delay = nil, giveup: false, ignore_meta: false
+def DirectLink link, timeout = nil, giveup: false, ignore_meta: false
   ArgumentError.new("link should be a <String>, not <#{link.class}>") unless link.is_a? String
   begin
     URI link
@@ -313,10 +322,10 @@ def DirectLink link, max_redirect_resolving_retry_delay = nil, giveup: false, ig
       **( %w{ reddit com } == URI(link).host.split(?.).last(2) ||
           %w{   redd it  } == URI(link).host.split(?.) ? {Cookie: "over18=1"} : {} ),
     }
-    head = NetHTTPUtils.request_data link, :head, header: header, **(max_redirect_resolving_retry_delay ? {
-      timeout: max_redirect_resolving_retry_delay,
-      max_start_http_retry_delay: max_redirect_resolving_retry_delay,
-      max_read_retry_delay: max_redirect_resolving_retry_delay
+    head = NetHTTPUtils.request_data link, :head, header: header, **(timeout ? {
+      timeout: timeout,
+      max_start_http_retry_delay: timeout,
+      max_read_retry_delay: timeout
     } : {})
   rescue Net::ReadTimeout
   rescue NetHTTPUtils::Error => e
@@ -369,8 +378,8 @@ def DirectLink link, max_redirect_resolving_retry_delay = nil, giveup: false, ig
       raise DirectLink::ErrorBadLink.new link if giveup   # TODO: print original url in such cases if there was a recursion
       f = ->_{ _.type == :a ? _.attr["href"] : _.children.flat_map(&f) }
       require "kramdown"
-      return f[Kramdown::Document.new(u).root].map do |sublink|
-        DirectLink URI.join(link, sublink).to_s, max_redirect_resolving_retry_delay, giveup: giveup
+      return f[Kramdown::Document.new(u).root].flat_map do |sublink|
+        DirectLink URI.join(link, sublink).to_s, timeout, giveup: giveup
       end
     end
     return struct.new *u.values_at(*%w{ fallback_url width height }), "video" if u.is_a? Hash
@@ -381,8 +390,9 @@ def DirectLink link, max_redirect_resolving_retry_delay = nil, giveup: false, ig
          %w{   redd it  } == URI(link).host.split(?.)
 
   begin
-    w, h, u = DirectLink.vk(link)
-    return struct.new u, w, h
+    return DirectLink.vk(link).map do |w, h, u|
+      struct.new u, w, h
+    end
   rescue DirectLink::ErrorMissingEnvVar
   end if %w{ vk com } == URI(link).host.split(?.)
 
@@ -391,7 +401,10 @@ def DirectLink link, max_redirect_resolving_retry_delay = nil, giveup: false, ig
   rescue FastImage::UnknownImageType
     raise if giveup
     require "nokogiri"
-    head = NetHTTPUtils.request_data link, :head, header: {"User-Agent" => "Mozilla"}
+    head = NetHTTPUtils.request_data link, :head, header: {"User-Agent" => "Mozilla"},
+      max_start_http_retry_delay: timeout,
+      timeout: timeout,                 # NetHTTPUtild passes this as read_timeout to Net::HTTP.start
+      max_read_retry_delay: timeout     # and then compares accumulated delay to this
     # if we use :get here we will download megabytes of files just to giveup on content_type we can't process
     case head.instance_variable_get(:@last_response).content_type
     when "text/html" ; nil
@@ -399,7 +412,10 @@ def DirectLink link, max_redirect_resolving_retry_delay = nil, giveup: false, ig
     end
     html = Nokogiri::HTML NetHTTPUtils.request_data link, header: {"User-Agent" => "Mozilla"}
     if t = html.at_css("meta[@property='og:image']")
-      return DirectLink t[:content], nil, giveup: true
+      begin
+        return DirectLink URI.join(link, t[:content]), nil, giveup: true
+      rescue URI::InvalidURIError
+      end
     end unless ignore_meta
     h = {}  # TODO: maybe move it outside because of possible img[:src] recursion?...
     l = lambda do |node, s = []|
@@ -413,9 +429,10 @@ def DirectLink link, max_redirect_resolving_retry_delay = nil, giveup: false, ig
         end
       end
     end
-    l[html].group_by(&:first).map{ |k, v| [k.join(?>), v.map(&:last)] }.tap do |results|
-      raise if results.empty?
-    end.max_by{ |_, v| v.map{ |i| i.width * i.height }.inject(:+) / v.size }.last
+    l[html].
+      tap{ |results| raise if results.empty? }.
+      group_by(&:first).map{ |k, v| [k.join(?>), v.map(&:last)] }.
+      max_by{ |_, v| v.map{ |i| i.width * i.height }.inject(:+) }.last
   else
     # TODO: maybe move this to right before `rescue` line
     w, h = f.size

data/test.rb

@@ -363,6 +363,7 @@ describe DirectLink do
     [
       [ :_500px, [
         ["https://500px.com/photo/264092015/morning-rider-by-tiger-seo", [1200, 800, "https://drscdn.500px.org/photo/264092015/m%3D900/v2?sig=68a9206477f573d8e2838faa6a929e7267f22dc5f9e98f1771f7a8a63efa2ed7", "jpeg"]],
+        ["https://500px.com/photo/1017579834/-poppies-flowers-by-David-Dubnitskiy/", [1819, 2500, "https://drscdn.500px.org/photo/1017579834/m%3D900/v2?sig=022e3e9dd836ffd8c1d31ae26c83735e4e42b4c8733d0c4380d8270aebbca44e", "jpeg"]],
       ] ],
       [ :flickr, [
         ["https://www.flickr.com/photos/tomas-/17220613278/", DirectLink::ErrorNotFound],
@@ -395,16 +396,18 @@ describe DirectLink do
         ["https://www.reddit.com/r/hangers/comments/97you5/tara_radovic/", [true, "https://i.imgur.com/rbLqgOu.jpg"]],   # "crossport" from Imgur
       ] ],
       [ :vk, [
-        ["https://vk.com/wall-105984091_7806", [960, 1280, "https://sun9-41.userapi.com/c855224/v855224900/a72f1/7OZ8ux9Wcwo.jpg"]],
-        ["https://vk.com/id57030827?z=photo57030827_456241143%2Falbum57030827_0", [1920, 1440, "https://sun9-66.userapi.com/c845322/v845322944/167836/bP9z41BybhI.jpg"]],
-        ["https://vk.com/wall-185182611_454?z=photo-185182611_457239340%2Fwall-185182611_454", [1280, 960, "https://sun9-46.userapi.com/c851028/v851028578/1a62f6/VB4SdR1O6Tg.jpg"]],
-        ["https://vk.com/wall-105984091_7946?z=photo-105984091_457243312%2Falbum-105984091_00%2Frev", [1280, 875, "https://sun9-37.userapi.com/c852020/v852020134/1b6b36/0IsDFb-Hda4.jpg"]],
-        ["https://vk.com/photo533531776_456239427?all=1", [750, 938, "https://sun9-25.userapi.com/c849416/v849416600/14b949/V01Ch1gYjhc.jpg"]],
-        ["https://vk.com/photo-155488973_456242404", [1486, 1000, "https://sun9-7.userapi.com/c852132/v852132877/8578e/m6AJWiskiKE.jpg"]],
-        ["https://vk.com/id2272074?z=photo2272074_264578776%2Fphotos2272074", [604, 484, "https://sun9-10.userapi.com/c10472/u2272074/-7/x_407b2ba2.jpg"]],
-        ["https://vk.com/feed?section=likes&z=photo-117564754_456261460%2Fliked3902406", [1024, 1335, "https://sun9-72.userapi.com/c854028/v854028353/895b6/izQJresLdf0.jpg"]],
-        ["https://vk.com/likizimy?z=photo-42543351_456239941%2Fwall-42543351_1908", [1179, 1731, "https://sun9-47.userapi.com/c855036/v855036571/60f7b/ryCPJIMyMkI.jpg"]],
-        ["https://vk.com/e_rod?z=photo298742340_457247118%2Fphotos298742340", [1728, 2160, "https://sun9-53.userapi.com/c858320/v858320596/c7714/oImGe4o1ZJI.jpg"]],
+        ["https://vk.com/wall-105984091_7806", [[960, 1280, "https://sun9-41.userapi.com/c855224/v855224900/a72f1/7OZ8ux9Wcwo.jpg"]]],
+        ["https://vk.com/wall298742340_4715", [[1080, 1080, "https://sun9-24.userapi.com/c857136/v857136625/15e38b/CsCqsJD174A.jpg"]]],
+        ["https://vk.com/id57030827?z=photo57030827_456241143%2Falbum57030827_0", [[1920, 1440, "https://sun9-66.userapi.com/c845322/v845322944/167836/bP9z41BybhI.jpg"]]],
+        ["https://vk.com/id57030827?z=photo57030827_456241143", [[1920, 1440, "https://sun9-66.userapi.com/c845322/v845322944/167836/bP9z41BybhI.jpg"]]],
+        ["https://vk.com/wall-185182611_454?z=photo-185182611_457239340%2Fwall-185182611_454", [[1280, 960, "https://sun9-46.userapi.com/c851028/v851028578/1a62f6/VB4SdR1O6Tg.jpg"]]],
+        ["https://vk.com/wall-105984091_7946?z=photo-105984091_457243312%2Falbum-105984091_00%2Frev", [[1280, 875, "https://sun9-37.userapi.com/c852020/v852020134/1b6b36/0IsDFb-Hda4.jpg"]]],
+        ["https://vk.com/photo533531776_456239427?all=1", [[750, 938, "https://sun9-25.userapi.com/c849416/v849416600/14b949/V01Ch1gYjhc.jpg"]]],
+        ["https://vk.com/photo-155488973_456242404", [[1486, 1000, "https://sun9-7.userapi.com/c852132/v852132877/8578e/m6AJWiskiKE.jpg"]]],
+        ["https://vk.com/id2272074?z=photo2272074_264578776%2Fphotos2272074", [[604, 484, "https://sun9-10.userapi.com/c10472/u2272074/-7/x_407b2ba2.jpg"]]],
+        ["https://vk.com/feed?section=likes&z=photo-117564754_456261460%2Fliked3902406", [[1024, 1335, "https://sun9-72.userapi.com/c854028/v854028353/895b6/izQJresLdf0.jpg"]]],
+        ["https://vk.com/likizimy?z=photo-42543351_456239941%2Fwall-42543351_1908", [[1179, 1731, "https://sun9-47.userapi.com/c855036/v855036571/60f7b/ryCPJIMyMkI.jpg"]]],
+        ["https://vk.com/e_rod?z=photo298742340_457247118%2Fphotos298742340", [[1728, 2160, "https://sun9-53.userapi.com/c858320/v858320596/c7714/oImGe4o1ZJI.jpg"]]],
       ] ],
     ].each do |method, tests|
       next if method == :vk && ENV.include?("TRAVIS")
@@ -441,7 +444,7 @@ describe DirectLink do
         ["https://goo.gl/ySqUb5", "https://i.imgur.com/QpOBvRY.png"],
       ],
       _500px: [
-        %w{ https://500px.com/photo/112134597/milky-way-by-tom-hall https://web.500px.com/photo/112134597/milky-way-by-tom-hall? },
+        %w{ https://500px.com/photo/112134597/milky-way-by-tom-hall https://500px.com/photo/112134597/milky-way-by-tom-hall },
       ],
       flickr: [
         "https://www.flickr.com/photos/59880970@N07/15773941043/in/dateposted-public/",
@@ -648,7 +651,7 @@ describe DirectLink do
 
     describe "other domains tests" do
       [
-        ["http://www.aeronautica.difesa.it/organizzazione/REPARTI/divolo/PublishingImages/6%C2%B0%20Stormo/2013-decollo%20al%20tramonto%20REX%201280.jpg", ["http://www.aeronautica.difesa.it/organizzazione/REPARTI/divolo/PublishingImages/6%C2%B0%20Stormo/2013-decollo%20al%20tramonto%20REX%201280.jpg", 1280, 853, :jpeg], nil, 1],
+        # ["http://www.aeronautica.difesa.it/organizzazione/REPARTI/divolo/PublishingImages/6%C2%B0%20Stormo/2013-decollo%20al%20tramonto%20REX%201280.jpg", ["http://www.aeronautica.difesa.it/organizzazione/REPARTI/divolo/PublishingImages/6%C2%B0%20Stormo/2013-decollo%20al%20tramonto%20REX%201280.jpg", 1280, 853, :jpeg], nil, 1],   # website is dead?
         # ["http://minus.com/lkP3hgRJd9npi", SocketError, /nodename nor servname provided, or not known|No address associated with hostname/, 0],
         ["http://www.cutehalloweencostumeideas.org/wp-content/uploads/2017/10/Niagara-Falls_04.jpg", SocketError, /nodename nor servname provided, or not known|Name or service not known/, 0],
       ].each_with_index do |(input, expectation, message_string_or_regex, max_redirect_resolving_retry_delay), i|
@@ -674,36 +677,39 @@ describe DirectLink do
     describe "giving up" do
       [
         ["http://example.com",                    FastImage::UnknownImageType],
-        ["https://www.tic.com/index.html",        FastImage::UnknownImageType, true],
-        ["https://www.tic.com/index.html",        2],
+        # ["https://www.tic.com/index.html",        FastImage::UnknownImageType, true],   # needs new test or stub
+        # ["https://www.tic.com/index.html",        2],                                   # needs new test or stub
         ["http://imgur.com/HQHBBBD",              FastImage::UnknownImageType, true],
         ["http://imgur.com/HQHBBBD",              "https://i.imgur.com/HQHBBBD.jpg?fb"],  # .at_css("meta[@property='og:image']")
         ["https://www.deviantart.com/nadyasonika/art/Asuka-Langley-Beach-Time-590134861", FastImage::UnknownImageType, true],
-        ["https://www.deviantart.com/nadyasonika/art/Asuka-Langley-Beach-Time-590134861", "https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/943f66cb-78ad-40f2-a086-44420b98b431/d9rcmz1-5cbc5670-0193-485b-ac14-755ddb9562f4.jpg/v1/fill/w_1024,h_732,q_75,strp/asuka_langley_beach_time_by_nadyasonika_d9rcmz1-fullview.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOjdlMGQxODg5ODIyNjQzNzNhNWYwZDQxNWVhMGQyNmUwIiwiaXNzIjoidXJuOmFwcDo3ZTBkMTg4OTgyMjY0MzczYTVmMGQ0MTVlYTBkMjZlMCIsIm9iaiI6W1t7ImhlaWdodCI6Ijw9NzMyIiwicGF0aCI6IlwvZlwvOTQzZjY2Y2ItNzhhZC00MGYyLWEwODYtNDQ0MjBiOThiNDMxXC9kOXJjbXoxLTVjYmM1NjcwLTAxOTMtNDg1Yi1hYzE0LTc1NWRkYjk1NjJmNC5qcGciLCJ3aWR0aCI6Ijw9MTAyNCJ9XV0sImF1ZCI6WyJ1cm46c2VydmljZTppbWFnZS5vcGVyYXRpb25zIl19.M-a_heYtVPwnR4eC9KIPk2mIYeNzEaTg4b4jqr_GwyI"],
+        ["https://www.deviantart.com/nadyasonika/art/Asuka-Langley-Beach-Time-590134861", "https://images-wixmp-ed30a86b8c4ca887773594c2.wixmp.com/f/943f66cb-78ad-40f2-a086-44420b98b431/d9rcmz1-5cbc5670-0193-485b-ac14-755ddb9562f4.jpg/v1/fill/w_1024,h_732,q_75,strp/asuka_langley_beach_time_by_nadyasonika_d9rcmz1-fullview.jpg?token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJ1cm46YXBwOiIsImlzcyI6InVybjphcHA6Iiwib2JqIjpbW3siaGVpZ2h0IjoiPD03MzIiLCJwYXRoIjoiXC9mXC85NDNmNjZjYi03OGFkLTQwZjItYTA4Ni00NDQyMGI5OGI0MzFcL2Q5cmNtejEtNWNiYzU2NzAtMDE5My00ODViLWFjMTQtNzU1ZGRiOTU2MmY0LmpwZyIsIndpZHRoIjoiPD0xMDI0In1dXSwiYXVkIjpbInVybjpzZXJ2aWNlOmltYWdlLm9wZXJhdGlvbnMiXX0.L6OhXuQZ_9ovKOdjjuQbvxpD0mG8M_KiqV4ljEDfW3Q"],
+        ["https://calgary.skyrisecities.com/news/2019/11/blue-morning-light", "https://cdn.skyrisecities.com/sites/default/files/images/articles/2019/11/39834/39834-132071.jpg"], # og:image without scheme
+        ["https://www.reddit.com/r/darksouls3/comments/e59djh/hand_it_over_that_thing_your_wallpaper/", DirectLink::ErrorBadLink, true],
+        ["https://www.reddit.com/r/darksouls3/comments/e59djh/hand_it_over_that_thing_your_wallpaper/", 6],
       ].each_with_index do |(input, expectation, giveup), i|
         it "##{i + 1} (#{URI(input).host}) (giveup=#{!!giveup})" do  # to match with minitest `-n` run flag
-          ti = ENV.delete "IMGUR_CLIENT_ID"
-          tr = ENV.delete "REDDIT_SECRETS"
+          ti = ENV.delete "IMGUR_CLIENT_ID" if %w{ imgur com } == URI(input).host.split(?.).last(2)
+          tr = ENV.delete "REDDIT_SECRETS" if %w{ reddit com } == URI(input).host.split(?.).last(2)
           begin
             case expectation
             when Class
               e = assert_raises expectation, "for #{input} (giveup = #{giveup})" do
-                DirectLink input, nil, giveup: giveup
+                DirectLink input, 10, giveup: giveup
               end
               assert_equal expectation.to_s, e.class.to_s, "for #{input} (giveup = #{giveup})"
             when String
-              result = DirectLink input, nil, giveup: giveup
+              result = DirectLink input, 10, giveup: giveup
               assert_equal expectation, result.url, "for #{input} (giveup = #{giveup})"
             else
-              result = DirectLink input, nil, giveup: giveup
+              result = DirectLink input, 10, giveup: giveup
               result = [result] unless result.is_a? Array   # we can't do `Array(<Struct>)` because it splats by elements
               assert_equal expectation, result.size, ->{
                 "for #{input} (giveup = #{giveup}): #{result.map &:url}"
               }
             end
           ensure
-            ENV["IMGUR_CLIENT_ID"] = ti
-            ENV["REDDIT_SECRETS"] = tr
+            ENV["IMGUR_CLIENT_ID"] = ti if ti
+            ENV["REDDIT_SECRETS"] = tr if tr
           end
         end
       end
@@ -816,7 +822,7 @@ describe DirectLink do
     end
     it "ignores <meta> tag" do
       string, status = Open3.capture2e "RUBYOPT='-rbundler/setup' ./bin/directlink --json --ignore-meta https://www.kp.ru/daily/26342.7/3222103/"
-      assert_equal [0, 21, "https://s11.stc.all.kpcdn.net/share/i/12/8024261/wx1080.jpg"], [status.exitstatus, JSON.load(string).size, JSON.load(string).first.fetch("url")]
+      assert_equal [0, 21, "https://s11.stc.all.kpcdn.net/share/i/12/8024261/inx960x640.jpg"], [status.exitstatus, JSON.load(string).size, JSON.load(string).first.fetch("url")]
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: directlink
 version: !ruby/object:Gem::Version
-  version: 0.0.8.4
+  version: 0.0.9.0
 platform: ruby
 authors:
 - Victor Maslov aka Nakilon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-08 00:00:00.000000000 Z
+date: 2020-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastimage
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.3.0
+        version: 0.4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.3.0
+        version: 0.4.0.0
 - !ruby/object:Gem::Dependency
   name: reddit_bot
   requirement: !ruby/object:Gem::Requirement