directlink 0.0.4.2 → 0.0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 95b60e38f85cce3fe9c3cf915a4ae95cf76a1a33
-  data.tar.gz: c2a6dfdd49aa4b9ab22bf9dbaad5d594f1307454
+  metadata.gz: 57cb3f9cecd52d2a4ac93edb8dd372398b0a54fa
+  data.tar.gz: 4dc3b43d8f661432207c6481eac1d3246377a003
 SHA512:
-  metadata.gz: dbca7e2c709fc76d04deb83c77b2742cb9ccd8b842d8f366a36c938f4baa709cd4748d09a8c503d78811364cacbd014c724dd8f78caa641225a89ff3dee9af89
-  data.tar.gz: e7ed956ca117b8e2d4a281cab5f314e553d375181381a80fc3a882bf9f6cec19fe360d1bbbe5ec3b4f6aa38a9516fcb140ed57c91329e8062af43d548714bfe7
+  metadata.gz: f1199f9b98636f09e58676764e1c943ef792fe24271f1d127bbbb8d7b8355544924d13cf19be91ff06ed468e885dbd98def0c5189ce351d28daacda35a9c12e1
+  data.tar.gz: 0c5e5720f11a60aa8548f8598b36d2395e1fd08a2bea654c2fe288916e85399d3897e8843aa2a90fb91e02e813b38859754362cb97373307e09b6bb92d139086

data/README.md

@@ -85,7 +85,9 @@ When an image hosting with known API is recognized, it will try to use the API t
 ```
 $ export IMGUR_CLIENT_ID=0f99cd781...
 $ export FLICKR_API_KEY=dc2bfd348b...
+$ export REDDIT_SECRETS=secrets.yaml
 ```
+(check the format of reddit secrets file in the [reddit_bot gem dependency README](https://github.com/Nakilon/reddit_bot/#usage))
 
 #### the "don't give up mode"
 
@@ -100,6 +102,7 @@ $ directlink https://github.com/Nakilon/dhash-vips
 => https://camo.githubusercontent.com/5456cc20ae9b20c06792ddd19b533ae36404d8c1/68747470733a2f2f73746f726167652e676f6f676c65617069732e636f6d2f64686173682d766970732e6e616b696c6f6e2e70726f2f6964686173685f6578616d706c655f6f75742e706e67
    png 1610x800
 ```
+It can even find images in the Markdown body of a Reddit self post! (new feature, needs more testing)
 
 ### As a library
 
@@ -161,5 +164,5 @@ SocketError: Failed to open TCP connection to minus.com:80 (getaddrinfo: nodenam
 * 500px.com has discontinued API in June 2018 -- the tool now uses undocumented methods
 * `DirectLink()` can return an Array of Structs for 1) Imgur 2) Reddit unless `giveup = true` is set
 
-TODO: maybe make all these web service specific methods private and discourage to use them since they all return very different things and sometimes don't raise exceptions while the `DirectLink()` does
+TODO: maybe make all these web service specific methods private and discourage to use them since they all return very different things and sometimes don't raise exceptions while the `DirectLink()` does  
 TODO: what should `--json` print if exception was thrown?

data/bin/directlink

@@ -40,7 +40,7 @@ if github
     # FileUtils.rm_rf dir
   end
 else
-  require "directlink"
+  require_relative "../lib/directlink"
 end
 NetHTTPUtils.logger.level = debug ? Logger::INFO : Logger::FATAL
 # TODO --timeout=

data/directlink.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name         = "directlink"
-  spec.version      = "0.0.4.2"
+  spec.version      = "0.0.4.3"
   spec.summary      = "converts any kind of image hyperlink to direct link, type of image and its resolution"
 
   spec.author       = "Victor Maslov aka Nakilon"
@@ -13,6 +13,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "nokogiri"
   spec.add_dependency "reddit_bot", "~>1.6.7"
   spec.add_dependency "kramdown"
+  spec.add_dependency "addressable"
   spec.add_development_dependency "minitest"
 
   spec.require_path = "lib"

data/lib/directlink.rb

@@ -238,7 +238,8 @@ def DirectLink link, max_redirect_resolving_retry_delay = nil, giveup = false
   begin
     URI link
   rescue URI::InvalidURIError
-    link = URI.escape link
+    require "addressable"
+    link = Addressable::URI.escape link
   end
   raise DirectLink::ErrorBadLink.new link, true unless URI(link).host
 

data/test.rb

@@ -397,6 +397,15 @@ describe DirectLink do
 
   describe "DirectLink()" do
 
+    # thanks to gem addressable
+    it "does not throw URI::InvalidURIError if there are brackets" do
+      assert_equal 404, (
+        assert_raises NetHTTPUtils::Error do
+          DirectLink "https://www.flickr.com/photos/leogaggl/28488925847/%20[2048x1152]"
+        end.code
+      )
+    end
+
     it "throws ErrorBadLink if link is invalid" do
       assert_equal "test".inspect, (
         assert_raises DirectLink::ErrorBadLink do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: directlink
 version: !ruby/object:Gem::Version
-  version: 0.0.4.2
+  version: 0.0.4.3
 platform: ruby
 authors:
 - Victor Maslov aka Nakilon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-22 00:00:00.000000000 Z
+date: 2018-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastimage
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement