directive 0.23.4 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ef48394905fefd453b43be9efdf367359d55eea58e6c16412c1853829c176192
-  data.tar.gz: 5ac5a192231512ff013d0bce6fff551ae8022b183f65ef689bc51151afa44e07
+  metadata.gz: f4b65ae4632fd364637d4d6a342eee46ffa577aee6638c1c69ee69bbc2215357
+  data.tar.gz: ca78edee3c25be6f367f03e89280e9ca3ee61c2c1d4a85f7603be7a30ca16a7f
 SHA512:
-  metadata.gz: a105dc620529a0c9390a3dd8081ac7a3f6d5881a53aa972b2cb440420051258ff46e7b142fb44567614419eb346702aaa41bddda4c29fc6596b82f121ec4cc7c
-  data.tar.gz: b4fdf356f47a2a56e1c29158b542a55e798c64632cdec6578993dd97d1e06584c72c5b7e9c5849105e4d4fede721be188e7a2800bd44ee55ec562bb8ecc41ab1
+  metadata.gz: 671cc9ead1f1394e95de171f1b5827bdf9bf979c088f0228c90fd4ff0e03d1eac64089368b0fa39b08956b60f8d38839e5283966eaa3c0ea1216aed4bda66cf3
+  data.tar.gz: 64716207b988d73307bd3908b42130ea8ea20e20a3265f94837f56ab674d003b82e25346d5a5267ee00d1afd355e5a6860ddd00549a59fa9138745ef01c76104

data/lib/directive/config_object.rb

@@ -17,19 +17,23 @@ module Directive
     class << self
       private
 
-      def option(name, *)
+      def option(name, *args, **kwargs)
+        name = name.to_sym
+
         _ensure_safe_option_name(name)
 
-        super
+        super(name, *args, **kwargs)
       end
 
       def nested(namespace, &block)
+        namespace = namespace.to_sym
+
         _ensure_safe_option_name(namespace)
 
         nested_config_builder_for(namespace).tap do |builder|
           builder.instance_exec(&block)
 
-          _nested_options << namespace.to_sym
+          _nested_options << namespace
           define_method(namespace) do |&nested_configure_block|
             builder.__send__(:configuration).tap do |nested_config|
               nested_configure_block.call(nested_config) if nested_configure_block.respond_to?(:call)
@@ -43,10 +47,10 @@ module Directive
       end
 
       def _ensure_safe_option_name(name)
-        raise ArgumentError, "#{name.inspect} is reserved and cannot be used at a config option" if name.to_sym.in? RESERVED_WORDS
-        raise ArgumentError, "#{name.inspect} is already in use" if _nested_options.include?(name.to_sym)
+        raise ArgumentError, "#{name.inspect} is reserved and cannot be used at a config option" if name.in? RESERVED_WORDS
+        raise ArgumentError, "#{name.inspect} is defined twice" if _nested_options.include?(name)
 
-        puts "Warning: the config option #{name} is already defined" if _options.include?(name.to_sym) # rubocop:disable Rails/Output
+        puts "Warning: the config option #{name} is already defined" if _options.include?(name) # rubocop:disable Rails/Output
       end
 
       def inherited(base)

data/lib/directive/reader.rb

@@ -17,19 +17,15 @@ module Directive
     attr_reader :config
 
     def method_missing(method_name, *)
-      name = method_name.to_sym
-
-      return mutex.synchronize { config.public_send(name) } if config._options.map(&:to_sym).include?(name)
-      return config._nested_builders[name].reader if config._nested_builders.key?(name)
+      return mutex.synchronize { config.public_send(method_name) } if config._options.include?(method_name)
+      return config._nested_builders[method_name].reader if config._nested_builders.key?(method_name)
 
       super
     end
 
     def respond_to_missing?(method_name, *)
-      name = method_name.to_sym
-
-      config._options.map(&:to_sym).include?(name) ||
-        config._nested_builders.key?(name) ||
+      config._options.include?(method_name) ||
+        config._nested_builders.key?(method_name) ||
         super
     end
 

data/lib/directive/spec_helper/matchers/configuration/define_config_option.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "spicerack/rspec/custom_matchers/define_option"
+
 module Directive
   module SpecHelper
     module Matchers
@@ -19,21 +21,35 @@ module Directive
         #       it { is_expected.to define_config_option :foo }
         #       it { is_expected.to define_config_option :bar, default: :baz }
         #     end
-        define :define_config_option do |option, default: nil|
-          description { "define config option #{option.inspect}" }
-          failure_message { "expected #{@obj} to define config option #{option.inspect} with default #{default.inspect}" }
+        define :define_config_option do |option, **config_options|
+          attr_reader :obj, :option, :default, :default_expected
+
+          description { "define config option #{option.inspect}#{with_default_message}" }
+          failure_message { "expected #{obj} to define config option #{option.inspect}#{with_default_message}" }
 
           match do |obj|
+            config_options.assert_valid_keys(:default)
+
             @obj = obj
+            @options = option
+
+            @default_expected = config_options.key?(:default)
+            @default = config_options[:default]
 
             if obj.is_a? Directive::ConfigObject
-              expect(obj).to define_option option, default: default
+              expect(obj).to define_option option.to_sym, default: default
             else
               expect(obj).to respond_to :config
               expect(obj.config.instance_variable_get(:@config)).to be_present
-              expect(obj.config.instance_variable_get(:@config)).to define_option option, default: default
+              expect(obj.config.instance_variable_get(:@config)).to define_option option.to_sym, default: default
             end
           end
+
+          def with_default_message
+            return unless default_expected
+
+            " with default #{default.inspect}"
+          end
         end
       end
     end

data/lib/directive/version.rb

@@ -2,5 +2,5 @@
 
 module Directive
   # This constant is managed by spicerack
-  VERSION = "0.23.4"
+  VERSION = "0.24.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: directive
 version: !ruby/object:Gem::Version
-  version: 0.23.4
+  version: 0.24.0
 platform: ruby
 authors:
 - Allen Rettberg
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-27 00:00:00.000000000 Z
+date: 2020-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.4
+        version: 0.24.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.4
+        version: 0.24.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -104,16 +104,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -186,7 +186,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Gem configuration made simple