dionysus-rb 1.4.1 → 1.6.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/CHANGELOG.md +18 -0
- data/Gemfile.lock +1 -1
- data/README.md +24 -0
- data/lib/dionysus/consumer/persistor.rb +55 -34
- data/lib/dionysus/consumer/synchronizable_model.rb +12 -0
- data/lib/dionysus/producer/config.rb +16 -1
- data/lib/dionysus/producer/outbox/duplicates_filter.rb +17 -3
- data/lib/dionysus/producer/outbox/records_processor.rb +24 -0
- data/lib/dionysus/version.rb +1 -1
- metadata +2 -2
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: 1b3fb6e16f40d4396b115342f72098bbb2b3f56d8fb630898123e63acce866dc
|
|
4
|
+
data.tar.gz: ff8f56aa9b8a142131d92b53d83f7014b987439158c39a7518c096f9e05de980
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: 9250e85c200c5190a6f85fef44404fa0576d39621960af375b3cbd3cd7ffe172b19fff8021c4f32b1cd63ac453457c6c3bffd504abac9851091d3f4091530b45
|
|
7
|
+
data.tar.gz: 28194d92924dbac55258734f66ed3a4090ebe514d2edf8dcfd0368a244c4373111c70be23a32b1d3fb08f271f52ade9434529b4ea6dd91015bee8d0bfaa077b5
|
data/CHANGELOG.md
CHANGED
|
@@ -1,5 +1,23 @@
|
|
|
1
1
|
## [Unreleased]
|
|
2
2
|
|
|
3
|
+
## [1.6.0]
|
|
4
|
+
- Judge a payload's embedded children on their own timestamps instead of dropping them with the parent. When `persist_with_dionysus?` rejects a record, `persist` used to `next` past the whole loop body - the child `persist` calls included - so every `has_many` and `has_one` record embedded in that payload was discarded with it, with no error and no counter. The parent is still not written; only the traversal of its children is decoupled from its verdict. Each child re-enters `persist` and is guarded on its own `synced_updated_at || synced_created_at`, so a child the consumer has never seen is created and a child older than the row held locally is still skipped.
|
|
5
|
+
- Reproduced at the consumer, not argued: `spec/embedded_children_persistence_spec.rb` runs a whole batch through the generated consumer with deduplication in place, from two failures observed in production. In the first, all seven money-bearing messages carried an `updated_at` 44 ms older than the zero-money payload already accepted, and the payment embedded in them - a row that did not exist locally - was never created. Three control examples pin the fixture down: the same shape at a timestamp the guard accepts persists the money, creates the embedded payment and calls `resolve_to_many_association`, so a red assertion is a statement about this gem rather than about the payload being malformed.
|
|
6
|
+
- `resolve_to_many_association` and `resolve_to_one_association` are suppressed for the whole subtree beneath a rejected parent. Cancelling or deleting the children absent from the payload's list is how a genuine deletion propagates, and it requires a complete current list - which is exactly what a payload already judged stale cannot provide. Consuming applications implement that hook destructively, several with `destroy_all`, and the old `next` was shielding them by accident; suppressing it deliberately keeps that behaviour rather than changing it.
|
|
7
|
+
- Children beneath a rejected parent are compared strictly, through the new `SynchronizableModel#advances_dionysus_state?`. The ordinary guard accepts a tie, and a purge stamps the cancel column with `update_all` without bumping `synced_updated_at` - so a stale payload that merely ties on a child's timestamp is precisely how a cancelled child would be revived. A tie carries nothing that is not already held, so requiring the child to be demonstrably newer closes that without costing a repair. `persist_with_dionysus?` itself is untouched and behaves as before on the ordinary path. A child the payload carries no timestamp for at all is refused outright for the same reason: a payload already judged stale proves nothing about it, and where `resolve_to_many_association` hard-deletes, applying one would bring back a child a fresher payload had removed.
|
|
8
|
+
- The stale verdict is sticky for the whole subtree, which is a trade rather than a free win: a child that is itself fresh now advances while its own children keep the generation they had, because the purge needs a complete list that only a non-stale ancestor can vouch for. Before this change the child did not advance either, so the subtree stayed internally consistent and equally wrong; a later payload that passes the root guard repairs it. Recorded as a pending example.
|
|
9
|
+
- Not fixed here, and left as a pending example rather than a silent gap: when deduplication keeps a message whose `updated_at` the guard rejects while a sibling in the same group would have been accepted, the parent's own columns are still lost. Recovering that needs the guard - not a payload timestamp - to choose the survivor. Keeping siblings whose `updated_at` looks newer is disproven by the existing torn-payload fixture in the deduplication specs, where the correct payload carries the *lower* `updated_at`; ranking on any single key has a production counterexample, so `RemoveDuplicatesStrategy` is unchanged. A consuming application that needs the parent half today can pass `params_batch_transformation: nil` for the topic, which is covered by an example here.
|
|
10
|
+
|
|
11
|
+
## [1.5.0]
|
|
12
|
+
- Publish the survivor of a collapsed run of duplicates once more after a delay, behind `config.republish_deduplicated_records` (default `false`) with `config.republish_deduplicated_records_delay` (default 30 seconds). It does nothing unless `remove_consecutive_duplicates_before_publishing` is also on, since there is no run to collapse otherwise.
|
|
13
|
+
- What a collapsed run means. `DuplicatesFilter` keeps the last record of each consecutive run for the same resource, event and topic. A run longer than one only happens when the record was written again while an earlier message for it was still queued - which is the same window in which a payload can be serialized across a write and end up carrying an `updated_at` older than its own contents. `publish_consistent_snapshots` bounds its retries and publishes the last attempt regardless, so a payload that may still be torn does get published; this schedules one more publish once the writes have settled.
|
|
14
|
+
- Why a republish is sufficient, and why it needs no change on the consumer. The outbox stores a pointer, not a payload: `Outbox::Publisher#publish` re-reads the row with `find_by`, so the scheduled record is serialized fresh at publish time and carries the settled state. The consumer's guard is `event_updated_at >= synced_at`, and `synced_at` is its mirror of the row's `updated_at` as of the last accepted message - a value the row's own `updated_at` can never fall below. A freshly-read republish is therefore accepted by construction, so nothing has to be forced past the guard and no timestamp has to be altered to make it win.
|
|
15
|
+
- Scheduled with `retry_at`, not a future `created_at`. `fetch_publishable` already honours `retry_at` exactly, whereas `created_at` is compared against `Time.current + outbox_worker_publishing_delay` - so a future `created_at` publishes early by the length of that look-ahead window, and would report a negative `publishing_latency`. `retry_at` leaves `created_at` honest; `failed_at` and `error_class` stay `nil`, so a scheduled republish is distinguishable from a failed record awaiting retry.
|
|
16
|
+
- Termination. A scheduled record that comes due on its own is a run of one, so it schedules nothing further. If the record is still being written when it comes due, it collapses again and schedules once more, which is the intended behaviour - the extra load is bounded at one additional record per key per batch, and pile-ups for the same key collapse through the same filter.
|
|
17
|
+
- Observer records are skipped: they carry a changeset and publish through `publish_observers`, a different path.
|
|
18
|
+
- Records that failed to publish are skipped too - they are already retried by `handle_error`'s backoff, so scheduling a republish for them would duplicate that.
|
|
19
|
+
- Operational note: the scheduled records sit unpublished for the delay, so they raise the average and maximum reported by the outbox latency gauges. That is a truthful measurement - those messages really do wait - but any alert threshold on outbox latency should be checked before switching this on.
|
|
20
|
+
|
|
3
21
|
## [1.4.1]
|
|
4
22
|
- Stamp `serialized_at` when the attempt that is actually published begins, not before the retry loop. 1.4.0 takes the stamp once and then re-serializes up to `max_snapshot_attempts` times, so a message can be published a whole retry cycle after its own stamp - and the payload it publishes is the one read last, not the one the stamp describes. Consumers rank duplicates by `[serialized_at, offset]`, so the freshest payload ended up carrying the oldest stamp and losing its group to a staler sibling. That is the failure `serialized_at` was added to prevent, reintroduced by the guard added to prevent a different one.
|
|
5
23
|
- Measured on the affected topic over 65 minutes: 205 of 6,572 messages (3.12%) carried an `updated_at` LATER than their own `serialized_at`, the worst by 1,225 ms. A timestamp cannot describe a moment after the one it was taken at, so that alone proves the stamp preceded the payload.
|
data/Gemfile.lock
CHANGED
data/README.md
CHANGED
|
@@ -336,6 +336,8 @@ Dionysus::Producer.configure do |config|
|
|
|
336
336
|
config.publish_after_commit = true # not required, defaults to `false`. Check `Publishing records right after the transaction is committed` section for more details.
|
|
337
337
|
config.outbox_worker_publishing_delay = 5 # non required, defaults to 0 a delay in seconds until the outbox record is considered publishable. Check `Publishing records right after the transaction is committed` section for more details.
|
|
338
338
|
config.remove_consecutive_duplicates_before_publishing = true # not required, defaults to false. If set to true, the consecutive duplicates in the publishable batch will be removed and only one message will be published to a given topic. For example, if for whatever reason there are ten messages in a row for a given topic to publish `user_updated` ecent, only the last will be published. Check `Dionysus::Consumer::ParamsBatchTransformations::RemoveDuplicatesStrategy` for exact implementation. To verify if this feature is useful, it's recommended to browse Karafka UI and check messages in the topics if there are any obvious duplicates happening often.
|
|
339
|
+
config.republish_deduplicated_records = true # not required, defaults to false. Only has an effect with `remove_consecutive_duplicates_before_publishing` enabled. When a run of consecutive duplicates collapses, the surviving record is scheduled to publish once more after a delay - a run only collapses when the record was written again while an earlier message for it was still queued, which is the window in which a payload can be serialized across a write. Check `Republishing deduplicated records` section for more details.
|
|
340
|
+
config.republish_deduplicated_records_delay = 60 # not required, defaults to 30 (seconds). Only relevant with `republish_deduplicated_records` enabled. How long the scheduled republish waits - it has to outlast the burst of writes that produced the duplicates, or the republish is serialized inside the same contended window it exists to escape.
|
|
339
341
|
config.observers_inline_maximum_size = 100 # not required, defaults to 1000. This config setting matters in case there is a huge amount of dependent records (observers). If the threshold is exceeded, the observers will be published via Genesis process to not cause issues like blocking the outbox worker.
|
|
340
342
|
config.publish_consistent_snapshots = true # not required, defaults to `false`. A serializer reads a record's own columns and then queries its associations, so a write landing in between produces a payload whose `updated_at` predates the records embedded next to it - consumers rank and guard on that timestamp, so such a payload is discarded along with its embedded associations. When enabled, the row's timestamp is read back (bypassing the query cache) after serializing and the payload is re-serialized if the record moved. Emits the `dionysus.publish.consistent_snapshot` counter described below.
|
|
341
343
|
config.max_snapshot_attempts = 2 # not required, defaults to 3. Only relevant with `publish_consistent_snapshots` enabled. A record written faster than it serializes fails the check on every attempt, so it pays the full serialization cost this many times over and still publishes a payload that may be torn - lower this to bound that cost. Set it to 1 to keep the check and its metric while disabling re-serialization entirely.
|
|
@@ -355,6 +357,28 @@ With `publish_consistent_snapshots` enabled, every guarded message increments `d
|
|
|
355
357
|
|
|
356
358
|
Watch the `exhausted` rate before and after a rollout: the retry cost scales with write rate multiplied by serialization span, so the hottest records are both the most expensive to guard and the least likely to converge.
|
|
357
359
|
|
|
360
|
+
##### Republishing deduplicated records
|
|
361
|
+
|
|
362
|
+
`remove_consecutive_duplicates_before_publishing` keeps only the last record of each consecutive run for the same resource, event and topic. A run longer than one only happens when the record was written again while an earlier message for it was still queued - the same window in which a payload can be serialized across a write and end up carrying an `updated_at` older than its own contents. `publish_consistent_snapshots` bounds its retries and publishes the last attempt regardless, so a payload that may still be torn does get published.
|
|
363
|
+
|
|
364
|
+
With `republish_deduplicated_records` enabled, the survivor of every collapsed run is scheduled to publish once more, `republish_deduplicated_records_delay` seconds later:
|
|
365
|
+
|
|
366
|
+
```ruby
|
|
367
|
+
config.remove_consecutive_duplicates_before_publishing = true
|
|
368
|
+
config.republish_deduplicated_records = true
|
|
369
|
+
config.republish_deduplicated_records_delay = 30
|
|
370
|
+
```
|
|
371
|
+
|
|
372
|
+
This needs no change on the consumer side. The outbox stores a pointer rather than a payload - `Outbox::Publisher#publish` re-reads the row with `find_by` - so the scheduled record is serialized fresh when it comes due and carries the settled state. The consumer's guard is `event_updated_at >= synced_at`, and `synced_at` is the consumer's mirror of the row's `updated_at` as of the last accepted message, a value the row's own `updated_at` can never fall below. A freshly-read republish is therefore accepted rather than discarded as stale, so nothing has to be forced past the guard and no timestamp has to be altered to make it win.
|
|
373
|
+
|
|
374
|
+
The republish is scheduled with `retry_at`, not a future `created_at`. `fetch_publishable` honours `retry_at` exactly, whereas `created_at` is compared against `Time.current + outbox_worker_publishing_delay` - a future `created_at` would publish early by the length of that look-ahead window, and would report a negative `publishing_latency`. `failed_at` and `error_class` stay `nil`, so a scheduled republish stays distinguishable from a record awaiting an error retry.
|
|
375
|
+
|
|
376
|
+
A scheduled record that comes due on its own is a run of one, so it schedules nothing further. If the record is still being written when it comes due it collapses again and schedules once more, which is the intent; the extra load is bounded at one additional record per key per batch, and pile-ups for the same key collapse through the same filter.
|
|
377
|
+
|
|
378
|
+
Observer records are skipped - they carry a changeset that decides which observers fire, and they publish through `publish_observers`. Records that failed to publish are skipped too, since `handle_error`'s backoff already retries them.
|
|
379
|
+
|
|
380
|
+
Before enabling this, check any alert threshold on outbox latency. The scheduled records sit unpublished for the delay, so they raise the average and maximum reported by the `"#{namespace}.dionysus.producer.outbox.latency.*"` gauges. That is a truthful measurement - those messages really do wait - but it will move the gauge.
|
|
381
|
+
|
|
358
382
|
##### DionysusOutbox model
|
|
359
383
|
|
|
360
384
|
Generate a model for the outbox:
|
|
@@ -9,14 +9,14 @@ class Dionysus::Consumer::Persistor
|
|
|
9
9
|
@topic = topic
|
|
10
10
|
end
|
|
11
11
|
|
|
12
|
-
def persist(dionysus_event, batch_number)
|
|
12
|
+
def persist(dionysus_event, batch_number, under_stale_parent: false)
|
|
13
13
|
if dionysus_event.generic_event?
|
|
14
14
|
if dionysus_event.created? && topic.options[:import] == true
|
|
15
15
|
persist_via_dionysus_create(dionysus_event, batch_number)
|
|
16
16
|
elsif dionysus_event.destroyed? && topic.options[:import] == true
|
|
17
17
|
persist_via_dionysus_destroy(dionysus_event, batch_number)
|
|
18
18
|
else
|
|
19
|
-
persist_standard_event(dionysus_event, batch_number)
|
|
19
|
+
persist_standard_event(dionysus_event, batch_number, under_stale_parent: under_stale_parent)
|
|
20
20
|
end
|
|
21
21
|
else
|
|
22
22
|
log_unknown_event_type(dionysus_event)
|
|
@@ -43,12 +43,9 @@ class Dionysus::Consumer::Persistor
|
|
|
43
43
|
config.model_factory.for_model(dionysus_event.model_name)
|
|
44
44
|
end
|
|
45
45
|
|
|
46
|
-
def persist_standard_event(dionysus_event, batch_number)
|
|
46
|
+
def persist_standard_event(dionysus_event, batch_number, under_stale_parent: false)
|
|
47
47
|
Array.wrap(dionysus_event.transformed_data).each do |deseralized_record|
|
|
48
48
|
model_klass = find_model_klass(dionysus_event) or return
|
|
49
|
-
attributes = deseralized_record.attributes
|
|
50
|
-
has_one_relationships = deseralized_record.has_one
|
|
51
|
-
has_many_relationships = deseralized_record.has_many
|
|
52
49
|
synced_id = deseralized_record.synced_id
|
|
53
50
|
|
|
54
51
|
if synced_id.nil?
|
|
@@ -59,38 +56,53 @@ class Dionysus::Consumer::Persistor
|
|
|
59
56
|
record = Dionysus::Consumer::SynchronizableModel.new(config,
|
|
60
57
|
model_klass.find_or_initialize_by(config.synced_id_attribute => synced_id))
|
|
61
58
|
event_updated_at = deseralized_record.synced_updated_at || deseralized_record.synced_created_at
|
|
59
|
+
persistable = persistable?(record, event_updated_at, under_stale_parent)
|
|
62
60
|
|
|
63
|
-
|
|
61
|
+
apply_record(dionysus_event, record, deseralized_record, synced_id, batch_number) if persistable
|
|
64
62
|
|
|
65
|
-
|
|
66
|
-
|
|
67
|
-
|
|
68
|
-
|
|
69
|
-
|
|
70
|
-
else
|
|
71
|
-
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.restore_with_dionysus") do
|
|
72
|
-
record.restore_with_dionysus if record.restorable?(deseralized_record)
|
|
73
|
-
end
|
|
74
|
-
end
|
|
63
|
+
# children re-enter persist and are guarded on their own timestamp; only the child list is untrusted
|
|
64
|
+
persist_relationships(dionysus_event, record, deseralized_record, batch_number,
|
|
65
|
+
under_stale_parent: under_stale_parent || !persistable)
|
|
66
|
+
end
|
|
67
|
+
end
|
|
75
68
|
|
|
76
|
-
|
|
69
|
+
def persistable?(record, event_updated_at, under_stale_parent)
|
|
70
|
+
if under_stale_parent
|
|
71
|
+
record.advances_dionysus_state?(event_updated_at)
|
|
72
|
+
else
|
|
73
|
+
record.persist_with_dionysus?(event_updated_at)
|
|
74
|
+
end
|
|
75
|
+
end
|
|
77
76
|
|
|
78
|
-
|
|
79
|
-
|
|
77
|
+
def apply_record(dionysus_event, record, deseralized_record, synced_id, batch_number)
|
|
78
|
+
record.assign_attributes_from_dionysus(deseralized_record.attributes)
|
|
79
|
+
if dionysus_event.destroyed?
|
|
80
|
+
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.remove_with_dionysus") do
|
|
81
|
+
record.remove_with_dionysus(deseralized_record) if dionysus_event.aggregate_root?
|
|
82
|
+
end
|
|
83
|
+
else
|
|
84
|
+
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.restore_with_dionysus") do
|
|
85
|
+
record.restore_with_dionysus if record.restorable?(deseralized_record)
|
|
80
86
|
end
|
|
87
|
+
end
|
|
88
|
+
|
|
89
|
+
dionysus_event.local_changes[[dionysus_event.model_name, synced_id]] = record.changes if record.changes.present?
|
|
90
|
+
|
|
91
|
+
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.save") do
|
|
92
|
+
record.save unless record.destroyed?
|
|
93
|
+
end
|
|
94
|
+
end
|
|
81
95
|
|
|
82
|
-
|
|
83
|
-
|
|
84
|
-
|
|
85
|
-
|
|
86
|
-
end
|
|
96
|
+
def persist_relationships(dionysus_event, record, deseralized_record, batch_number, under_stale_parent:)
|
|
97
|
+
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.persist_to_many_relationships") do
|
|
98
|
+
deseralized_record.has_many.each do |relationship|
|
|
99
|
+
persist_to_many_relationship(dionysus_event, relationship, record, batch_number, under_stale_parent: under_stale_parent)
|
|
87
100
|
end
|
|
101
|
+
end
|
|
88
102
|
|
|
89
|
-
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
batch_number)
|
|
93
|
-
end
|
|
103
|
+
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.persist_to_one_relationships") do
|
|
104
|
+
deseralized_record.has_one.each do |relationship|
|
|
105
|
+
persist_to_one_relationship(dionysus_event, relationship, record, batch_number, under_stale_parent: under_stale_parent)
|
|
94
106
|
end
|
|
95
107
|
end
|
|
96
108
|
end
|
|
@@ -99,7 +111,9 @@ class Dionysus::Consumer::Persistor
|
|
|
99
111
|
Dionysus.logger.debug("[Dionysus] unknown event type #{dionysus_event.event_name}")
|
|
100
112
|
end
|
|
101
113
|
|
|
102
|
-
def persist_to_one_relationship(original_event,
|
|
114
|
+
def persist_to_one_relationship(original_event, relationship, parent_model_record, batch_number,
|
|
115
|
+
under_stale_parent: false)
|
|
116
|
+
relationship_name, record = relationship
|
|
103
117
|
instrumentation_arguments = {
|
|
104
118
|
event_name: original_event.event_name,
|
|
105
119
|
parent_model_record: parent_model_record.model_name.to_s,
|
|
@@ -115,17 +129,21 @@ class Dionysus::Consumer::Persistor
|
|
|
115
129
|
relationship_name, records, aggregate_root: false)
|
|
116
130
|
|
|
117
131
|
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.persist_to_one_relationship.#{relationship_name}.persist") do
|
|
118
|
-
persist(dionysus_event, batch_number)
|
|
132
|
+
persist(dionysus_event, batch_number, under_stale_parent: under_stale_parent)
|
|
119
133
|
original_event.local_changes.merge!(dionysus_event.local_changes)
|
|
120
134
|
end
|
|
121
135
|
|
|
136
|
+
return if under_stale_parent
|
|
137
|
+
|
|
122
138
|
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.persist_to_one_relationship.#{relationship_name}.resolve_to_one_association") do
|
|
123
139
|
parent_model_record.resolve_to_one_association(relationship_name, record.synced_id)
|
|
124
140
|
end
|
|
125
141
|
end
|
|
126
142
|
end
|
|
127
143
|
|
|
128
|
-
def persist_to_many_relationship(original_event,
|
|
144
|
+
def persist_to_many_relationship(original_event, relationship, parent_model_record, batch_number,
|
|
145
|
+
under_stale_parent: false)
|
|
146
|
+
relationship_name, records = relationship
|
|
129
147
|
instrumentation_arguments = {
|
|
130
148
|
event_name: original_event.event_name,
|
|
131
149
|
parent_model_record: parent_model_record.model_name.to_s,
|
|
@@ -140,10 +158,13 @@ class Dionysus::Consumer::Persistor
|
|
|
140
158
|
relationship_name, records, aggregate_root: false)
|
|
141
159
|
|
|
142
160
|
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.persist_to_many_relationship.#{relationship_name}.persist") do
|
|
143
|
-
persist(dionysus_event, batch_number)
|
|
161
|
+
persist(dionysus_event, batch_number, under_stale_parent: under_stale_parent)
|
|
144
162
|
original_event.local_changes.merge!(dionysus_event.local_changes)
|
|
145
163
|
end
|
|
146
164
|
|
|
165
|
+
# the purge needs a complete current list, which a payload already judged stale cannot provide
|
|
166
|
+
return if under_stale_parent
|
|
167
|
+
|
|
147
168
|
synced_ids_of_related_records = records.map(&:synced_id)
|
|
148
169
|
instrument("dionysus.consume.#{topic}.batch_number_#{batch_number}.persist.persist_to_many_relationship.#{relationship_name}.resolve_to_many_association") do
|
|
149
170
|
parent_model_record.resolve_to_many_association(relationship_name, synced_ids_of_related_records)
|
|
@@ -25,6 +25,18 @@ class Dionysus::Consumer::SynchronizableModel < SimpleDelegator
|
|
|
25
25
|
(synced_at && event_updated_at && event_updated_at >= synced_at) || synced_at.nil? || event_updated_at.nil?
|
|
26
26
|
end
|
|
27
27
|
|
|
28
|
+
# A purge stamps the cancel column without bumping synced_updated_at, so under a stale payload a tie
|
|
29
|
+
# on the child's timestamp is how a cancelled child gets revived. Demand demonstrably newer.
|
|
30
|
+
# An unstamped child is refused outright: a payload the guard has already rejected proves nothing
|
|
31
|
+
# about a child it carries no timestamp for, and applying one would resurrect a child that a fresher
|
|
32
|
+
# payload had already deleted. Refusing it is exactly what the old blanket `next` did.
|
|
33
|
+
def advances_dionysus_state?(event_updated_at)
|
|
34
|
+
return false if event_updated_at.nil?
|
|
35
|
+
|
|
36
|
+
persist_with_dionysus?(event_updated_at) &&
|
|
37
|
+
!(synced_at && event_updated_at == synced_at)
|
|
38
|
+
end
|
|
39
|
+
|
|
28
40
|
def assign_attributes_from_dionysus(attributes)
|
|
29
41
|
public_send("#{synced_data_attribute}=", attributes)
|
|
30
42
|
reverse_mapping = config.attributes_mapping_for_model(model.model_name).to_a.to_h(&:reverse)
|
|
@@ -10,7 +10,7 @@ class Dionysus::Producer::Config
|
|
|
10
10
|
:genesis_consistency_safety_delay, :hermes_event_producer, :publish_after_commit, :outbox_worker_publishing_delay,
|
|
11
11
|
:high_priority_sidekiq_queue, :observers_inline_maximum_size, :remove_consecutive_duplicates_before_publishing,
|
|
12
12
|
:include_serialized_at_in_payload, :publish_with_uncached_reads, :publish_consistent_snapshots,
|
|
13
|
-
:max_snapshot_attempts
|
|
13
|
+
:max_snapshot_attempts, :republish_deduplicated_records, :republish_deduplicated_records_delay
|
|
14
14
|
|
|
15
15
|
def self.default_sidekiq_queue
|
|
16
16
|
:dionysus
|
|
@@ -137,4 +137,19 @@ class Dionysus::Producer::Config
|
|
|
137
137
|
|
|
138
138
|
false
|
|
139
139
|
end
|
|
140
|
+
|
|
141
|
+
# Publish the survivor of a collapsed run of duplicates once more, after a delay, so a payload
|
|
142
|
+
# that may have been serialized across a write is followed by one read after the writes settled.
|
|
143
|
+
# Off by default; does nothing unless remove_consecutive_duplicates_before_publishing is also on.
|
|
144
|
+
def republish_deduplicated_records
|
|
145
|
+
return @republish_deduplicated_records if defined?(@republish_deduplicated_records)
|
|
146
|
+
|
|
147
|
+
false
|
|
148
|
+
end
|
|
149
|
+
|
|
150
|
+
# Has to outlast the burst of writes that produced the duplicates, or the republish is serialized
|
|
151
|
+
# inside the same contended window it exists to escape.
|
|
152
|
+
def republish_deduplicated_records_delay
|
|
153
|
+
(@republish_deduplicated_records_delay || 30).to_d.seconds
|
|
154
|
+
end
|
|
140
155
|
end
|
|
@@ -5,6 +5,10 @@ class Dionysus::Producer::Outbox::DuplicatesFilter
|
|
|
5
5
|
new(records_to_publish).call
|
|
6
6
|
end
|
|
7
7
|
|
|
8
|
+
def self.deduplicated_records(records_to_publish)
|
|
9
|
+
new(records_to_publish).deduplicated_records
|
|
10
|
+
end
|
|
11
|
+
|
|
8
12
|
attr_reader :records_to_publish
|
|
9
13
|
private :records_to_publish
|
|
10
14
|
|
|
@@ -13,13 +17,23 @@ class Dionysus::Producer::Outbox::DuplicatesFilter
|
|
|
13
17
|
end
|
|
14
18
|
|
|
15
19
|
def call
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
20
|
+
consecutive_runs.flat_map(&:last)
|
|
21
|
+
end
|
|
22
|
+
|
|
23
|
+
# The survivor of every run that collapsed something: the record was written again while an
|
|
24
|
+
# earlier message for it was still queued.
|
|
25
|
+
def deduplicated_records
|
|
26
|
+
consecutive_runs.select { |run| run.size > 1 }.map(&:last)
|
|
19
27
|
end
|
|
20
28
|
|
|
21
29
|
private
|
|
22
30
|
|
|
31
|
+
def consecutive_runs
|
|
32
|
+
@consecutive_runs ||= records_to_publish
|
|
33
|
+
.slice_when { |record_1, record_2| generate_uniqueness_key(record_1) != generate_uniqueness_key(record_2) }
|
|
34
|
+
.to_a
|
|
35
|
+
end
|
|
36
|
+
|
|
23
37
|
def generate_uniqueness_key(record)
|
|
24
38
|
[record.resource_class, record.resource_id, record.event_name, record.topic]
|
|
25
39
|
end
|
|
@@ -23,6 +23,7 @@ class Dionysus::Producer::Outbox::RecordsProcessor
|
|
|
23
23
|
end
|
|
24
24
|
published_records = records - failed_records
|
|
25
25
|
mark_as_published(published_records)
|
|
26
|
+
schedule_republishes(records, failed_records)
|
|
26
27
|
records
|
|
27
28
|
end
|
|
28
29
|
|
|
@@ -36,6 +37,29 @@ class Dionysus::Producer::Outbox::RecordsProcessor
|
|
|
36
37
|
Dionysus::Producer::Outbox::DuplicatesFilter.call(records)
|
|
37
38
|
end
|
|
38
39
|
|
|
40
|
+
# `retry_at` rather than a future `created_at`: it is honoured exactly, whereas `created_at` is
|
|
41
|
+
# offset by `outbox_worker_publishing_delay` and feeds `publishing_latency`.
|
|
42
|
+
def schedule_republishes(records, failed_records)
|
|
43
|
+
return unless config.republish_deduplicated_records
|
|
44
|
+
return unless config.remove_consecutive_duplicates_before_publishing
|
|
45
|
+
|
|
46
|
+
republish_at = Time.current + config.republish_deduplicated_records_delay
|
|
47
|
+
deduplicated = Dionysus::Producer::Outbox::DuplicatesFilter.deduplicated_records(records)
|
|
48
|
+
|
|
49
|
+
(deduplicated - failed_records).each do |record|
|
|
50
|
+
next if record.observer?
|
|
51
|
+
|
|
52
|
+
outbox_model.create!(
|
|
53
|
+
resource_class: record.resource_class,
|
|
54
|
+
resource_id: record.resource_id,
|
|
55
|
+
event_name: record.event_name,
|
|
56
|
+
partition_key: record.partition_key,
|
|
57
|
+
topic: record.topic,
|
|
58
|
+
retry_at: republish_at
|
|
59
|
+
)
|
|
60
|
+
end
|
|
61
|
+
end
|
|
62
|
+
|
|
39
63
|
def publish(record)
|
|
40
64
|
if record.observer?
|
|
41
65
|
outbox_publisher.publish_observers(record)
|
data/lib/dionysus/version.rb
CHANGED
metadata
CHANGED
|
@@ -1,14 +1,14 @@
|
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
|
2
2
|
name: dionysus-rb
|
|
3
3
|
version: !ruby/object:Gem::Version
|
|
4
|
-
version: 1.
|
|
4
|
+
version: 1.6.0
|
|
5
5
|
platform: ruby
|
|
6
6
|
authors:
|
|
7
7
|
- Karol Galanciak
|
|
8
8
|
autorequire:
|
|
9
9
|
bindir: bin
|
|
10
10
|
cert_chain: []
|
|
11
|
-
date: 2026-
|
|
11
|
+
date: 2026-09-01 00:00:00.000000000 Z
|
|
12
12
|
dependencies:
|
|
13
13
|
- !ruby/object:Gem::Dependency
|
|
14
14
|
name: activerecord
|