dining-table 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e2bb002b4a0ab18643810cb14fb3790d285b384
-  data.tar.gz: 0578437ede4fe83f41814a2c4d99ee898b52a953
+  metadata.gz: 5624a9625e338420410c971d0d7d14105cddd1a9
+  data.tar.gz: 55197b3b204db1726e9678761b490e4c26266f67
 SHA512:
-  metadata.gz: 882749ff1912bd3c9467c334f9a5abfa4eaf48e0b3a43fccb2595a74c1a50e77318720952e2a1ded192e4b75e63ccf51a7c6a307c78084bfb7cd6c791a973a6e
-  data.tar.gz: abffd0f5edd5d89312482265a01b3fd2cafe6a73c20bb9f405a5bf37e35a2b6b1960c087f7fee9676f643c20bcea2ea09a0de7a7f0ef38b299b4a281ef88db5a
+  metadata.gz: cb6e4942a3224b25c866977ae72a1759e6793d49564848d6ee7a417351a9b92bdf4655757f8589c16ae9388b79bf3c7560cb09f9b268b1d4e75b50807ddf3011
+  data.tar.gz: 1a3d5ee3346a3d7ee25f30fb28e45a003f3f656f607af4e4ce19c0af713a01fc7fcf70dbd4f4282b6fe3da507840fe706c92cf19e439cc2284115f0b9d7f8b9d

data/README.md

@@ -95,7 +95,7 @@ class CarTable < DiningTable::Table
 end
 ```
 
-Please note how the collection passed in when creating the table obect (`@cars` in `CarTable.new(@cars, self)`) is available as `collection`.
+Please note how the collection passed in when creating the table object (`@cars` in `CarTable.new(@cars, self)`) is available as `collection`.
 
 Similarly to `skip_header`, if for some reason you don't want a footer (even though at least one column defines one), call `skip_footer`:
 
@@ -107,6 +107,15 @@ class CarTable < DiningTable::Table
   end
 end
 ```
+#### Empty collection
+
+Note that when the collection to be presented in the table is empty, `dining-table` can't determine table headers 
+that aren't explicitly specified as there are no objects to use with `human_attribute_name`. In order to avoid this 
+edge case, you can pass in the class of the objects normally present in the collection when creating the table:
+
+```ruby
+<%= CarTable.new(@cars, self, class: Car).render %>
+```
 
 ### Links and view helpers
 

data/VERSION

@@ -1 +1 @@
-1.0.0
+1.1.0

data/dining-table.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Juwelier::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: dining-table 1.0.0 ruby lib
+# stub: dining-table 1.1.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "dining-table".freeze
-  s.version = "1.0.0"
+  s.version = "1.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Micha\u{eb}l Van Damme".freeze]
-  s.date = "2018-06-17"
+  s.date = "2018-11-28"
   s.description = "Easily output tabular data, be it in HTML, CSV or XLSX. Create clean table classes instead of messing with views to create nice tables.".freeze
   s.email = "michael.vandamme@vub.ac.be".freeze
   s.extra_rdoc_files = [

data/lib/dining-table/columns/column.rb

@@ -26,6 +26,7 @@ module DiningTable
           label = determine_label(:header)
           return label if label
           object_class = table.collection.first.class if table.collection.first
+          object_class ||= table.object_class if !object_class
           object_class.human_attribute_name( name ) if object_class && object_class.respond_to?( :human_attribute_name )
         end
       end

data/lib/dining-table/table.rb

@@ -48,6 +48,10 @@ module DiningTable
       self.no_footer = true
     end
 
+    def object_class
+      options[:class]
+    end
+
     private
     
       # auxiliary function

data/spec/html_table_spec.rb

@@ -36,7 +36,19 @@ describe 'HTMLTableSpec' do
       end
     end
   end
-  
+
+  it "correctly renders a table's header when the table body is empty and a class is provided" do
+    html = CarTable.new([], nil, :class => CarWithHumanAttributeName).render
+    doc = document( html )
+    [ 'Brand', 'Number of doors', 'Stock' ].each_with_index do |header, col_index|
+      xpath = "/table/thead/tr[1]/th[#{ col_index + 1 }]"
+      check_not_empty(doc.elements, xpath)
+      doc.elements.each(xpath) do |element|
+        element.text.must_equal header
+      end
+    end
+  end
+
   it "correctly renders a table's header when explicit headers are defined" do
     @cars = CarWithHumanAttributeName.collection
     html = CarTableWithHeader.new(@cars, @view_context).render
@@ -55,6 +67,23 @@ describe 'HTMLTableSpec' do
     end
   end
 
+  it "correctly renders a table's header when explicit headers are defined and the table body is empty" do
+    html = CarTableWithHeader.new([], @view_context).render
+    doc = document( html )
+    [ 'The brand', 'The number of doors' ].each_with_index do |header, col_index|
+      xpath = "/table/thead/tr[1]/th[#{ col_index + 1 }]"
+      check_not_empty(doc.elements, xpath)
+      doc.elements.each(xpath) do |element|
+        element.text.must_equal header
+      end
+    end
+    # last header has link
+    doc.elements.each("/table/thead/tr[1]/th[3]/a") do |element|
+      element.text.must_equal 'Stock'
+      element.attributes.get_attribute('href').value.must_equal "http://www.google.com"
+    end
+  end
+
   it "correctly renders a table's footer when footers are defined" do
     @cars = CarWithHumanAttributeName.collection
     html = CarTableWithFooter.new(@cars, @view_context).render

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dining-table
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Michaël Van Damme
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-17 00:00:00.000000000 Z
+date: 2018-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler