dineromail 0.1.4 → 0.2.0

data/lib/dineromail/notification.rb

@@ -2,15 +2,15 @@ require 'happymapper'
 module Dineromail
   class Notification
     include HappyMapper
-    
+
     tag 'operacion'
-    element :transaction_id, Integer, :tag => 'id'
+    element :transaction_id, String, :tag => 'id'
     element :type, String, :tag => 'tipo'
-    
+
     def initialize(options = {})
       @options = options.symbolize_keys
     end
-    
+
     def status_report
       unless @status_report
         @status_report = StatusReport.get_report_for(transaction_id,@options)
@@ -18,21 +18,31 @@ module Dineromail
       @status_report
     end
     
+    def transaction_id
+      #If the transaction_id being used is the string representation 
+      #of an integer return an integer for backward compatibility
+      if @transaction_id =~ /\A\d+\Z/
+        @transaction_id.to_i
+      else
+        @transaction_id
+      end
+    end
+
     def valid_report?
       status_report.valid_report?
     end
-    
+
     def method_missing(symbol, *args)
       unless status_report.operations.empty?
         status_report.operations.first.send(symbol, *args)
       end
     end
-    
+
     def self.parse(xml)
       #Convert tags to lowercase
       xml = xml.gsub(/<(.*?)[> ]/){|tag| tag.downcase}
       super(xml)
     end
-    
+
   end
-end
+end

data/lib/dineromail/operation.rb

@@ -4,7 +4,7 @@ module Dineromail
     include HappyMapper
     
     tag 'operacion'
-    element :transaction_id, Integer, :tag => 'id'
+    element :transaction_id, String, :tag => 'id'
     element :date, DateTime, :tag => 'fecha'
     element :status, Integer, :tag => 'estado'
     element :amount, Float, :tag => 'monto'
@@ -30,5 +30,15 @@ module Dineromail
       status == CANCELLED_STATUS
     end
     
+    def transaction_id
+      #If the transaction_id being used is the string representation 
+      #of an integer return an integer for backward compatibility
+      if @transaction_id =~ /\A\d+\Z/
+        @transaction_id.to_i
+      else
+        @transaction_id
+      end
+    end
+    
   end
 end

data/lib/dineromail/status_report.rb

@@ -4,8 +4,6 @@ require 'dineromail/buyer'
 require 'dineromail/operation'
 module Dineromail
   class StatusReport
-    attr_accessor :transaction_id
-    
     include HappyMapper
     
     tag 'reporte'

data/lib/dineromail/version.rb

@@ -1,3 +1,3 @@
 module Dineromail
-  VERSION = "0.1.4"
+  VERSION = "0.2.0"
 end

data/spec/dineromail/notification_spec.rb

@@ -9,6 +9,12 @@ describe Dineromail::Notification do
     notifications.last.transaction_id.should == 5547
   end
   
+  it 'should allow alphanumeric transaction ids' do
+    notification_xml = File.read( 'spec/fixtures/notification_alphanumeric_id.xml')
+    notifications = Dineromail::Notification.parse(notification_xml)
+    notifications.first.transaction_id.should == 'ABC123'
+  end
+  
   it 'should get automaticaly the status data associated with the notification' do
     HTTParty.stub!(:get).and_return {
       stub :body => File.read( 'spec/fixtures/status_report.xml')

data/spec/dineromail/status_report_spec.rb

@@ -36,6 +36,13 @@ describe Dineromail::StatusReport do
     item.unit_price.should == 6.9
   end
   
+  it 'should allow alphanumeric transaction ids' do
+    xml = File.read( 'spec/fixtures/status_report_alphanumeric_id.xml')
+    status_report = Dineromail::StatusReport.parse(xml)
+    operation = status_report.operations.first
+    operation.transaction_id.should == 'ABC123'
+  end
+  
   it 'should use the configuration to get the parameters for the request if no options are given' do
     transaction_id = 42
     Dineromail.configure do |c|

data/spec/fixtures/notification_alphanumeric_id.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<NOTIFICACION>
+    <TIPONOTIFICACION>1</TIPONOTIFICACION>
+    <OPERACIONES>
+        <OPERACION>
+            <TIPO>1</TIPO>
+            <ID>ABC123</ID>
+        </OPERACION>
+    </OPERACIONES>
+</NOTIFICACION>

data/spec/fixtures/status_report.xml

@@ -5,7 +5,7 @@
         <OPERACIONES>
             <OPERACION>
                 <ID>1889</ID>
-                <FECHA>01/28/2011 12:02:01 PM</FECHA>
+                <FECHA>28/01/2011 12:02:01 PM</FECHA>
                 <ESTADO>1</ESTADO>
                 <NUMTRANSACCION>67777</NUMTRANSACCION>
                 <COMPRADOR>

data/spec/fixtures/status_report_alphanumeric_id.xml

@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<REPORTE>
+    <ESTADOREPORTE>1</ESTADOREPORTE>
+    <DETALLE>
+        <OPERACIONES>
+            <OPERACION>
+                <ID>ABC123</ID>
+                <FECHA>28/01/2011 12:02:01 PM</FECHA>
+                <ESTADO>1</ESTADO>
+                <NUMTRANSACCION>67777</NUMTRANSACCION>
+                <COMPRADOR>
+                    <EMAIL>comprador@email.com</EMAIL>
+                    <DIRECCION>San Martin 10</DIRECCION>
+                    <COMENTARIO>comentario</COMENTARIO>
+                    <NOMBRE>Juan</NOMBRE>
+                    <TELEFONO>4444444</TELEFONO>
+                    <TIPODOC>DNI</TIPODOC>
+                    <NUMERODOC>222222222</NUMERODOC>
+                </COMPRADOR>
+                <MONTO>60.2</MONTO>
+                <MONTONETO>50.3</MONTONETO>
+                <METODOPAGO>TARJETA DE CREDITO</METODOPAGO>
+                <MEDIOPAGO>VISA</MEDIOPAGO>
+                <CUOTAS>1</CUOTAS>
+                <ITEMS>
+                    <ITEM>
+                        <DESCRIPCION>Libro</DESCRIPCION>
+                        <MONEDA>1</MONEDA>
+                        <PRECIOUNITARIO>6.90</PRECIOUNITARIO>
+                        <CANTIDAD>2</CANTIDAD>
+                    </ITEM>
+                </ITEMS>
+                <VENDEDOR>
+                    <TIPODOC></TIPODOC>
+                    <NUMERODOC></NUMERODOC>
+                </VENDEDOR>
+            </OPERACION>
+        </OPERACIONES>
+    </DETALLE>
+</REPORTE>

metadata

@@ -1,122 +1,93 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: dineromail
-version: !ruby/object:Gem::Version 
-  hash: 19
-  prerelease: false
-  segments: 
-  - 0
-  - 1
-  - 4
-  version: 0.1.4
+version: !ruby/object:Gem::Version
+  version: 0.2.0
+  prerelease: 
 platform: ruby
-authors: 
+authors:
 - Nicolas Mosconi
 - Shadi Calcagni
 - Juan Pablo Gutierrez
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-09-05 00:00:00 -03:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-07-18 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: happymapper
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &82024490 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: httparty
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *82024490
+- !ruby/object:Gem::Dependency
+  name: httparty
+  requirement: &82111890 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: rails
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *82111890
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: &82111490 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 3
-        - 0
-        version: "3.0"
+      - !ruby/object:Gem::Version
+        version: '3.0'
   type: :runtime
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: bundler
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  version_requirements: *82111490
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: &82111210 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: rspec-rails
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  version_requirements: *82111210
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: &82110980 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id005
-- !ruby/object:Gem::Dependency 
-  name: rspec2-rails-views-matchers
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  version_requirements: *82110980
+- !ruby/object:Gem::Dependency
+  name: rspec2-rails-views-matchers
+  requirement: &82110760 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id006
+  prerelease: false
+  version_requirements: *82110760
 description: Integration with dineromail plataform for rails projects
-email: 
+email:
 - nicolas@soluciones-simplex.com.ar
 - shadi@soluciones-simplex.com.ar
 - juanpablo@soluciones-simplex.com.ar
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - Gemfile
 - LICENSE
@@ -135,42 +106,34 @@ files:
 - spec/dineromail/notification_spec.rb
 - spec/dineromail/status_report_spec.rb
 - spec/fixtures/notification.xml
+- spec/fixtures/notification_alphanumeric_id.xml
 - spec/fixtures/status_report.xml
+- spec/fixtures/status_report_alphanumeric_id.xml
 - spec/helpers/dineromail_helper_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
-homepage: ""
+homepage: ''
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: Dineromail library for Rails
 test_files: []
-
+has_rdoc: