dimensions-rails 1.0.1 → 1.0.2

data/README.md

@@ -1,6 +1,14 @@
 # Dimensions::Rails
 
-Use [dimensions](http://github.com/sstephenson/dimensions) by [@sstephenson](http://github.com/sstephenson) to add automatic images size and improve browser rendering.
+```erb
+<%= image_tag 'logo.png' %>
+```
+
+```html
+<img src="/assets/logo.png" width="230" height="80">
+```
+
+It uses [dimensions](http://github.com/sstephenson/dimensions) by [@sstephenson](http://github.com/sstephenson) to add automatic images size and improve browser rendering.
 
 ### How this improves browser rendering?
 

data/Rakefile

@@ -7,3 +7,6 @@ APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
 load 'rails/tasks/engine.rake'
 
 Bundler::GemHelper.install_tasks
+
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new :default

data/lib/dimensions-rails/version.rb

@@ -1,5 +1,5 @@
 module Dimensions
   module Rails
-    VERSION = '1.0.1'
+    VERSION = '1.0.2'
   end
 end

data/lib/dimensions-rails.rb

@@ -14,9 +14,11 @@ module Dimensions
       # https://developers.google.com/speed/docs/best-practices/rendering#SpecifyImageDimensions
       # 
       def image_tag source, options = {}
-        unless options[:size]
-          fs_path = asset_paths.asset_for(source, nil).to_path
-          options[:width], options[:height] = ::Dimensions.dimensions(fs_path)
+        unless options[:size] or options[:width] or options[:height]
+          fs_path = asset_paths.asset_for(source, nil)
+          if fs_path.present?
+            options[:width], options[:height] = ::Dimensions.dimensions(fs_path.to_path)
+          end
         end
         super
       end

data/spec/dummy/config/initializers/session_store.rb

@@ -1,6 +1,6 @@
 # Be sure to restart your server when you modify this file.
 
-Dummy::Application.config.session_store :cookie_store, key: '_dummy_session'
+Dummy::Application.config.session_store :cookie_store, :key => '_dummy_session'
 
 # Use the database for sessions instead of the cookie-based default,
 # which shouldn't be used to store highly confidential information

data/spec/dummy/config/initializers/wrap_parameters.rb

@@ -5,7 +5,7 @@
 
 # Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.
 ActiveSupport.on_load(:action_controller) do
-  wrap_parameters format: [:json]
+  wrap_parameters :format => [:json]
 end
 
 # Disable root element in JSON by default.

data/spec/helper/dimensions-rails_spec.rb

@@ -1,9 +1,15 @@
 require 'spec_helper'
 
-describe ApplicationHelper, type: :helper do
+describe ApplicationHelper, :type => :helper do
   it 'adds size to images' do
     tag = helper.image_tag('rails.png')
     tag.should match('height="64"')
     tag.should match('width="50"')
   end
+  
+  it "works with a missing image" do
+    tag = helper.image_tag('missing.png')
+    tag.should_not match('height=')
+    tag.should_not match('width=')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dimensions-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-24 00:00:00.000000000 Z
+date: 2012-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dimensions
-  requirement: &70139268408120 !ruby/object:Gem::Requirement
+  requirement: &70147771669520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70139268408120
+  version_requirements: *70147771669520
 - !ruby/object:Gem::Dependency
   name: railties
-  requirement: &70139268407560 !ruby/object:Gem::Requirement
+  requirement: &70147775777000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70139268407560
+  version_requirements: *70147775777000
 - !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: &70139268407060 !ruby/object:Gem::Requirement
+  requirement: &70147775784920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70139268407060
+  version_requirements: *70147775784920
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70139268406580 !ruby/object:Gem::Requirement
+  requirement: &70147775797240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70139268406580
+  version_requirements: *70147775797240
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &70139268422460 !ruby/object:Gem::Requirement
+  requirement: &70147775795360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,10 +65,10 @@ dependencies:
         version: '3.0'
   type: :development
   prerelease: false
-  version_requirements: *70139268422460
+  version_requirements: *70147775795360
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &70139268422000 !ruby/object:Gem::Requirement
+  requirement: &70147775793480 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,7 +76,7 @@ dependencies:
         version: '2.0'
   type: :development
   prerelease: false
-  version_requirements: *70139268422000
+  version_requirements: *70147775793480
 description: Use dimensions by @sstephenson to add automatic images size and improve
   browser rendering
 email:
@@ -144,7 +144,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3860962919628613806
+      hash: 1184433799985488213
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -153,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3860962919628613806
+      hash: 1184433799985488213
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.17