digits_solver 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4525006e958912fda9a02dcae3bd4f9d1a08003ad4d28c54c8f439cc74407b77
-  data.tar.gz: b7351af8932b86749718e26030be4fc678f9f9637de861aefcf6a51bb6eb82f9
+  metadata.gz: 3cc76291aaef108bc1e004bb3477fddd31520a414a82027be8111ef746add465
+  data.tar.gz: '08302397fba6f31c6c92e8a14e9817f8b2f308c7d0fb2c1e46b17b653a11d20c'
 SHA512:
-  metadata.gz: c1cc800b59af1a3264946bffa754868c6a7e805b614105443be97a0b4c881db0b0f577136db00477b61a7dd794b4c94b28a23a58d763f60d8b9e05f101d7830d
-  data.tar.gz: 6ec3f7bbc27edf3830caf952428266d0136fed2cf66143d9d190b68c31a16c99d260a5940e7033f8df5ff9a7f5d226c0bb4e238b8bc74aaa6cad68693249b599
+  metadata.gz: dd79298b33da986c95ad772b18c3cbad3c8827b2f7e3ab5c76a07fe6d17abb1247000c3d172e557ee78ebcef98bd71df73983348271fe76da0ecea5b240b7fb8
+  data.tar.gz: 7fe1e62a96ce0d064628857740f46e1b4b2d54e88a4988581d0524f614a3bf84a11130d9ad589a74fdfb1158a18a5b80f101d3d2f559dcc8d525e988a19367c3

data/README.md

@@ -6,11 +6,11 @@ The goal of this gem is to solve puzzles à-la [NY Times Digits game](https://ww
 actually know this game under a different name. In France this looks like the calculation part of an almost 50 year old TV
 show named 'Les chiffres et les lettres'...
 
-The goal is to use numbers from the draw combined by any basic operation (+ - / *) to reach that goal. You cannot have negative numbers as result of "-" operation, and can only divide number resulting in an integer.
+The goal is to use numbers from the draw combined by any basic operation (+ - / *) to reach that goal. You cannot have negative numbers as result of "-" operation, and can only divide number resulting into an integer.
 
-This gem implements a brute-force approach to solve the problem but is ready to host alternative strategies.  
-Basically this strategy won't work beyond 7 numbers in the draw (it is limited in the command line at 6 but not within
-the code), as for 7 numbers within the draw it already takes few minutes on my machine. Although this strategy does not
+This gem implements a brute-force approach to solve the problem but is ready to host alternate strategies.  
+Basically this strategy won't work beyond 7 numbers in the draw (it is limited in the command line to 6 numbers but not within
+the code), as for a 7 numbers draw it already takes few minutes on my machine. Although this strategy does not
 stop at the first encountered solution but browses the whole tree of possibilities (that could be easily done).
 
 To go beyond, you would probably have to go for a more mathematical approach...

data/lib/digits_solver/solution.rb

@@ -17,7 +17,6 @@ module DigitsSolver
       @problem_statement = problem_statement
       @operands = operands
       @operations_to_apply = operations_to_apply
-      DigitsSolver.logger.debug "New solution: #{inspect}"
     end
 
     def ==(other)
@@ -58,6 +57,7 @@ module DigitsSolver
     end
 
     def to_evaluable_code
+      # parenthesis management is ... meh, but better than nothing, and at least mathematically correct.
       evaluable_code = operations_to_apply.each.with_index.reduce(operands.first) do |res, (operation, idx)|
         op1 = res
         op2 = operands[idx + 1]

data/lib/digits_solver/solution_set.rb

@@ -11,7 +11,7 @@ module DigitsSolver
       def solve_for(problem_statement, strategy: DEFAULT_STRATEGY)
         extend strategy
         solutions, attempts_count = solve(problem_statement)
-        DigitsSolver.logger.info "Found #{solutions.count} solutions amongst #{attempts_count} tries."
+        DigitsSolver.logger.info "Found #{solutions.count} potentially non unique solutions amongst #{attempts_count} tries."
         new problem_statement, solutions, strategy
       end
     end
@@ -36,6 +36,7 @@ module DigitsSolver
                              .take(nb)
       nb == 1 ? res.first : res
     end
+
     alias best_solutions best_solution
 
     def size
@@ -64,9 +65,20 @@ module DigitsSolver
       @indexed_solutions = {}
       @solutions = []
 
-      solutions.each do |solution|
-        self << solution
+      DigitsSolver.logger.info "#{solutions.count} candidate solutions"
+      discarded_nb = solutions.reduce(0) do |count, solution|
+        if self << solution
+          DigitsSolver.logger.debug "New solution added to solution set: #{solution.to_evaluable_code}"
+          count
+        else
+          count + 1
+        end
       end
+      DigitsSolver.logger.info "Discarded: #{discarded_nb}"
+      msg = "Added #{self.solutions.count} solutions to the set of solutions, "
+      msg += discarded_nb.zero? ? 'none' : discarded_nb.to_s
+      msg += ' were discarded'
+      DigitsSolver.logger.info msg
     end
   end
 end

data/lib/digits_solver/strategies/base.rb

@@ -25,7 +25,7 @@ module DigitsSolver
         ops_a = OPERATIONS.to_a
         number_of_possibilities = nb_operations**max_operations_number
 
-        DigitsSolver.logger.info "number of operations permutations: #{number_of_possibilities}, nb op: #{nb_operations}"
+        DigitsSolver.logger.info "The number of operations permutations for the #{nb_operations} basic operations and a draw of #{max_operations_number + 1} numbers (ie #{max_operations_number} consecutive operations) is #{number_of_possibilities}."
 
         (0...number_of_possibilities).map do |i|
           i.to_s(nb_operations)
@@ -43,16 +43,16 @@ module DigitsSolver
             ops = operations_chain.take(idx + 1)
             operands = ordered_draw.take(idx + 2)
             yield DigitsSolver::Solution.new(problem_statement, operands, ops)
-            break
+            return cur_op_res
+
           end
           cur_op_res
         end
       end
 
       def apply_operation_to_operands(operation, operand1, operand2)
-        res = send(operation, operand1, operand2)
-        DigitsSolver.logger.debug "#{operand1} #{OPERATIONS[operation]} #{operand2} = #{res}"
-        res
+        # wow that's a useful one ;-), at least more understandable
+        send operation, operand1, operand2
       end
 
       def plus(a, b)

data/lib/digits_solver/strategies/brute_force.rb

@@ -13,10 +13,9 @@ module DigitsSolver
         attempts_count = 0
 
         draw.permutation.map do |ordered_draw|
-          DigitsSolver.logger.debug ordered_draw.inspect
+          DigitsSolver.logger.debug "Testing #{ordered_draw.inspect} for all possible chains of operations"
           possible_operations.each do |operations_chain|
             attempts_count += 1
-            DigitsSolver.logger.debug operations_chain.inspect
             begin
               apply_operations_chain_to_ordered_draw(operations_chain, ordered_draw, problem_statement) do |valid_solution|
                 solutions << valid_solution
@@ -26,7 +25,7 @@ module DigitsSolver
             end
           end
         end
-        DigitsSolver.logger.debug "Solutions: #{solutions.inspect}"
+        DigitsSolver.logger.debug "Found #{solutions.count} solutions."
         [solutions, attempts_count]
       end
     end

data/lib/digits_solver/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DigitsSolver
-  VERSION = '0.1.2'
+  VERSION = '0.1.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: digits_solver
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Laurent B.