digicert 0.1.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fdf876cef7eea96750f7678894027221b448f2e6
-  data.tar.gz: fcb2979e844e56a22617647f85d50364d2038b0c
+  metadata.gz: 6c74c249a9270232627bac89c2dd50fafe7e5716
+  data.tar.gz: 437b67f4b9f77b265aa7007bb2e7646cb28f70c8
 SHA512:
-  metadata.gz: dfc0e06614d1e50fe1379855abe21f099574c4af48878c9ea109f5a5ad4b61c4b72fe3f7897c30279683160afcacdb72c7cd6f7daf73d3d25ae86a027bfa7d0d
-  data.tar.gz: c97dc961f495a41aa270e02bcf4cedeedc7cc95071ec5e1a4d6a9230d099fe5fcad3572e8b043bc3f16fb931551df9118703509f01498cef676f2d139953095e
+  metadata.gz: b3996047b941dc247f6499730d0988f8aa0e6c4d9d9cf166ffa0b9044e3800f278e6e8bd859694fb2901bdbcfda476ea6f10237f097602a78a22f31f870520cc
+  data.tar.gz: bb2d9796001e2a277f2e446308b675d27853d0ee1c1754e6ba7917fcdea64868ff7f555ee9c766f4e64e42631d7c47e4d037cfcf426d40c7b18aa41f5d3a6924

data/CHANGELOG.md

@@ -0,0 +1,13 @@
+## 0.2.0 (2017-08-09)
+
+* Fix reissue/duplication issue for custom attribute (PR #124)
+
+## 0.1.2 (2017-05-20)
+
+* Add support for query params in orders (PR #118)
+* Add filter support for digicert resources (PR #120)
+* Expose test stubs and helpers to developer (PR #115)
+
+### 0.1.1 (2017-04-17)
+
+* Initial Release - Fully Functional (PR #112)

data/README.md

@@ -595,13 +595,11 @@ already exists for that order.
 ```ruby
 Digicert::OrderReissuer.create(
   order: order_id,
-  certificate: {
-    common_name: certificate_common_name,
-    dns_names: [certificate_dns_name],
-    csr: certificate_csr,
-    signature_hash: certificate_signature_hash,
-    server_platform: { id: certificate_server_platform_id },
-  }
+  common_name: certificate_common_name,
+  dns_names: [certificate_dns_name],
+  csr: certificate_csr,
+  signature_hash: certificate_signature_hash,
+  server_platform: { id: certificate_server_platform_id },
 )
 ```
 
@@ -615,13 +613,11 @@ hash. The common name and sans need to be the same as the original order.
 ```ruby
 Digicert::OrderDuplicator.create(
   order: order_id,
-  certificate: {
-    common_name: certificate_common_name,
-    dns_names: [certificate_dns_name],
-    csr: certificate_csr,
-    signature_hash: certificate_signature_hash,
-    server_platform: { id: certificate_server_platform_id },
-  }
+  common_name: certificate_common_name,
+  dns_names: [certificate_dns_name],
+  csr: certificate_csr,
+  signature_hash: certificate_signature_hash,
+  server_platform: { id: certificate_server_platform_id },
 )
 ```
 

data/lib/digicert/order_manager.rb

@@ -11,18 +11,16 @@ module Digicert
     private
 
     def validate(attributes)
-      order_attributes.merge(attributes)
+      { certificate: order_attributes.merge(attributes) }
     end
 
     def order_attributes
       {
-        certificate: {
-          common_name: order.certificate.common_name,
-          dns_names: order.certificate.dns_names,
-          csr: order.certificate.csr,
-          signature_hash: order.certificate.signature_hash,
-          server_platform: { id: order.certificate.server_platform.id },
-        },
+        common_name: order.certificate.common_name,
+        dns_names: order.certificate.dns_names,
+        csr: order.certificate.csr,
+        signature_hash: order.certificate.signature_hash,
+        server_platform: { id: order.certificate.server_platform.id },
       }
     end
 

data/lib/digicert/version.rb

@@ -21,5 +21,5 @@
 # ++
 
 module Digicert
-  VERSION = "0.1.2".freeze
+  VERSION = "0.2.0".freeze
 end

data/spec/acceptance/duplicating_certificate_spec.rb

@@ -67,13 +67,11 @@ RSpec.describe "Certificate Order Duplication" do
 
   def certificate_attributes
     {
-      certificate: {
-        common_name: order.certificate.common_name,
-        dns_names: order.certificate.dns_names,
-        csr: order.certificate.csr,
-        signature_hash: order.certificate.signature_hash,
-        server_platform: { id: order.certificate.server_platform.id },
-      },
+      common_name: order.certificate.common_name,
+      dns_names: order.certificate.dns_names,
+      csr: order.certificate.csr,
+      signature_hash: order.certificate.signature_hash,
+      server_platform: { id: order.certificate.server_platform.id },
     }
   end
 

data/spec/acceptance/reissuing_certificate_spec.rb

@@ -13,9 +13,9 @@ RSpec.describe "Re-issuing a certificate" do
     # Reissue an existing certificate order, it
     # usages the order_id from the existing order
     #
-    stub_digicert_order_reissue_api(order.id, new_order_attributes)
+    stub_digicert_order_reissue_api(order.id, certificate_attributes)
     reissued_order = Digicert::OrderReissuer.create(
-      order_id: order.id, **new_order_attributes,
+      order_id: order.id, **certificate_attributes,
     )
 
     # Retrieve the request details from the
@@ -76,15 +76,13 @@ RSpec.describe "Re-issuing a certificate" do
     }
   end
 
-  def new_order_attributes
+  def certificate_attributes
     {
-      certificate: {
-        common_name: order.certificate.common_name,
-        dns_names: order.certificate.dns_names,
-        csr: order.certificate.csr,
-        signature_hash: order.certificate.signature_hash,
-        server_platform: { id: order.certificate.server_platform.id },
-      },
+      common_name: order.certificate.common_name,
+      dns_names: order.certificate.dns_names,
+      csr: order.certificate.csr,
+      signature_hash: order.certificate.signature_hash,
+      server_platform: { id: order.certificate.server_platform.id },
     }
   end
 

data/spec/digicert/order_duplicator_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Digicert::OrderDuplicator do
     it "creates a duplicate of an existing order" do
       stub_digicert_order_fetch_api(order_id)
 
-      stub_digicert_order_duplicate_api(order_id, order_attributes)
+      stub_digicert_order_duplicate_api(order_id, certificate_attributes)
       order = Digicert::OrderDuplicator.create(order_id: order_id)
 
       expect(order.id).not_to be_nil
@@ -17,15 +17,13 @@ RSpec.describe Digicert::OrderDuplicator do
     123_456_789
   end
 
-  def order_attributes
+  def certificate_attributes
     {
-      certificate: {
-        common_name: order.certificate.common_name,
-        dns_names: order.certificate.dns_names,
-        csr: order.certificate.csr,
-        signature_hash: order.certificate.signature_hash,
-        server_platform: { id: order.certificate.server_platform.id },
-      },
+      common_name: order.certificate.common_name,
+      dns_names: order.certificate.dns_names,
+      csr: order.certificate.csr,
+      signature_hash: order.certificate.signature_hash,
+      server_platform: { id: order.certificate.server_platform.id },
     }
   end
 

data/spec/digicert/order_reissuer_spec.rb

@@ -2,14 +2,30 @@ require "spec_helper"
 
 RSpec.describe Digicert::OrderReissuer do
   describe ".create" do
-    it "reissue an existing order" do
-      stub_digicert_order_fetch_api(order_id)
+    context "without custom attributes" do
+      it "reissues with existing order attributes" do
+        stub_digicert_order_fetch_api(order_id)
+        stub_digicert_order_reissue_api(order_id, certificate_attributes)
 
-      stub_digicert_order_reissue_api(order_id, order_attributes)
-      order = Digicert::OrderReissuer.create(order_id: order_id)
+        order = Digicert::OrderReissuer.create(order_id: order_id)
 
-      expect(order.id).not_to be_nil
-      expect(order.requests.first.id).not_to be_nil
+        expect(order.id).not_to be_nil
+        expect(order.requests.first.id).not_to be_nil
+      end
+    end
+
+    context "with custom attributes" do
+      it "reissues with merging the existing and custom attributes" do
+        stub_digicert_order_fetch_api(order_id)
+        stub_digicert_order_reissue_api(order_id, certificate_attributes)
+
+        order = Digicert::OrderReissuer.create(
+          order_id: order_id, **certificate_attributes
+        )
+
+        expect(order.id).not_to be_nil
+        expect(order.requests.first.id).not_to be_nil
+      end
     end
   end
 
@@ -21,15 +37,17 @@ RSpec.describe Digicert::OrderReissuer do
     @order ||= Digicert::Order.fetch(order_id)
   end
 
-  def order_attributes
+  def certificate_attributes
     {
-      certificate: {
-        common_name: order.certificate.common_name,
-        dns_names: order.certificate.dns_names,
-        csr: order.certificate.csr,
-        signature_hash: order.certificate.signature_hash,
-        server_platform: { id: order.certificate.server_platform.id },
-      },
+      common_name: order.certificate.common_name,
+      dns_names: order.certificate.dns_names,
+      csr: order.certificate.csr,
+      signature_hash: order.certificate.signature_hash,
+      server_platform: { id: order.certificate.server_platform.id },
     }
   end
+
+  def new_attributes
+    @new_attributes ||= certificate_attributes.merge(signature_hash: "sha512")
+  end
 end

data/spec/support/fake_digicert_api.rb

@@ -198,7 +198,7 @@ module Digicert
       stub_api_response(
         :post,
         ["order", "certificate", order_id, "reissue"].join("/"),
-        data: attributes,
+        data: { certificate: attributes },
         filename: "order_reissued",
         status: 201,
       )
@@ -208,7 +208,7 @@ module Digicert
       stub_api_response(
         :post,
         ["order", "certificate", order_id, "duplicate"].join("/"),
-        data: attributes,
+        data: { certificate: attributes },
         filename: "order_duplicated",
         status: 201,
       )

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: digicert
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-20 00:00:00.000000000 Z
+date: 2017-08-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: r509
@@ -122,6 +122,7 @@ files:
 - ".sample.env"
 - ".sample.pryrc"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt