digicert 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 55bfc7916ddf2ce78f11cbbe178e6b7e0417778d
-  data.tar.gz: ae7b474592b1f669afe8df47cb58dd04ee61af8d
+  metadata.gz: fdf876cef7eea96750f7678894027221b448f2e6
+  data.tar.gz: fcb2979e844e56a22617647f85d50364d2038b0c
 SHA512:
-  metadata.gz: 5adb81424d8b251143a7aef3711837044ae8aa51257fed7e16b4e4794676aa88ea1bd0a9cd598e80671883d057453da401519928b20744a5014371d2f71d7851
-  data.tar.gz: 4c4d35432a65cd9e0fbc862a4dd3b9df6541927fa78b3f5cdf77593b776d887aabca4d2bf1ada3729dd2dabec7dfadb702dbecf281ea3c663e76c889f7aff6db
+  metadata.gz: dfc0e06614d1e50fe1379855abe21f099574c4af48878c9ea109f5a5ad4b61c4b72fe3f7897c30279683160afcacdb72c7cd6f7daf73d3d25ae86a027bfa7d0d
+  data.tar.gz: c97dc961f495a41aa270e02bcf4cedeedc7cc95071ec5e1a4d6a9230d099fe5fcad3572e8b043bc3f16fb931551df9118703509f01498cef676f2d139953095e

data/.rubocop.yml

@@ -1,4 +1,6 @@
 AllCops:
+  TargetRubyVersion: 2.3
+
   Exclude:
     - db/schema.rb
 
@@ -351,6 +353,9 @@ Style/StringLiterals:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#consistent-string-literals'
   EnforcedStyle: double_quotes
   Enabled: true
+  SupportedStyles:
+    - single_quotes
+    - double_quotes
 
 Style/FrozenStringLiteralComment:
   Enabled: false

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in digicert.gemspec
 gemspec

data/README.md

@@ -4,6 +4,8 @@
 Status](https://travis-ci.org/riboseinc/digicert.svg?branch=master)](https://travis-ci.org/riboseinc/digicert)
 [![Code
 Climate](https://codeclimate.com/github/riboseinc/digicert/badges/gpa.svg)](https://codeclimate.com/github/riboseinc/digicert)
+[![Gem
+Version](https://badge.fury.io/rb/digicert.svg)](https://badge.fury.io/rb/digicert)
 
 The Ruby client for the official Digicert API.
 
@@ -515,6 +517,35 @@ Use this interface to retrieve a list of all certificate orders.
 Digicert::Order.all
 ```
 
+This interface also supports query params like `limit`, `offset`, `sort` and
+filters. We can use those to retrieve more precised orders.
+
+```ruby
+Digicert::Order.all(
+  limit: 20,
+  offset: 0,
+  sort: 'date_created',
+
+  filters: {
+    status: "approved",
+    common_name: "ribosetest.com"
+  }
+)
+```
+
+There is also another interface `.filter`, which is basically an alias around
+the `.all` interface but it passes each of the argument as a filters attributes
+
+```ruby
+Digicert::Order.filter(status: "approved", common_name: "ribosetest.com")
+
+# Similar functionality with all interface
+#
+Digicert::Order.all(
+  filters: { status: "approved", common_name: "ribosetest.com" }
+)
+```
+
 #### List of Email Validations
 
 Use this interface to view the status of all emails that require validation on a

data/bin/rspec

@@ -8,8 +8,9 @@
 #
 
 require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path(
+  "../../Gemfile", Pathname.new(__FILE__).realpath
+)
 
 require "rubygems"
 require "bundler/setup"

data/lib/digicert.rb

@@ -40,4 +40,7 @@ require "digicert/duplicate_certificate_finder"
 require "digicert/certificate"
 
 module Digicert
+  def self.root
+    File.dirname(__dir__)
+  end
 end

data/lib/digicert/actions/all.rb

@@ -7,7 +7,7 @@ module Digicert
 
       def all
         response = Digicert::Request.new(
-          :get, resource_path, params: query_params,
+          :get, resource_path, params: query_params
         ).parse
 
         response[resources_key]
@@ -18,8 +18,12 @@ module Digicert
       end
 
       module ClassMethods
-        def all(filter_params = {})
-          new(params: filter_params).all
+        def all(query_params = {})
+          new(params: query_params).all
+        end
+
+        def filter(filter_params = {})
+          new(params: { filters: filter_params }).all
         end
       end
     end

data/lib/digicert/actions/create.rb

@@ -7,7 +7,7 @@ module Digicert
 
       def create
         Digicert::Request.new(
-          :post, resource_creation_path, validate(attributes),
+          :post, resource_creation_path, validate(attributes)
         ).parse
       end
 

data/lib/digicert/actions/fetch.rb

@@ -7,7 +7,7 @@ module Digicert
 
       def fetch
         Digicert::Request.new(
-          :get, [resource_path, resource_id].join("/"), params: query_params,
+          :get, [resource_path, resource_id].join("/"), params: query_params
         ).parse
       end
 

data/lib/digicert/actions/update.rb

@@ -7,7 +7,7 @@ module Digicert
 
       def update
         Digicert::Request.new(
-          :put, resource_update_path, attributes,
+          :put, resource_update_path, attributes
         ).run
       end
 

data/lib/digicert/certificate.rb

@@ -22,7 +22,7 @@ module Digicert
 
     def download_to_path(path:, ext: "zip", **attributes)
       certificate_downloader.fetch_to_path(
-        resource_id, attributes.merge(path: path, ext: ext),
+        resource_id, attributes.merge(path: path, ext: ext)
       )
     end
 

data/lib/digicert/client_certificate/premium.rb

@@ -6,7 +6,7 @@ module Digicert
       private
 
       def certificate_type
-        "client_premium_sha2"
+        "client_premium"
       end
 
       def validate_certificate(csr:, **attributes)

data/lib/digicert/csr_generator.rb

@@ -27,7 +27,7 @@ module Digicert
 
     def r509_attributes_hash
       { key: rsa_key, subject: subject_items, san_names: san_names }.
-        reject { |key, value| value.nil? || value.empty? }
+        reject { |_key, value| value.nil? || value.empty? }
     end
 
     def subject_items

data/lib/digicert/domain.rb

@@ -11,13 +11,13 @@ module Digicert
 
     def activate
       request_klass.new(
-        :put, [resource_path, resource_id, "activate"].join("/"),
+        :put, [resource_path, resource_id, "activate"].join("/")
       ).parse
     end
 
     def deactivate
       request_klass.new(
-        :put, [resource_path, resource_id, "deactivate"].join("/"),
+        :put, [resource_path, resource_id, "deactivate"].join("/")
       ).parse
     end
 
@@ -50,7 +50,7 @@ module Digicert
       required_attributes = {
         name: name,
         organization: organization,
-        validations: validate_validations(validations)
+        validations: validate_validations(validations),
       }
 
       required_attributes.merge(attributes)

data/lib/digicert/email_validation.rb

@@ -10,7 +10,7 @@ module Digicert
 
     def self.valid?(token:, email:)
       response = Digicert::Request.new(
-        :put, ["email-validation", token].join("/"), params: {email: email }
+        :put, ["email-validation", token].join("/"), params: { email: email }
       ).run
 
       response.code.to_i == 204

data/lib/digicert/errors.rb

@@ -14,7 +14,7 @@ module Digicert
         Errno::ECONNRESET,
         Net::OpenTimeout,
         SocketError,
-        Net::HTTPServerError
+        Net::HTTPServerError,
       ]
     end
 

data/lib/digicert/errors/request_error.rb

@@ -9,7 +9,7 @@ module Digicert
       end
 
       def message
-        <<-MSG.gsub(/^ {8}/, '')
+        <<-MSG.gsub(/^ {8}/, "")
         #{explanation}:
         #{response_body}
         MSG
@@ -28,7 +28,8 @@ module Digicert
       attr_reader :msg
 
       def response_body
-        JSON[msg] rescue {}
+        JSON[msg]
+      rescue {}
       end
     end
   end

data/lib/digicert/order_cancellation.rb

@@ -4,7 +4,7 @@ module Digicert
   class OrderCancellation < Digicert::Base
     def create
       request_klass.new(
-        :put, resource_path, default_attributes.merge(attributes),
+        :put, resource_path, default_attributes.merge(attributes)
       ).run
     end
 

data/lib/digicert/order_manager.rb

@@ -22,7 +22,7 @@ module Digicert
           csr: order.certificate.csr,
           signature_hash: order.certificate.signature_hash,
           server_platform: { id: order.certificate.server_platform.id },
-        }
+        },
       }
     end
 

data/lib/digicert/organization.rb

@@ -34,7 +34,7 @@ module Digicert
         first_name: first_name,
         last_name: last_name,
         email: email,
-        telephone: telephone
+        telephone: telephone,
       }
 
       required_attributes.merge(attrs)

data/lib/digicert/request.rb

@@ -1,6 +1,8 @@
 require "uri"
 require "json"
 require "net/http"
+
+require "digicert/util"
 require "digicert/response"
 require "digicert/errors"
 
@@ -65,7 +67,7 @@ module Digicert
       URI::HTTPS.build(
         host: Digicert.configuration.api_host,
         path: digicert_api_path_with_base,
-        query: build_query_params
+        query: build_query_params,
       )
     end
 
@@ -82,13 +84,13 @@ module Digicert
     def set_request_headers!(request)
       request.initialize_http_header(
         "Content-Type" => "application/json",
-        "X-DC-DEVKEY" => Digicert.configuration.api_key
+        "X-DC-DEVKEY" => Digicert.configuration.api_key,
       )
     end
 
     def build_query_params
       if @query_params
-        URI.encode_www_form(@query_params)
+        Digicert::Util.to_query(@query_params)
       end
     end
 

data/lib/digicert/response.rb

@@ -1,5 +1,5 @@
 require "json"
-require 'ostruct'
+require "ostruct"
 
 module Digicert
   class Response
@@ -26,5 +26,5 @@ module Digicert
     end
   end
 
-  class ResponseObject < OpenStruct;end
+  class ResponseObject < OpenStruct; end
 end

data/lib/digicert/rspec.rb

@@ -0,0 +1,21 @@
+# Test Helpers for RSpec
+#
+# Actual API requests are slow and expensive and we try not to make actual
+# API request when possible. For most of our tests we mock the API call which
+# verifies the endpoint, http verb and headers and based on those it responses
+# with an identical fixture file.
+#
+# The main purpose of this file is to allow you to use our test helpers by
+# simplify adding this file to your application and then use the available
+# helper  method when necessary.
+#
+# Please check `spec/support` directory to see the available helper methods.
+#
+# We do not include this module with the gem by default, but you can do so
+# by adding `require "digicert/rspec"` on top of your `spec_helpe` file.
+#
+require File.join(Digicert.root, "spec/support/fake_digicert_api.rb")
+
+RSpec.configure do |config|
+  config.include Digicert::FakeDigicertApi
+end

data/lib/digicert/ssl_certificate/base.rb

@@ -3,7 +3,6 @@ require "digicert/base_order"
 module Digicert
   module SSLCertificate
     class Base < Digicert::BaseOrder
-
     end
   end
 end

data/lib/digicert/util.rb

@@ -0,0 +1,34 @@
+require "cgi"
+
+module Digicert
+  class Util
+    def to_query(query)
+      build_query(query).flatten.join("&")
+    end
+
+    def self.to_query(query)
+      new.to_query(query)
+    end
+
+    private
+
+    def build_query(value, key = nil)
+      if value.is_a?(Hash)
+        build_recursive_query(value, key)
+      else
+        build_escaped_key_value_pair(key, value)
+      end
+    end
+
+    def build_recursive_query(query, namespace = nil)
+      query.map do |key, value|
+        query_key = namespace ? "#{namespace}[#{key}]" : key
+        build_query(value, query_key)
+      end
+    end
+
+    def build_escaped_key_value_pair(key, value)
+      [CGI.escape(key.to_s), CGI.escape(value.to_s)].join("=")
+    end
+  end
+end

data/lib/digicert/version.rb

@@ -21,5 +21,5 @@
 # ++
 
 module Digicert
-  VERSION = "0.1.1".freeze
+  VERSION = "0.1.2".freeze
 end

data/spec/acceptance/duplicating_certificate_spec.rb

@@ -73,7 +73,7 @@ RSpec.describe "Certificate Order Duplication" do
         csr: order.certificate.csr,
         signature_hash: order.certificate.signature_hash,
         server_platform: { id: order.certificate.server_platform.id },
-      }
+      },
     }
   end
 

data/spec/acceptance/reissuing_certificate_spec.rb

@@ -32,7 +32,7 @@ RSpec.describe "Re-issuing a certificate" do
     #
     if request.status == "pending"
       stub_digicert_certificate_request_update_api(
-        request_id, request_status_attributes,
+        request_id, request_status_attributes
       )
 
       Digicert::CertificateRequest.update(request_id, request_status_attributes)
@@ -84,7 +84,7 @@ RSpec.describe "Re-issuing a certificate" do
         csr: order.certificate.csr,
         signature_hash: order.certificate.signature_hash,
         server_platform: { id: order.certificate.server_platform.id },
-      }
+      },
     }
   end
 

data/spec/digicert/actions/all_spec.rb

@@ -3,12 +3,40 @@ require "digicert/base"
 
 RSpec.describe "Digicert::Actions::ALL" do
   describe ".all" do
-    it "retrieves the list of resources" do
-      stub_digicert_organization_list_api
-      organizations = Digicert::TestAllAction.all
+    context "with out query param" do
+      it "retrieves the list of resources" do
+        stub_digicert_organization_list_api
+        organizations = Digicert::TestAllAction.all
 
-      expect(organizations.count).to eq(2)
-      expect(organizations.first.name).not_to be_nil
+        expect(organizations.count).to eq(2)
+        expect(organizations.first.name).not_to be_nil
+      end
+    end
+
+    context "with specificed query params" do
+      it "pass the params and retrieve the list of resources" do
+        query_params = { limit: 2, offset: 0, sort: "date_created" }
+
+        stub_digicert_organization_list_api(query_params)
+        organizations = Digicert::TestAllAction.all(query_params)
+
+        expect(organizations.count).to eq(2)
+        expect(organizations.first.name).not_to be_nil
+      end
+    end
+  end
+
+  describe ".filter" do
+    context "with filters params" do
+      it "retrieves the filterered resources" do
+        filters = { status: "approved" }
+        stub_digicert_organization_list_api(filters: filters)
+
+        organizations = Digicert::TestAllAction.filter(filters)
+
+        expect(organizations.count).to eq(2)
+        expect(organizations.first.name).not_to be_nil
+      end
     end
   end
 

data/spec/digicert/actions/update_spec.rb

@@ -7,11 +7,11 @@ RSpec.describe "Digicert::Actions::Update" do
     it "updates the resource attributes" do
       resource_id = 123_456_789
       stub_digicert_certificate_request_update_api(
-        resource_id, certificate_status_attributes,
+        resource_id, certificate_status_attributes
       )
 
       resource = Digicert::TestUpdateAction.update(
-        resource_id, certificate_status_attributes,
+        resource_id, certificate_status_attributes
       )
 
       expect(resource.code.to_i).to eq(204)

data/spec/digicert/certificate_downloader_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe Digicert::CertificateDownloader do
       stub_digicert_certificate_download_by_platform(certificate_id, platform)
 
       certificate = Digicert::CertificateDownloader.fetch(
-        certificate_id, platform: platform,
+        certificate_id, platform: platform
       )
 
       expect(certificate.code.to_i).to eq(200)
@@ -24,7 +24,7 @@ RSpec.describe Digicert::CertificateDownloader do
 
       stub_digicert_certificate_download_by_platform(certificate_id)
       Digicert::CertificateDownloader.fetch_to_path(
-        certificate_id, path: download_path, ext: "zip",
+        certificate_id, path: download_path, ext: "zip"
       )
 
       download_url = [download_path, "certificate.zip"].join("/")
@@ -39,7 +39,7 @@ RSpec.describe Digicert::CertificateDownloader do
 
       stub_digicert_certificate_download_by_platform(certificate_id, platform)
       certificate = Digicert::CertificateDownloader.fetch_by_platform(
-        certificate_id, platform: platform,
+        certificate_id, platform: platform
       )
 
       expect(certificate.code.to_i).to eq(200)
@@ -54,7 +54,7 @@ RSpec.describe Digicert::CertificateDownloader do
 
       stub_digicert_certificate_download_by_format(certificate_id, format)
       certificate = Digicert::CertificateDownloader.fetch_by_format(
-        certificate_id, format: format,
+        certificate_id, format: format
       )
 
       expect(certificate.code.to_i).to eq(200)

data/spec/digicert/certificate_request_spec.rb

@@ -29,11 +29,11 @@ RSpec.describe Digicert::CertificateRequest do
     it "updates the specified ceritfiicate request status" do
       request_id = 123_456_789
       stub_digicert_certificate_request_update_api(
-        request_id, request_status_attributes,
+        request_id, request_status_attributes
       )
 
       status_update = Digicert::CertificateRequest.update(
-        request_id, request_status_attributes,
+        request_id, request_status_attributes
       )
 
       expect(status_update.code).to eq("204")

data/spec/digicert/certificate_spec.rb

@@ -82,7 +82,7 @@ RSpec.describe Digicert::Certificate do
       stub_digicert_certificate_revoke_api(certificate_id, comments: comments)
 
       revocation = Digicert::Certificate.revoke(
-        certificate_id, comments: comments,
+        certificate_id, comments: comments
       )
 
       expect(revocation.id).not_to be_nil

data/spec/digicert/client_certificate/digital_signature_plus_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe Digicert::ClientCertificate::DigitalSignaturePlus do
   describe ".create" do
     it "creates a new order for a digital signature plus certificate" do
       stub_digicert_order_create_api(
-        "client_digital_signature_plus", order_attributes,
+        "client_digital_signature_plus", order_attributes
       )
 
       order = Digicert::ClientCertificate::DigitalSignaturePlus.create(

data/spec/digicert/client_certificate/email_security_plus_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe Digicert::ClientCertificate::EmailSecurityPlus do
   describe ".create" do
     it "creates a new order for a email security plus certificate" do
       stub_digicert_order_create_api(
-        "client_email_security_plus", order_attributes,
+        "client_email_security_plus", order_attributes
       )
 
       order = Digicert::ClientCertificate::EmailSecurityPlus.create(

data/spec/digicert/client_certificate/premium_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 RSpec.describe Digicert::ClientCertificate::Premium do
   describe ".create" do
     it "creates a new order for a client premium certificate" do
-      stub_digicert_order_create_api("client_premium_sha2", order_attributes)
+      stub_digicert_order_create_api("client_premium", order_attributes)
       order = Digicert::ClientCertificate::Premium.create(order_attributes)
 
       expect(order.id).not_to be_nil

data/spec/digicert/domain_spec.rb

@@ -38,7 +38,7 @@ RSpec.describe Digicert::Domain do
   describe ".fetch" do
     it "retrieves the specific domain" do
       domain_id = 123_456_789
-      filters = { include_dcv: true, include_validation: true}
+      filters = { include_dcv: true, include_validation: true }
 
       stub_digicert_domain_fetch_api(domain_id, filters)
       domain = Digicert::Domain.fetch(domain_id, filters)
@@ -80,7 +80,7 @@ RSpec.describe Digicert::Domain do
       validations: [
         {
           type: "ev",
-          user: { id: 12 }
+          user: { id: 12 },
         },
       ],
       dcv: { method: "email" },

data/spec/digicert/order_duplicator_spec.rb

@@ -25,7 +25,7 @@ RSpec.describe Digicert::OrderDuplicator do
         csr: order.certificate.csr,
         signature_hash: order.certificate.signature_hash,
         server_platform: { id: order.certificate.server_platform.id },
-      }
+      },
     }
   end
 

data/spec/digicert/order_reissuer_spec.rb

@@ -29,7 +29,7 @@ RSpec.describe Digicert::OrderReissuer do
         csr: order.certificate.csr,
         signature_hash: order.certificate.signature_hash,
         server_platform: { id: order.certificate.server_platform.id },
-      }
+      },
     }
   end
 end

data/spec/digicert/order_spec.rb

@@ -15,13 +15,27 @@ RSpec.describe Digicert::Order do
   end
 
   describe ".all" do
-    it "retrieves the list of all certificate orders" do
-      stub_digicert_order_list_api
-      orders = Digicert::Order.all
+    context "without any query params" do
+      it "retrieves the list of all certificate orders" do
+        stub_digicert_order_list_api
+        orders = Digicert::Order.all
+
+        expect(orders.first.id).not_to be_nil
+        expect(orders.first.status).to eq("issued")
+        expect(orders.first.certificate.common_name).to eq("digicert.com")
+      end
+    end
+
+    context "with specified query params" do
+      it "retrieves the filtered list of certificate orders" do
+        query_params = { limit: 3, offset: 0, sort: "date_created" }
+        stub_digicert_order_list_api(query_params)
+
+        orders = Digicert::Order.all(query_params)
 
-      expect(orders.first.id).not_to be_nil
-      expect(orders.first.status).to eq("issued")
-      expect(orders.first.certificate.common_name).to eq("digicert.com")
+        expect(orders.count).to eq(query_params[:limit])
+        expect(orders.first.certificate.common_name).to eq("digicert.com")
+      end
     end
   end
 
@@ -61,7 +75,7 @@ RSpec.describe Digicert::Order do
       order.reissue
 
       expect(
-        Digicert::OrderReissuer
+        Digicert::OrderReissuer,
       ).to have_received(:create).with(order_id: order_id)
     end
   end
@@ -75,7 +89,7 @@ RSpec.describe Digicert::Order do
       order.duplicate
 
       expect(
-        Digicert::OrderDuplicator
+        Digicert::OrderDuplicator,
       ).to have_received(:create).with(order_id: order_id)
     end
   end
@@ -89,7 +103,7 @@ RSpec.describe Digicert::Order do
       order.duplicate_certificates
 
       expect(
-        Digicert::DuplicateCertificate
+        Digicert::DuplicateCertificate,
       ).to have_received(:all).with(order_id: order_id)
     end
   end
@@ -105,7 +119,7 @@ RSpec.describe Digicert::Order do
       order.cancel(note: note)
 
       expect(
-        Digicert::OrderCancellation
+        Digicert::OrderCancellation,
       ).to have_received(:create).with(order_id: order_id, note: note)
     end
   end

data/spec/digicert/request_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe Digicert::Request do
         stub_invalid_ping_request_via_get
         request = Digicert::Request.new(:get, "ping")
 
-        expect{ request.run }.to raise_error(/not_found\|route/)
+        expect { request.run }.to raise_error(/not_found\|route/)
       end
     end
   end

data/spec/digicert/util_spec.rb

@@ -0,0 +1,26 @@
+require "cgi"
+require "spec_helper"
+
+RSpec.describe Digicert::Util do
+  describe ".to_query" do
+    context "plain hash with key and value" do
+      it "builds and returns the queryable params" do
+        params = { limit: 10, sort: "date_created" }
+        query_params = Digicert::Util.to_query(params)
+
+        expect(query_params).to eq("limit=10&sort=date_created")
+      end
+    end
+
+    context "with nested hash as key" do
+      it "resolves it and returns the queryable params" do
+        params = { limit: 10, filters: { status: "issued", search: "ribose" } }
+        query_params = Digicert::Util.to_query(params)
+
+        expect(
+          CGI.unescape(query_params),
+        ).to eq("limit=10&filters[status]=issued&filters[search]=ribose")
+      end
+    end
+  end
+end

data/spec/requests/certificate_reissuing_spec.rb

@@ -3,7 +3,6 @@ require "spec_helper"
 RSpec.describe "Reissuing Certificate" do
   describe "reissue" do
     it "reissues an existing nonexpired certificate", api_call: true do
-
       # This tests will find the last created certificate order and
       # then will try to reissue that, but one important thing to note
       # that digicert only allows expects active certificate to reissue

data/spec/requests/domain_management_spec.rb

@@ -42,7 +42,7 @@ RSpec.describe "Domain Management" do
       dcv: { method: "email" },
       name: ribose_test_domain,
       organization: { id: organization_id },
-      validations: [{ type: "OV", user: { id: administrator_id }}],
+      validations: [{ type: "OV", user: { id: administrator_id } }],
     }
   end
 

data/spec/requests/order_client_email_security_plus_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe "Order client email security plus" do
       # interface with `product_name_id` and required attributes
       #
       order_request = Digicert::Order.create(
-        product_name_id, order_attributes,
+        product_name_id, order_attributes
       )
 
       puts order_request

data/spec/requests/order_client_premium_certificate_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+
+RSpec.describe "Client Premium Certificate" do
+  describe "ordering a client premium certificate", api_call: true do
+    it "creates a new order or a client's premium certificate" do
+      product_name_id = "client_premium"
+
+      # Reqeust a new certificate using the order creation
+      # interface by providing t`name_id` and required attributes
+      #
+      order_request = Digicert::Order.create(
+        product_name_id, order_attributes
+      )
+
+      # Retrieve order details using the order_request id as
+      # it should contains the `certifcate`, so we then can
+      # download the generated certificate
+      #
+      order = Digicert::Order.fetch(order_request.id)
+
+      expect(order.product.name).to eq("Premium")
+      expect(order.certificate.common_name).to eq(common_name)
+      expect(order.organization.display_name).to eq(ribose_inc.display_name)
+    end
+  end
+
+  def common_name
+    "Awesome People"
+  end
+
+  def order_attributes
+    {
+      validity_years: 1,
+      certificate: certificate_attributes,
+      organization: { id: ribose_inc.id },
+    }
+  end
+
+  def ribose_inc
+    @ribose_inc ||= Digicert::Organization.all.first
+  end
+
+  def certificate_attributes
+    {
+      common_name: common_name,
+      signature_hash: "sha256",
+      emails: [awesomepeople_email],
+      csr: csr_content_for_ribosetest,
+    }
+  end
+
+  def domain
+    "ribosetest.com"
+  end
+
+  def awesomepeople_email
+    ["awesomepeople", domain].join("@")
+  end
+
+  def csr_content_for_ribosetest
+    @csr_content ||= Digicert::CSRGenerator.generate(
+      common_name: common_name, organization: ribose_inc,
+    )
+  end
+end

data/spec/requests/order_ssl_ev_plus_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe "Order SSl EV Plus" do
       # interface by providing t`name_id` and required attributes
       #
       order_request = Digicert::Order.create(
-        product_name_id, order_attributes,
+        product_name_id, order_attributes
       )
 
       # Retrieve order details using the order_request id as
@@ -45,7 +45,7 @@ RSpec.describe "Order SSl EV Plus" do
       common_name: common_name,
       signature_hash: "sha256",
       csr: csr_content_for_ribosetest,
-      server_platform: { id: 2 }
+      server_platform: { id: 2 },
     }
   end
 

data/spec/requests/order_ssl_wildcard_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe "Order SSLWildcard" do
       # interface by providing t`name_id` and required attributes
       #
       order_request = Digicert::Order.create(
-        product_name_id, order_attributes,
+        product_name_id, order_attributes
       )
 
       # Retrieve order details using the order_request id as

data/spec/spec_helper.rb

@@ -1,7 +1,9 @@
 require "dotenv/load"
 require "webmock/rspec"
 require "bundler/setup"
+
 require "digicert"
+require "digicert/rspec"
 
 Dir["./spec/support/**/*.rb"].sort.each { |file| require file }
 
@@ -30,6 +32,4 @@ RSpec.configure do |config|
     Digicert.configuration.debug_mode = true
     WebMock.allow_net_connect!
   end
-
-  config.include Digicert::FakeDigicertApi
 end

data/spec/support/fake_digicert_api.rb

@@ -2,19 +2,19 @@ module Digicert
   module FakeDigicertApi
     def stub_digicert_product_list_api
       stub_api_response(
-        :get, "product", filename: "products", status: 200,
+        :get, "product", filename: "products", status: 200
       )
     end
 
     def stub_digicert_product_fetch_api(name_id)
       stub_api_response(
-        :get, ["product", name_id].join("/"), filename: "product", status: 200,
+        :get, ["product", name_id].join("/"), filename: "product", status: 200
       )
     end
 
     def stub_digicert_certificate_request_list_api
       stub_api_response(
-        :get, "request", filename: "certificate_requests", status: 200,
+        :get, "request", filename: "certificate_requests", status: 200
       )
     end
 
@@ -49,25 +49,31 @@ module Digicert
 
     def stub_digicert_order_fetch_api(order_id)
       stub_api_response(
-        :get, ["order/certificate", order_id].join("/"), filename: "order",
+        :get, ["order/certificate", order_id].join("/"), filename: "order"
       )
     end
 
-    def stub_digicert_order_list_api
+    def stub_digicert_order_list_api(params = {})
       stub_api_response(
-        :get, "order/certificate", filename: "orders", status: 200,
+        :get,
+        path_with_query("order/certificate", params),
+        filename: "orders",
+        status: 200,
       )
     end
 
     def stub_digicert_certificate_order_fetch_api(order_id)
       stub_api_response(
-        :get, ["order/certificate", order_id].join("/"), filename: "order",
+        :get, ["order/certificate", order_id].join("/"), filename: "order"
       )
     end
 
-    def stub_digicert_organization_list_api
+    def stub_digicert_organization_list_api(params = {})
       stub_api_response(
-        :get, "organization", filename: "organizations", status: 200,
+        :get,
+        path_with_query("organization", params),
+        filename: "organizations",
+        status: 200,
       )
     end
 
@@ -83,7 +89,7 @@ module Digicert
 
     def stub_digicert_organization_fetch_api(id)
       stub_api_response(
-        :get, ["organization", id].join("/"), filename: "organization",
+        :get, ["organization", id].join("/"), filename: "organization"
       )
     end
 
@@ -117,13 +123,13 @@ module Digicert
 
     def stub_digicert_container_list_api
       stub_api_response(
-        :get, "container", filename: "containers", status: 200,
+        :get, "container", filename: "containers", status: 200
       )
     end
 
     def stub_digicert_container_fetch_api(container_id)
       stub_api_response(
-        :get, ["container", container_id].join("/"), filename: "container",
+        :get, ["container", container_id].join("/"), filename: "container"
       )
     end
 
@@ -139,7 +145,7 @@ module Digicert
 
     def stub_digicert_domain_list_api(filters = {})
       stub_api_response(
-        :get, path_with_query("domain", filters), filename: "domains",
+        :get, path_with_query("domain", filters), filename: "domains"
       )
     end
 
@@ -283,7 +289,7 @@ module Digicert
     end
 
     def path_with_query(path, params)
-      query_params = params.map { |key, value| "#{key}=#{value}" }.join("&")
+      query_params = Digicert::Util.to_query(params)
       [path, query_params].join("?")
     end
 
@@ -310,13 +316,13 @@ module Digicert
     def api_key_header
       {
         "Content-Type" => "application/json",
-        "X-DC-DEVKEY" => Digicert.configuration.api_key
+        "X-DC-DEVKEY" => Digicert.configuration.api_key,
       }
     end
 
     def digicert_fixture(filename)
       file_name = [filename, "json"].join(".")
-      file_path = ["../../", "fixtures", file_name].join("/")
+      file_path = File.join(Digicert.root, "spec", "fixtures", file_name)
 
       File.read(File.expand_path(file_path, __FILE__))
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: digicert
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-17 00:00:00.000000000 Z
+date: 2017-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: r509
@@ -173,10 +173,12 @@ files:
 - lib/digicert/product.rb
 - lib/digicert/request.rb
 - lib/digicert/response.rb
+- lib/digicert/rspec.rb
 - lib/digicert/ssl_certificate/base.rb
 - lib/digicert/ssl_certificate/ssl_ev_plus.rb
 - lib/digicert/ssl_certificate/ssl_plus.rb
 - lib/digicert/ssl_certificate/ssl_wildcard.rb
+- lib/digicert/util.rb
 - lib/digicert/version.rb
 - spec/acceptance/certificate_download_spec.rb
 - spec/acceptance/duplicating_certificate_spec.rb
@@ -211,6 +213,7 @@ files:
 - spec/digicert/ssl_certificate/ssl_ev_plus_spec.rb
 - spec/digicert/ssl_certificate/ssl_plus_spec.rb
 - spec/digicert/ssl_certificate/ssl_wildcard_spec.rb
+- spec/digicert/util_spec.rb
 - spec/fixtures/certificate.pem
 - spec/fixtures/certificate.zip
 - spec/fixtures/certificate_request.json
@@ -247,6 +250,7 @@ files:
 - spec/requests/container_management_spec.rb
 - spec/requests/domain_management_spec.rb
 - spec/requests/order_client_email_security_plus_spec.rb
+- spec/requests/order_client_premium_certificate_spec.rb
 - spec/requests/order_management_spec.rb
 - spec/requests/order_ssl_ev_plus_spec.rb
 - spec/requests/order_ssl_wildcard_spec.rb