digestifier 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d3a5586226e9c9c2d3873fa148109906568a72bd
-  data.tar.gz: f0028131bb564be48fb02c89914559727834f6fd
+  metadata.gz: bc2bff6ead8753dd54d921694f2b63d050a75c04
+  data.tar.gz: e12e3a4577b2402543f642a8f912fb391888d9e8
 SHA512:
-  metadata.gz: ae5bb559b00b5e577bf18a91f16398abe0dca5a330806cf553764c44fbc79af499aa54cc72c1e45e7e10e82ccb7ad2707c565aae63da26bb955f34dca7412fa7
-  data.tar.gz: cd7b5a66c3e5592c834ce79380d28ded690e079a36e80814af27a77d1b78f1f3243c14211980a94fa5708398f70b6fb1984a5f46afddef32dca271df9b6f57e0
+  metadata.gz: 0caf0b5098f15efe9f3c3778a45e67c6fa981f9e35f7623023c8dfb80c1e5828f5938ae1d2f2d9563e07e2f27b1b304b09f68c2169334325327b3c5266d6f803
+  data.tar.gz: d8a0bc60a634fde41e4cfdd03f36d71d4ce606647df4f3fd954706ab9001bef5a5073626b22bfd5cef71b0e38116942d65a87691b03cc99f820667956561cfe9

data/README.md

@@ -6,7 +6,7 @@ A simple Rails engine for sending out email digests of activity.
 
 Add this line to your application's Gemfile:
 
-    gem 'digestifier', '0.0.2'
+    gem 'digestifier', '0.0.3'
 
 Don't forget to bundle:
 
@@ -58,6 +58,12 @@ task :send_digest => :environment do
 end
 ```
 
+You can test sending an email to a specific recipient using the following code:
+
+```ruby
+Digestifier::Delivery.new(DIGEST, recipient).deliver
+```
+
 ### Customising partial templates
 
 This step is almost certainly essential: you'll want to customise how each item in your digest is presented. The partials for this should be located in `app/views/digestifier/mailer`, and use the item's class name, downcased and underscored (for example: `_article.html.erb` or `_comment.html.haml`).
@@ -82,6 +88,16 @@ The two instance variables you have access to are `@recipient` and `@content_ite
 <% end %>
 ```
 
+Also: you'll very likely want to customise the email's subject - this is done via Rails' internationalisation:
+
+```yaml
+en:
+  digestifier:
+    mailer:
+      digest:
+        subject: "The Latest News"
+```
+
 ### Customising the mailer
 
 If you want to put your own Mailer, then this is certainly possible:

data/app/models/digestifier/setting.rb

@@ -5,8 +5,7 @@ class Digestifier::Setting < ActiveRecord::Base
 
   serialize :preferences, JSON
 
-  validates :recipient,   presence: true
-  validates :preferences, presence: true
+  validates :recipient, presence: true
 
   def self.for(recipient)
     where(

data/db/migrate/3_add_enabled_to_settings.rb

@@ -0,0 +1,6 @@
+class AddEnabledToSettings < ActiveRecord::Migration
+  def change
+    add_column :digestifier_settings, :enabled, :boolean, default: true,
+      null: false
+  end
+end

data/digestifier.gemspec

@@ -1,7 +1,7 @@
 # coding: utf-8
 Gem::Specification.new do |spec|
   spec.name          = 'digestifier'
-  spec.version       = '0.0.2'
+  spec.version       = '0.0.3'
   spec.authors       = ['Pat Allan']
   spec.email         = ['pat@freelancing-gods.com']
   spec.summary       = 'Digests as a Rails Engine'

data/lib/digestifier/delivery.rb

@@ -1,7 +1,7 @@
 class Digestifier::Delivery
   def self.deliver(digest)
     digest.recipients.call.find_each do |recipient|
-      new(digest, recipient).deliver
+      new(digest, recipient).deliver_and_capture
     end
   end
 
@@ -9,9 +9,19 @@ class Digestifier::Delivery
     @digest, @recipient = digest, recipient
   end
 
+  def capture
+    Digestifier::Receipt.capture recipient
+  end
+
   def deliver
+    return unless settings.enabled?
+
     Digestifier.mailer.digest(recipient, contents).deliver
-    Digestifier::Receipt.capture recipient
+  end
+
+  def deliver_and_capture
+    deliver
+    capture
   end
 
   private
@@ -25,7 +35,6 @@ class Digestifier::Delivery
   end
 
   def frequency
-    settings = Digestifier::Setting.for recipient
     return default_frequency unless settings.preferences['frequency']
 
     settings.preferences['frequency']
@@ -35,4 +44,8 @@ class Digestifier::Delivery
     receipt = Digestifier::Receipt.last_for(recipient)
     receipt.nil? ? frequency.ago : receipt.captured_at
   end
+
+  def settings
+    @settings ||= Digestifier::Setting.for recipient
+  end
 end

data/spec/acceptance/recipient_preferences_spec.rb

@@ -29,4 +29,18 @@ describe 'Custom digest frequency' do
     expect(mail.body).to match(/Recent Post/)
     expect(mail.body).to_not match(/Old Post/)
   end
+
+  it 'respects disabled digest preferences' do
+    Article.create! name: 'Recent Post'
+
+    setting = Digestifier::Setting.for(user)
+    setting.enabled = false
+    setting.save!
+
+    Digestifier::Delivery.deliver digest
+
+    ActionMailer::Base.deliveries.detect { |mail|
+      mail.to.include?('me@somewhere.com')
+    }.should be_nil
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: digestifier
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Pat Allan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-09 00:00:00.000000000 Z
+date: 2013-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -88,6 +88,7 @@ files:
 - config.ru
 - db/migrate/1_create_receipts.rb
 - db/migrate/2_create_settings.rb
+- db/migrate/3_add_enabled_to_settings.rb
 - digestifier.gemspec
 - lib/digestifier.rb
 - lib/digestifier/delivery.rb