diffend 0.2.30 → 0.2.35

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52618cdf40375202e18c1cdaa481554084f3b92f337fd61c089e147f0027e982
-  data.tar.gz: 859f390055e3030d3a357b604067e6c05814f653225a802136563be4bc32f9ee
+  metadata.gz: '0780c79922b3857482318780ad968af290af191fd0c59e032f9a0f94d671ad6d'
+  data.tar.gz: d2f91acc6e7ea5d3a59bd8b86c49c5c4d763eff6bf3af3ecf6b00d99730da36b
 SHA512:
-  metadata.gz: 9f17436faa3bdabe77c891c930bb9dac01f426ae715d37035d7727112e221526ac003daa44d196dbb056f4c21bca49589a7799e36bef81db6bf8b3c29012adb5
-  data.tar.gz: 232310953c6dc8cd500aac54b0fd8d7f9980457b40032021b46bf7753f62c8a7d6167486c3e15e0d2e940101b47b8b8cdd8af67577eca7ba626b2db9706724c6
+  metadata.gz: 15ec791f3eea3e174ad8a09d68f9f5b20511e9728c3f4481b9b2c97e377cdb5eb6e0faee215a24979b18f846e8a2bd01cc9569634c4307ccf448e4bcb73e035d
+  data.tar.gz: a5b7b8ab500fa6dcb187f46137d89337bc1f4bd3eaa006c5ba43dada667ffbce01ea61a68678a5f04a211b91cbdc8e73f55fcb3350db7bb74a93dc50d3051cd7

data.tar.gz.sig

@@ -1,4 +1 @@
-P{���hK_�=(�k1��G�d}�g��%���\:U���nC?�_��*{�Z�w�Fz��29�%`bv���*2~��ac�����̮�R�N).
-2A�.΀��I'�/W�pbB�d8|D|JV1�
-�9�����V,@�3�V����H��9���Qk�9|��a�՟�dB�J�3��*h�����\~�~U�9o�{H�c��H���@�ۨ����.H��+�Q������Q��V��ޣ��ڕ
������j�iY/�3B㻧������A���jK��3?��w�݀�]��$���K�
�`��?Y�sl��&eF�
-llj��ժm���eE�En��l�6ԳQԠH�c�r��猁�h�T��u.�����;f��
+�2��oa�)qN���Q�6���@`Sb-��8��!=4

data/.ruby-version

@@ -1 +1 @@
-2.7.1
+2.7.2

data/CHANGELOG.md

@@ -2,6 +2,32 @@
 
 ## [Unreleased][master]
 
+## [0.2.35] (2020-11-04)
+- clean command name and title of a process ([#76](https://github.com/diffend-io/diffend-ruby/pull/76))
+- handle `uninitialized constant #<Class:Diffend::Configs::Fetcher>::ERB` ([#75](https://github.com/diffend-io/diffend-ruby/pull/75))
+
+## [0.2.34] (2020-10-25)
+- handle `Bundler::GitError` ([#72](https://github.com/diffend-io/diffend-ruby/pull/72))
+
+## [0.2.33] (2020-10-25)
+- fix an exception when configuration file is missing ([#65](https://github.com/diffend-io/diffend-ruby/pull/65))
+- silently exit when configuration file is missing in `Diffend::Monitor` ([#66](https://github.com/diffend-io/diffend-ruby/pull/66))
+- introduce default config ([#67](https://github.com/diffend-io/diffend-ruby/pull/67))
+- handle `SocketError` ([#68](https://github.com/diffend-io/diffend-ruby/pull/68))
+
+## [0.2.32] (2020-10-02)
+- fix how we build platform from `Gem::Platform` ([#56](https://github.com/diffend-io/diffend-ruby/pull/56))
+- introduce `Diffend::LatestVersion` ([#57](https://github.com/diffend-io/diffend-ruby/pull/57))
+- refactor `Diffend::Config` ([#58](https://github.com/diffend-io/diffend-ruby/pull/58))
+- set command in `Diffend::Config` ([#59](https://github.com/diffend-io/diffend-ruby/pull/59))
+- introduce `Diffend::Logger` ([#60](https://github.com/diffend-io/diffend-ruby/pull/60))
+- set severity to `FATAL` in `Diffend::Monitor` ([#61](https://github.com/diffend-io/diffend-ruby/pull/61))
+- handle `Bundler::VersionConflict` ([#62](https://github.com/diffend-io/diffend-ruby/pull/62))
+
+## [0.2.31] (2020-09-24)
+- change request timeout to 15 seconds ([#53](https://github.com/diffend-io/diffend-ruby/pull/53))
+- report request issues as warnings ([#54](https://github.com/diffend-io/diffend-ruby/pull/54))
+
 ## [0.2.30] (2020-09-21)
 - handle dependencies resolve issues ([#51](https://github.com/diffend-io/diffend-ruby/pull/51))
 - better detection when to start `Diffend::Monitor` ([#50](https://github.com/diffend-io/diffend-ruby/pull/50))
@@ -72,7 +98,12 @@
 
 - initial release
 
-[master]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.30...HEAD
+[master]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.35...HEAD
+[0.2.35]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.34...v0.2.35
+[0.2.34]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.33...v0.2.34
+[0.2.33]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.32...v0.2.33
+[0.2.32]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.31...v0.2.32
+[0.2.31]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.30...v0.2.31
 [0.2.30]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.29...v0.2.30
 [0.2.29]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.28...v0.2.29
 [0.2.28]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.27...v0.2.28

data/Gemfile

@@ -7,7 +7,5 @@ plugin 'diffend'
 gemspec
 
 group :development, :test do
-  gem 'byebug', platform: :ruby
-  gem 'pry', platform: :jruby
   gem 'rspec'
 end

data/Gemfile.lock

@@ -1,36 +1,26 @@
 PATH
   remote: .
   specs:
-    diffend (0.2.30)
+    diffend (0.2.35)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    byebug (11.1.3)
-    coderay (1.1.3)
     diff-lcs (1.4.4)
-    ffi (1.13.1-java)
-    method_source (1.0.0)
-    pry (0.13.1-java)
-      coderay (~> 1.1)
-      method_source (~> 1.0)
-      spoon (~> 0.0)
     rake (13.0.1)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.2)
-      rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.2)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.0)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
-    spoon (0.0.6)
-      ffi
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.0)
 
 PLATFORMS
   java
@@ -38,9 +28,7 @@ PLATFORMS
 
 DEPENDENCIES
   bundler
-  byebug
   diffend!
-  pry
   rake
   rspec
 

data/config/diffend.yml

@@ -0,0 +1,6 @@
+project_id: <%= ENV['DIFFEND_PROJECT_ID'] %>
+shareable_id: <%= ENV['DIFFEND_SHAREABLE_ID'] %>
+shareable_key: <%= ENV['DIFFEND_SHAREABLE_KEY'] %>
+env: <%= ENV['DIFFEND_ENV'] || 'development' %>
+ignore_errors: <%= ENV['DIFFEND_IGNORE_ERRORS'] || 'true' %>
+development: <%= ENV['DIFFEND_DEVELOPMENT'] || 'true' %>

data/lib/diffend/build_bundler_definition.rb

@@ -6,7 +6,7 @@ module Diffend
     class << self
       # Build clean instance of bundler definition, as we don't want to pollute the main one
       #
-      # @param command [String] bundler command that we are executing
+      # @param command [String] command executed via bundler
       # @param gemfile [String] path to Gemfile
       # @param lockfile [String] path to Gemfile.lock
       #

data/lib/diffend/config.rb

@@ -2,18 +2,79 @@
 
 module Diffend
   # Diffend config object
-  module Config
-    class << self
-      # Build diffend config object
-      #
-      # @return [OpenStruct, nil]
-      #
-      # @raise [Errors::MissingConfigurationFile] when no config file
-      def call
-        Diffend::Config::Fetcher.call(
-          File.expand_path('..', ::Bundler.bin_path)
-        )
-      end
+  class Config
+    attr_reader :project_id, :shareable_id, :shareable_key, :build_path, :env, :command
+
+    # Build diffend config object
+    #
+    # @return [Diffend::Config]
+    def initialize(command: nil, severity: nil, build_path: nil)
+      @log_level = severity
+      build(command, build_path)
+      validate
+    end
+
+    def logger
+      @logger ||= Diffend::Logger.new(@log_level)
+    end
+
+    def ignore_errors?
+      @ignore_errors
+    end
+
+    def development?
+      @development
+    end
+
+    # Provides diffend commands endpoint url
+    #
+    # @return [String]
+    def commands_url
+      return ENV['DIFFEND_COMMANDS_URL'] if ENV.key?('DIFFEND_COMMANDS_URL')
+
+      "https://my.diffend.io/api/projects/#{project_id}/bundle/#{command}"
+    end
+
+    # Provides diffend errors endpoint url
+    #
+    # @return [String]
+    def errors_url
+      return ENV['DIFFEND_ERRORS_URL'] if ENV.key?('DIFFEND_ERRORS_URL')
+
+      "https://my.diffend.io/api/projects/#{project_id}/errors"
+    end
+
+    # @param request_id [String]
+    #
+    # @return [String]
+    def track_url(request_id)
+      "https://my.diffend.io/api/projects/#{project_id}/bundle/#{request_id}/track"
+    end
+
+    private
+
+    def build(command, build_path)
+      build_path ||= File.expand_path('..', ::Bundler.bin_path)
+      hash = Diffend::Configs::Fetcher.call(logger, plugin_path, build_path)
+      hash['build_path'] = build_path
+      hash['command'] = command || build_command
+
+      hash.each { |key, value| instance_variable_set(:"@#{key}", value) }
+    end
+
+    def validate
+      Diffend::Configs::Validator.call(self)
+    end
+
+    # Command that was run with bundle
+    #
+    # @return [String]
+    def build_command
+      ARGV.first || ::Bundler.feature_flag.default_cli_command.to_s
+    end
+
+    def plugin_path
+      Pathname.new(File.expand_path('../..', __dir__))
     end
   end
 end

data/lib/diffend/configs/fetcher.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+%w[
+  erb
+  yaml
+].each(&method(:require))
+
+module Diffend
+  # Module for all the components related to setting up the config
+  module Configs
+    # Class responsible for fetching the config from .diffend.yml
+    module Fetcher
+      class << self
+        # @param logger [Diffend::Logger]
+        # @param plugin_path [String] path of the plugin
+        # @param build_path [String] path of the current build
+        #
+        # @return [Hash] details from configuration file
+        #
+        # @example
+        #   details = Fetcher.new.call('./')
+        #   details.build_path #=> './'
+        def call(logger, plugin_path, build_path)
+          build(plugin_path, build_path)
+        rescue Errors::MalformedConfigurationFile
+          build_malformed_error_message(build_path)
+            .tap(&logger.method(:fatal))
+
+          raise Diffend::Errors::HandledException
+        end
+
+        private
+
+        # @param plugin_path [String] path of the plugin
+        # @param build_path [String] path of the current build
+        #
+        # @return [OpenStruct] open struct with config details
+        def build(plugin_path, build_path)
+          default_config = File.join(plugin_path, 'config', 'diffend.yml')
+          project_config = File.join(build_path, '.diffend.yml')
+
+          hash = read_file(default_config)
+
+          if File.exist?(project_config)
+            hash.merge!(read_file(project_config) || {})
+          end
+
+          hash
+        end
+
+        def read_file(path)
+          YAML.safe_load(ERB.new(File.read(path)).result)
+        rescue Psych::SyntaxError
+          raise Errors::MalformedConfigurationFile
+        end
+
+        # @return [String] malformed configuration file message
+        def build_malformed_error_message
+          <<~MSG
+            \nYour Diffend configuration file is malformed.\n
+            Please re-setup.\n
+          MSG
+        end
+      end
+    end
+  end
+end

data/lib/diffend/configs/validator.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+module Diffend
+  # Module for all the components related to setting up the config
+  module Configs
+    # Class responsible for validating the config from .diffend.yml
+    module Validator
+      KNOWN_KEYS = {
+        project_id: [String],
+        shareable_id: [String],
+        shareable_key: [String],
+        build_path: [String],
+        env: [String],
+        command: [String],
+        ignore_errors?: [TrueClass, FalseClass],
+        development?: [TrueClass, FalseClass]
+      }.freeze
+
+      class << self
+        # @param config [Diffend::Config]
+        def call(config)
+          KNOWN_KEYS.each_key do |key|
+            if missing?(config, key)
+              missing_key_message(key)
+                .tap(&config.logger.method(:fatal))
+
+              raise Diffend::Errors::HandledException
+            end
+
+            if invalid?(config, key)
+              invalid_key_message(config, key)
+                .tap(&config.logger.method(:fatal))
+
+              raise Diffend::Errors::HandledException
+            end
+          end
+        end
+
+        private
+
+        # @param config [Diffend::Config]
+        # @param key [String]
+        #
+        # @return [Boolean] true if we are missing a key, false otherwise
+        def missing?(config, key)
+          value = config.public_send(key)
+
+          value.nil? || (value.respond_to?(:empty?) && value.empty?)
+        end
+
+        # @param config [Diffend::Config]
+        # @param key [String]
+        #
+        # @return [Boolean] true if we are missing a key, false otherwise
+        def invalid?(config, key)
+          !KNOWN_KEYS[key].include?(config.public_send(key).class)
+        end
+
+        # Missing key message
+        #
+        # @param key [String] missing key
+        #
+        # @return [String]
+        def missing_key_message(key)
+          <<~MSG
+            \nDiffend configuration is missing #{key} key.\n
+          MSG
+        end
+
+        # Invalid key message
+        #
+        # @param hash [Hash] config hash
+        # @param key [String] invalid key
+        #
+        # @return [String]
+        def invalid_key_message(hash, key)
+          <<~MSG
+            \nDiffend configuration value for #{key} is invalid.\n
+            It should be #{KNOWN_KEYS[key].join(' or ')} but is #{hash.public_send(key).class}.\n
+          MSG
+        end
+      end
+    end
+  end
+end

data/lib/diffend/errors.rb

@@ -5,10 +5,6 @@ module Diffend
   module Errors
     # Base error class from which all the errors should inherit
     BaseError = Class.new(StandardError)
-    # Raised when we couldn't find a valid configuration file
-    MissingConfigurationFile = Class.new(BaseError)
-    # Raised when configuration file is empty
-    EmptyConfigurationFile = Class.new(BaseError)
     # Raised when configuration file is malformed
     MalformedConfigurationFile = Class.new(BaseError)
     # Raised when project_id is missing in configuration file

data/lib/diffend/execute.rb

@@ -6,12 +6,11 @@ module Diffend
     class << self
       # Build verdict
       #
-      # @param command [String] either install or update
-      # @param config [OpenStruct] diffend config
-      def call(command, config)
+      # @param config [Diffend::Config]
+      def call(config)
         Diffend::RequestVerdict
-          .call(command, config, build_definition(command))
-          .tap { |response| build_message(command, config, response) }
+          .call(config, build_definition(config.command))
+          .tap { |response| build_message(config, response) }
       rescue Diffend::Errors::DependenciesResolveException
         # We are unable to resolve dependencies, no message will be printed
       end
@@ -27,14 +26,13 @@ module Diffend
         )
       end
 
-      # @param command [String] either install or update
-      # @param config [OpenStruct] diffend config
+      # @param config [Diffend::Config]
       # @param response [Hash] response from diffend API
-      def build_message(command, config, response)
+      def build_message(config, response)
         if response.key?('error')
-          build_error(response)
+          build_error(config, response)
         elsif response.key?('action')
-          build_verdict(command, config, response)
+          build_verdict(config, response)
         else
           Diffend::HandleErrors::Report.call(
             config: config,
@@ -48,25 +46,24 @@ module Diffend
       # @param response [Hash] response from diffend API
       def build_error(response)
         build_error_message(response)
-          .tap(&Bundler.ui.method(:error))
+          .tap(&config.logger.method(:error))
 
         raise Diffend::Errors::HandledException
       end
 
-      # @param command [String] either install or update
-      # @param config [OpenStruct] diffend config
+      # @param config [Diffend::Config]
       # @param response [Hash] response from diffend API
-      def build_verdict(command, config, response)
+      def build_verdict(config, response)
         case response['action']
         when 'allow'
-          build_allow_message(command, response)
-            .tap(&Bundler.ui.method(:confirm))
+          build_allow_message(config.command, response)
+            .tap(&config.logger.method(:info))
         when 'warn'
-          build_warn_message(command, response)
-            .tap(&Bundler.ui.method(:warn))
+          build_warn_message(config.command, response)
+            .tap(&config.logger.method(:warn))
         when 'deny'
-          build_deny_message(command, response)
-            .tap(&Bundler.ui.method(:error))
+          build_deny_message(config.command, response)
+            .tap(&config.logger.method(:error))
 
           exit 1
         else
@@ -89,7 +86,7 @@ module Diffend
         MSG
       end
 
-      # @param command [String] either install or update
+      # @param command [String] command executed via bundler
       # @param response [Hash] response from diffend API
       #
       # @return [String]
@@ -101,7 +98,7 @@ module Diffend
         MSG
       end
 
-      # @param command [String] either install or update
+      # @param command [String] command executed via bundler
       # @param response [Hash] response from diffend API
       #
       # @return [String]
@@ -113,7 +110,7 @@ module Diffend
         MSG
       end
 
-      # @param command [String] either install or update
+      # @param command [String] command executed via bundler
       # @param response [Hash] response from diffend API
       #
       # @return [String]
@@ -126,7 +123,7 @@ module Diffend
       end
 
       # @param type [String] verdict type
-      # @param command [String] either install or update
+      # @param command [String] command executed via bundler
       #
       # @return [String]
       def build_message_header(type, command)