diffend 0.2.25 → 0.2.26

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e6f2f5188a60431f6125d9b82e75f6edb661bf9c805ff13f685b962555c2cdb2
-  data.tar.gz: 3b4161909c2c494a37b3e8e3f9839f2fb86dd7c5712ca200cfb40e3c77e6bba6
+  metadata.gz: f22ef308037176744a8795a6371eb3340f01d597b706c66e45b8355dbf2d41a9
+  data.tar.gz: 1e5734925c51663f20e804ecef8d329f7b24a05dfce891b33366f1e867edbf78
 SHA512:
-  metadata.gz: a305d14cb1c2fe8166de8a830a465ed0647b690aec10ec917cf31348944a6f8f3867b75053f2817ab04153a27bc141064bc2ecc46dc73a77f68850011592c11c
-  data.tar.gz: f279c3f69cfcd07706a4c4652741d7ebc9423d222724d2c0093fa363f3be25970216d5adcaf156825db1edde6a8d6fb3d990f31a8d7480b656ff23e2a23490bc
+  metadata.gz: 8930d5dfc0e3c8438515069ab5c472ae93aaf934c6d16c595c70b9167384347d7c0358c4c50fc49d18b1a4024ed959be4fff00485731c9e622b8c8e89f7c1a98
+  data.tar.gz: e9741f2fe2db83a7650dd2272b9f79cfa7e5bc4b3c2989cae0d8390215459a386a545f23eb0163e350e6e32a7dca7963c9a9bfcdb65496dfa062051a2c023aad

data/.github/workflows/ci.yml

@@ -34,6 +34,8 @@ jobs:
         run: |
           gem install bundler --no-document
       - name: Bundle install
+        env:
+          DIFFEND_DEVELOPMENT: true
         run: |
           bundle config path vendor/bundle
           bundle install --jobs 4 --retry 3

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## [Unreleased][master]
 
+## [0.2.26] (2020-09-10)
+- introduce DIFFEND_DEVELOPMENT environment variable ([#36](https://github.com/diffend-io/diffend-ruby/pull/36))
+- adjust message for allow verdict ([#37](https://github.com/diffend-io/diffend-ruby/pull/37))
+- do not run the plugin when it is not enabled ([#38](https://github.com/diffend-io/diffend-ruby/pull/38))
+
 ## [0.2.25] (2020-09-09)
 - add support for a warn verdict ([#34](https://github.com/diffend-io/diffend-ruby/pull/34))
 
@@ -50,7 +55,8 @@
 
 - initial release
 
-[master]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.25...HEAD
+[master]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.26...HEAD
+[0.2.26]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.25...v0.2.26
 [0.2.25]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.24...v0.2.25
 [0.2.24]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.23...v0.2.24
 [0.2.23]: https://github.com/diffend-io/diffend-ruby/compare/v0.2.22...v0.2.23

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    diffend (0.2.25)
+    diffend (0.2.26)
 
 GEM
   remote: https://rubygems.org/

data/lib/diffend.rb

@@ -27,7 +27,7 @@
 # Diffend main namespace
 module Diffend
   # Current plugin version
-  VERSION = '0.2.25'
+  VERSION = '0.2.26'
   # Diffend homepage
   HOMEPAGE = 'https://diffend.io'
 
@@ -41,7 +41,9 @@ module Diffend
 
     # Execute diffend plugin
     def execute
-      detect_installed_version
+      return unless enabled?
+
+      verify_version
 
       config = fetch_config
 
@@ -63,7 +65,8 @@ module Diffend
       )
     end
 
-    def detect_installed_version
+    def verify_version
+      return if ENV['DIFFEND_DEVELOPMENT'] == 'true'
       return if installed_version == VERSION
 
       build_outdated_version_message(installed_version)
@@ -72,16 +75,6 @@ module Diffend
       exit 1
     end
 
-    # @param version [Hash] installed version
-    #
-    # @return [String]
-    def build_outdated_version_message(version)
-      <<~MSG
-        \nYou are running an outdated version (#{version}) of the plugin, which will lead to issues.
-        \nPlease upgrade to the latest one (#{VERSION}) by executing "rm -rf .bundle/plugin".\n
-      MSG
-    end
-
     # @return [String] installed plugin version
     def installed_version
       Bundler::Plugin
@@ -93,6 +86,30 @@ module Diffend
         .last
     end
 
+    # Checks if plugin is enabled
+    #
+    # @return [Boolean] true if enabled, false otherwise
+    def enabled?
+      Bundler
+        .default_gemfile
+        .read
+        .split("\n")
+        .reject(&:empty?)
+        .map(&:strip)
+        .select { |line| line.start_with?('plugin') }
+        .any? { |line| line.include?('diffend') }
+    end
+
+    # @param version [Hash] installed version
+    #
+    # @return [String]
+    def build_outdated_version_message(version)
+      <<~MSG
+        \nYou are running an outdated version (#{version}) of the plugin, which will lead to issues.
+        \nPlease upgrade to the latest one (#{VERSION}) by executing "rm -rf .bundle/plugin".\n
+      MSG
+    end
+
     # Command that was run with bundle
     #
     # @return [String]

data/lib/diffend/voting.rb

@@ -84,7 +84,7 @@ module Diffend
       def build_allow_message(command, response)
         <<~MSG
           #{build_message_header('an allow', command)}
-          #{build_message_info(response)}
+          #{build_message_info(response)}\n
           #{response['review_url']}\n
         MSG
       end
@@ -96,7 +96,7 @@ module Diffend
       def build_warn_message(command, response)
         <<~MSG
           #{build_message_header('a warn', command)}
-          #{build_message_info(response)}
+          #{build_message_info(response)} Please go to the url below and review the issues.\n
           #{response['review_url']}\n
         MSG
       end
@@ -108,7 +108,7 @@ module Diffend
       def build_deny_message(command, response)
         <<~MSG
           #{build_message_header('a deny', command)}
-          #{build_message_info(response)}
+          #{build_message_info(response)} Please go to the url below and review the issues.\n
           #{response['review_url']}\n
         MSG
       end
@@ -125,7 +125,7 @@ module Diffend
       #
       # @return [String]
       def build_message_info(response)
-        "\nQuality score: #{response['quality_score']}, allows: #{response['allows_count']}, warnings: #{response['warns_count']}, denies: #{response['denies_count']}. Please go to the url below and review the issues.\n"
+        "\nQuality score: #{response['quality_score']}, allows: #{response['allows_count']}, warnings: #{response['warns_count']}, denies: #{response['denies_count']}."
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: diffend
 version: !ruby/object:Gem::Version
-  version: 0.2.25
+  version: 0.2.26
 platform: ruby
 authors:
 - Tomasz Pajor
@@ -34,7 +34,7 @@ cert_chain:
   9MmF6uCQa1EjK2p8tYT0MnbHrFkoehxdX4VO9y99GAkhZyJNKPYPtyAUFV27sT2V
   LfCJRk4ifKIN/FUCwDSn8Cz0m6oH265q0p6wdzI6qrWOjP8tGOMBTA==
   -----END CERTIFICATE-----
-date: 2020-09-09 00:00:00.000000000 Z
+date: 2020-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler