diff_test 0.8.9 → 0.8.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0eb6d31f88ec71845c1da318d944b46bcb0d7c6b550b0bb9c936a4236cd4e802
-  data.tar.gz: 879e45fa217f327c095c4f1bccac3d7308df661a3735ba3a549cdc8550c4360c
+  metadata.gz: 572fb4d96758c15f33fb86d759208c20707bc041e86bd41846ad3fb25e7878bc
+  data.tar.gz: 58be1a6c50f15d51ee35c867f9f82351e027f11391e80a00236a72084935c64d
 SHA512:
-  metadata.gz: d935e9d4ebce09151f96d998b9aa7cfcd4adc3f8a5e45622b29e1e57a093184b39e98321392eab581b37c2a7b51f8927bbb99fb4df447896ced3f3e409868b3f
-  data.tar.gz: cf82343110711249ec65a56486a559ae899614e886f49faceea1c35020abc58758f438a87969db609f866171abe5228421e7e23f12fcd9170689cbe1c8e40580
+  metadata.gz: 3d127f58c88c7e5d05a0af258fda8f1e553f98f2e17c1ca7b5d079f620a769211ca62b5e0e6d9ac1fbb0a44624f3af7c2c2bda947d6cbd8a072d55edf802584e
+  data.tar.gz: 296d9ddcff60b4958d90ecdd4f7acf1b7402af66fd4f73c23d392efe22dc4ab3bb2f721bb1c404619f91b69889e4a5ad4fe0b2295d77fdd545b586fe0c00a7c7

data/README.md

@@ -253,3 +253,22 @@ test/services/zoom_webhook_event_processor_test.rb
 
 overhead of const TracePoint and file path prefix native
 method_added/const_added
+
+
+# WRITE test for it setting time from previous successful run
+
+
+
+# Perf improvements
+
+# TestExecution
+#   - New Test table (just for test name)
+#   - Drop updated_at
+#   - impacted_file_hash becomes integer
+
+# ImpactedFile
+    - add file_path and file_hash
+
+# TestExecutionImpactedFile
+    - Store file hash with impacted file
+    - TestExecutionImpactedFile then just belongs to test execution and impacted_file

data/lib/diff_test/file_hash_computer.rb

@@ -11,7 +11,7 @@ module DiffTest
       content = DiffTest::Integrations::RailsJs::Annotator.unannotate(content)
 
       @cache ||= {}
-      @cache[file_path] = XXhash.xxh64(content).to_s
+      @cache[file_path] = XXhash.xxh32(content).to_s
     end
 
     def self.compute_relative(file_path)

data/lib/diff_test/helper.rb

@@ -74,5 +74,9 @@ module DiffTest
       puts "Finished #{name.join(' ')} in #{(Time.now - start).round(2)}s------------"
       result
     end
+
+    def log(message)
+      puts "DiffTest #{Time.current.strftime('%H:%M:%S')}: #{message}" if ENV['DIFF_TEST_LOG']
+    end
   end
 end

data/lib/diff_test/integrations/minitest/lifecycle.rb

@@ -55,7 +55,7 @@ module DiffTest
               test_name = self.name
 
               DiffTest::TestExecution.current = execution =  DiffTest::TestExecution.new(test_file_path:, test_name:)
-              should_run = DiffTest::ShouldRunDecider.should_run?(execution.id, system_test: true)
+              should_run = execution.should_run?
               DiffTest::TestSuiteExecution.current.ensure_application_eager_loaded! if should_run
             rescue => e
               DiffTest.error("An error ocurred while trying to create a test execution. Please report this issue.\nException: #{e}")
@@ -67,11 +67,10 @@ module DiffTest
               super
             else
               # Skip raises an exception too, which is handled by `capture_exception`
-              time_it do
-                capture_exceptions do
-                  skip("Impacted files have not changed. Skipping...")
-                end
+              capture_exceptions do
+                skip("Impacted files have not changed. Skipping...")
               end
+              self.time = execution.previous_runtime_s
               ::Minitest::Result.from(self)
             end
           ensure

data/lib/diff_test/integrations/rails_js/annotator.rb

@@ -45,7 +45,7 @@ module DiffTest
         end
 
         def self.insert_at_first_non_comment_line_str(content, text_to_insert)
-          lines = content.lines.map(&:chomp)
+          lines = content.lines
 
           in_multiline_comment = false
           comment_type = nil
@@ -97,7 +97,7 @@ module DiffTest
           new_lines = lines.dup
           new_lines.insert(insert_index, text_to_insert)
 
-          new_lines.join("\n")
+          new_lines.join
         end
       end
     end

data/lib/diff_test/should_run_decider.rb

@@ -8,21 +8,24 @@ module DiffTest
     end
 
     def should_run?(test_id, system_test:)
-      return true unless @test_executions_by_test
+      return { should_run: true } unless @test_executions_by_test
 
       previous_test_executions = @test_executions_by_test[test_id] || []
+      previous_runtime_ms = nil
 
       # If there are any previous test executions run whose impacted files are the same as now
       #  Assume its safe to skip
       has_previous_execution_with_no_impacted_changes = previous_test_executions.any? do |previous_test_execution|
         hashes_match = previous_test_execution['test_execution_impacted_files'].all? do |test_execution_impacted_file|
           impacted_file_id = test_execution_impacted_file['impacted_file_id'].to_s
-          file_hash = test_execution_impacted_file['file_hash']
+          file_hash = test_execution_impacted_file['file_hash'].to_s
           impacted_file_path = @impacted_file_path_by_id[impacted_file_id]
 
           DiffTest::FileHashComputer.compute_relative(impacted_file_path) == file_hash
         end
         next false unless hashes_match
+
+        previous_runtime_ms = previous_test_execution['runtime_ms']
         next true unless system_test
 
         test_suite_execution = @test_suite_executions_by_id[previous_test_execution['test_suite_execution_id'].to_s]
@@ -32,8 +35,13 @@ module DiffTest
         false
       end
 
-      return true if ENV['DIFF_TEST_ALWAYS_RUN'] == '1'
-      !has_previous_execution_with_no_impacted_changes
+      return { should_run: true } if ENV['DIFF_TEST_ALWAYS_RUN'] == '1'
+
+      should_run =  !has_previous_execution_with_no_impacted_changes
+      {
+        should_run:,
+        previous_runtime_ms:,
+      }
     end
 
     def self.current

data/lib/diff_test/test_execution.rb

@@ -13,9 +13,16 @@ module DiffTest
       self.class.set(id, self)
     end
 
+    def should_run_decider_result
+      @should_run_decider_result ||= DiffTest::ShouldRunDecider.should_run?(id, system_test: system_test?)
+    end
+
     def should_run?
-      return @should_run unless @should_run.nil?
-      @should_run = DiffTest::ShouldRunDecider.should_run?(id, system_test: system_test?)
+      should_run_decider_result[:should_run]
+    end
+
+    def previous_runtime_s
+      (should_run_decider_result[:previous_runtime_ms] / 1000.0) if should_run_decider_result[:previous_runtime_ms]
     end
 
     def save_payload
@@ -23,7 +30,7 @@ module DiffTest
         test: id,
         result: @result,
         runtime_ms: runtime_ms,
-        impacted_files: (@impacted_file_tracker.save_payload if passed?),
+        impacted_files: (@impacted_file_tracker.save_payload if successful?),
       }.compact
     end
 
@@ -32,6 +39,7 @@ module DiffTest
     end
 
     def start
+      DiffTest::Helper.log("TestExecution.start: #{id}")
       @impacted_file_tracker.start
       @started_at = Process.clock_gettime(Process::CLOCK_MONOTONIC)
     end
@@ -39,6 +47,7 @@ module DiffTest
     def stop
       @impacted_file_tracker.stop
       @stopped_at = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+      DiffTest::Helper.log("TestExecution.stop: #{id}")
       finish
     end
 
@@ -66,6 +75,14 @@ module DiffTest
       @result == :passed
     end
 
+    def skipped?
+      @result == :skipped
+    end
+
+    def successful?
+      passed? || skipped?
+    end
+
     def runtime_ms
       return 0 if @stopped_at.nil? || @started_at.nil?
       (@stopped_at - @started_at) * 1000

data/lib/diff_test/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DiffTest
-  VERSION = "0.8.9"
+  VERSION = "0.8.12"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: diff_test
 version: !ruby/object:Gem::Version
-  version: 0.8.9
+  version: 0.8.12
 platform: ruby
 authors:
 - Owais
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-28 00:00:00.000000000 Z
+date: 2025-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty