diff_test 0.8.8 → 0.8.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 30ebf53cd9e386268105985641fa99ddee89e06769ca244562f27b180fcac613
-  data.tar.gz: 44896ebcebfd807e3a1881b62556fc406a4255018e1ebc71f274b178b6dd2cd7
+  metadata.gz: 0eb6d31f88ec71845c1da318d944b46bcb0d7c6b550b0bb9c936a4236cd4e802
+  data.tar.gz: 879e45fa217f327c095c4f1bccac3d7308df661a3735ba3a549cdc8550c4360c
 SHA512:
-  metadata.gz: 1e2c4f1f1c463574d8a88878c43a8cbeb7b051b51efef2f6a0693314e2dceeb8aa13730a13087284b625833485def5e0b9823196a6c8aa57794cb69a494eb04d
-  data.tar.gz: 6130dedb438ee5960d29cbee6153bc3fa3e2e85e6e049b7de1917fa122269916af869cf419933504b2f1060f360a4b8c6df2ccda26a909027b28a1bd1533a01e
+  metadata.gz: d935e9d4ebce09151f96d998b9aa7cfcd4adc3f8a5e45622b29e1e57a093184b39e98321392eab581b37c2a7b51f8927bbb99fb4df447896ced3f3e409868b3f
+  data.tar.gz: cf82343110711249ec65a56486a559ae899614e886f49faceea1c35020abc58758f438a87969db609f866171abe5228421e7e23f12fcd9170689cbe1c8e40580

data/README.md

@@ -253,6 +253,3 @@ test/services/zoom_webhook_event_processor_test.rb
 
 overhead of const TracePoint and file path prefix native
 method_added/const_added
-
-
-# WRITE test for it setting time from previous successful run

data/lib/diff_test/integrations/minitest/lifecycle.rb

@@ -55,7 +55,7 @@ module DiffTest
               test_name = self.name
 
               DiffTest::TestExecution.current = execution =  DiffTest::TestExecution.new(test_file_path:, test_name:)
-              should_run = execution.should_run?
+              should_run = DiffTest::ShouldRunDecider.should_run?(execution.id, system_test: true)
               DiffTest::TestSuiteExecution.current.ensure_application_eager_loaded! if should_run
             rescue => e
               DiffTest.error("An error ocurred while trying to create a test execution. Please report this issue.\nException: #{e}")
@@ -67,10 +67,11 @@ module DiffTest
               super
             else
               # Skip raises an exception too, which is handled by `capture_exception`
-              capture_exceptions do
-                skip("Impacted files have not changed. Skipping...")
+              time_it do
+                capture_exceptions do
+                  skip("Impacted files have not changed. Skipping...")
+                end
               end
-              self.time = execution.previous_runtime_s
               ::Minitest::Result.from(self)
             end
           ensure

data/lib/diff_test/integrations/rails_js/processing_skip_analyzer.rb

@@ -14,7 +14,7 @@ module DiffTest
         end
 
         def skip_processing?
-          !html? || chunked?
+          !DiffTest::TestExecution.current || !html? || chunked?
         end
 
         def chunked?

data/lib/diff_test/should_run_decider.rb

@@ -8,10 +8,9 @@ module DiffTest
     end
 
     def should_run?(test_id, system_test:)
-      return { should_run: true } unless @test_executions_by_test
+      return true unless @test_executions_by_test
 
       previous_test_executions = @test_executions_by_test[test_id] || []
-      previous_runtime_ms = nil
 
       # If there are any previous test executions run whose impacted files are the same as now
       #  Assume its safe to skip
@@ -24,8 +23,6 @@ module DiffTest
           DiffTest::FileHashComputer.compute_relative(impacted_file_path) == file_hash
         end
         next false unless hashes_match
-
-        previous_runtime_ms = previous_test_execution['runtime_ms']
         next true unless system_test
 
         test_suite_execution = @test_suite_executions_by_id[previous_test_execution['test_suite_execution_id'].to_s]
@@ -35,13 +32,8 @@ module DiffTest
         false
       end
 
-      return { should_run: true } if ENV['DIFF_TEST_ALWAYS_RUN'] == '1'
-
-      should_run =  !has_previous_execution_with_no_impacted_changes
-      {
-        should_run:,
-        previous_runtime_ms:,
-      }
+      return true if ENV['DIFF_TEST_ALWAYS_RUN'] == '1'
+      !has_previous_execution_with_no_impacted_changes
     end
 
     def self.current

data/lib/diff_test/test_execution.rb

@@ -13,16 +13,9 @@ module DiffTest
       self.class.set(id, self)
     end
 
-    def should_run_decider_result
-      @should_run_decider_result ||= DiffTest::ShouldRunDecider.should_run?(id, system_test: system_test?)
-    end
-
     def should_run?
-      should_run_decider_result[:should_run]
-    end
-
-    def previous_runtime_s
-      (should_run_decider_result[:previous_runtime_ms] / 1000.0) if should_run_decider_result[:previous_runtime_ms]
+      return @should_run unless @should_run.nil?
+      @should_run = DiffTest::ShouldRunDecider.should_run?(id, system_test: system_test?)
     end
 
     def save_payload
@@ -30,7 +23,7 @@ module DiffTest
         test: id,
         result: @result,
         runtime_ms: runtime_ms,
-        impacted_files: (@impacted_file_tracker.save_payload if successful?),
+        impacted_files: (@impacted_file_tracker.save_payload if passed?),
       }.compact
     end
 
@@ -73,14 +66,6 @@ module DiffTest
       @result == :passed
     end
 
-    def skipped?
-      @result == :skipped
-    end
-
-    def successful?
-      passed? || skipped?
-    end
-
     def runtime_ms
       return 0 if @stopped_at.nil? || @started_at.nil?
       (@stopped_at - @started_at) * 1000

data/lib/diff_test/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DiffTest
-  VERSION = "0.8.8"
+  VERSION = "0.8.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: diff_test
 version: !ruby/object:Gem::Version
-  version: 0.8.8
+  version: 0.8.9
 platform: ruby
 authors:
 - Owais
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-26 00:00:00.000000000 Z
+date: 2025-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty