diff_test 0.8.6 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d912f83be5f069f6801db49f64088b2300053e75927b9b15994d3a69630954ff
-  data.tar.gz: 1b7f27298ad240ad3d4f2f9f75257de1ebadc47ffdd7da7656f72318524bd36f
+  metadata.gz: 30a81175a332e93a6bb3791a2457c3f8afd04217a8f48ccb1d1abf48306407b7
+  data.tar.gz: '0891219e6104458312cdc2fbf164218318271349fcc8e1c2b42ade2b55546451'
 SHA512:
-  metadata.gz: ac0dba39aa22af19f73911ae8e70d2ba0acb17484f720d39f8f18d355ccb62cd50b4b3d077cb478119f1464eea0a2bdb69c87135d63f76dc02900b61e33ac74d
-  data.tar.gz: c50115b9407f7904675e987e930485932cc72a9da2a148361f9ae05e7c996c35171606e98b338ff4533799edfa083282b3634f8455dd9aa6246de24720e4424c
+  metadata.gz: 3bdc4073b05ac2260f8875e3fb309d27d306507598d1f4d85f5941515ad5878fd2101cfe166fa2ffd3579794180de1bfe5e63b080cc7edf0592202788a0801fe
+  data.tar.gz: aab168ef2a5be65d5f7fb551cc0a7f1e9ac3513539d8b6b6f78e82dbfe0c87d9544bb1a2687a741f459345fff9751d2ae618de1cf58c4cac0904b53346470701

data/README.md

@@ -253,3 +253,6 @@ test/services/zoom_webhook_event_processor_test.rb
 
 overhead of const TracePoint and file path prefix native
 method_added/const_added
+
+
+# WRITE test for it setting time from previous successful run

data/lib/diff_test/integrations/minitest/lifecycle.rb

@@ -55,7 +55,7 @@ module DiffTest
               test_name = self.name
 
               DiffTest::TestExecution.current = execution =  DiffTest::TestExecution.new(test_file_path:, test_name:)
-              should_run = DiffTest::ShouldRunDecider.should_run?(execution.id, system_test: true)
+              should_run = execution.should_run?
               DiffTest::TestSuiteExecution.current.ensure_application_eager_loaded! if should_run
             rescue => e
               DiffTest.error("An error ocurred while trying to create a test execution. Please report this issue.\nException: #{e}")
@@ -67,11 +67,10 @@ module DiffTest
               super
             else
               # Skip raises an exception too, which is handled by `capture_exception`
-              time_it do
-                capture_exceptions do
-                  skip("Impacted files have not changed. Skipping...")
-                end
+              capture_exceptions do
+                skip("Impacted files have not changed. Skipping...")
               end
+              self.time = execution.previous_runtime_s
               ::Minitest::Result.from(self)
             end
           ensure

data/lib/diff_test/should_run_decider.rb

@@ -8,9 +8,10 @@ module DiffTest
     end
 
     def should_run?(test_id, system_test:)
-      return true unless @test_executions_by_test
+      return { should_run: true } unless @test_executions_by_test
 
       previous_test_executions = @test_executions_by_test[test_id] || []
+      previous_runtime_ms = nil
 
       # If there are any previous test executions run whose impacted files are the same as now
       #  Assume its safe to skip
@@ -23,6 +24,8 @@ module DiffTest
           DiffTest::FileHashComputer.compute_relative(impacted_file_path) == file_hash
         end
         next false unless hashes_match
+
+        previous_runtime_ms = previous_test_execution['runtime_ms']
         next true unless system_test
 
         test_suite_execution = @test_suite_executions_by_id[previous_test_execution['test_suite_execution_id'].to_s]
@@ -32,8 +35,13 @@ module DiffTest
         false
       end
 
-      return true if ENV['DIFF_TEST_ALWAYS_RUN'] == '1'
-      !has_previous_execution_with_no_impacted_changes
+      return { should_run: true } if ENV['DIFF_TEST_ALWAYS_RUN'] == '1'
+
+      should_run =  !has_previous_execution_with_no_impacted_changes
+      {
+        should_run:,
+        previous_runtime_ms:,
+      }
     end
 
     def self.current

data/lib/diff_test/test_execution.rb

@@ -13,9 +13,16 @@ module DiffTest
       self.class.set(id, self)
     end
 
+    def should_run_decider_result
+      @should_run_decider_result ||= DiffTest::ShouldRunDecider.should_run?(id, system_test: system_test?)
+    end
+
     def should_run?
-      return @should_run unless @should_run.nil?
-      @should_run = DiffTest::ShouldRunDecider.should_run?(id, system_test: system_test?)
+      should_run_decider_result[:should_run]
+    end
+
+    def previous_runtime_s
+      (should_run_decider_result[:previous_runtime_ms] / 1000.0) if should_run_decider_result[:previous_runtime_ms]
     end
 
     def save_payload
@@ -23,7 +30,7 @@ module DiffTest
         test: id,
         result: @result,
         runtime_ms: runtime_ms,
-        impacted_files: (@impacted_file_tracker.save_payload if passed?),
+        impacted_files: (@impacted_file_tracker.save_payload if successful?),
       }.compact
     end
 
@@ -66,6 +73,14 @@ module DiffTest
       @result == :passed
     end
 
+    def skipped?
+      @result == :skipped
+    end
+
+    def successful?
+      passed? || skipped?
+    end
+
     def runtime_ms
       return 0 if @stopped_at.nil? || @started_at.nil?
       (@stopped_at - @started_at) * 1000

data/lib/diff_test/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DiffTest
-  VERSION = "0.8.6"
+  VERSION = "0.8.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: diff_test
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.8.7
 platform: ruby
 authors:
 - Owais
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-20 00:00:00.000000000 Z
+date: 2025-04-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty