did_you_mean 1.2.1 → 1.5.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (67) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/ruby.yml +39 -0
  3. data/CHANGELOG.md +172 -57
  4. data/Gemfile +2 -0
  5. data/README.md +79 -28
  6. data/Rakefile +38 -12
  7. data/appveyor.yml +25 -0
  8. data/benchmark/jaro_winkler/memory_usage.rb +4 -4
  9. data/benchmark/jaro_winkler/speed.rb +14 -6
  10. data/benchmark/levenshtein/memory_usage.rb +4 -4
  11. data/benchmark/levenshtein/speed.rb +13 -8
  12. data/benchmark/require_path_checker.rb +47 -0
  13. data/benchmark/speed.yml +13 -0
  14. data/did_you_mean.gemspec +6 -4
  15. data/documentation/CHANGELOG.md.erb +8 -0
  16. data/documentation/changelog_generator.rb +34 -0
  17. data/documentation/human_typo_api.md +20 -0
  18. data/documentation/tree_spell_algorithm.md +82 -0
  19. data/documentation/tree_spell_checker_api.md +24 -0
  20. data/lib/did_you_mean.rb +95 -52
  21. data/lib/did_you_mean/core_ext/name_error.rb +4 -6
  22. data/lib/did_you_mean/experimental.rb +2 -2
  23. data/lib/did_you_mean/formatters/plain_formatter.rb +24 -0
  24. data/lib/did_you_mean/formatters/verbose_formatter.rb +36 -0
  25. data/lib/did_you_mean/levenshtein.rb +1 -1
  26. data/lib/did_you_mean/spell_checker.rb +8 -14
  27. data/lib/did_you_mean/spell_checkers/key_error_checker.rb +8 -2
  28. data/lib/did_you_mean/spell_checkers/method_name_checker.rb +48 -6
  29. data/lib/did_you_mean/spell_checkers/name_error_checkers.rb +2 -2
  30. data/lib/did_you_mean/spell_checkers/name_error_checkers/class_name_checker.rb +5 -5
  31. data/lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb +56 -4
  32. data/lib/did_you_mean/spell_checkers/require_path_checker.rb +35 -0
  33. data/lib/did_you_mean/tree_spell_checker.rb +109 -0
  34. data/lib/did_you_mean/verbose.rb +2 -2
  35. data/lib/did_you_mean/version.rb +1 -1
  36. data/test/core_ext/test_name_error_extension.rb +48 -0
  37. data/test/edit_distance/{jaro_winkler_test.rb → test_jaro_winkler.rb} +2 -2
  38. data/test/fixtures/book.rb +1 -1
  39. data/test/fixtures/mini_dir.yml +15 -0
  40. data/test/fixtures/rspec_dir.yml +112 -0
  41. data/test/helper.rb +29 -0
  42. data/test/spell_checking/{class_name_check_test.rb → test_class_name_check.rb} +15 -11
  43. data/test/spell_checking/{key_name_check_test.rb → test_key_name_check.rb} +18 -8
  44. data/test/spell_checking/{method_name_check_test.rb → test_method_name_check.rb} +41 -13
  45. data/test/spell_checking/test_require_path_check.rb +32 -0
  46. data/test/spell_checking/{uncorrectable_name_check_test.rb → test_uncorrectable_name_check.rb} +3 -3
  47. data/test/spell_checking/{variable_name_check_test.rb → test_variable_name_check.rb} +36 -18
  48. data/test/{spell_checker_test.rb → test_spell_checker.rb} +2 -2
  49. data/test/test_tree_spell_checker.rb +170 -0
  50. data/test/test_verbose_formatter.rb +23 -0
  51. data/test/tree_spell/change_word.rb +61 -0
  52. data/test/tree_spell/human_typo.rb +69 -0
  53. data/test/tree_spell/test_change_word.rb +38 -0
  54. data/test/tree_spell/test_explore.rb +128 -0
  55. data/test/tree_spell/test_human_typo.rb +24 -0
  56. metadata +53 -66
  57. data/.ruby-version +0 -1
  58. data/.travis.yml +0 -14
  59. data/lib/did_you_mean/experimental/initializer_name_correction.rb +0 -20
  60. data/lib/did_you_mean/experimental/ivar_name_correction.rb +0 -74
  61. data/lib/did_you_mean/verbose_formatter.rb +0 -7
  62. data/test/core_ext/name_error_extension_test.rb +0 -47
  63. data/test/deprecated_formatter_test.rb +0 -9
  64. data/test/experimental/initializer_name_correction_test.rb +0 -15
  65. data/test/experimental/method_name_checker_test.rb +0 -13
  66. data/test/test_helper.rb +0 -13
  67. data/test/verbose_formatter_test.rb +0 -23
@@ -0,0 +1,24 @@
1
+ require_relative '../helper'
2
+ require_relative 'human_typo'
3
+
4
+ class HumanTypoTest < Test::Unit::TestCase
5
+ def setup
6
+ @input = 'spec/services/anything_spec'
7
+ @sh = TreeSpell::HumanTypo.new(@input, lambda: 0.05)
8
+ @len = @input.length
9
+ end
10
+
11
+ def test_changes
12
+ # srand seed ensures all four actions are called
13
+ srand 247_696_449
14
+ sh = TreeSpell::HumanTypo.new(@input, lambda: 0.20)
15
+ word_error = sh.call
16
+ assert_equal word_error, 'spec/suervcieq/anythin_gpec'
17
+ end
18
+
19
+ def test_check_input
20
+ assert_raise(RuntimeError, "input length must be greater than 5 characters: tiny") do
21
+ TreeSpell::HumanTypo.new('tiny')
22
+ end
23
+ end
24
+ end
metadata CHANGED
@@ -1,29 +1,15 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: did_you_mean
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.2.1
4
+ version: 1.5.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Yuki Nishijima
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2018-04-03 00:00:00.000000000 Z
11
+ date: 2020-12-22 00:00:00.000000000 Z
12
12
  dependencies:
13
- - !ruby/object:Gem::Dependency
14
- name: bundler
15
- requirement: !ruby/object:Gem::Requirement
16
- requirements:
17
- - - ">="
18
- - !ruby/object:Gem::Version
19
- version: '0'
20
- type: :development
21
- prerelease: false
22
- version_requirements: !ruby/object:Gem::Requirement
23
- requirements:
24
- - - ">="
25
- - !ruby/object:Gem::Version
26
- version: '0'
27
13
  - !ruby/object:Gem::Dependency
28
14
  name: rake
29
15
  requirement: !ruby/object:Gem::Requirement
@@ -38,20 +24,6 @@ dependencies:
38
24
  - - ">="
39
25
  - !ruby/object:Gem::Version
40
26
  version: '0'
41
- - !ruby/object:Gem::Dependency
42
- name: minitest
43
- requirement: !ruby/object:Gem::Requirement
44
- requirements:
45
- - - ">="
46
- - !ruby/object:Gem::Version
47
- version: '0'
48
- type: :development
49
- prerelease: false
50
- version_requirements: !ruby/object:Gem::Requirement
51
- requirements:
52
- - - ">="
53
- - !ruby/object:Gem::Version
54
- version: '0'
55
27
  description: The gem that has been saving people from typos since 2014.
56
28
  email:
57
29
  - mail@yukinishijima.net
@@ -59,27 +31,30 @@ executables: []
59
31
  extensions: []
60
32
  extra_rdoc_files: []
61
33
  files:
34
+ - ".github/workflows/ruby.yml"
62
35
  - ".gitignore"
63
- - ".ruby-version"
64
- - ".travis.yml"
65
36
  - CHANGELOG.md
66
37
  - Gemfile
67
38
  - LICENSE.txt
68
39
  - README.md
69
40
  - Rakefile
41
+ - appveyor.yml
70
42
  - benchmark/jaro_winkler/memory_usage.rb
71
43
  - benchmark/jaro_winkler/speed.rb
72
44
  - benchmark/levenshtein/memory_usage.rb
73
45
  - benchmark/levenshtein/speed.rb
74
46
  - benchmark/memory_usage.rb
47
+ - benchmark/require_path_checker.rb
48
+ - benchmark/speed.yml
75
49
  - did_you_mean.gemspec
76
- - doc/CHANGELOG.md.erb
77
- - doc/changelog_generator.rb
50
+ - documentation/CHANGELOG.md.erb
51
+ - documentation/changelog_generator.rb
52
+ - documentation/human_typo_api.md
53
+ - documentation/tree_spell_algorithm.md
54
+ - documentation/tree_spell_checker_api.md
78
55
  - lib/did_you_mean.rb
79
56
  - lib/did_you_mean/core_ext/name_error.rb
80
57
  - lib/did_you_mean/experimental.rb
81
- - lib/did_you_mean/experimental/initializer_name_correction.rb
82
- - lib/did_you_mean/experimental/ivar_name_correction.rb
83
58
  - lib/did_you_mean/formatters/plain_formatter.rb
84
59
  - lib/did_you_mean/formatters/verbose_formatter.rb
85
60
  - lib/did_you_mean/jaro_winkler.rb
@@ -91,24 +66,31 @@ files:
91
66
  - lib/did_you_mean/spell_checkers/name_error_checkers/class_name_checker.rb
92
67
  - lib/did_you_mean/spell_checkers/name_error_checkers/variable_name_checker.rb
93
68
  - lib/did_you_mean/spell_checkers/null_checker.rb
69
+ - lib/did_you_mean/spell_checkers/require_path_checker.rb
70
+ - lib/did_you_mean/tree_spell_checker.rb
94
71
  - lib/did_you_mean/verbose.rb
95
- - lib/did_you_mean/verbose_formatter.rb
96
72
  - lib/did_you_mean/version.rb
97
- - test/core_ext/name_error_extension_test.rb
98
- - test/deprecated_formatter_test.rb
99
- - test/edit_distance/jaro_winkler_test.rb
100
- - test/experimental/initializer_name_correction_test.rb
101
- - test/experimental/method_name_checker_test.rb
73
+ - test/core_ext/test_name_error_extension.rb
74
+ - test/edit_distance/test_jaro_winkler.rb
102
75
  - test/fixtures/book.rb
103
- - test/spell_checker_test.rb
104
- - test/spell_checking/class_name_check_test.rb
105
- - test/spell_checking/key_name_check_test.rb
106
- - test/spell_checking/method_name_check_test.rb
107
- - test/spell_checking/uncorrectable_name_check_test.rb
108
- - test/spell_checking/variable_name_check_test.rb
109
- - test/test_helper.rb
110
- - test/verbose_formatter_test.rb
111
- homepage: https://github.com/yuki24/did_you_mean
76
+ - test/fixtures/mini_dir.yml
77
+ - test/fixtures/rspec_dir.yml
78
+ - test/helper.rb
79
+ - test/spell_checking/test_class_name_check.rb
80
+ - test/spell_checking/test_key_name_check.rb
81
+ - test/spell_checking/test_method_name_check.rb
82
+ - test/spell_checking/test_require_path_check.rb
83
+ - test/spell_checking/test_uncorrectable_name_check.rb
84
+ - test/spell_checking/test_variable_name_check.rb
85
+ - test/test_spell_checker.rb
86
+ - test/test_tree_spell_checker.rb
87
+ - test/test_verbose_formatter.rb
88
+ - test/tree_spell/change_word.rb
89
+ - test/tree_spell/human_typo.rb
90
+ - test/tree_spell/test_change_word.rb
91
+ - test/tree_spell/test_explore.rb
92
+ - test/tree_spell/test_human_typo.rb
93
+ homepage: https://github.com/ruby/did_you_mean
112
94
  licenses:
113
95
  - MIT
114
96
  metadata: {}
@@ -127,23 +109,28 @@ required_rubygems_version: !ruby/object:Gem::Requirement
127
109
  - !ruby/object:Gem::Version
128
110
  version: '0'
129
111
  requirements: []
130
- rubyforge_project:
131
- rubygems_version: 2.7.6
112
+ rubygems_version: 3.1.3
132
113
  signing_key:
133
114
  specification_version: 4
134
115
  summary: '"Did you mean?" experience in Ruby'
135
116
  test_files:
136
- - test/core_ext/name_error_extension_test.rb
137
- - test/deprecated_formatter_test.rb
138
- - test/edit_distance/jaro_winkler_test.rb
139
- - test/experimental/initializer_name_correction_test.rb
140
- - test/experimental/method_name_checker_test.rb
117
+ - test/core_ext/test_name_error_extension.rb
118
+ - test/edit_distance/test_jaro_winkler.rb
141
119
  - test/fixtures/book.rb
142
- - test/spell_checker_test.rb
143
- - test/spell_checking/class_name_check_test.rb
144
- - test/spell_checking/key_name_check_test.rb
145
- - test/spell_checking/method_name_check_test.rb
146
- - test/spell_checking/uncorrectable_name_check_test.rb
147
- - test/spell_checking/variable_name_check_test.rb
148
- - test/test_helper.rb
149
- - test/verbose_formatter_test.rb
120
+ - test/fixtures/mini_dir.yml
121
+ - test/fixtures/rspec_dir.yml
122
+ - test/helper.rb
123
+ - test/spell_checking/test_class_name_check.rb
124
+ - test/spell_checking/test_key_name_check.rb
125
+ - test/spell_checking/test_method_name_check.rb
126
+ - test/spell_checking/test_require_path_check.rb
127
+ - test/spell_checking/test_uncorrectable_name_check.rb
128
+ - test/spell_checking/test_variable_name_check.rb
129
+ - test/test_spell_checker.rb
130
+ - test/test_tree_spell_checker.rb
131
+ - test/test_verbose_formatter.rb
132
+ - test/tree_spell/change_word.rb
133
+ - test/tree_spell/human_typo.rb
134
+ - test/tree_spell/test_change_word.rb
135
+ - test/tree_spell/test_explore.rb
136
+ - test/tree_spell/test_human_typo.rb
@@ -1 +0,0 @@
1
- 2.5.1
@@ -1,14 +0,0 @@
1
- language: ruby
2
- script: bundle exec rake
3
- cache: bundler
4
- sudo: false
5
-
6
- before_install:
7
- - gem install bundler
8
-
9
- after_success:
10
- - bundle exec rake test:accuracy
11
- - bundle exec rake benchmark:memory
12
-
13
- rvm:
14
- - 2.5.1
@@ -1,20 +0,0 @@
1
- # frozen-string-literal: true
2
-
3
- require 'did_you_mean/levenshtein'
4
-
5
- module DidYouMean
6
- module Experimental
7
- module InitializerNameCorrection
8
- def method_added(name)
9
- super
10
-
11
- distance = Levenshtein.distance(name.to_s, 'initialize')
12
- if distance != 0 && distance <= 2
13
- warn "warning: #{name} might be misspelled, perhaps you meant initialize?"
14
- end
15
- end
16
- end
17
-
18
- ::Class.prepend(InitializerNameCorrection)
19
- end
20
- end
@@ -1,74 +0,0 @@
1
- # frozen-string-literal: true
2
-
3
- require 'did_you_mean'
4
-
5
- module DidYouMean
6
- module Experimental #:nodoc:
7
- class IvarNameCheckerBuilder #:nodoc:
8
- attr_reader :original_checker
9
-
10
- def initialize(original_checker) #:nodoc:
11
- @original_checker = original_checker
12
- end
13
-
14
- def new(no_method_error) #:nodoc:
15
- IvarNameChecker.new(no_method_error, original_checker: @original_checker)
16
- end
17
- end
18
-
19
- class IvarNameChecker #:nodoc:
20
- REPLS = {
21
- "(irb)" => -> { Readline::HISTORY.to_a.last }
22
- }
23
-
24
- TRACE = TracePoint.trace(:raise) do |tp|
25
- e = tp.raised_exception
26
-
27
- if SPELL_CHECKERS.include?(e.class.to_s) && !e.instance_variable_defined?(:@frame_binding)
28
- e.instance_variable_set(:@frame_binding, tp.binding)
29
- end
30
- end
31
-
32
- attr_reader :original_checker
33
-
34
- def initialize(no_method_error, original_checker: )
35
- @original_checker = original_checker.new(no_method_error)
36
-
37
- @location = no_method_error.backtrace_locations.first
38
- @ivar_names = no_method_error.frame_binding.receiver.instance_variables
39
- end
40
-
41
- def corrections
42
- original_checker.corrections + ivar_name_corrections
43
- end
44
-
45
- def ivar_name_corrections
46
- @ivar_name_corrections ||= SpellChecker.new(dictionary: @ivar_names).correct(receiver_name.to_s)
47
- end
48
-
49
- private
50
-
51
- def receiver_name
52
- return unless @original_checker.receiver.nil?
53
-
54
- abs_path = @location.absolute_path
55
- lineno = @location.lineno
56
-
57
- /@(\w+)*\.#{@original_checker.method_name}/ =~ line(abs_path, lineno).to_s && $1
58
- end
59
-
60
- def line(abs_path, lineno)
61
- if REPLS[abs_path]
62
- REPLS[abs_path].call
63
- elsif File.exist?(abs_path)
64
- File.open(abs_path) do |file|
65
- file.detect { file.lineno == lineno }
66
- end
67
- end
68
- end
69
- end
70
- end
71
-
72
- NameError.send(:attr, :frame_binding)
73
- SPELL_CHECKERS['NoMethodError'] = Experimental::IvarNameCheckerBuilder.new(SPELL_CHECKERS['NoMethodError'])
74
- end
@@ -1,7 +0,0 @@
1
- require 'did_you_mean'
2
- require 'did_you_mean/formatters/verbose_formatter'
3
-
4
- DidYouMean.formatter = DidYouMean::VerboseFormatter.new
5
-
6
- warn '`require "did_you_mean/verbose_formatter"\' has been deprecated and will be removed' \
7
- " in the next major Ruby version. Please require 'did_you_mean/verbose' instead."
@@ -1,47 +0,0 @@
1
- require 'test_helper'
2
-
3
- class NameErrorExtensionTest < Minitest::Test
4
- SPELL_CHECKERS = DidYouMean::SPELL_CHECKERS
5
-
6
- class TestSpellChecker
7
- def initialize(*); end
8
- def corrections; ["does_exist"]; end
9
- end
10
-
11
- def setup
12
- @org, SPELL_CHECKERS['NameError'] = SPELL_CHECKERS['NameError'], TestSpellChecker
13
-
14
- @error = assert_raises(NameError){ doesnt_exist }
15
- end
16
-
17
- def teardown
18
- SPELL_CHECKERS['NameError'] = @org
19
- end
20
-
21
- def test_message
22
- message = <<~MESSAGE.chomp
23
- undefined local variable or method `doesnt_exist' for #{to_s}
24
- Did you mean? does_exist
25
- MESSAGE
26
-
27
- assert_equal message, @error.to_s
28
- assert_equal message, @error.message
29
- end
30
-
31
- def test_to_s_does_not_make_disruptive_changes_to_error_message
32
- error = assert_raises(NameError) do
33
- raise NameError, "uninitialized constant Object"
34
- end
35
-
36
- error.to_s
37
- assert_equal 1, error.to_s.scan("Did you mean?").count
38
- end
39
- end
40
-
41
- class DeprecatedIgnoreCallersTest < Minitest::Test
42
- def test_ignore
43
- assert_output nil, "IGNORED_CALLERS has been deprecated and has no effect.\n" do
44
- DidYouMean::IGNORED_CALLERS << /( |`)do_not_correct_typo'/
45
- end
46
- end
47
- end
@@ -1,9 +0,0 @@
1
- require 'test_helper'
2
-
3
- class DeprecatedFormatterTest < Minitest::Test
4
- def test_deprecated_formatter
5
- assert_output nil, /test\/deprecated_formatter_test.rb:6: warning: constant DidYouMean::Formatter is deprecated/ do
6
- assert_equal "\nDid you mean? does_exist", ::DidYouMean::Formatter.new(['does_exist']).to_s
7
- end
8
- end
9
- end
@@ -1,15 +0,0 @@
1
- require 'test_helper'
2
-
3
- class InitializerNameCorrectionTest < Minitest::Test
4
- def test_corrects_wrong_initializer_name
5
- assert_output nil, "warning: intialize might be misspelled, perhaps you meant initialize?\n" do
6
- Class.new { def intialize; end }
7
- end
8
- end
9
-
10
- def test_does_not_correct_correct_initializer_name
11
- assert_output nil, "" do
12
- Class.new { def initialize; end }
13
- end
14
- end
15
- end
@@ -1,13 +0,0 @@
1
- require 'test_helper'
2
-
3
- class ExperimentalMethodNameCorrectionTest < Minitest::Test
4
- def test_corrects_incorrect_ivar_name
5
- @number = 1
6
- @nubmer = nil
7
- error = assert_raises(NoMethodError) { @nubmer.zero? }
8
- remove_instance_variable :@nubmer
9
-
10
- assert_correction :@number, error.corrections
11
- assert_match "Did you mean? @number", error.to_s
12
- end
13
- end
@@ -1,13 +0,0 @@
1
- require 'minitest/autorun'
2
- require 'minitest/pride'
3
- require 'did_you_mean'
4
-
5
- puts "DidYouMean version: #{DidYouMean::VERSION}"
6
-
7
- module DidYouMean::TestHelper
8
- def assert_correction(expected, array)
9
- assert_equal Array(expected), array, "Expected #{array.inspect} to only include #{expected.inspect}"
10
- end
11
- end
12
-
13
- MiniTest::Test.include(DidYouMean::TestHelper)
@@ -1,23 +0,0 @@
1
- require 'test_helper'
2
-
3
- class VerboseFormatterTest < Minitest::Test
4
- def setup
5
- require 'did_you_mean/verbose'
6
-
7
- does_exist = does_exist = nil
8
- @error = assert_raises(NameError){ doesnt_exist }
9
- end
10
-
11
- def teardown
12
- DidYouMean.formatter = DidYouMean::PlainFormatter.new
13
- end
14
-
15
- def test_message
16
- assert_equal <<~MESSAGE.chomp, @error.message
17
- undefined local variable or method `doesnt_exist' for #{to_s}
18
-
19
- Did you mean? does_exist
20
-
21
- MESSAGE
22
- end
23
- end