did_you_mean 1.1.0 → 1.1.2

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 70f21af56b6f4e14b5c5984d3ce5180a779c81c9
4
- data.tar.gz: 1f73d774f056a90eadace8401876b6f35ea54177
3
+ metadata.gz: e50a42e037d9fa16330e17d7d49e9154d55e82e7
4
+ data.tar.gz: 87d0b5afb0e456b509ed2cb5342260c6620514ab
5
5
  SHA512:
6
- metadata.gz: 17fbd60b5fd5a951b241b1b0277b1888c3495849825fd699dd1da24a8ac9b4b0a7366505f3584a3a41c125e785b6be556ae0a7f736168e39cb3b6d6b36a3cfa5
7
- data.tar.gz: 6a63b180eb98df8cfd4c59c209e9ff676d07e80b548d3d07c05e5e619cacd2725097d9f3da0037b34b517fcedb6c605229c0c4ab5c4fd68a68f124e03d85e9c1
6
+ metadata.gz: 811f197ffe3fe3a3bc4d783f2080350ef7dbe3038478bbb5aaae88f699c9c7b84d6eed8b2b7228825ae97d622e5d3c722f6b0515e7098363b11e1dc3ab249524
7
+ data.tar.gz: eca91e8ddd6b914cd9ac060a3f1fc1dfdc934607c5c5add7f9fbb8cef7dc69bb1576cc28fe5be919a58f25441639175c0d46193b625d1446896e992fe01ad675
data/.ruby-version CHANGED
@@ -1 +1 @@
1
- 2.4.0-dev
1
+ 2.4.1
data/.travis.yml CHANGED
@@ -11,4 +11,5 @@ after_success:
11
11
  - bundle exec rake benchmark:memory
12
12
 
13
13
  rvm:
14
+ - 2.4.0
14
15
  - ruby-head
data/did_you_mean.gemspec CHANGED
@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
17
17
  spec.test_files = spec.files.grep(%r{^(test)/})
18
18
  spec.require_paths = ["lib"]
19
19
 
20
- spec.required_ruby_version = '>= 2.4.0dev'
20
+ spec.required_ruby_version = '>= 2.4.0'
21
21
 
22
22
  spec.add_development_dependency "bundler"
23
23
  spec.add_development_dependency "rake"
@@ -10,7 +10,10 @@ module DidYouMean
10
10
  msg = super.dup
11
11
  bt = caller(1, 6)
12
12
 
13
- msg << Formatter.new(corrections).to_s if IGNORED_CALLERS.all? {|ignored| bt.grep(ignored).empty? }
13
+ if IGNORED_CALLERS.all? {|ignored| bt.grep(ignored).empty? } && (!cause.respond_to?(:corrections) || cause.corrections.empty?)
14
+ msg << Formatter.new(corrections).to_s
15
+ end
16
+
14
17
  msg
15
18
  rescue
16
19
  super
@@ -1,3 +1,3 @@
1
1
  module DidYouMean
2
- VERSION = "1.1.0"
2
+ VERSION = "1.1.2"
3
3
  end
@@ -9,6 +9,12 @@ class MethodNameTest < Minitest::Test
9
9
  raiae NoMethodError
10
10
  end
11
11
 
12
+ def raise_no_method_error
13
+ self.firstname
14
+ rescue NoMethodError => e
15
+ raise e, e.message, e.backtrace
16
+ end
17
+
12
18
  protected
13
19
  def the_protected_method; end
14
20
 
@@ -86,4 +92,28 @@ class MethodNameTest < Minitest::Test
86
92
  ensure
87
93
  NilClass.class_eval { undef empty? }
88
94
  end
95
+
96
+ def test_does_not_append_suggestions_twice
97
+ error = assert_raises NoMethodError do
98
+ begin
99
+ @user.firstname
100
+ rescue NoMethodError => e
101
+ raise e, e.message, e.backtrace
102
+ end
103
+ end
104
+
105
+ assert_equal 1, error.to_s.scan(/Did you mean/).count
106
+ end
107
+
108
+ def test_does_not_append_suggestions_three_times
109
+ error = assert_raises NoMethodError do
110
+ begin
111
+ @user.raise_no_method_error
112
+ rescue NoMethodError => e
113
+ raise e, e.message, e.backtrace
114
+ end
115
+ end
116
+
117
+ assert_equal 1, error.to_s.scan(/Did you mean/).count
118
+ end
89
119
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: did_you_mean
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.1.0
4
+ version: 1.1.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - Yuki Nishijima
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2016-12-19 00:00:00.000000000 Z
11
+ date: 2017-03-25 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: bundler
@@ -119,7 +119,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
119
119
  requirements:
120
120
  - - ">="
121
121
  - !ruby/object:Gem::Version
122
- version: 2.4.0dev
122
+ version: 2.4.0
123
123
  required_rubygems_version: !ruby/object:Gem::Requirement
124
124
  requirements:
125
125
  - - ">="
@@ -127,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
127
127
  version: '0'
128
128
  requirements: []
129
129
  rubyforge_project:
130
- rubygems_version: 2.6.8
130
+ rubygems_version: 2.6.11
131
131
  signing_key:
132
132
  specification_version: 4
133
133
  summary: '"Did you mean?" experience in Ruby'