did_you_mean 0.9.5 → 0.9.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1ca4eb20ca371d3757c5f06e9edd950b12678e52
-  data.tar.gz: b628df2f452d7708b600c84664322005d797cee9
+  metadata.gz: d3c2e7741b6bedc61c7cc58e92c91865569048a9
+  data.tar.gz: 7e59a32ec4e252139f8d263f24b43c9b200ae533
 SHA512:
-  metadata.gz: cc2fbb68045d990ce50f4a3aa260037736f5ad480d3cdaad352d3666020fc88c2e3be7fdbfe27525773d556244c1cfc0c4e7aa8ad3f9174e4b03342be28b9035
-  data.tar.gz: 75e974ffc415ab2fd3d78fdef7de4ce44cb37245124a57a9ae73019f16d9a75025789f34ce2b7c67144f692b609b8acf45bee49e048cc7e033934273b3b6a85d
+  metadata.gz: 67d987ee1812e17a2a4c06ff9c59d614fd2eb8d9bcc71e7ebceaa5a3b4591deaa854543656d1a84ff3e00b57994a7140febd203d0fbb432da2f7bb1ca72b2027
+  data.tar.gz: ff2c13185089c7c6f602f13e3deaf257415ceae0dadd494614989a6ffb85e61a8c9329b7ea8a87a290957ce403c70910f524daeb3ea2e7b0261492f6b0d2df87

data/lib/did_you_mean/finders/similar_method_finder.rb

@@ -8,7 +8,9 @@ module DidYouMean
     end
 
     def words
-      (receiver.methods + receiver.singleton_methods).uniq
+      method_names = receiver.methods + receiver.singleton_methods
+      method_names.delete(@method_name)
+      method_names.uniq
     end
 
     alias target_word method_name

data/lib/did_you_mean/version.rb

@@ -1,3 +1,3 @@
 module DidYouMean
-  VERSION = "0.9.5"
+  VERSION = "0.9.6"
 end

data/test/similar_method_finder_test.rb

@@ -6,9 +6,12 @@ class SimilarMethodFinderTest < Minitest::Test
     def first_name; end
     def descendants; end
 
-    private
+    protected
+    def the_protected_method; end
 
+    private
     def friend; end
+    def the_private_method; end
 
     class << self
       def load; end
@@ -46,4 +49,12 @@ class SimilarMethodFinderTest < Minitest::Test
     error = assert_raises(NoMethodError){ User.new.dependents }
     assert_suggestion error.finder.similar_words, :descendants
   end
+
+  def test_private_methods_should_not_be_suggested
+    error = assert_raises(NoMethodError){ User.new.the_protected_method }
+    refute_includes error.finder.similar_words, 'the_protected_method'
+
+    error = assert_raises(NoMethodError){ User.new.the_private_method }
+    refute_includes error.finder.similar_words, 'the_private_method'
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: did_you_mean
 version: !ruby/object:Gem::Version
-  version: 0.9.5
+  version: 0.9.6
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-07 00:00:00.000000000 Z
+date: 2015-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: interception
@@ -92,7 +92,6 @@ files:
 - ".gitignore"
 - ".travis.yml"
 - Appraisals
-- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md

data/CHANGELOG.md

@@ -1,182 +0,0 @@
-## [v0.9.5](https://github.com/yuki24/did_you_mean/tree/v0.9.5)
-
-_<sup>released on 2015-01-07 12:41:23 UTC</sup>_
-
-#### Bug Fixes
-
-- Whitelist `#safe_constantize` method from `ActiveSupport::Inflector` to avoid significant performance slowdown ( [@tleish](https://github.com/tleish), [#19](https://github.com/yuki24/did_you_mean/issues/19 "Significant Slowdown when Using Debugger"), [#20](https://github.com/yuki24/did_you_mean/pull/20 "Whitelisting safe\_constantize (ActiveSupport::Inflector) method"))
-
-## [v0.9.4](https://github.com/yuki24/did_you_mean/tree/v0.9.4)
-
-_<sup>released on 2014-11-18 03:51:41 UTC</sup>_
-
-#### Bug Fixes
-
-- Fixed a bug where no suggestions will be made in JRuby
-
-## [v0.9.3](https://github.com/yuki24/did_you_mean/tree/v0.9.3)
-
-_<sup>released on 2014-11-18 03:19:24 UTC</sup>_
-
-#### Internal Changes
-
-- Replaced the crazy C extension with a so much better one (thanks to [@nobu](https://github.com/nobu)!)
-
-## [v0.9.2](https://github.com/yuki24/did_you_mean/tree/v0.9.2)
-
-_<sup>released on 2014-11-17 15:32:33 UTC</sup>_
-
-#### Bug Fixes
-
-- Fixed a bug where did\_you\_mean doesn't compile on Ruby 2.1.2/2.1.5 ( [#16](https://github.com/yuki24/did_you_mean/issues/16 "Gem building failed on Debian 6.0.10 x86\_64"))
-
-## [v0.9.1](https://github.com/yuki24/did_you_mean/tree/v0.9.1)
-
-_<sup>released on 2014-11-16 18:54:24 UTC</sup>_
-
-#### Internal Changes
-
-- Shrink the gem size by removing unneeded ruby header files.
-- Now it forces everyone to upgrade the gem when they upgrade Ruby to a new version. This avoids introducing a bug like [#14](https://github.com/yuki24/did_you_mean/issues/14 "Compatibility with `letter\_opener` gem").
-
-## [v0.9.0](https://github.com/yuki24/did_you_mean/tree/v0.9.0)
-
-_<sup>released on 2014-11-09 01:26:31 UTC</sup>_
-
-#### New Features
-
-- did\_you\_mean now suggests instance variable names if `@` is missing ( [#12](https://github.com/yuki24/did_you_mean/issues/12 "Suggest instance- and class-vars"), [<tt>39d1e2b</tt>](https://github.com/yuki24/did_you_mean/commit/39d1e2bd66d6ff8acbc4dd5da922fc7e5fcefb20))
-
-```ruby
-@full_name = "Yuki Nishijima"
-first_name, last_name = full_name.split(" ")
-# => NameError: undefined local variable or method `full_name' for main:Object
-#
-#     Did you mean? @full_name
-#
-```
-
-#### Bug Fixes
-
-- Fixed a bug where did\_you\_mean changes some behaviours of Ruby 2.1.3/2.1.4 installed on Max OS X ( [#14](https://github.com/yuki24/did_you_mean/issues/14 "Compatibility with `letter\_opener` gem"), [<tt>44c451f</tt>](https://github.com/yuki24/did_you_mean/commit/44c451f8c38b11763ba28ddf1ceb9696707ccea0), [<tt>9ebde21</tt>](https://github.com/yuki24/did_you_mean/commit/9ebde211e92eac8494e704f627c62fea7fdbee16))
-- Fixed a bug where sometimes `NoMethodError` suggests duplicate method names ( [<tt>9865cc5</tt>](https://github.com/yuki24/did_you_mean/commit/9865cc5a9ce926dd9ad4c20d575b710e5f257a4b))
-
-## [v0.8.0](https://github.com/yuki24/did_you_mean/tree/v0.8.0)
-
-_<sup>released on 2014-10-27 02:03:13 UTC</sup>_
-
-**This version has been yanked from rubygems.org as it has a serious bug with Ruby 2.1.3 and 2.1.4 installed on Max OS X. Please upgrade to 0.9.0 as soon as possible.**
-
-#### New Features
-
-- JRuby support!
-
-#### Bug Fixes
-
-- Fixed a bug where did\_you\_mean unexpectedly disables [better\_errors](https://github.com/charliesome/better_errors)'s REPL
-- Replaced [binding\_of\_caller](https://github.com/banister/binding_of_caller) dependency with [interception](https://github.com/ConradIrwin/interception)
-- Fixed the wrong implementation of Levenshtein algorithm ( [#2](https://github.com/yuki24/did_you_mean/pull/2 "Fix bug of DidYouMean::Levenshtein#min3."), [@fortissimo1997](https://github.com/fortissimo1997))
-
-## [v0.7.0](https://github.com/yuki24/did_you_mean/tree/v0.7.0)
-
-_<sup>released on 2014-09-26 03:37:18 UTC</sup>_
-
-**This version has been yanked from rubygems.org as it has a serious bug with Ruby 2.1.3 and 2.1.4 installed on Max OS X. Please upgrade to 0.9.0 as soon as possible.**
-
-#### New Features
-
-- Added support for Ruby 2.1.3, 2.2.0-preview1 and ruby-head
-- Added support for ActiveRecord 4.2.0.beta1
-- Word searching is now about 40% faster than v0.6.0
-- Removed `text` gem dependency
-- Better output on pry and Rspec
-
-#### Small/Internal Changes
-
-- A lot of internal refactoring
-
-## [v0.6.0](https://github.com/yuki24/did_you_mean/tree/v0.6.0)
-
-_<sup>released on 2014-05-18 00:23:24 UTC</sup>_
-
-**This version has been yanked from rubygems.org as it has a serious bug with Ruby 2.1.3 and 2.1.4 installed on Max OS X. Please upgrade to 0.9.0 as soon as possible.**
-
-#### New Features
-
-- Added basic support for constants. Now you'll see class name suggestions when you misspelled a class names/module names:
-
-```ruby
-> Ocject
-# => NameError: uninitialized constant Ocject
-#
-#     Did you mean? Object
-#
-```
-
-#### Bug Fixes
-
-- Fixed a bug where did\_you\_mean segfaults on Ruby head(2.2.0dev)
-
-## [v0.5.0](https://github.com/yuki24/did_you_mean/tree/v0.5.0)
-
-_<sup>released on 2014-05-10 17:59:54 UTC</sup>_
-
-#### New Features
-
-- Added support for Ruby 2.1.2
-
-## [v0.4.0](https://github.com/yuki24/did_you_mean/tree/v0.4.0)
-
-_<sup>released on 2014-04-20 02:10:31 UTC</sup>_
-
-#### New Features
-
-- did\_you\_mean now suggests a similar attribute name when you misspelled it.
-
-```ruby
-User.new(flrst_name: "wrong flrst name")
-# => ActiveRecord::UnknownAttributeError: unknown attribute: flrst_name
-#
-#     Did you mean? first_name: string
-#
-```
-
-#### Bug Fixes
-
-- Fixed a bug where did\_you\_mean doesn't work with `ActiveRecord::UnknownAttributeError`
-
-## [v0.3.1](https://github.com/yuki24/did_you_mean/tree/v0.3.1)
-
-_<sup>released on 2014-03-20 23:16:20 UTC</sup>_
-
-#### Small/Internal Changes
-
-- Changed output for readability.
-- Better algorithm to find the correct method.
-
-## [v0.3.0](https://github.com/yuki24/did_you_mean/tree/v0.3.0)
-
-_<sup>released on 2014-03-20 23:13:13 UTC</sup>_
-
-#### New Features
-
-- Added support for Ruby 2.1.1 and 2.2.0(head).
-
-## [v0.2.0](https://github.com/yuki24/did_you_mean/tree/v0.2.0)
-
-_<sup>released on 2014-03-20 23:12:13 UTC</sup>_
-
-#### Incompatible Changes
-
-- dropped support for JRuby and Rubbinious.
-
-#### New Features
-
-- did\_you\_mean no longer makes Ruby slow.
-
-## [v0.1.0: First Release](https://github.com/yuki24/did_you_mean/tree/v0.1.0)
-
-_<sup>released on 2014-03-20 23:11:14 UTC</sup>_
-
-- Now you will have "did you mean?" experience in Ruby!
-- but still very experimental since this gem makes Ruby a lot slower.