did_you_mean 0.5.0 → 0.9.0

data/test/test_helper.rb

@@ -1,7 +1,7 @@
 require 'minitest/autorun'
 require 'minitest/unit'
 require 'did_you_mean'
-require 'active_record'
+require 'mail'
 
 begin
   MiniTest::Test
@@ -9,17 +9,25 @@ rescue NameError
   MiniTest::Test = MiniTest::Unit::TestCase
 end
 
-# database
-ActiveRecord::Base.configurations = {'test' => {adapter: 'sqlite3', database: ':memory:'}}
-ActiveRecord::Base.establish_connection('test')
+require 'did_you_mean/test_helper'
+MiniTest::Test.send :include, DidYouMean::TestHelper
 
-# models
-class User < ActiveRecord::Base; end
+begin
+  require 'active_record'
+
+  # database
+  ActiveRecord::Base.configurations = {'test' => {adapter: 'sqlite3', database: ':memory:'}}
+  ActiveRecord::Base.establish_connection(:test)
+
+  # models
+  class User < ActiveRecord::Base; end
 
-class CreateAllTables < ActiveRecord::Migration
-  def self.up
-    create_table(:users) {|t| t.string :first_name; t.integer :last_name }
+  class CreateAllTables < ActiveRecord::Migration
+    def self.up
+      create_table(:users) {|t| t.string :first_name }
+    end
   end
+  ActiveRecord::Migration.verbose = false
+  CreateAllTables.up
+rescue LoadError
 end
-ActiveRecord::Migration.verbose = false
-CreateAllTables.up

metadata

@@ -1,31 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: did_you_mean
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Yuki Nishijima
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-10 00:00:00.000000000 Z
+date: 2014-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: text
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: binding_of_caller
+  name: interception
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,21 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: appraisal
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -109,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: mail
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -122,8 +94,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: It adds "did you mean?" experience on NoMethodError and NameError because
-  of a typo.
+description: '"did you mean?" experience in Ruby: the error message will tell you
+  the right one when you misspelled something.'
 email:
 - mail@yukinishijima.net
 executables: []
@@ -139,11 +111,10 @@ files:
 - README.md
 - Rakefile
 - did_you_mean.gemspec
-- docs/better_errors_example.png
-- docs/irb_example.png
-- docs/rspec_example.png
+- docs/did_you_mean_example.png
 - ext/did_you_mean/extconf.rb
 - ext/did_you_mean/method_missing.c
+- ext/did_you_mean/org/yukinishijima/ReceiverCapturer.java
 - ext/did_you_mean/ruby_headers/193/addr2line.h
 - ext/did_you_mean/ruby_headers/193/constant.h
 - ext/did_you_mean/ruby_headers/193/debug.h
@@ -240,7 +211,146 @@ files:
 - ext/did_you_mean/ruby_headers/210/vm_exec.h
 - ext/did_you_mean/ruby_headers/210/vm_insnhelper.h
 - ext/did_you_mean/ruby_headers/210/vm_opts.h
+- ext/did_you_mean/ruby_headers/211/addr2line.h
+- ext/did_you_mean/ruby_headers/211/constant.h
+- ext/did_you_mean/ruby_headers/211/dln.h
+- ext/did_you_mean/ruby_headers/211/encdb.h
+- ext/did_you_mean/ruby_headers/211/eval_intern.h
+- ext/did_you_mean/ruby_headers/211/gc.h
+- ext/did_you_mean/ruby_headers/211/id.h
+- ext/did_you_mean/ruby_headers/211/internal.h
+- ext/did_you_mean/ruby_headers/211/iseq.h
+- ext/did_you_mean/ruby_headers/211/method.h
+- ext/did_you_mean/ruby_headers/211/node.h
+- ext/did_you_mean/ruby_headers/211/parse.h
+- ext/did_you_mean/ruby_headers/211/probes.h
+- ext/did_you_mean/ruby_headers/211/probes_helper.h
+- ext/did_you_mean/ruby_headers/211/regenc.h
+- ext/did_you_mean/ruby_headers/211/regint.h
+- ext/did_you_mean/ruby_headers/211/regparse.h
+- ext/did_you_mean/ruby_headers/211/revision.h
+- ext/did_you_mean/ruby_headers/211/ruby_atomic.h
+- ext/did_you_mean/ruby_headers/211/siphash.h
+- ext/did_you_mean/ruby_headers/211/thread_native.h
+- ext/did_you_mean/ruby_headers/211/thread_pthread.h
+- ext/did_you_mean/ruby_headers/211/thread_win32.h
+- ext/did_you_mean/ruby_headers/211/timev.h
+- ext/did_you_mean/ruby_headers/211/transcode_data.h
+- ext/did_you_mean/ruby_headers/211/transdb.h
+- ext/did_you_mean/ruby_headers/211/verconf.h
+- ext/did_you_mean/ruby_headers/211/version.h
+- ext/did_you_mean/ruby_headers/211/vm_core.h
+- ext/did_you_mean/ruby_headers/211/vm_debug.h
+- ext/did_you_mean/ruby_headers/211/vm_exec.h
+- ext/did_you_mean/ruby_headers/211/vm_insnhelper.h
+- ext/did_you_mean/ruby_headers/211/vm_opts.h
+- ext/did_you_mean/ruby_headers/212/addr2line.h
+- ext/did_you_mean/ruby_headers/212/constant.h
+- ext/did_you_mean/ruby_headers/212/dln.h
+- ext/did_you_mean/ruby_headers/212/encdb.h
+- ext/did_you_mean/ruby_headers/212/eval_intern.h
+- ext/did_you_mean/ruby_headers/212/gc.h
+- ext/did_you_mean/ruby_headers/212/id.h
+- ext/did_you_mean/ruby_headers/212/internal.h
+- ext/did_you_mean/ruby_headers/212/iseq.h
+- ext/did_you_mean/ruby_headers/212/method.h
+- ext/did_you_mean/ruby_headers/212/node.h
+- ext/did_you_mean/ruby_headers/212/parse.h
+- ext/did_you_mean/ruby_headers/212/probes.h
+- ext/did_you_mean/ruby_headers/212/probes_helper.h
+- ext/did_you_mean/ruby_headers/212/regenc.h
+- ext/did_you_mean/ruby_headers/212/regint.h
+- ext/did_you_mean/ruby_headers/212/regparse.h
+- ext/did_you_mean/ruby_headers/212/revision.h
+- ext/did_you_mean/ruby_headers/212/ruby_atomic.h
+- ext/did_you_mean/ruby_headers/212/siphash.h
+- ext/did_you_mean/ruby_headers/212/thread_native.h
+- ext/did_you_mean/ruby_headers/212/thread_pthread.h
+- ext/did_you_mean/ruby_headers/212/thread_win32.h
+- ext/did_you_mean/ruby_headers/212/timev.h
+- ext/did_you_mean/ruby_headers/212/transcode_data.h
+- ext/did_you_mean/ruby_headers/212/transdb.h
+- ext/did_you_mean/ruby_headers/212/verconf.h
+- ext/did_you_mean/ruby_headers/212/version.h
+- ext/did_you_mean/ruby_headers/212/vm_core.h
+- ext/did_you_mean/ruby_headers/212/vm_debug.h
+- ext/did_you_mean/ruby_headers/212/vm_exec.h
+- ext/did_you_mean/ruby_headers/212/vm_insnhelper.h
+- ext/did_you_mean/ruby_headers/212/vm_opts.h
+- ext/did_you_mean/ruby_headers/213/addr2line.h
+- ext/did_you_mean/ruby_headers/213/constant.h
+- ext/did_you_mean/ruby_headers/213/dln.h
+- ext/did_you_mean/ruby_headers/213/encdb.h
+- ext/did_you_mean/ruby_headers/213/eval_intern.h
+- ext/did_you_mean/ruby_headers/213/gc.h
+- ext/did_you_mean/ruby_headers/213/id.h
+- ext/did_you_mean/ruby_headers/213/internal.h
+- ext/did_you_mean/ruby_headers/213/iseq.h
+- ext/did_you_mean/ruby_headers/213/method.h
+- ext/did_you_mean/ruby_headers/213/node.h
+- ext/did_you_mean/ruby_headers/213/parse.h
+- ext/did_you_mean/ruby_headers/213/probes.h
+- ext/did_you_mean/ruby_headers/213/probes_helper.h
+- ext/did_you_mean/ruby_headers/213/regenc.h
+- ext/did_you_mean/ruby_headers/213/regint.h
+- ext/did_you_mean/ruby_headers/213/regparse.h
+- ext/did_you_mean/ruby_headers/213/revision.h
+- ext/did_you_mean/ruby_headers/213/ruby_atomic.h
+- ext/did_you_mean/ruby_headers/213/siphash.h
+- ext/did_you_mean/ruby_headers/213/thread_native.h
+- ext/did_you_mean/ruby_headers/213/thread_pthread.h
+- ext/did_you_mean/ruby_headers/213/thread_win32.h
+- ext/did_you_mean/ruby_headers/213/timev.h
+- ext/did_you_mean/ruby_headers/213/transcode_data.h
+- ext/did_you_mean/ruby_headers/213/transdb.h
+- ext/did_you_mean/ruby_headers/213/verconf.h
+- ext/did_you_mean/ruby_headers/213/version.h
+- ext/did_you_mean/ruby_headers/213/vm_core.h
+- ext/did_you_mean/ruby_headers/213/vm_debug.h
+- ext/did_you_mean/ruby_headers/213/vm_exec.h
+- ext/did_you_mean/ruby_headers/213/vm_insnhelper.h
+- ext/did_you_mean/ruby_headers/213/vm_opts.h
+- ext/did_you_mean/ruby_headers/214/addr2line.h
+- ext/did_you_mean/ruby_headers/214/constant.h
+- ext/did_you_mean/ruby_headers/214/dln.h
+- ext/did_you_mean/ruby_headers/214/encdb.h
+- ext/did_you_mean/ruby_headers/214/eval_intern.h
+- ext/did_you_mean/ruby_headers/214/gc.h
+- ext/did_you_mean/ruby_headers/214/id.h
+- ext/did_you_mean/ruby_headers/214/internal.h
+- ext/did_you_mean/ruby_headers/214/iseq.h
+- ext/did_you_mean/ruby_headers/214/method.h
+- ext/did_you_mean/ruby_headers/214/node.h
+- ext/did_you_mean/ruby_headers/214/parse.h
+- ext/did_you_mean/ruby_headers/214/probes.h
+- ext/did_you_mean/ruby_headers/214/probes_helper.h
+- ext/did_you_mean/ruby_headers/214/regenc.h
+- ext/did_you_mean/ruby_headers/214/regint.h
+- ext/did_you_mean/ruby_headers/214/regparse.h
+- ext/did_you_mean/ruby_headers/214/revision.h
+- ext/did_you_mean/ruby_headers/214/ruby_atomic.h
+- ext/did_you_mean/ruby_headers/214/siphash.h
+- ext/did_you_mean/ruby_headers/214/thread_native.h
+- ext/did_you_mean/ruby_headers/214/thread_pthread.h
+- ext/did_you_mean/ruby_headers/214/thread_win32.h
+- ext/did_you_mean/ruby_headers/214/timev.h
+- ext/did_you_mean/ruby_headers/214/transcode_data.h
+- ext/did_you_mean/ruby_headers/214/transdb.h
+- ext/did_you_mean/ruby_headers/214/verconf.h
+- ext/did_you_mean/ruby_headers/214/version.h
+- ext/did_you_mean/ruby_headers/214/vm_core.h
+- ext/did_you_mean/ruby_headers/214/vm_debug.h
+- ext/did_you_mean/ruby_headers/214/vm_exec.h
+- ext/did_you_mean/ruby_headers/214/vm_insnhelper.h
+- ext/did_you_mean/ruby_headers/214/vm_opts.h
 - ext/did_you_mean/ruby_headers/220/addr2line.h
+- ext/did_you_mean/ruby_headers/220/ccan/build_assert/build_assert.h
+- ext/did_you_mean/ruby_headers/220/ccan/check_type/check_type.h
+- ext/did_you_mean/ruby_headers/220/ccan/container_of/container_of.h
+- ext/did_you_mean/ruby_headers/220/ccan/licenses/BSD-MIT
+- ext/did_you_mean/ruby_headers/220/ccan/licenses/CC0
+- ext/did_you_mean/ruby_headers/220/ccan/list/list.h
+- ext/did_you_mean/ruby_headers/220/ccan/str/str.h
 - ext/did_you_mean/ruby_headers/220/constant.h
 - ext/did_you_mean/ruby_headers/220/dln.h
 - ext/did_you_mean/ruby_headers/220/encdb.h
@@ -260,6 +370,7 @@ files:
 - ext/did_you_mean/ruby_headers/220/revision.h
 - ext/did_you_mean/ruby_headers/220/ruby_atomic.h
 - ext/did_you_mean/ruby_headers/220/siphash.h
+- ext/did_you_mean/ruby_headers/220/symbol.h
 - ext/did_you_mean/ruby_headers/220/thread_native.h
 - ext/did_you_mean/ruby_headers/220/thread_pthread.h
 - ext/did_you_mean/ruby_headers/220/thread_win32.h
@@ -279,18 +390,26 @@ files:
 - gemfiles/activerecord_32.gemfile
 - gemfiles/activerecord_40.gemfile
 - gemfiles/activerecord_41.gemfile
+- gemfiles/activerecord_42.gemfile
 - gemfiles/activerecord_edge.gemfile
 - lib/did_you_mean.rb
 - lib/did_you_mean/core_ext/name_error.rb
-- lib/did_you_mean/method_finder.rb
-- lib/did_you_mean/strategies.rb
-- lib/did_you_mean/strategies/similar_attribute_finder.rb
-- lib/did_you_mean/strategies/similar_method_finder.rb
-- lib/did_you_mean/strategies/similar_name_finder.rb
+- lib/did_you_mean/finders.rb
+- lib/did_you_mean/finders/name_error_finders.rb
+- lib/did_you_mean/finders/name_error_finders/similar_class_finder.rb
+- lib/did_you_mean/finders/name_error_finders/similar_name_finder.rb
+- lib/did_you_mean/finders/similar_attribute_finder.rb
+- lib/did_you_mean/finders/similar_method_finder.rb
+- lib/did_you_mean/levenshtein.rb
+- lib/did_you_mean/test_helper.rb
 - lib/did_you_mean/version.rb
-- test.sh
+- lib/did_you_mean/word_collection.rb
 - test/all_test.rb
+- test/name_error_extension_test.rb
+- test/no_method_error_extension_test.rb
+- test/null_finder_test.rb
 - test/similar_attribute_finder_test.rb
+- test/similar_class_finder_test.rb
 - test/similar_method_finder_test.rb
 - test/similar_name_finder_test.rb
 - test/test_helper.rb
@@ -314,13 +433,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.2
 signing_key: 
 specification_version: 4
 summary: '"Did you mean?" experience in Ruby'
 test_files:
 - test/all_test.rb
+- test/name_error_extension_test.rb
+- test/no_method_error_extension_test.rb
+- test/null_finder_test.rb
 - test/similar_attribute_finder_test.rb
+- test/similar_class_finder_test.rb
 - test/similar_method_finder_test.rb
 - test/similar_name_finder_test.rb
 - test/test_helper.rb

data/lib/did_you_mean/method_finder.rb

@@ -1,24 +0,0 @@
-require "text"
-
-module DidYouMean
-  class MethodMatcher
-    def initialize(method_collection, target_method)
-      @method_collection = method_collection.uniq
-      @target_method     = target_method
-    end
-
-    def similar_methods
-      @similar_methods ||= method_collection.select do |method|
-        ::Text::Levenshtein.distance(method.to_s, target_method.to_s) <= sensitiveness
-      end
-    end
-
-    private
-
-    attr_reader :method_collection, :target_method
-
-    def sensitiveness
-      (target_method.size * 0.3).ceil
-    end
-  end
-end

data/lib/did_you_mean/strategies.rb

@@ -1,23 +0,0 @@
-module DidYouMean
-  class NullFinder
-    def self.build(*)
-      new
-    end
-
-    def did_you_mean?; end
-
-    def empty?
-      true
-    end
-  end
-
-  @@strategies = Hash.new(NullFinder)
-
-  def self.strategies
-    @@strategies
-  end
-end
-
-require 'did_you_mean/strategies/similar_name_finder'
-require 'did_you_mean/strategies/similar_method_finder'
-require 'did_you_mean/strategies/similar_attribute_finder'

data/lib/did_you_mean/strategies/similar_attribute_finder.rb

@@ -1,41 +0,0 @@
-module DidYouMean
-  class SimilarAttributeFinder
-    attr_reader :columns, :attribute_name
-
-    def self.build(exception)
-      columns        = exception.frame_binding.eval("self.class").columns
-      attribute_name = exception.original_message.gsub("unknown attribute: ", "")
-
-      new(attribute_name, columns)
-    end
-
-    def initialize(attribute_name, columns)
-      @attribute_name, @columns = attribute_name, columns
-    end
-
-    def did_you_mean?
-      return if empty?
-
-      output = "\n\n"
-      output << "    Did you mean? #{format(similar_columns.first)}\n"
-      output << similar_columns[1..-1].map{|word| "#{' ' * 18}#{format(word)}\n" }.join
-      output
-    end
-
-    def empty?
-      similar_columns.empty?
-    end
-
-    def similar_columns
-      @similar_columns ||= MethodMatcher.new(columns.map(&:name), attribute_name).similar_methods
-    end
-
-    private
-
-    def format(name)
-      "%s: %s" % [name, columns.detect{|c| c.name == name }.type]
-    end
-  end
-
-  strategies["ActiveRecord::UnknownAttributeError"] = SimilarAttributeFinder
-end

data/lib/did_you_mean/strategies/similar_method_finder.rb

@@ -1,46 +0,0 @@
-module DidYouMean
-  class SimilarMethodFinder
-    attr_reader :name, :receiver
-
-    def self.build(exception)
-      new(exception.name, exception.args.first)
-    end
-
-    def initialize(name, receiver)
-      @name, @receiver = name, receiver
-    end
-
-    def did_you_mean?
-      return if empty?
-
-      output = "\n\n"
-      output << "   Did you mean? #{separator}#{similar_methods.first}\n"
-      output << similar_methods[1..-1].map{|word| "#{' ' * 17}#{separator}#{word}\n" }.join
-      output
-    end
-
-    def empty?
-      similar_methods.empty?
-    end
-
-    def similar_methods
-      @similar_methods ||= MethodMatcher.new(receiver.methods + receiver.singleton_methods, name).similar_methods
-    end
-
-    private
-
-    def receiver_name
-      class_method? ? receiver.name : receiver.class.name
-    end
-
-    def separator
-      class_method? ? "." : "#"
-    end
-
-    def class_method?
-      receiver.is_a? Class
-    end
-  end
-
-  strategies["NoMethodError"] = SimilarMethodFinder
-end