dice_bag 0.8.0 → 0.9.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    NDlkYzIxYjM3Zjk1YTM2YThhYTc2OWQ0YjE1MGZiYzg1YTUwMzlmOQ==
-  data.tar.gz: !binary |-
-    MjBkY2RhMWU0ZTI0ZWMzMDhiM2JkMTczYmRhYmIzYWIwYWU2YTFjYg==
+SHA1:
+  metadata.gz: 60e5efa65c58bb068ea937851e75ace6470f3b0c
+  data.tar.gz: 56c46bf21478f61b2af8e5a3d689fc0204a4ef73
 SHA512:
-  metadata.gz: !binary |-
-    NTU5ZTQzMzgzODlmN2ZmYzNiOTczMTQzODRlYzA2YTUxNjBlOTNiN2MzZGY5
-    OTc2OGZjZTI2ZjcwYjQ2YTA3YjA5YWEyZDg5ZDBlMmE1MDNhM2EwMmI4YWY5
-    ZmNhZWRhZWYxMzNjZmFhMjVjMDExMmRiOWY3ZWMzODkyYTVhM2U=
-  data.tar.gz: !binary |-
-    MDJlZGIzNDgzMWIzMDhkYTJlYzJlMGU4Y2NiYWQ3ZDYxMmQxZWU4NGFjOGRm
-    MzdhYzhhM2ZjMmZlMjM1MWNiZDdhNmZiN2VjMzc1NDU3YTgxODQ3MjY2Yjll
-    ZTI5MjMwMThlMzJlYzM3ZGQ0NGZjMDY2NjgxOWVmMzJiMzJkMjY=
+  metadata.gz: 27e0e05915afc78875d92a57a1587f5efd75282f9985c124f28f6cbd59db012e77e75d2b51e97e8ab6d11ca5917774c0a1641c98a928d2d9ab63e704c6fb9df7
+  data.tar.gz: 95970fb430a7b7fac1c662d6b27033d5db905be6598f9aea21bc802366e1d19345241c62af9fa1a49dd307723cd134b49240f574cb6c0dca038b33ec514c8fd0

data/lib/dice_bag/configuration.rb

@@ -16,7 +16,28 @@ module DiceBag
     end
 
     def method_missing(name)
-      ENV[name.to_s.upcase]
+      if name.to_s.end_with?('!')
+        ensured_in_production(name)
+      else
+        ENV[name.to_s.upcase]
+      end
+    end
+
+    private
+
+    def ensured_in_production(name)
+      variable_name = name.to_s.chomp('!').upcase
+      value = ENV[variable_name]
+      if in_production? && value.nil?
+        raise "Environment variable #{variable_name} required in production but it was not provided"
+      end
+      value
+    end
+
+    def in_production?
+      (defined?(Rails) && Rails.env.production?) ||
+      (defined?(Sinatra) && Sinatra::Application.production?) ||
+      ENV['RACK_ENV'] == 'production'
     end
 
     # This class acts like +Configuration+ but with a prefix applied to the

data/lib/dice_bag/templates/newrelic.yml.dice

@@ -5,7 +5,7 @@ common: &default_settings
   app_name: <%= configured.domain || 'PROJECT_NAME' %>
   enabled: <%= configured.enable_newrelic || false %>
   log_level: <%= configured.new_relic_debug == 'true' ? 'debug' : 'info' %>
-  ssl: false
+  ssl: true
   apdex_t: 0.5
   capture_params: false
   transaction_tracer:

data/lib/dice_bag/version.rb

@@ -1,3 +1,3 @@
 module DiceBag
-  VERSION = '0.8.0'
+  VERSION = '0.9.0'
 end

data/spec/command_spec.rb

@@ -6,7 +6,7 @@ describe DiceBag::Project do
 
   describe "#name" do 
     it "should give me a default name for non Rails apps" do
-      project.name.should == DiceBag::Project::DEFAULT_NAME
+      expect(project.name).to eq(DiceBag::Project::DEFAULT_NAME)
     end
   end
 

data/spec/configuration_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+require 'dice_bag/configuration'
+module DiceBag
+
+  shared_examples_for 'configuration in production' do
+    it 'returns values ending in ! available in the environment' do
+      expect(Configuration.new.test_var!).to eq(value)
+    end
+    it 'returns values not ending in ! not available in the environment' do
+      expect(Configuration.new.idontexist).to eq(nil)
+    end
+    it 'raises an exception when the value ends in ! and is not available in the environment' do
+      expect{Configuration.new.idontexist!}.to raise_exception(StandardError)
+    end
+  end
+
+
+  RSpec.describe Configuration do
+    let(:value) { '42' }
+    before(:each) do
+      ENV['TEST_VAR'] = value
+    end
+
+    it "returns values" do
+      expect(Configuration.new.test_var).to eq(value)
+    end
+    it "returns values ending in !" do
+      expect(Configuration.new.test_var!).to eq(value)
+    end
+
+    context 'Running in Rails production environment' do
+      before(:each) do
+        rails = class_double('Rails')
+        allow(rails).to receive_message_chain("env.production?") { true }
+        stub_const("Rails", rails)
+      end
+      it_behaves_like 'configuration in production'
+    end
+
+    context 'Running in Sinatra production environment' do
+      before(:each) do
+        sinatra = class_double('Sinatra')
+        allow(sinatra).to receive(:production?).and_return(true)
+        stub_const("Sinatra::Application", sinatra)
+      end
+      it_behaves_like 'configuration in production'
+    end
+
+    context 'Running in a rack app production environment' do
+      # Not the most elegant but given how much we use ENV in these tests, does seem good enough
+      before(:each) do
+        ENV['RACK_ENV'] = 'production'
+      end
+      after(:each) do
+        ENV['RACK_ENV'] = nil
+      end
+      it_behaves_like 'configuration in production'
+    end
+
+  end
+end

data/spec/spec_helper.rb

@@ -5,7 +5,6 @@ require 'dice_bag'
 require 'rspec'
 
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   config.order = 'random'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dice_bag
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Andrew Smith
@@ -9,67 +9,65 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-03 00:00:00.000000000 Z
+date: 2015-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: aruba
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.12'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Dice Bag is a library of rake tasks for configuring web apps in the style
-  of The Twelve-Factor App. It also provides continuous integration tasks that rely
-  on the configuration tasks.
+description: 
 email:
 - asmith@mdsol.com
 - jcarres@mdsol.com
@@ -100,10 +98,10 @@ files:
 - lib/dice_bag/version.rb
 - lib/dice_bag/warning.rb
 - spec/command_spec.rb
+- spec/configuration_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/mdsol/dice_bag
-licenses:
-- MIT
+licenses: []
 metadata: {}
 post_install_message: 
 rdoc_options: []
@@ -111,12 +109,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -129,5 +127,6 @@ summary: Dice Bag is a library of rake tasks for configuring web apps in the sty
   on the configuration tasks.
 test_files:
 - spec/command_spec.rb
+- spec/configuration_spec.rb
 - spec/spec_helper.rb
 has_rdoc: