diaspora_federation 0.2.5 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 35131d74a51b0fc8445843fb59db5f48f964d7462f892d4c1324eaaa34ad927d
-  data.tar.gz: dcc6e003cffe457597d42a0659fc85a52355834f966ca05ccef8cafae57a42dd
+  metadata.gz: 202b522935a3c394944b6578a45868370beff4748994f9bf8fa5cded6dd436b0
+  data.tar.gz: 761667ad6330ccb2088751a0bde704e914b0e590f347938577c19002d0aaf4a4
 SHA512:
-  metadata.gz: ae87265e272332d979019e06c2bcade0bed570da326213efc5ddc3f7a5c3c4dac573d0bdf7b0836827cd68325ecde557fc959daa55b647e71cc07cc28d48d79b
-  data.tar.gz: 56c39d7011b5c8ed4e10270682cf9d7ed57b3765e8dbee6d1fd3d2a55630fe9c804eb1ac47147771ea2ce5730805ba8cdb7408dd950ba60c824e35abbed200d6
+  metadata.gz: 1adda0e8a5d0f789a31a589b24775ea2b09e06d3d24116ea29f0a8057680783a8dd79094c7f4c0047c1c064b18d92c2d40b6c9506ab813284c826589f714b9c3
+  data.tar.gz: dcd14ec61c90371f4153094b02d0341838b92d37401cb1354c1845d81cbeaf6b3d32fc883809a88ad35dc6974a5b4d2d6a5f3ed844ab2ddb658c292ca070c6be

data/Changelog.md

@@ -1,3 +1,35 @@
+# 0.3.0
+
+## Breaking changes
+
+* Drop support for rails 5.1 and older [4b4375c](https://github.com/diaspora/diaspora_federation/commit/4b4375cf787e09537f53aff92b054a0386681747) [ecfe0ea](https://github.com/diaspora/diaspora_federation/commit/ecfe0ea850d203e8144adab744c4b43263200902)
+* Drop support for ruby 2.6 and older [68df3cf](https://github.com/diaspora/diaspora_federation/commit/68df3cf555efafc72942cfec2c8fb3e8852ddec1) [#121](https://github.com/diaspora/diaspora_federation/pull/121)
+* Drop support for faraday 0.x [#116](https://github.com/diaspora/diaspora_federation/pull/116)
+* Remove support to receive old federation protocol [#114](https://github.com/diaspora/diaspora_federation/pull/114)
+* Remove support for old non-RFC WebFinger [#122](https://github.com/diaspora/diaspora_federation/pull/122)
+
+## Features
+
+* Add rails 6 support [afee784](https://github.com/diaspora/diaspora_federation/commit/afee78476b1715ba32e2b97d7cbf2584d57718dd)
+* Add faraday 1.x support [#116](https://github.com/diaspora/diaspora_federation/pull/116)
+* Add support for up to ruby 3.1 [#121](https://github.com/diaspora/diaspora_federation/pull/121)
+
+# 0.2.7
+
+## Features
+
+* Add `remote_photo_path` to `AccountMigration` entity [#119](https://github.com/diaspora/diaspora_federation/pull/119)
+
+## Bug fixes
+
+* Only parse each nested element name once from the XML [#118](https://github.com/diaspora/diaspora_federation/pull/118)
+
+# 0.2.6
+
+## Bug fixes
+
+* Make `width` and `height` optional for photos in the JSON schema [#110](https://github.com/diaspora/diaspora_federation/pull/110)
+
 # 0.2.5
 
 ## Features

data/lib/diaspora_federation/callbacks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   # Callbacks are used to communicate with the application. They are called to
   # fetch data and after data is received.

data/lib/diaspora_federation/discovery/discovery.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Discovery
     # This class contains the logic to fetch all data for the given diaspora* ID.
@@ -22,7 +24,7 @@ module DiasporaFederation
         validate_diaspora_id
 
         DiasporaFederation.callbacks.trigger(:save_person_after_webfinger, person)
-        logger.info "successfully webfingered #{diaspora_id}"
+        logger.info "Successfully webfingered #{diaspora_id}"
         person
       rescue DiscoveryError
         raise # simply re-raise DiscoveryError
@@ -35,6 +37,7 @@ module DiasporaFederation
       def validate_diaspora_id
         # Validates if the diaspora* ID matches the diaspora* ID in the webfinger response
         return if diaspora_id == clean_diaspora_id(webfinger.acct_uri)
+
         raise DiscoveryError, "diaspora* ID does not match: Wanted #{diaspora_id} but got" \
                               " #{clean_diaspora_id(webfinger.acct_uri)}"
       end
@@ -43,19 +46,17 @@ module DiasporaFederation
         diaspora_id.strip.sub("acct:", "").to_s.downcase
       end
 
-      def get(url, http_fallback=false)
+      def get(url, http_fallback: false)
         logger.info "Fetching #{url} for #{diaspora_id}"
         response = HttpClient.get(url)
         raise "Failed to fetch #{url}: #{response.status}" unless response.success?
+
         response.body
       rescue => e # rubocop:disable Style/RescueStandardError
-        unless http_fallback && url.start_with?("https://")
-          raise DiscoveryError, "Failed to fetch #{url} for #{diaspora_id}: #{e.class}: #{e.message}"
-        end
+        raise DiscoveryError, "Failed to fetch #{url} for #{diaspora_id}: #{e.class}: #{e.message}" unless http_fallback
 
         logger.warn "Retry with http: #{url} for #{diaspora_id}: #{e.class}: #{e.message}"
-        url.sub!("https://", "http://")
-        retry
+        get(url.sub("https://", "http://"))
       end
 
       def domain
@@ -66,21 +67,11 @@ module DiasporaFederation
         "acct:#{diaspora_id}"
       end
 
-      def legacy_webfinger_url_from_host_meta
-        # This tries the xrd url with https first, then falls back to http.
-        host_meta = HostMeta.from_xml(get("https://#{domain}/.well-known/host-meta", true))
-        host_meta.webfinger_template_url.gsub("{uri}", acct_parameter)
-      end
-
       def webfinger
-        return @webfinger if @webfinger
-        webfinger_url = "https://#{domain}/.well-known/webfinger?resource=#{acct_parameter}"
-
         # This tries the WebFinger URL with https first, then falls back to http if webfinger_http_fallback is enabled.
-        @webfinger = WebFinger.from_json(get(webfinger_url, DiasporaFederation.webfinger_http_fallback))
-      rescue => e # rubocop:disable Style/RescueStandardError
-        logger.warn "WebFinger failed, retrying with legacy WebFinger for #{diaspora_id}: #{e.class}: #{e.message}"
-        @webfinger = WebFinger.from_xml(get(legacy_webfinger_url_from_host_meta))
+        @webfinger ||=
+          WebFinger.from_json(get("https://#{domain}/.well-known/webfinger?resource=#{acct_parameter}",
+                                  http_fallback: DiasporaFederation.webfinger_http_fallback))
       end
 
       def hcard

data/lib/diaspora_federation/discovery/exceptions.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Discovery
     # Raised, if there is an error while discover a new person

data/lib/diaspora_federation/discovery/h_card.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Discovery
     # This class provides the means of generating and parsing account data to and
@@ -54,14 +56,6 @@ module DiasporaFederation
       #   @return [String] display name of the user
       property :full_name, :string
 
-      # @!attribute [r] url
-      #   @deprecated should be changed to the profile url. The pod url is in
-      #     the WebFinger (see {WebFinger#seed_url}, will affect older diaspora*
-      #     installations).
-      #
-      #   @return [String] link to the pod
-      property :url, :string, optional: true
-
       # @!attribute [r] public_key
       #   When a user is created on the pod, the pod MUST generate a pgp keypair
       #   for them. This key is used for signing messages. The format is a
@@ -143,10 +137,6 @@ module DiasporaFederation
         add_simple_property(content, :family_name, "family_name", @last_name)
         #######################################
 
-        add_property(content, :url) do |html|
-          html.a(@url.to_s, id: "pod_location", class: "url", rel: "me", href: @url.to_s)
-        end
-
         add_photos(content)
 
         builder.doc.to_xhtml(indent: 2, indent_text: " ")
@@ -260,6 +250,7 @@ module DiasporaFederation
 
         doc = Nokogiri::HTML::Document.parse(html_string)
         raise InvalidData, "hcard html incomplete" unless html_document_complete?(doc)
+
         doc
       end
 

data/lib/diaspora_federation/discovery/web_finger.rb

@@ -1,10 +1,9 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Discovery
     # The WebFinger document used for diaspora* user discovery is based on an
-    # {http://tools.ietf.org/html/draft-jones-appsawg-webfinger older draft of the specification}.
-    #
-    # In the meantime an actual RFC draft has been in development, which should
-    # serve as a base for all future changes of this implementation.
+    # {https://datatracker.ietf.org/doc/html/rfc7033 RFC 7033}.
     #
     # @example Creating a WebFinger document from a person hash
     #   wf = WebFinger.new(
@@ -15,22 +14,20 @@ module DiasporaFederation
     #     atom_url:    "https://server.example/public/user.atom",
     #     salmon_url:  "https://server.example/receive/users/0123456789abcdef"
     #   )
-    #   xml_string = wf.to_xml
+    #   json_string = wf.to_json
     #
-    # @example Creating a WebFinger instance from an xml document
-    #   wf = WebFinger.from_xml(xml_string)
+    # @example Creating a WebFinger instance from an JSON document
+    #   wf = WebFinger.from_json(json_string)
     #   ...
     #   hcard_url = wf.hcard_url
     #   ...
     #
-    # @see http://tools.ietf.org/html/draft-jones-appsawg-webfinger "WebFinger" -
-    #   current draft
     # @see http://www.iana.org/assignments/link-relations/link-relations.xhtml
     #   official list of IANA link relations
     class WebFinger < Entity
       # @!attribute [r] acct_uri
-      #   The Subject element should contain the webfinger address that was asked
-      #   for. If it does not, then this webfinger profile MUST be ignored.
+      #   The Subject element should contain the WebFinger address that was asked
+      #   for. If it does not, then this WebFinger profile MUST be ignored.
       #   @return [String]
       property :acct_uri, :string
 
@@ -65,27 +62,27 @@ module DiasporaFederation
       property :salmon_url, :string, optional: true
 
       # @!attribute [r] subscribe_url
-      #   This url is used to find another user on the home-pod of the user in the webfinger.
+      #   This url is used to find another user on the home-pod of the user in the WebFinger.
       property :subscribe_url, :string, optional: true
 
       # +hcard_url+ link relation
-      REL_HCARD = "http://microformats.org/profile/hcard".freeze
+      REL_HCARD = "http://microformats.org/profile/hcard"
 
       # +seed_url+ link relation
-      REL_SEED = "http://joindiaspora.com/seed_location".freeze
+      REL_SEED = "http://joindiaspora.com/seed_location"
 
       # +profile_url+ link relation.
       # @note This might just as well be an +Alias+ instead of a +Link+.
-      REL_PROFILE = "http://webfinger.net/rel/profile-page".freeze
+      REL_PROFILE = "http://webfinger.net/rel/profile-page"
 
       # +atom_url+ link relation
-      REL_ATOM = "http://schemas.google.com/g/2010#updates-from".freeze
+      REL_ATOM = "http://schemas.google.com/g/2010#updates-from"
 
       # +salmon_url+ link relation
-      REL_SALMON = "salmon".freeze
+      REL_SALMON = "salmon"
 
       # +subscribe_url+ link relation
-      REL_SUBSCRIBE = "http://ostatus.org/schema/1.0/subscribe".freeze
+      REL_SUBSCRIBE = "http://ostatus.org/schema/1.0/subscribe"
 
       # Additional WebFinger data
       # @return [Hash] additional elements
@@ -104,29 +101,29 @@ module DiasporaFederation
         super(data)
       end
 
-      # Creates the XML string from the current WebFinger instance
-      # @return [String] XML string
+      # @!visibility private
+      # Generating WebFinger to XML is not supported anymore, use {#to_json} instead.
       def to_xml
-        to_xrd.to_xml
+        raise "Generating WebFinger to XML is not supported anymore, use 'to_json' instead."
       end
 
-      def to_json
+      # Creates the JSON string from the current WebFinger instance
+      # @return [String] JSON string
+      def to_json(*_args)
         to_xrd.to_json
       end
 
-      # Creates a WebFinger instance from the given XML string
-      # @param [String] webfinger_xml WebFinger XML string
-      # @return [WebFinger] WebFinger instance
-      # @raise [InvalidData] if the given XML string is invalid or incomplete
-      def self.from_xml(webfinger_xml)
-        from_hash(parse_xml_and_validate(webfinger_xml))
+      # @!visibility private
+      # Parsing WebFinger as XML is not supported anymore, use {from_json} instead.
+      def self.from_xml(_webfinger_xml)
+        raise "Parsing WebFinger as XML is not supported anymore, use 'from_json' instead."
       end
 
       # Creates a WebFinger instance from the given JSON string
       # @param [String] webfinger_json WebFinger JSON string
       # @return [WebFinger] WebFinger instance
       def self.from_json(webfinger_json)
-        from_hash(XrdDocument.json_data(webfinger_json))
+        from_hash(parse_json_and_validate(webfinger_json))
       end
 
       # Creates a WebFinger instance from the given data
@@ -155,15 +152,15 @@ module DiasporaFederation
 
       private
 
-      # Parses the XML string to a Hash and does some rudimentary checking on
+      # Parses the JSON string to a Hash and does some rudimentary checking on
       # the data Hash.
-      # @param [String] webfinger_xml WebFinger XML string
-      # @return [Hash] data XML data
-      # @raise [InvalidData] if the given XML string is invalid or incomplete
-      private_class_method def self.parse_xml_and_validate(webfinger_xml)
-        XrdDocument.xml_data(webfinger_xml).tap do |data|
+      # @param [String] webfinger_json WebFinger JSON string
+      # @return [Hash] data JSON data
+      # @raise [InvalidData] if the given JSON string is invalid or incomplete
+      private_class_method def self.parse_json_and_validate(webfinger_json)
+        XrdDocument.json_data(webfinger_json).tap do |data|
           valid = data.key?(:subject) && data.key?(:links)
-          raise InvalidData, "webfinger xml is incomplete" unless valid
+          raise InvalidData, "Webfinger JSON is incomplete" unless valid
         end
       end
 

data/lib/diaspora_federation/discovery/xrd_document.rb

@@ -1,15 +1,13 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Discovery
     # This class implements basic handling of XRD documents as far as it is
     # necessary in the context of the protocols used with diaspora* federation.
     #
-    # @note {http://tools.ietf.org/html/rfc6415 RFC 6415} recommends that servers
-    #   should also offer the JRD format in addition to the XRD representation.
-    #   Implementing +XrdDocument#to_json+ and +XrdDocument.json_data+ should
-    #   be almost trivial due to the simplicity of the format and the way the data
-    #   is stored internally already. See
-    #   {http://tools.ietf.org/html/rfc6415#appendix-A RFC 6415, Appendix A}
-    #   for a description of the JSON format.
+    # It also implements handling of the JRD format, see
+    # {https://datatracker.ietf.org/doc/html/rfc6415#appendix-A RFC 6415, Appendix A}
+    # for a description of the JSON format.
     #
     # @example Creating a XrdDocument
     #   doc = XrdDocument.new
@@ -29,13 +27,13 @@ module DiasporaFederation
     # @see http://docs.oasis-open.org/xri/xrd/v1.0/xrd-1.0.html Extensible Resource Descriptor (XRD) Version 1.0
     class XrdDocument
       # xml namespace url
-      XMLNS = "http://docs.oasis-open.org/ns/xri/xrd-1.0".freeze
+      XMLNS = "http://docs.oasis-open.org/ns/xri/xrd-1.0"
 
       # +Link+ element attributes
       LINK_ATTRS = %i[rel type href template].freeze
 
       # format string for datetime (+Expires+ element)
-      DATETIME_FORMAT = "%Y-%m-%dT%H:%M:%SZ".freeze
+      DATETIME_FORMAT = "%Y-%m-%dT%H:%M:%SZ"
 
       # The <Expires> element contains a time value which specifies the instant at
       # and after which the document has expired and SHOULD NOT be used.
@@ -80,14 +78,14 @@ module DiasporaFederation
         }.to_xml
       end
 
-      def to_json
+      def to_json(*_args)
         {
           subject:    subject,
           expires:    (expires.strftime(DATETIME_FORMAT) if expires.instance_of?(DateTime)),
           aliases:    (aliases if aliases.any?),
           properties: (properties if properties.any?),
           links:      (links if links.any?)
-        }.reject {|_, v| v.nil? }
+        }.compact
       end
 
       # Parse the XRD document from the given string and create a hash containing
@@ -130,7 +128,7 @@ module DiasporaFederation
           aliases:    json_hash["aliases"],
           properties: json_hash["properties"],
           links:      symbolize_keys_for_links(json_hash["links"])
-        }.reject {|_, v| v.nil? }
+        }.compact
       rescue JSON::JSONError => e
         raise InvalidDocument,
               "Not a JRD document: #{e.class}: #{e.message[0..255].encode(Encoding.default_external, undef: :replace)}"
@@ -138,14 +136,17 @@ module DiasporaFederation
 
       private
 
+      # rubocop:disable Layout/EmptyLinesAroundAttributeAccessor Style/AccessorGrouping
       attr_reader :expires
       attr_reader :subject
+      # rubocop:enable Layout/EmptyLinesAroundAttributeAccessor Style/AccessorGrouping
 
       NS = {xrd: XMLNS}.freeze
 
       def add_aliases_to(xml)
         aliases.each do |a|
           next if !a.instance_of?(String) || a.empty?
+
           xml.Alias(a.to_s)
         end
       end
@@ -171,6 +172,7 @@ module DiasporaFederation
 
         doc = Nokogiri::XML(xrd_doc)
         raise InvalidDocument, "Not an XRD document" if !doc.root || doc.root.name != "XRD"
+
         doc
       end
 
@@ -204,7 +206,7 @@ module DiasporaFederation
 
       # symbolize link keys from JSON hash, but only convert known keys
       private_class_method def self.symbolize_keys_for_links(links)
-        links.map do |link|
+        links&.map do |link|
           {}.tap do |hash|
             LINK_ATTRS.each do |attr|
               hash[attr] = link[attr.to_s] if link.key?(attr.to_s)

data/lib/diaspora_federation/discovery.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   # This module provides the namespace for the various classes implementing
   # WebFinger and other protocols used for metadata discovery on remote servers
@@ -8,7 +10,6 @@ end
 
 require "diaspora_federation/discovery/exceptions"
 require "diaspora_federation/discovery/xrd_document"
-require "diaspora_federation/discovery/host_meta"
 require "diaspora_federation/discovery/web_finger"
 require "diaspora_federation/discovery/h_card"
 require "diaspora_federation/discovery/discovery"

data/lib/diaspora_federation/entities/account_deletion.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity is sent when an account was deleted on a remote pod.
@@ -12,7 +14,7 @@ module DiasporaFederation
       #   Alias for author
       #   @see AccountDeletion#author
       #   @return [String] diaspora* ID
-      property :author, :string, alias: :diaspora_id, xml_name: :diaspora_handle
+      property :author, :string, alias: :diaspora_id
 
       # @return [String] string representation of this object
       def to_s

data/lib/diaspora_federation/entities/account_migration/signable.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     class AccountMigration < Entity

data/lib/diaspora_federation/entities/account_migration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity is sent when a person changes their diaspora* ID (e.g. when a user migration
@@ -33,17 +35,23 @@ module DiasporaFederation
       #   @return [String] old identity
       property :old_identity, :string, default: nil
 
+      # @!attribute [r] remote_photo_path
+      #   The url to the path of the photos on the new pod. Can be empty if photos weren't migrated.
+      #   @return [String] remote photo path
+      property :remote_photo_path, :string, optional: true
+
       # Returns diaspora* ID of the old person identity.
       # @return [String] diaspora* ID of the old person identity
       def old_identity
         return @old_identity if author_is_new_id?
+
         author
       end
 
       # Returns diaspora* ID of the new person identity.
       # @return [String] diaspora* ID of the new person identity
       def new_identity
-        profile.author if profile
+        profile&.author
       end
 
       # @return [String] string representation of this object
@@ -85,6 +93,7 @@ module DiasporaFederation
       def sign_with_respective_key
         privkey = DiasporaFederation.callbacks.trigger(:fetch_private_key, signer_id)
         raise PrivateKeyNotFound, "signer=#{signer_id} obj=#{self}" if privkey.nil?
+
         sign_with_key(privkey).tap do
           logger.info "event=sign status=complete signature=signature signer=#{signer_id} obj=#{self}"
         end

data/lib/diaspora_federation/entities/comment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity represents a comment to some kind of post (e.g. status message).
@@ -5,7 +7,7 @@ module DiasporaFederation
     # @see Validators::CommentValidator
     class Comment < Entity
       # The {Comment} parent is a {Post}
-      PARENT_TYPE = "Post".freeze
+      PARENT_TYPE = "Post"
 
       include Relayable
 

data/lib/diaspora_federation/entities/contact.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity represents a contact with another person. A user issues it

data/lib/diaspora_federation/entities/conversation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity represents a private conversation between users.
@@ -8,7 +10,7 @@ module DiasporaFederation
       #   The diaspora* ID of the person initiated the conversation
       #   @see Person#author
       #   @return [String] diaspora* ID
-      property :author, :string, xml_name: :diaspora_handle
+      property :author, :string
 
       # @!attribute [r] guid
       #   A random string of at least 16 chars
@@ -27,7 +29,7 @@ module DiasporaFederation
       # @!attribute [r] participants
       #   The diaspora* IDs of the persons participating the conversation separated by ";"
       #   @return [String] participants diaspora* IDs
-      property :participants, :string, xml_name: :participant_handles
+      property :participants, :string
 
       # @!attribute [r] messages
       #   @return [[Entities::Message]] Messages of this conversation

data/lib/diaspora_federation/entities/embed.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity is used to specify embed information about an URL that should be embedded.

data/lib/diaspora_federation/entities/event.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity represents an event and it is federated as a part of a status message.

data/lib/diaspora_federation/entities/event_participation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity represents a participation in an event, i.e. it is issued when a user responds to en event.
@@ -5,7 +7,7 @@ module DiasporaFederation
     # @see Validators::EventParticipationValidator
     class EventParticipation < Entity
       # The {EventParticipation} parent is an {Event}
-      PARENT_TYPE = "Event".freeze
+      PARENT_TYPE = "Event"
 
       include Relayable
 

data/lib/diaspora_federation/entities/like.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity represents a like to some kind of post (e.g. status message).
@@ -11,7 +13,7 @@ module DiasporaFederation
       #   Can be "Post" or "Comment" (Comments are currently not implemented in the
       #   diaspora* frontend).
       #   @return [String] parent type
-      property :parent_type, :string, xml_name: :target_type
+      property :parent_type, :string
 
       # @!attribute [r] positive
       #   If +true+ set a like, if +false+, set a dislike (dislikes are currently not

data/lib/diaspora_federation/entities/location.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity is used to specify location data and used embedded in a status message.

data/lib/diaspora_federation/entities/message.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity represents a private message exchanged in private conversation.
@@ -8,7 +10,7 @@ module DiasporaFederation
       #   The diaspora* ID of the author
       #   @see Person#author
       #   @return [String] diaspora* ID
-      property :author, :string, xml_name: :diaspora_handle
+      property :author, :string
 
       # @!attribute [r] guid
       #   A random string of at least 16 chars

data/lib/diaspora_federation/entities/participation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # Participation is sent to subscribe a user on updates for some post.
@@ -8,7 +10,7 @@ module DiasporaFederation
       #   The diaspora* ID of the author
       #   @see Person#author
       #   @return [String] diaspora* ID
-      property :author, :string, xml_name: :diaspora_handle
+      property :author, :string
 
       # @!attribute [r] guid
       #   A random string of at least 16 chars
@@ -25,7 +27,7 @@ module DiasporaFederation
       #   A string describing a type of the target to subscribe on
       #   Currently only "Post" is supported.
       #   @return [String] parent type
-      property :parent_type, :string, xml_name: :target_type
+      property :parent_type, :string
 
       # @return [String] string representation of this object
       def to_s
@@ -35,7 +37,7 @@ module DiasporaFederation
       # Validates that the parent exists and the parent author is local
       def validate_parent
         parent = DiasporaFederation.callbacks.trigger(:fetch_related_entity, parent_type, parent_guid)
-        raise ParentNotLocal, "obj=#{self}" unless parent && parent.local
+        raise ParentNotLocal, "obj=#{self}" unless parent&.local
       end
 
       # Validate that the parent is local.

data/lib/diaspora_federation/entities/person.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DiasporaFederation
   module Entities
     # This entity contains the base data of a person.
@@ -19,7 +21,7 @@ module DiasporaFederation
       #   alias for author
       #   @see Person#author
       #   @return [String] diaspora* ID
-      property :author, :string, alias: :diaspora_id, xml_name: :diaspora_handle
+      property :author, :string, alias: :diaspora_id
 
       # @!attribute [r] url
       #   @see Discovery::WebFinger#seed_url