dial 0.1.6 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4267ea5bc603e20d21e2cc7956154d210a7aad2441a4088c517adee6f9e630a5
-  data.tar.gz: 57de7d2c3bf2cd8055c3e180ff745b95b8541176f0e8aea6ec05a69f5d1175c5
+  metadata.gz: 0bb2a49d25b9e1d11931b2bc987ad87098b04d7f29787b91422fae8ca482ca41
+  data.tar.gz: 73b24362f41546bee29b3df431c9edc611264c9d6cd662fed450c13f6f48e377
 SHA512:
-  metadata.gz: 82995a0e0d7898af69ea939db4081214844e5b5de7f911be3c6e61ce51d9446d4abeda7dccd0be882c5efabd49267cdcfd2a042ae9c066b1c163f3e68ec1a0ee
-  data.tar.gz: f5b75425302efda23211c8a87ef94f543d9b253ccb5965d04067db2f81c05c9ad1d2432d222419ccd6ed08dfa90d7243f42452a695c3faaa79f7c5aa5d8bdab3
+  metadata.gz: bfb8d6bfba055cc017a379740c23ed7daf6a0ab6141e360b44f9cc8ed168242d7f6d5ee1aeeb03b6c7974cda3cd759130cae17ace399f8ac7abc6e00433db1a3
+  data.tar.gz: 388af81b669f651ab4dde3086b3ce3afd3736c3ef127956f33eb8f1f785fd98bd373696e9cfc808fed1276c7dbef7aff460b645e398ae7f637971230eb990225

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 ## [Unreleased]
 
+## [0.1.8] - 2025-01-27
+
+- Require ruby 3.3.0 or later
+- Handle stale file deletion in railtie, extend to log files
+- Make log files unique to each session - simplify installation
+
+## [0.1.7] - 2025-01-25
+
+- Increase default vernier allocation interval from 1k to 10k
+
 ## [0.1.6] - 2025-01-25
 
 - Fix redeclaration of JS constants

data/README.md

@@ -12,11 +12,12 @@ Check out the demo:
 
 ## Installation
 
-1. Add the gem to your Rails application's Gemfile (adjust the `require` option to match your server of choice):
+1. Add the gem to your Rails application's Gemfile:
 
 ```ruby
-# require in just the server process
-gem "dial", require: !!($PROGRAM_NAME =~ /puma/)
+group :development do
+  gem "dial"
+end
 ```
 
 2. Install the gem:
@@ -29,7 +30,7 @@ bundle install
 
 ```ruby
 # this will mount the engine at /dial
-mount Dial::Engine, at: "/" if Object.const_defined? "Dial::Engine"
+mount Dial::Engine, at: "/" if Rails.env.development?
 ```
 
 ## Development

data/dial.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
   spec.summary = "A modern Rails profiler"
   spec.homepage = "https://github.com/joshuay03/dial"
   spec.license = "MIT"
-  spec.required_ruby_version = ">= 3.2.1"
+  spec.required_ruby_version = ">= 3.3.0"
 
   spec.metadata["source_code_uri"] = spec.homepage
   spec.metadata["changelog_uri"] = "#{spec.homepage}/blob/main/CHANGELOG.md"

data/lib/dial/constants.rb

@@ -3,11 +3,14 @@
 require_relative "version"
 
 module Dial
+  PROGRAM_ID = Process.getsid Process.pid
+
   REQUEST_TIMING_HEADER = "dial_request_timing"
 
   PROFILE_OUT_STALE_SECONDS = 60 * 60
-  PROFILE_OUT_RELATIVE_DIRNAME = "tmp/dial/profiles/"
+  PROFILE_OUT_RELATIVE_DIRNAME = "tmp/dial/profiles"
 
-  PROSOPITE_IGNORE_QUERIES = [/schema_migrations/]
-  PROSOPITE_LOG_RELATIVE_PATHNAME = "log/dial/prosopite.log"
+  PROSOPITE_IGNORE_QUERIES = [/schema_migrations/].freeze
+  PROSOPITE_LOG_RELATIVE_DIRNAME = "log/dial"
+  PROSOPITE_LOG_FILENAME = "#{Util.uuid}_prosopite_#{PROGRAM_ID}.log".freeze
 end

data/lib/dial/middleware.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "securerandom"
-
 require "vernier"
 require "prosopite"
 
@@ -21,13 +19,13 @@ module Dial
     def call env
       start_time = Process.clock_gettime Process::CLOCK_MONOTONIC
 
-      profile_out_filename = "#{SecureRandom.uuid_v7}.json"
-      profile_out_pathname = "#{profile_out_dir_pathname}#{profile_out_filename}"
+      profile_out_filename = "#{Util.uuid}_vernier.json"
+      profile_out_pathname = "#{profile_out_dir_pathname}/#{profile_out_filename}"
 
       status, headers, rack_body = nil
       ruby_vm_stat, gc_stat, gc_stat_heap = nil
       ::Prosopite.scan do
-        ::Vernier.profile out: profile_out_pathname, interval: 500, allocation_interval: 1000, hooks: [:memory_usage, :rails] do
+        ::Vernier.profile out: profile_out_pathname, interval: 500, allocation_interval: 10_000, hooks: [:memory_usage, :rails] do
           ruby_vm_stat, gc_stat, gc_stat_heap = with_diffed_ruby_stats do
             status, headers, rack_body = @app.call env
           end
@@ -36,12 +34,10 @@ module Dial
       server_timing = server_timing headers
 
       unless headers[::Rack::CONTENT_TYPE]&.include? "text/html"
-        File.delete profile_out_pathname if File.exist? profile_out_pathname
         return [status, headers, rack_body]
       end
 
       query_logs = clear_query_logs!
-      remove_stale_profile_out_files!
 
       finish_time = Process.clock_gettime Process::CLOCK_MONOTONIC
       env[REQUEST_TIMING_HEADER] = ((finish_time - start_time) * 1_000).round 2
@@ -73,26 +69,9 @@ module Dial
       ]
     end
 
-    def remove_stale_profile_out_files!
-      stale_profile_out_files.each do |profile_out_file|
-        File.delete profile_out_file
-      end
-    end
-
-    def stale_profile_out_files
-      Dir.glob("#{profile_out_dir_pathname}/*.json").select do |profile_out_file|
-        timestamp = Util.uuid_v7_timestamp File.basename profile_out_file
-        timestamp < Time.now - PROFILE_OUT_STALE_SECONDS
-      end
-    end
-
-    def profile_out_dir_pathname
-      @_profile_out_dir_pathname ||= ::Rails.root.join PROFILE_OUT_RELATIVE_DIRNAME
-    end
-
     def clear_query_logs!
       [].tap do |query_logs|
-        File.open(query_log_pathname, "r+") do |file|
+        File.open("#{query_log_dir_pathname}/#{PROSOPITE_LOG_FILENAME}", "r+") do |file|
           entry = section = count = nil
           file.each_line do |line|
             entry, section, count = process_query_log_line line, entry, section, count
@@ -129,8 +108,12 @@ module Dial
       end
     end
 
-    def query_log_pathname
-      @_query_log_dir_pathname ||= ::Rails.root.join PROSOPITE_LOG_RELATIVE_PATHNAME
+    def profile_out_dir_pathname
+      ::Rails.root.join PROFILE_OUT_RELATIVE_DIRNAME
+    end
+
+    def query_log_dir_pathname
+      ::Rails.root.join PROSOPITE_LOG_RELATIVE_DIRNAME
     end
   end
 end

data/lib/dial/railtie.rb

@@ -18,13 +18,19 @@ module Dial
       end
     end
 
+    initializer "dial.clean_up_vernier_profile_out_files" do |app|
+      stale_files("#{profile_out_dir_pathname}/*.json").each do |profile_out_file|
+        File.delete profile_out_file rescue nil
+      end
+    end
+
     initializer "dial.set_up_prosopite" do |app|
       app.config.after_initialize do
         if ::ActiveRecord::Base.connection.adapter_name == "PostgreSQL"
           require "pg_query"
         end
 
-        prosopite_log_pathname = ::Rails.root.join PROSOPITE_LOG_RELATIVE_PATHNAME
+        prosopite_log_pathname = "#{query_log_dir_pathname}/#{PROSOPITE_LOG_FILENAME}"
         FileUtils.mkdir_p File.dirname prosopite_log_pathname
         FileUtils.touch prosopite_log_pathname
         ::Prosopite.custom_logger = ProsopiteLogger.new prosopite_log_pathname
@@ -32,5 +38,28 @@ module Dial
         ::Prosopite.ignore_queries = PROSOPITE_IGNORE_QUERIES
       end
     end
+
+    initializer "dial.clean_up_prosopite_log_files" do |app|
+      stale_files("#{query_log_dir_pathname}/*.log").each do |query_log_file|
+        File.delete query_log_file rescue nil
+      end
+    end
+
+    private
+
+    def stale_files glob_pattern
+      Dir.glob(glob_pattern).select do |file|
+        timestamp = Util.uuid_timestamp Util.file_name_uuid File.basename file
+        timestamp < Time.now - PROFILE_OUT_STALE_SECONDS
+      end
+    end
+
+    def profile_out_dir_pathname
+      ::Rails.root.join PROFILE_OUT_RELATIVE_DIRNAME
+    end
+
+    def query_log_dir_pathname
+      ::Rails.root.join PROSOPITE_LOG_RELATIVE_DIRNAME
+    end
   end
 end

data/lib/dial/util.rb

@@ -1,9 +1,19 @@
 # frozen_string_literal: true
 
+require "securerandom"
+
 module Dial
   module Util
     class << self
-      def uuid_v7_timestamp uuid
+      def uuid
+        SecureRandom.uuid_v7
+      end
+
+      def file_name_uuid file_name
+        file_name.split("_").first
+      end
+
+      def uuid_timestamp uuid
         high_bits_hex = uuid.split("-").first(2).join[0, 12].to_i 16
         Time.at high_bits_hex / 1000.0
       end

data/lib/dial/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dial
-  VERSION = "0.1.6"
+  VERSION = "0.1.8"
 end

data/lib/dial.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require_relative "dial/constants"
 require_relative "dial/util"
+require_relative "dial/constants"
 
 require_relative "dial/railtie"
 require_relative "dial/engine"

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dial
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.8
 platform: ruby
 authors:
 - Joshua Young
 bindir: bin
 cert_chain: []
-date: 2025-01-25 00:00:00.000000000 Z
+date: 2025-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -147,7 +147,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.1
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="