dial 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c1ac4b6e83d9c20da87125b635bb0d9e98d71147d1fa0490606bc7f5431aa171
-  data.tar.gz: ad2c423d69ade789af8cb6c52776d1688607a6a97c04215c231f26931a986f0d
+  metadata.gz: dcc8b8f15acf035328c3330930476af9621529608cabcb511b240cc7da9a9ecf
+  data.tar.gz: 05b4c3610edad8e1b6b4cb1cad387ea962d7e250c8cb165a845926bbd668e37c
 SHA512:
-  metadata.gz: 957163d6a4b723704c6956d0056f6f36a67f1ce07415b5e39ae84be396ca58a77cb5fd076ce8dec8471e019e10d7fb516594cb8c9ea5806b7c80f15af8063c17
-  data.tar.gz: df6125c631c2948aa24cc03508f951b47bc198c39ecc34d4a1a091eb265c0b6aa572f75d8e6b4883d6856b2bf830ba1bd7617e6e0fb5bacd924c7475876302fd
+  metadata.gz: 9bf37053b4f2bc59bd322646d7485326378c6d234d822571e59f14530ea4382830a6b842f514bef3f9fc7d6719b9b212251023b5c6a214304fb920aac0c4abd3
+  data.tar.gz: c5688daab1bd6d82310bab1270a243e507eb54bbc12cbf187c2d3237e43fe1d5022df34fa7f105b642ca563f10f7b343181a74bc5c1864a1dd36d5cca6d15f85

data/CHANGELOG.md

@@ -1,13 +1,13 @@
 ## [Unreleased]
 
+## [0.1.3] - 2024-11-14
+
+- Enable allocation profiling by default
+
 ## [0.1.2] - 2024-11-10
 
 - Add support for request profiling with vernier
 
 ## [0.1.1] - 2024-11-08
 
-- Set upper bound on dependencies
-
-## [0.1.0] - 2024-11-08
-
 - Initial release

data/README.md

@@ -7,17 +7,8 @@ WIP
 
 A modern profiler for Rails applications.
 
-<details>
-<summary>POC</summary>
-
-![Snapshot 1](https://github.com/user-attachments/assets/904daaf5-3f18-4c94-a7e4-9418539a19f3)
-
-![Snapshot 2](https://github.com/user-attachments/assets/eb6ed9f5-b258-42df-8901-222c7d969fdd)
-
 https://github.com/user-attachments/assets/bae59681-ebeb-42b3-9489-9692c072c3dc
 
-</details>
-
 ## Installation
 
 Install the gem and add it to your Rails application's Gemfile by executing:

data/lib/dial/engine/routes.rb

@@ -3,7 +3,7 @@
 Dial::Engine.routes.draw do
   scope path: "/dial", as: "dial" do
     get "profile", to: lambda { |env|
-      uuid = env[Rack::QUERY_STRING].sub("uuid=", "")
+      uuid = env[::Rack::QUERY_STRING].sub "uuid=", ""
       path = String ::Rails.root.join Dial::PROFILE_OUT_RELATIVE_DIRNAME, "#{uuid}.json"
 
       if File.exist? path

data/lib/dial/{panel.rb → middleware/panel.rb}

@@ -1,8 +1,6 @@
 # frozen_string_literal: true
 
-require "cgi"
-
-require_relative "constants"
+require "uri"
 
 module Dial
   class Panel
@@ -14,9 +12,9 @@ module Dial
           <div id="dial">
             <div id="dial-preview">
               <span>
-                #{formatted_rails_route_info(env)} |
-                #{formatted_request_timing(env)} |
-                #{formatted_profile_ouput(env, profile_out_filename)}
+                #{formatted_rails_route_info env} |
+                #{formatted_request_timing env} |
+                #{formatted_profile_output env, profile_out_filename}
               </span>
               <span>#{formatted_rails_version}</span>
               <span>#{formatted_rack_version}</span>
@@ -27,30 +25,30 @@ module Dial
               <hr>
 
               <details>
-                <summary>RubyVM stat</summary>
+                <summary>Server timing</summary>
                 <div class="section">
-                  #{formatted_ruby_vm_stat(ruby_vm_stat)}
+                  #{formatted_server_timing server_timing}
                 </div>
               </details>
 
               <details>
-                <summary>GC stat</summary>
+                <summary>RubyVM stat</summary>
                 <div class="section">
-                  #{formatted_gc_stat(gc_stat)}
+                  #{formatted_ruby_vm_stat ruby_vm_stat}
                 </div>
               </details>
 
               <details>
-                <summary>GC stat heap</summary>
+                <summary>GC stat</summary>
                 <div class="section">
-                  #{formatted_gc_stat_heap(gc_stat_heap)}
+                  #{formatted_gc_stat gc_stat}
                 </div>
               </details>
 
               <details>
-                <summary>Server timing</summary>
+                <summary>GC stat heap</summary>
                 <div class="section">
-                  #{formatted_server_timing(server_timing)}
+                  #{formatted_gc_stat_heap gc_stat_heap}
                 </div>
               </details>
             </div>
@@ -77,42 +75,41 @@ module Dial
             padding: 0.5rem;
             font-size: 0.85rem;
             color: black;
-            cursor: pointer;
-          }
-
-          #dial-preview {
-            display: flex;
-            flex-direction: column;
-            cursor: pointer;
-          }
-
-          #dial-details {
-            display: none;
-          }
-
-          .section {
-            display: flex;
-            flex-direction: column;
-            margin-top: 0.5rem;
-          }
-
-          span {
-            text-align: left;
-          }
-
-          hr {
-            width: -moz-available;
-            margin-top: 0.5rem;
-          }
 
-          details {
-            margin-top: 0.5rem;
-            text-align: left;
-          }
-
-          summary {
-            margin-bottom: 0.25rem;
-            cursor: pointer;
+            #dial-preview {
+              display: flex;
+              flex-direction: column;
+              cursor: pointer;
+            }
+
+            #dial-details {
+              display: none;
+            }
+
+            .section {
+              display: flex;
+              flex-direction: column;
+              margin: 0.25rem 0 0 0;
+            }
+
+            span {
+              text-align: left;
+            }
+
+            hr {
+              width: -moz-available;
+              margin: 0.65rem 0 0 0;
+            }
+
+            details {
+              margin: 0.5rem 0 0 0;
+              text-align: left;
+            }
+
+            summary {
+              margin: 0.25rem 0 0 0;
+              cursor: pointer;
+            }
           }
         CSS
       end
@@ -142,15 +139,13 @@ module Dial
         "<b>Request timing:</b> #{env[REQUEST_TIMING_HEADER]}ms"
       end
 
-      def formatted_profile_ouput env, profile_out_filename
-        uuid = profile_out_filename.sub ".json", ""
-        path = "dial/profile?uuid=#{uuid}"
+      def formatted_profile_output env, profile_out_filename
+        uuid = profile_out_filename.delete_suffix ".json"
         host = env[::Rack::HTTP_HOST]
         base_url = ::Rails.application.routes.url_helpers.dial_url host: host
-        profile_out_url = CGI.escape base_url + path
-        url = "https://vernier.prof/from-url/#{profile_out_url}"
+        profile_out_url = URI.encode_www_form_component base_url + "dial/profile?uuid=#{uuid}"
 
-        "<a href='#{url}' target='_blank'>View profile</a>"
+        "<a href='https://vernier.prof/from-url/#{profile_out_url}' target='_blank'>View profile</a>"
       end
 
       def formatted_rails_version
@@ -162,7 +157,18 @@ module Dial
       end
 
       def formatted_ruby_version
-        "<b>Ruby version:</b> #{RUBY_DESCRIPTION}"
+        "<b>Ruby version:</b> #{::RUBY_DESCRIPTION}"
+      end
+
+      def formatted_server_timing server_timing
+        if server_timing.any?
+          server_timing
+            # TODO: Nested sorting
+            .sort_by { |_, timing| -timing }
+            .map { |event, timing| "<span><b>#{event}:</b> #{timing}</span>" }.join
+        else
+          "NA"
+        end
       end
 
       def formatted_ruby_vm_stat ruby_vm_stat
@@ -185,17 +191,6 @@ module Dial
           HTML
         end.join
       end
-
-      def formatted_server_timing server_timing
-        if server_timing.any?
-          server_timing
-            # TODO: Nested sorting
-            .sort_by { |_, timing| -timing }
-            .map { |event, timing| "<span><b>#{event}:</b> #{timing}</span>" }.join
-        else
-          "NA"
-        end
-      end
     end
   end
 end

data/lib/dial/{rails_stat.rb → middleware/rails_stat.rb}

@@ -5,8 +5,8 @@ module Dial
     private
 
     def server_timing headers
-      timing = if (ActionDispatch.const_defined? :Constants)  && (ActionDispatch::Constants.const_defined? :SERVER_TIMING)
-        headers[ActionDispatch::Constants::SERVER_TIMING]
+      timing = if ::ActionDispatch.const_defined? "Constants::SERVER_TIMING"
+        headers[::ActionDispatch::Constants::SERVER_TIMING]
       else
         headers["Server-Timing"]
       end

data/lib/dial/{ruby_stat.rb → middleware/ruby_stat.rb}

@@ -5,11 +5,11 @@ module Dial
     private
 
     def ruby_vm_stat_diff before, after
-      stat_diff before, after, except: [:next_shape_id]
+      stat_diff before, after, no_diff: [:next_shape_id]
     end
 
     def gc_stat_diff before, after
-      stat_diff before, after, except: [
+      stat_diff before, after, no_diff: [
         :heap_allocatable_slots,
         :malloc_increase_bytes_limit,
         :remembered_wb_unprotected_objects_limit,
@@ -20,14 +20,14 @@ module Dial
 
     def gc_stat_heap_diff before, after
       after.each_with_object({}) do |(slot_index, slot_stat), diff|
-        diff[slot_index] = stat_diff before[slot_index], slot_stat, except: [:slot_size]
+        diff[slot_index] = stat_diff before[slot_index], slot_stat, no_diff: [:slot_size]
       end
     end
 
-    def stat_diff before, after, except: []
-      after.except(*except).each_with_object({}) do |(key, value), diff|
+    def stat_diff before, after, no_diff: []
+      after.except(*no_diff).each_with_object({}) do |(key, value), diff|
         diff[key] = value - before[key]
-      end
+      end.merge after.slice *no_diff
     end
   end
 end

data/lib/dial/middleware.rb

@@ -2,10 +2,10 @@
 
 require "vernier"
 
-require_relative "ruby_stat"
-require_relative "rails_stat"
 require_relative "constants"
-require_relative "panel"
+require_relative "middleware/panel"
+require_relative "middleware/ruby_stat"
+require_relative "middleware/rails_stat"
 
 module Dial
   class Middleware
@@ -17,7 +17,7 @@ module Dial
     end
 
     def call env
-      start_time = ::Process.clock_gettime ::Process::CLOCK_MONOTONIC
+      start_time = Process.clock_gettime Process::CLOCK_MONOTONIC
 
       ruby_vm_stat_before = RubyVM.stat
       gc_stat_before = GC.stat
@@ -29,7 +29,7 @@ module Dial
       profile_out_pathname = "#{profile_out_dirname}#{profile_out_filename}"
 
       status, headers, rack_body = nil
-      ::Vernier.profile out: profile_out_pathname do
+      ::Vernier.profile out: profile_out_pathname, interval: 500, allocation_interval: 1000 do
         status, headers, rack_body = @app.call env
       end
 
@@ -38,19 +38,19 @@ module Dial
         return [status, headers, rack_body]
       end
 
-      finish_time = ::Process.clock_gettime ::Process::CLOCK_MONOTONIC
+      finish_time = Process.clock_gettime Process::CLOCK_MONOTONIC
       env[REQUEST_TIMING_HEADER] = ((finish_time - start_time) * 1_000).round 2
 
-      ruby_vm_stat_diff = ruby_vm_stat_diff ruby_vm_stat_before, RubyVM.stat
-      gc_stat_diff = gc_stat_diff gc_stat_before, GC.stat
-      gc_stat_heap_diff = gc_stat_heap_diff gc_stat_heap_before, GC.stat_heap
+      ruby_vm_stat = ruby_vm_stat_diff ruby_vm_stat_before, RubyVM.stat
+      gc_stat = gc_stat_diff gc_stat_before, GC.stat
+      gc_stat_heap = gc_stat_heap_diff gc_stat_heap_before, GC.stat_heap
       server_timing = server_timing headers
 
       body = String.new.tap do |str|
         rack_body.each { |chunk| str << chunk }
-        rack_body.close if body.respond_to? :close
+        rack_body.close if rack_body.respond_to? :close
       end.sub "</body>", <<~HTML
-          #{Panel.html env, profile_out_filename, ruby_vm_stat_diff, gc_stat_diff, gc_stat_heap_diff, server_timing}
+          #{Panel.html env, profile_out_filename, ruby_vm_stat, gc_stat, gc_stat_heap, server_timing}
         </body>
       HTML
 

data/lib/dial/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dial
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: dial
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Joshua Young
 bindir: bin
 cert_chain: []
-date: 2024-11-10 00:00:00.000000000 Z
+date: 2024-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -99,10 +99,10 @@ files:
 - lib/dial/engine.rb
 - lib/dial/engine/routes.rb
 - lib/dial/middleware.rb
-- lib/dial/panel.rb
-- lib/dial/rails_stat.rb
+- lib/dial/middleware/panel.rb
+- lib/dial/middleware/rails_stat.rb
+- lib/dial/middleware/ruby_stat.rb
 - lib/dial/railtie.rb
-- lib/dial/ruby_stat.rb
 - lib/dial/version.rb
 homepage: https://github.com/joshuay03/dial
 licenses: